diff options
author | Julia Lawall <julia@diku.dk> | 2010-05-13 16:02:03 -0400 |
---|---|---|
committer | Marcel Holtmann <marcel@holtmann.org> | 2010-07-21 13:39:06 -0400 |
commit | f8df39f1810b02f877c1ba1eed8e0710019e3b48 (patch) | |
tree | c0830933fc0bac2279a38b3225da4206f3ae48ef /drivers/bluetooth | |
parent | 5ee283c063a236b19e4582c675a2d8d615d5809c (diff) |
Bluetooth: Use kzalloc for drivers
Use kzalloc rather than the combination of kmalloc and memset.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,size,flags;
statement S;
@@
-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
if (x == NULL) S
-memset(x, 0, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'drivers/bluetooth')
-rw-r--r-- | drivers/bluetooth/btmrvl_sdio.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c index 182e55345d6a..dcc2a6ec23f0 100644 --- a/drivers/bluetooth/btmrvl_sdio.c +++ b/drivers/bluetooth/btmrvl_sdio.c | |||
@@ -217,7 +217,7 @@ static int btmrvl_sdio_download_helper(struct btmrvl_sdio_card *card) | |||
217 | 217 | ||
218 | tmphlprbufsz = ALIGN_SZ(BTM_UPLD_SIZE, BTSDIO_DMA_ALIGN); | 218 | tmphlprbufsz = ALIGN_SZ(BTM_UPLD_SIZE, BTSDIO_DMA_ALIGN); |
219 | 219 | ||
220 | tmphlprbuf = kmalloc(tmphlprbufsz, GFP_KERNEL); | 220 | tmphlprbuf = kzalloc(tmphlprbufsz, GFP_KERNEL); |
221 | if (!tmphlprbuf) { | 221 | if (!tmphlprbuf) { |
222 | BT_ERR("Unable to allocate buffer for helper." | 222 | BT_ERR("Unable to allocate buffer for helper." |
223 | " Terminating download"); | 223 | " Terminating download"); |
@@ -225,8 +225,6 @@ static int btmrvl_sdio_download_helper(struct btmrvl_sdio_card *card) | |||
225 | goto done; | 225 | goto done; |
226 | } | 226 | } |
227 | 227 | ||
228 | memset(tmphlprbuf, 0, tmphlprbufsz); | ||
229 | |||
230 | helperbuf = (u8 *) ALIGN_ADDR(tmphlprbuf, BTSDIO_DMA_ALIGN); | 228 | helperbuf = (u8 *) ALIGN_ADDR(tmphlprbuf, BTSDIO_DMA_ALIGN); |
231 | 229 | ||
232 | /* Perform helper data transfer */ | 230 | /* Perform helper data transfer */ |
@@ -319,7 +317,7 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card) | |||
319 | BT_DBG("Downloading FW image (%d bytes)", firmwarelen); | 317 | BT_DBG("Downloading FW image (%d bytes)", firmwarelen); |
320 | 318 | ||
321 | tmpfwbufsz = ALIGN_SZ(BTM_UPLD_SIZE, BTSDIO_DMA_ALIGN); | 319 | tmpfwbufsz = ALIGN_SZ(BTM_UPLD_SIZE, BTSDIO_DMA_ALIGN); |
322 | tmpfwbuf = kmalloc(tmpfwbufsz, GFP_KERNEL); | 320 | tmpfwbuf = kzalloc(tmpfwbufsz, GFP_KERNEL); |
323 | if (!tmpfwbuf) { | 321 | if (!tmpfwbuf) { |
324 | BT_ERR("Unable to allocate buffer for firmware." | 322 | BT_ERR("Unable to allocate buffer for firmware." |
325 | " Terminating download"); | 323 | " Terminating download"); |
@@ -327,8 +325,6 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card) | |||
327 | goto done; | 325 | goto done; |
328 | } | 326 | } |
329 | 327 | ||
330 | memset(tmpfwbuf, 0, tmpfwbufsz); | ||
331 | |||
332 | /* Ensure aligned firmware buffer */ | 328 | /* Ensure aligned firmware buffer */ |
333 | fwbuf = (u8 *) ALIGN_ADDR(tmpfwbuf, BTSDIO_DMA_ALIGN); | 329 | fwbuf = (u8 *) ALIGN_ADDR(tmpfwbuf, BTSDIO_DMA_ALIGN); |
334 | 330 | ||