diff options
author | Jiejing Zhang <kzjeef@gmail.com> | 2011-04-07 08:37:06 -0400 |
---|---|---|
committer | Gustavo F. Padovan <padovan@profusion.mobi> | 2011-04-13 11:20:03 -0400 |
commit | 78b4a56c28c096a1eb02f1d864eb450eb910e43d (patch) | |
tree | 74d4fd7f19aa4bb496c58ce036019e7deca666c6 /drivers/bluetooth | |
parent | e1ba1f15469903b6f443fbf00f069d169e3fba6d (diff) |
Bluetooth: hci_uart: check the return value of recv()
Check the return value of hu->proto->recv() in hci_uart_tty_receive()
the recv() may return error, check it, not add this to statistics.
Signed-off-by: Jiejing Zhang <jiejing.zhang@freescale.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Diffstat (limited to 'drivers/bluetooth')
-rw-r--r-- | drivers/bluetooth/hci_ath.c | 7 | ||||
-rw-r--r-- | drivers/bluetooth/hci_ldisc.c | 6 |
2 files changed, 10 insertions, 3 deletions
diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c index bd34406faaae..4093935ddf42 100644 --- a/drivers/bluetooth/hci_ath.c +++ b/drivers/bluetooth/hci_ath.c | |||
@@ -201,8 +201,13 @@ static struct sk_buff *ath_dequeue(struct hci_uart *hu) | |||
201 | /* Recv data */ | 201 | /* Recv data */ |
202 | static int ath_recv(struct hci_uart *hu, void *data, int count) | 202 | static int ath_recv(struct hci_uart *hu, void *data, int count) |
203 | { | 203 | { |
204 | if (hci_recv_stream_fragment(hu->hdev, data, count) < 0) | 204 | int ret; |
205 | |||
206 | ret = hci_recv_stream_fragment(hu->hdev, data, count); | ||
207 | if (ret < 0) { | ||
205 | BT_ERR("Frame Reassembly Failed"); | 208 | BT_ERR("Frame Reassembly Failed"); |
209 | return ret; | ||
210 | } | ||
206 | 211 | ||
207 | return count; | 212 | return count; |
208 | } | 213 | } |
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index 48ad2a7ab080..320f71803a2b 100644 --- a/drivers/bluetooth/hci_ldisc.c +++ b/drivers/bluetooth/hci_ldisc.c | |||
@@ -359,6 +359,7 @@ static void hci_uart_tty_wakeup(struct tty_struct *tty) | |||
359 | */ | 359 | */ |
360 | static void hci_uart_tty_receive(struct tty_struct *tty, const u8 *data, char *flags, int count) | 360 | static void hci_uart_tty_receive(struct tty_struct *tty, const u8 *data, char *flags, int count) |
361 | { | 361 | { |
362 | int ret; | ||
362 | struct hci_uart *hu = (void *)tty->disc_data; | 363 | struct hci_uart *hu = (void *)tty->disc_data; |
363 | 364 | ||
364 | if (!hu || tty != hu->tty) | 365 | if (!hu || tty != hu->tty) |
@@ -368,8 +369,9 @@ static void hci_uart_tty_receive(struct tty_struct *tty, const u8 *data, char *f | |||
368 | return; | 369 | return; |
369 | 370 | ||
370 | spin_lock(&hu->rx_lock); | 371 | spin_lock(&hu->rx_lock); |
371 | hu->proto->recv(hu, (void *) data, count); | 372 | ret = hu->proto->recv(hu, (void *) data, count); |
372 | hu->hdev->stat.byte_rx += count; | 373 | if (ret > 0) |
374 | hu->hdev->stat.byte_rx += count; | ||
373 | spin_unlock(&hu->rx_lock); | 375 | spin_unlock(&hu->rx_lock); |
374 | 376 | ||
375 | tty_unthrottle(tty); | 377 | tty_unthrottle(tty); |