Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

Pull vfs updates from Al Viro:
 "The first vfs pile, with deep apologies for being very late in this
  window.

  Assorted cleanups and fixes, plus a large preparatory part of iov_iter
  work.  There's a lot more of that, but it'll probably go into the next
  merge window - it *does* shape up nicely, removes a lot of
  boilerplate, gets rid of locking inconsistencie between aio_write and
  splice_write and I hope to get Kent's direct-io rewrite merged into
  the same queue, but some of the stuff after this point is having
  (mostly trivial) conflicts with the things already merged into
  mainline and with some I want more testing.

  This one passes LTP and xfstests without regressions, in addition to
  usual beating.  BTW, readahead02 in ltp syscalls testsuite has started
  giving failures since "mm/readahead.c: fix readahead failure for
  memoryless NUMA nodes and limit readahead pages" - might be a false
  positive, might be a real regression..."

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (63 commits)
  missing bits of "splice: fix racy pipe->buffers uses"
  cifs: fix the race in cifs_writev()
  ceph_sync_{,direct_}write: fix an oops on ceph_osdc_new_request() failure
  kill generic_file_buffered_write()
  ocfs2_file_aio_write(): switch to generic_perform_write()
  ceph_aio_write(): switch to generic_perform_write()
  xfs_file_buffered_aio_write(): switch to generic_perform_write()
  export generic_perform_write(), start getting rid of generic_file_buffer_write()
  generic_file_direct_write(): get rid of ppos argument
  btrfs_file_aio_write(): get rid of ppos
  kill the 5th argument of generic_file_buffered_write()
  kill the 4th argument of __generic_file_aio_write()
  lustre: don't open-code kernel_recvmsg()
  ocfs2: don't open-code kernel_recvmsg()
  drbd: don't open-code kernel_recvmsg()
  constify blk_rq_map_user_iov() and friends
  lustre: switch to kernel_sendmsg()
  ocfs2: don't open-code kernel_sendmsg()
  take iov_iter stuff to mm/iov_iter.c
  process_vm_access: tidy up a bit
  ...

2 files changed, 20 insertions, 40 deletions

diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index 18c76e84d540..68e3992e8838 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -469,24 +469,14 @@ static void drbd_wait_ee_list_empty(struct drbd_device *device,
 
 static int drbd_recv_short(struct socket *sock, void *buf, size_t size, int flags)
 {
-        mm_segment_t oldfs;
         struct kvec iov = {
                 .iov_base = buf,
                 .iov_len = size,
         };
         struct msghdr msg = {
-                .msg_iovlen = 1,
-                .msg_iov = (struct iovec *)&iov,
                 .msg_flags = (flags ? flags : MSG_WAITALL | MSG_NOSIGNAL)
         };
-        int rv;
-
-        oldfs = get_fs();
-        set_fs(KERNEL_DS);
-        rv = sock_recvmsg(sock, &msg, size, msg.msg_flags);
-        set_fs(oldfs);
-
-        return rv;
+        return kernel_recvmsg(sock, &msg, &iov, 1, size, msg.msg_flags);
 }
 
 static int drbd_recv(struct drbd_connection *connection, void *buf, size_t size)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 55298db36b2d..3a70ea2f7cd6 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -630,37 +630,29 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
         }
  
         case NBD_CLEAR_SOCK: {
-                struct file *file;
-
+                struct socket *sock = nbd->sock;
                 nbd->sock = NULL;
-                file = nbd->file;
-                nbd->file = NULL;
                 nbd_clear_que(nbd);
                 BUG_ON(!list_empty(&nbd->queue_head));
                 BUG_ON(!list_empty(&nbd->waiting_queue));
                 kill_bdev(bdev);
-                if (file)
-                        fput(file);
+                if (sock)
+                        sockfd_put(sock);
                 return 0;
         }
 
         case NBD_SET_SOCK: {
-                struct file *file;
-                if (nbd->file)
+                struct socket *sock;
+                int err;
+                if (nbd->sock)
                         return -EBUSY;
-                file = fget(arg);
-                if (file) {
-                        struct inode *inode = file_inode(file);
-                        if (S_ISSOCK(inode->i_mode)) {
-                                nbd->file = file;
-                                nbd->sock = SOCKET_I(inode);
-                                if (max_part > 0)
-                                        bdev->bd_invalidated = 1;
-                                nbd->disconnect = 0; /* we're connected now */
-                                return 0;
-                        } else {
-                                fput(file);
-                        }
+                sock = sockfd_lookup(arg, &err);
+                if (sock) {
+                        nbd->sock = sock;
+                        if (max_part > 0)
+                                bdev->bd_invalidated = 1;
+                        nbd->disconnect = 0; /* we're connected now */
+                        return 0;
                 }
                 return -EINVAL;
         }
@@ -697,12 +689,12 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
 
         case NBD_DO_IT: {
                 struct task_struct *thread;
-                struct file *file;
+                struct socket *sock;
                 int error;
 
                 if (nbd->pid)
                         return -EBUSY;
-                if (!nbd->file)
+                if (!nbd->sock)
                         return -EINVAL;
 
                 mutex_unlock(&nbd->tx_lock);
@@ -731,15 +723,15 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
                 if (error)
                         return error;
                 sock_shutdown(nbd, 0);
-                file = nbd->file;
-                nbd->file = NULL;
+                sock = nbd->sock;
+                nbd->sock = NULL;
                 nbd_clear_que(nbd);
                 dev_warn(disk_to_dev(nbd->disk), "queue cleared\n");
                 kill_bdev(bdev);
                 queue_flag_clear_unlocked(QUEUE_FLAG_DISCARD, nbd->disk->queue);
                 set_device_ro(bdev, false);
-                if (file)
-                        fput(file);
+                if (sock)
+                        sockfd_put(sock);
                 nbd->flags = 0;
                 nbd->bytesize = 0;
                 bdev->bd_inode->i_size = 0;
@@ -875,9 +867,7 @@ static int __init nbd_init(void)
 
         for (i = 0; i < nbds_max; i++) {
                 struct gendisk *disk = nbd_dev[i].disk;
-                nbd_dev[i].file = NULL;
                 nbd_dev[i].magic = NBD_MAGIC;
-                nbd_dev[i].flags = 0;
                 INIT_LIST_HEAD(&nbd_dev[i].waiting_queue);
                 spin_lock_init(&nbd_dev[i].queue_lock);
                 INIT_LIST_HEAD(&nbd_dev[i].queue_head);