diff options
author | Joe Perches <joe@perches.com> | 2010-03-10 18:21:07 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-03-12 18:52:31 -0500 |
commit | 1ebddd85a6a6ad793eca82d65fba4573d0e28042 (patch) | |
tree | 5f413751925ad5d93aac3aacaf2c4e8bc3a31625 /drivers/block | |
parent | 275176bc2a7bbd5c4446ba12b8f4353a69012053 (diff) |
drivers/block/floppy.c: use %pf in logging messages
Print the function name not the pointer address where useful and possible
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/block')
-rw-r--r-- | drivers/block/floppy.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index c500c5cc34ee..46536b716acc 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c | |||
@@ -908,7 +908,7 @@ static inline void unlock_fdc(void) | |||
908 | DPRINT("FDC access conflict!\n"); | 908 | DPRINT("FDC access conflict!\n"); |
909 | 909 | ||
910 | if (do_floppy) | 910 | if (do_floppy) |
911 | DPRINT("device interrupt still active at FDC release: %p!\n", | 911 | DPRINT("device interrupt still active at FDC release: %pf!\n", |
912 | do_floppy); | 912 | do_floppy); |
913 | command_status = FD_COMMAND_NONE; | 913 | command_status = FD_COMMAND_NONE; |
914 | spin_lock_irqsave(&floppy_lock, flags); | 914 | spin_lock_irqsave(&floppy_lock, flags); |
@@ -1733,7 +1733,7 @@ irqreturn_t floppy_interrupt(int irq, void *dev_id) | |||
1733 | /* we don't even know which FDC is the culprit */ | 1733 | /* we don't even know which FDC is the culprit */ |
1734 | pr_info("DOR0=%x\n", fdc_state[0].dor); | 1734 | pr_info("DOR0=%x\n", fdc_state[0].dor); |
1735 | pr_info("floppy interrupt on bizarre fdc %d\n", fdc); | 1735 | pr_info("floppy interrupt on bizarre fdc %d\n", fdc); |
1736 | pr_info("handler=%p\n", handler); | 1736 | pr_info("handler=%pf\n", handler); |
1737 | is_alive(__func__, "bizarre fdc"); | 1737 | is_alive(__func__, "bizarre fdc"); |
1738 | return IRQ_NONE; | 1738 | return IRQ_NONE; |
1739 | } | 1739 | } |
@@ -1792,7 +1792,7 @@ static void reset_interrupt(void) | |||
1792 | debugt("reset interrupt:"); | 1792 | debugt("reset interrupt:"); |
1793 | result(); /* get the status ready for set_fdc */ | 1793 | result(); /* get the status ready for set_fdc */ |
1794 | if (FDCS->reset) { | 1794 | if (FDCS->reset) { |
1795 | pr_info("reset set in interrupt, calling %p\n", cont->error); | 1795 | pr_info("reset set in interrupt, calling %pf\n", cont->error); |
1796 | cont->error(); /* a reset just after a reset. BAD! */ | 1796 | cont->error(); /* a reset just after a reset. BAD! */ |
1797 | } | 1797 | } |
1798 | cont->redo(); | 1798 | cont->redo(); |
@@ -1833,7 +1833,7 @@ static void show_floppy(void) | |||
1833 | pr_info("\n"); | 1833 | pr_info("\n"); |
1834 | pr_info("floppy driver state\n"); | 1834 | pr_info("floppy driver state\n"); |
1835 | pr_info("-------------------\n"); | 1835 | pr_info("-------------------\n"); |
1836 | pr_info("now=%lu last interrupt=%lu diff=%lu last called handler=%p\n", | 1836 | pr_info("now=%lu last interrupt=%lu diff=%lu last called handler=%pf\n", |
1837 | jiffies, interruptjiffies, jiffies - interruptjiffies, | 1837 | jiffies, interruptjiffies, jiffies - interruptjiffies, |
1838 | lasthandler); | 1838 | lasthandler); |
1839 | 1839 | ||
@@ -1852,13 +1852,13 @@ static void show_floppy(void) | |||
1852 | pr_info("status=%x\n", fd_inb(FD_STATUS)); | 1852 | pr_info("status=%x\n", fd_inb(FD_STATUS)); |
1853 | pr_info("fdc_busy=%lu\n", fdc_busy); | 1853 | pr_info("fdc_busy=%lu\n", fdc_busy); |
1854 | if (do_floppy) | 1854 | if (do_floppy) |
1855 | pr_info("do_floppy=%p\n", do_floppy); | 1855 | pr_info("do_floppy=%pf\n", do_floppy); |
1856 | if (work_pending(&floppy_work)) | 1856 | if (work_pending(&floppy_work)) |
1857 | pr_info("floppy_work.func=%p\n", floppy_work.func); | 1857 | pr_info("floppy_work.func=%pf\n", floppy_work.func); |
1858 | if (timer_pending(&fd_timer)) | 1858 | if (timer_pending(&fd_timer)) |
1859 | pr_info("fd_timer.function=%p\n", fd_timer.function); | 1859 | pr_info("fd_timer.function=%pf\n", fd_timer.function); |
1860 | if (timer_pending(&fd_timeout)) { | 1860 | if (timer_pending(&fd_timeout)) { |
1861 | pr_info("timer_function=%p\n", fd_timeout.function); | 1861 | pr_info("timer_function=%pf\n", fd_timeout.function); |
1862 | pr_info("expires=%lu\n", fd_timeout.expires - jiffies); | 1862 | pr_info("expires=%lu\n", fd_timeout.expires - jiffies); |
1863 | pr_info("now=%lu\n", jiffies); | 1863 | pr_info("now=%lu\n", jiffies); |
1864 | } | 1864 | } |