diff options
author | Stephen M. Cameron <scameron@beardog.cce.hp.com> | 2011-03-12 04:02:30 -0500 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2011-03-12 04:02:30 -0500 |
commit | 6d9a4f9e21486fa83526a9a9fdf88b9b2cdfd299 (patch) | |
tree | f68adf8d3e17b7f47b04a48d2361efcfa29e813a /drivers/block | |
parent | fcab1c112ade881d884cd7b8161f7543194d12e1 (diff) |
cciss: fix missed command status value CMD_UNABORTABLE
and fix a nearby typo, "do" that should have been "due"
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers/block')
-rw-r--r-- | drivers/block/cciss.c | 11 | ||||
-rw-r--r-- | drivers/block/cciss_scsi.c | 13 |
2 files changed, 22 insertions, 2 deletions
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 25267e92ce31..9bf13988f1a2 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
@@ -2691,6 +2691,10 @@ static int process_sendcmd_error(ctlr_info_t *h, CommandList_struct *c) | |||
2691 | c->Request.CDB[0]); | 2691 | c->Request.CDB[0]); |
2692 | return_status = IO_NEEDS_RETRY; | 2692 | return_status = IO_NEEDS_RETRY; |
2693 | break; | 2693 | break; |
2694 | case CMD_UNABORTABLE: | ||
2695 | dev_warn(&h->pdev->dev, "cmd unabortable\n"); | ||
2696 | return_status = IO_ERROR; | ||
2697 | break; | ||
2694 | default: | 2698 | default: |
2695 | dev_warn(&h->pdev->dev, "cmd 0x%02x returned " | 2699 | dev_warn(&h->pdev->dev, "cmd 0x%02x returned " |
2696 | "unknown status %x\n", c->Request.CDB[0], | 2700 | "unknown status %x\n", c->Request.CDB[0], |
@@ -3141,6 +3145,13 @@ static inline void complete_command(ctlr_info_t *h, CommandList_struct *cmd, | |||
3141 | (cmd->rq->cmd_type == REQ_TYPE_BLOCK_PC) ? | 3145 | (cmd->rq->cmd_type == REQ_TYPE_BLOCK_PC) ? |
3142 | DID_PASSTHROUGH : DID_ERROR); | 3146 | DID_PASSTHROUGH : DID_ERROR); |
3143 | break; | 3147 | break; |
3148 | case CMD_UNABORTABLE: | ||
3149 | dev_warn(&h->pdev->dev, "cmd %p unabortable\n", cmd); | ||
3150 | rq->errors = make_status_bytes(SAM_STAT_GOOD, | ||
3151 | cmd->err_info->CommandStatus, DRIVER_OK, | ||
3152 | cmd->rq->cmd_type == REQ_TYPE_BLOCK_PC ? | ||
3153 | DID_PASSTHROUGH : DID_ERROR); | ||
3154 | break; | ||
3144 | default: | 3155 | default: |
3145 | dev_warn(&h->pdev->dev, "cmd %p returned " | 3156 | dev_warn(&h->pdev->dev, "cmd %p returned " |
3146 | "unknown status %x\n", cmd, | 3157 | "unknown status %x\n", cmd, |
diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c index 3bfbde8b4013..8fa2a2e90b9f 100644 --- a/drivers/block/cciss_scsi.c +++ b/drivers/block/cciss_scsi.c | |||
@@ -833,13 +833,18 @@ static void complete_scsi_command(CommandList_struct *c, int timeout, | |||
833 | break; | 833 | break; |
834 | case CMD_UNSOLICITED_ABORT: | 834 | case CMD_UNSOLICITED_ABORT: |
835 | cmd->result = DID_ABORT << 16; | 835 | cmd->result = DID_ABORT << 16; |
836 | dev_warn(&h->pdev->dev, "%p aborted do to an " | 836 | dev_warn(&h->pdev->dev, "%p aborted due to an " |
837 | "unsolicited abort\n", c); | 837 | "unsolicited abort\n", c); |
838 | break; | 838 | break; |
839 | case CMD_TIMEOUT: | 839 | case CMD_TIMEOUT: |
840 | cmd->result = DID_TIME_OUT << 16; | 840 | cmd->result = DID_TIME_OUT << 16; |
841 | dev_warn(&h->pdev->dev, "%p timedout\n", c); | 841 | dev_warn(&h->pdev->dev, "%p timedout\n", c); |
842 | break; | 842 | break; |
843 | case CMD_UNABORTABLE: | ||
844 | cmd->result = DID_ERROR << 16; | ||
845 | dev_warn(&h->pdev->dev, "c %p command " | ||
846 | "unabortable\n", c); | ||
847 | break; | ||
843 | default: | 848 | default: |
844 | cmd->result = DID_ERROR << 16; | 849 | cmd->result = DID_ERROR << 16; |
845 | dev_warn(&h->pdev->dev, | 850 | dev_warn(&h->pdev->dev, |
@@ -1016,11 +1021,15 @@ cciss_scsi_interpret_error(ctlr_info_t *h, CommandList_struct *c) | |||
1016 | break; | 1021 | break; |
1017 | case CMD_UNSOLICITED_ABORT: | 1022 | case CMD_UNSOLICITED_ABORT: |
1018 | dev_warn(&h->pdev->dev, | 1023 | dev_warn(&h->pdev->dev, |
1019 | "%p aborted do to an unsolicited abort\n", c); | 1024 | "%p aborted due to an unsolicited abort\n", c); |
1020 | break; | 1025 | break; |
1021 | case CMD_TIMEOUT: | 1026 | case CMD_TIMEOUT: |
1022 | dev_warn(&h->pdev->dev, "%p timedout\n", c); | 1027 | dev_warn(&h->pdev->dev, "%p timedout\n", c); |
1023 | break; | 1028 | break; |
1029 | case CMD_UNABORTABLE: | ||
1030 | dev_warn(&h->pdev->dev, | ||
1031 | "%p unabortable\n", c); | ||
1032 | break; | ||
1024 | default: | 1033 | default: |
1025 | dev_warn(&h->pdev->dev, | 1034 | dev_warn(&h->pdev->dev, |
1026 | "%p returned unknown status %x\n", | 1035 | "%p returned unknown status %x\n", |