aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorPhilipp Reisner <philipp.reisner@linbit.com>2010-04-28 08:46:57 -0400
committerPhilipp Reisner <philipp.reisner@linbit.com>2010-05-17 19:20:33 -0400
commit5223671bb0315d83f9ad7becbbb9e703aa735bbe (patch)
treeabd92e52a9a4b65a4c927e81bfd05896faa0c197 /drivers/block
parent6b4388ac1f282515db3a651707238cad00b50e80 (diff)
drbd: Fixed bitmap in case of online-grow without resync
The "surplus" bits of the old (smaller) bitmap must be clean in case of online-grow without resync. Note: Reverted 67ae8b80d4a116ab3b7094eb3723506b20c06dff as well, since the lines added by this patch are redundant. The bits get set by the bm_set_surplus(b) call before that. Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/drbd/drbd_bitmap.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/block/drbd/drbd_bitmap.c b/drivers/block/drbd/drbd_bitmap.c
index aa7e23cf7e22..e3f88d6e1412 100644
--- a/drivers/block/drbd/drbd_bitmap.c
+++ b/drivers/block/drbd/drbd_bitmap.c
@@ -519,7 +519,7 @@ int drbd_bm_resize(struct drbd_conf *mdev, sector_t capacity, int set_new_bits)
519 obits = b->bm_bits; 519 obits = b->bm_bits;
520 520
521 growing = bits > obits; 521 growing = bits > obits;
522 if (opages) 522 if (opages && growing && set_new_bits)
523 bm_set_surplus(b); 523 bm_set_surplus(b);
524 524
525 b->bm_pages = npages; 525 b->bm_pages = npages;
@@ -532,9 +532,6 @@ int drbd_bm_resize(struct drbd_conf *mdev, sector_t capacity, int set_new_bits)
532 if (set_new_bits) { 532 if (set_new_bits) {
533 bm_memset(b, owords, 0xff, words-owords); 533 bm_memset(b, owords, 0xff, words-owords);
534 b->bm_set += bits - obits; 534 b->bm_set += bits - obits;
535 __bm_change_bits_to(mdev, obits,
536 ALIGN(obits, BITS_PER_LONG),
537 1, KM_IRQ1);
538 } else 535 } else
539 bm_memset(b, owords, 0x00, words-owords); 536 bm_memset(b, owords, 0x00, words-owords);
540 537