aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorPhilipp Reisner <philipp.reisner@linbit.com>2011-04-12 00:24:24 -0400
committerPhilipp Reisner <philipp.reisner@linbit.com>2012-11-08 10:45:16 -0500
commitcd1d9950f69b46d88002b39652ed0cf3608d008b (patch)
treee40e9669a9394253506e06e3b3ec32bb7a3ce748 /drivers/block
parentff370e5a9ebaf9499431216a531a196d98283228 (diff)
drbd: Inlined drbd_free_mdev(); it got called only from one place
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/drbd/drbd_int.h1
-rw-r--r--drivers/block/drbd/drbd_main.c25
2 files changed, 7 insertions, 19 deletions
diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index ce56aa08314e..c49dc085d93a 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -1366,7 +1366,6 @@ extern rwlock_t global_state_lock;
1366 1366
1367extern int conn_lowest_minor(struct drbd_tconn *tconn); 1367extern int conn_lowest_minor(struct drbd_tconn *tconn);
1368enum drbd_ret_code conn_new_minor(struct drbd_tconn *tconn, unsigned int minor, int vnr); 1368enum drbd_ret_code conn_new_minor(struct drbd_tconn *tconn, unsigned int minor, int vnr);
1369extern void drbd_free_mdev(struct drbd_conf *mdev);
1370extern void drbd_delete_device(struct drbd_conf *mdev); 1369extern void drbd_delete_device(struct drbd_conf *mdev);
1371 1370
1372struct drbd_tconn *drbd_new_tconn(const char *name); 1371struct drbd_tconn *drbd_new_tconn(const char *name);
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 93a16db8a999..563427bfc274 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -2233,10 +2233,13 @@ void drbd_delete_device(struct drbd_conf *mdev)
2233 kfree(mdev->p_uuid); 2233 kfree(mdev->p_uuid);
2234 /* mdev->p_uuid = NULL; */ 2234 /* mdev->p_uuid = NULL; */
2235 2235
2236 /* cleanup the rest that has been 2236 kfree(mdev->current_epoch);
2237 * allocated from drbd_new_device 2237 if (mdev->bitmap) /* should no longer be there. */
2238 * and actually free the mdev itself */ 2238 drbd_bm_cleanup(mdev);
2239 drbd_free_mdev(mdev); 2239 __free_page(mdev->md_io_page);
2240 put_disk(mdev->vdisk);
2241 blk_cleanup_queue(mdev->rq_queue);
2242 kfree(mdev);
2240} 2243}
2241 2244
2242static void drbd_cleanup(void) 2245static void drbd_cleanup(void)
@@ -2551,20 +2554,6 @@ out_no_q:
2551 return err; 2554 return err;
2552} 2555}
2553 2556
2554/* counterpart of drbd_new_device.
2555 * last part of drbd_delete_device. */
2556void drbd_free_mdev(struct drbd_conf *mdev)
2557{
2558 kfree(mdev->current_epoch);
2559 if (mdev->bitmap) /* should no longer be there. */
2560 drbd_bm_cleanup(mdev);
2561 __free_page(mdev->md_io_page);
2562 put_disk(mdev->vdisk);
2563 blk_cleanup_queue(mdev->rq_queue);
2564 kfree(mdev);
2565}
2566
2567
2568int __init drbd_init(void) 2557int __init drbd_init(void)
2569{ 2558{
2570 int err; 2559 int err;