aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorJens Axboe <axboe@suse.de>2005-12-12 03:37:13 -0500
committerLinus Torvalds <torvalds@g5.osdl.org>2005-12-12 11:57:43 -0500
commitb4788f6d55548e587ced330ece711456f40ec8f1 (patch)
tree42468e3b7fbdcb5d9e7f93857df39003dbaa6b46 /drivers/block
parentadad0f331f9c693129e81e233c5461e2e7c3e443 (diff)
[PATCH] cciss: double put_disk()
This undoes the put_disk patch I sent in before. If I had been paying attention I would have seen that we call put_disk from free_hba during driver unload. That's the only time we want to call it. If it's called from deregister disk we may remove the controller (cNd0) unintentionally. Signed-off-by: Mike Miller <mike.miller@hp.com> Signed-off-by: Jens Axboe <axboe@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/cciss.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index a9e33db46e68..e34104d32637 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1146,7 +1146,6 @@ static int revalidate_allvol(ctlr_info_t *host)
1146 del_gendisk(disk); 1146 del_gendisk(disk);
1147 if (q) 1147 if (q)
1148 blk_cleanup_queue(q); 1148 blk_cleanup_queue(q);
1149 put_disk(disk);
1150 } 1149 }
1151 } 1150 }
1152 1151
@@ -1467,7 +1466,6 @@ static int deregister_disk(struct gendisk *disk, drive_info_struct *drv,
1467 del_gendisk(disk); 1466 del_gendisk(disk);
1468 if (q) 1467 if (q)
1469 blk_cleanup_queue(q); 1468 blk_cleanup_queue(q);
1470 put_disk(disk);
1471 } 1469 }
1472 } 1470 }
1473 1471
@@ -3243,7 +3241,6 @@ static void __devexit cciss_remove_one (struct pci_dev *pdev)
3243 del_gendisk(disk); 3241 del_gendisk(disk);
3244 if (q) 3242 if (q)
3245 blk_cleanup_queue(q); 3243 blk_cleanup_queue(q);
3246 put_disk(disk);
3247 } 3244 }
3248 } 3245 }
3249 3246