aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorLars Ellenberg <lars.ellenberg@linbit.com>2012-01-11 03:46:48 -0500
committerPhilipp Reisner <philipp.reisner@linbit.com>2012-05-09 09:16:48 -0400
commit41c4a0035b36d400b79cbd945390a76e909711a7 (patch)
treeecfc9c36addad208e1416aef84d7ffe9ff1a737f /drivers/block
parent6d49e101fd3d3dbd525564923a82fb8a66676420 (diff)
drbd: fix READ_RETRY_REMOTE_CANCELED to not complete if device is suspended
READ_RETRY_REMOTE_CANCELED needs to be grouped with the other _CANCELED cases, not with CONNECTION_LOST_WHILE_PENDING, as that would complete (fail) the bio even if the device became suspended. Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/drbd/drbd_req.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index bfed0834cd6f..2a246ac84d7f 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -569,6 +569,7 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what,
569 drbd_queue_work(&mdev->data.work, &req->w); 569 drbd_queue_work(&mdev->data.work, &req->w);
570 break; 570 break;
571 571
572 case read_retry_remote_canceled:
572 case send_canceled: 573 case send_canceled:
573 case send_failed: 574 case send_failed:
574 /* real cleanup will be done from tl_clear. just update flags 575 /* real cleanup will be done from tl_clear. just update flags
@@ -610,9 +611,6 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what,
610 _req_may_be_done_not_susp(req, m); 611 _req_may_be_done_not_susp(req, m);
611 break; 612 break;
612 613
613 case read_retry_remote_canceled:
614 req->rq_state &= ~RQ_NET_QUEUED;
615 /* fall through, in case we raced with drbd_disconnect */
616 case connection_lost_while_pending: 614 case connection_lost_while_pending:
617 /* transfer log cleanup after connection loss */ 615 /* transfer log cleanup after connection loss */
618 /* assert something? */ 616 /* assert something? */