diff options
author | Tejun Heo <tj@kernel.org> | 2010-09-03 05:56:18 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2010-09-10 06:35:37 -0400 |
commit | 02c42b7a68695c2c3e3fecf9f6b9a4ea43abe52f (patch) | |
tree | e3b49ba3b87e41794298b9a4a2822b21a152aefc /drivers/block | |
parent | 6259f28459a9de820f47a9ece4ffa22d4596a9af (diff) |
virtio_blk: drop REQ_HARDBARRIER support
Remove now unused REQ_HARDBARRIER support. virtio_blk already
supports REQ_FLUSH and the usefulness of REQ_FUA for virtio_blk is
questionable at this point, so there's nothing else to do to support
new REQ_FLUSH/FUA interface.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers/block')
-rw-r--r-- | drivers/block/virtio_blk.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index d10b635b3946..126062802cb7 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c | |||
@@ -128,9 +128,6 @@ static bool do_req(struct request_queue *q, struct virtio_blk *vblk, | |||
128 | } | 128 | } |
129 | } | 129 | } |
130 | 130 | ||
131 | if (vbr->req->cmd_flags & REQ_HARDBARRIER) | ||
132 | vbr->out_hdr.type |= VIRTIO_BLK_T_BARRIER; | ||
133 | |||
134 | sg_set_buf(&vblk->sg[out++], &vbr->out_hdr, sizeof(vbr->out_hdr)); | 131 | sg_set_buf(&vblk->sg[out++], &vbr->out_hdr, sizeof(vbr->out_hdr)); |
135 | 132 | ||
136 | /* | 133 | /* |
@@ -388,13 +385,7 @@ static int __devinit virtblk_probe(struct virtio_device *vdev) | |||
388 | vblk->disk->driverfs_dev = &vdev->dev; | 385 | vblk->disk->driverfs_dev = &vdev->dev; |
389 | index++; | 386 | index++; |
390 | 387 | ||
391 | /* | 388 | /* configure queue flush support */ |
392 | * If the FLUSH feature is supported we do have support for | ||
393 | * flushing a volatile write cache on the host. Use that to | ||
394 | * implement write barrier support; otherwise, we must assume | ||
395 | * that the host does not perform any kind of volatile write | ||
396 | * caching. | ||
397 | */ | ||
398 | if (virtio_has_feature(vdev, VIRTIO_BLK_F_FLUSH)) | 389 | if (virtio_has_feature(vdev, VIRTIO_BLK_F_FLUSH)) |
399 | blk_queue_flush(q, REQ_FLUSH); | 390 | blk_queue_flush(q, REQ_FLUSH); |
400 | 391 | ||
@@ -515,9 +506,9 @@ static const struct virtio_device_id id_table[] = { | |||
515 | }; | 506 | }; |
516 | 507 | ||
517 | static unsigned int features[] = { | 508 | static unsigned int features[] = { |
518 | VIRTIO_BLK_F_BARRIER, VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, | 509 | VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, VIRTIO_BLK_F_GEOMETRY, |
519 | VIRTIO_BLK_F_GEOMETRY, VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, | 510 | VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, VIRTIO_BLK_F_SCSI, |
520 | VIRTIO_BLK_F_SCSI, VIRTIO_BLK_F_FLUSH, VIRTIO_BLK_F_TOPOLOGY | 511 | VIRTIO_BLK_F_FLUSH, VIRTIO_BLK_F_TOPOLOGY |
521 | }; | 512 | }; |
522 | 513 | ||
523 | /* | 514 | /* |