aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/block
diff options
context:
space:
mode:
authorAlex Elder <elder@inktank.com>2013-01-20 15:44:42 -0500
committerSage Weil <sage@inktank.com>2013-02-13 21:29:08 -0500
commitecf7a0318b1b026fb147623c36324fa8c73447a9 (patch)
tree44c5a5a3f7e642be507ae3c2ab003b9d49721a52 /drivers/block
parent9969ebc5af93028c21f2614621737f0d6ff6fc06 (diff)
rbd: get rid of rbd_req_sync_watch()
Get rid of rbd_req_sync_watch(), because it is no longer used. Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/rbd.c42
1 files changed, 0 insertions, 42 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 60b68512fa93..a6a85271380a 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -1369,47 +1369,6 @@ static void rbd_watch_cb(u64 ver, u64 notify_id, u8 opcode, void *data)
1369 rbd_req_sync_notify_ack(rbd_dev, hver, notify_id); 1369 rbd_req_sync_notify_ack(rbd_dev, hver, notify_id);
1370} 1370}
1371 1371
1372/*
1373 * Request sync osd watch/unwatch. The value of "start" determines
1374 * whether a watch request is being initiated or torn down.
1375 */
1376static int rbd_req_sync_watch(struct rbd_device *rbd_dev, int start)
1377{
1378 struct ceph_osd_req_op *op;
1379 int ret = 0;
1380
1381 rbd_assert(start ^ !!rbd_dev->watch_event);
1382 rbd_assert(start ^ !!rbd_dev->watch_request);
1383
1384 if (start) {
1385 struct ceph_osd_client *osdc;
1386
1387 osdc = &rbd_dev->rbd_client->client->osdc;
1388 ret = ceph_osdc_create_event(osdc, rbd_watch_cb, 0, rbd_dev,
1389 &rbd_dev->watch_event);
1390 if (ret < 0)
1391 return ret;
1392 }
1393
1394 op = rbd_osd_req_op_create(CEPH_OSD_OP_WATCH,
1395 rbd_dev->watch_event->cookie,
1396 rbd_dev->header.obj_version, start);
1397 if (op)
1398 ret = rbd_req_sync_op(rbd_dev,
1399 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK,
1400 op, rbd_dev->header_name,
1401 0, 0, NULL, NULL);
1402
1403 /* Cancel the event if we're tearing down, or on error */
1404
1405 if (!start || !op || ret < 0) {
1406 ceph_osdc_cancel_event(rbd_dev->watch_event);
1407 rbd_dev->watch_event = NULL;
1408 }
1409 rbd_osd_req_op_destroy(op);
1410
1411 return ret;
1412}
1413 1372
1414/* 1373/*
1415 * Synchronous osd object method call 1374 * Synchronous osd object method call
@@ -3961,7 +3920,6 @@ static int rbd_dev_probe_finish(struct rbd_device *rbd_dev)
3961 if (ret) 3920 if (ret)
3962 goto err_out_bus; 3921 goto err_out_bus;
3963 3922
3964 (void) rbd_req_sync_watch; /* avoid a warning */
3965 ret = rbd_dev_header_watch_sync(rbd_dev, 1); 3923 ret = rbd_dev_header_watch_sync(rbd_dev, 1);
3966 if (ret) 3924 if (ret)
3967 goto err_out_bus; 3925 goto err_out_bus;