diff options
author | Tejun Heo <tj@kernel.org> | 2010-09-03 05:56:16 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2010-09-10 06:35:36 -0400 |
commit | 6958f145459ca7ad9715024de97445addacb8510 (patch) | |
tree | c8c945eb68ceb88bd34647d7bcaedd13a0d753ca /drivers/block/virtio_blk.c | |
parent | 589d7ed02ade0d06a3510da2e15a7edfdb2ef3d8 (diff) |
block: kill QUEUE_ORDERED_BY_TAG
Nobody is making meaningful use of ORDERED_BY_TAG now and queue
draining for barrier requests will be removed soon which will render
the advantage of tag ordering moot. Kill ORDERED_BY_TAG. The
following users are affected.
* brd: converted to ORDERED_DRAIN.
* virtio_blk: ORDERED_TAG path was already marked deprecated. Removed.
* xen-blkfront: ORDERED_TAG case dropped.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers/block/virtio_blk.c')
-rw-r--r-- | drivers/block/virtio_blk.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 2aafafca2b13..79652809eee8 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c | |||
@@ -395,15 +395,6 @@ static int __devinit virtblk_probe(struct virtio_device *vdev) | |||
395 | * to implement write barrier support. | 395 | * to implement write barrier support. |
396 | */ | 396 | */ |
397 | blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH); | 397 | blk_queue_ordered(q, QUEUE_ORDERED_DRAIN_FLUSH); |
398 | } else if (virtio_has_feature(vdev, VIRTIO_BLK_F_BARRIER)) { | ||
399 | /* | ||
400 | * If the BARRIER feature is supported the host expects us | ||
401 | * to order request by tags. This implies there is not | ||
402 | * volatile write cache on the host, and that the host | ||
403 | * never re-orders outstanding I/O. This feature is not | ||
404 | * useful for real life scenarious and deprecated. | ||
405 | */ | ||
406 | blk_queue_ordered(q, QUEUE_ORDERED_TAG); | ||
407 | } else { | 398 | } else { |
408 | /* | 399 | /* |
409 | * If the FLUSH feature is not supported we must assume that | 400 | * If the FLUSH feature is not supported we must assume that |