aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/block/swim.c
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2013-05-05 21:52:57 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2013-05-07 02:16:21 -0400
commitdb2a144bedd58b3dcf19950c2f476c58c9f39d18 (patch)
tree931f1b5a8e6bafe388b317bce02a9fd9af309d38 /drivers/block/swim.c
parenta8ca889ed9585894d53fd8919d80cbe8baff09e7 (diff)
block_device_operations->release() should return void
The value passed is 0 in all but "it can never happen" cases (and those only in a couple of drivers) *and* it would've been lost on the way out anyway, even if something tried to pass something meaningful. Just don't bother. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers/block/swim.c')
-rw-r--r--drivers/block/swim.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/block/swim.c b/drivers/block/swim.c
index 8766a2257091..2f445b7a174e 100644
--- a/drivers/block/swim.c
+++ b/drivers/block/swim.c
@@ -673,7 +673,7 @@ static int floppy_unlocked_open(struct block_device *bdev, fmode_t mode)
673 return ret; 673 return ret;
674} 674}
675 675
676static int floppy_release(struct gendisk *disk, fmode_t mode) 676static void floppy_release(struct gendisk *disk, fmode_t mode)
677{ 677{
678 struct floppy_state *fs = disk->private_data; 678 struct floppy_state *fs = disk->private_data;
679 struct swim __iomem *base = fs->swd->base; 679 struct swim __iomem *base = fs->swd->base;
@@ -687,8 +687,6 @@ static int floppy_release(struct gendisk *disk, fmode_t mode)
687 if (fs->ref_count == 0) 687 if (fs->ref_count == 0)
688 swim_motor(base, OFF); 688 swim_motor(base, OFF);
689 mutex_unlock(&swim_mutex); 689 mutex_unlock(&swim_mutex);
690
691 return 0;
692} 690}
693 691
694static int floppy_ioctl(struct block_device *bdev, fmode_t mode, 692static int floppy_ioctl(struct block_device *bdev, fmode_t mode,