diff options
author | Tejun Heo <tj@kernel.org> | 2009-04-22 22:05:19 -0400 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2009-04-28 01:37:36 -0400 |
commit | f06d9a2b52e246a66b606130cea3f0d7b7be17a7 (patch) | |
tree | 020df1f9d54b00c72d8af02ac0827d496597e75a /drivers/block/swim.c | |
parent | 40cbbb781d3eba5d6ac0860db078af490e5c7c6b (diff) |
block: replace end_request() with [__]blk_end_request_cur()
end_request() has been kept around for backward compatibility;
however, it's about time for it to go away.
* There aren't too many users left.
* Its use of @updtodate is pretty confusing.
* In some cases, newer code ends up using mixture of end_request() and
[__]blk_end_request[_all](), which is way too confusing.
So, add [__]blk_end_request_cur() and replace end_request() with it.
Most conversions are straightforward. Noteworthy ones are...
* paride/pcd: next_request() updated to take 0/-errno instead of 1/0.
* paride/pf: pf_end_request() and next_request() updated to take
0/-errno instead of 1/0.
* xd: xd_readwrite() updated to return 0/-errno instead of 1/0.
* mtd/mtd_blkdevs: blktrans_discard_request() updated to return
0/-errno instead of 1/0. Unnecessary local variable res
initialization removed from mtd_blktrans_thread().
[ Impact: cleanup ]
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Joerg Dorchain <joerg@dorchain.net>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Laurent Vivier <Laurent@lvivier.info>
Cc: Tim Waugh <tim@cyberelk.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Markus Lidel <Markus.Lidel@shadowconnect.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Pete Zaitcev <zaitcev@redhat.com>
Cc: unsik Kim <donari75@gmail.com>
Diffstat (limited to 'drivers/block/swim.c')
-rw-r--r-- | drivers/block/swim.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/block/swim.c b/drivers/block/swim.c index d22cc3856937..6544a7b06bf0 100644 --- a/drivers/block/swim.c +++ b/drivers/block/swim.c | |||
@@ -532,39 +532,39 @@ static void redo_fd_request(struct request_queue *q) | |||
532 | 532 | ||
533 | fs = req->rq_disk->private_data; | 533 | fs = req->rq_disk->private_data; |
534 | if (req->sector < 0 || req->sector >= fs->total_secs) { | 534 | if (req->sector < 0 || req->sector >= fs->total_secs) { |
535 | end_request(req, 0); | 535 | __blk_end_request_cur(req, -EIO); |
536 | continue; | 536 | continue; |
537 | } | 537 | } |
538 | if (req->current_nr_sectors == 0) { | 538 | if (req->current_nr_sectors == 0) { |
539 | end_request(req, 1); | 539 | __blk_end_request_cur(req, 0); |
540 | continue; | 540 | continue; |
541 | } | 541 | } |
542 | if (!fs->disk_in) { | 542 | if (!fs->disk_in) { |
543 | end_request(req, 0); | 543 | __blk_end_request_cur(req, -EIO); |
544 | continue; | 544 | continue; |
545 | } | 545 | } |
546 | if (rq_data_dir(req) == WRITE) { | 546 | if (rq_data_dir(req) == WRITE) { |
547 | if (fs->write_protected) { | 547 | if (fs->write_protected) { |
548 | end_request(req, 0); | 548 | __blk_end_request_cur(req, -EIO); |
549 | continue; | 549 | continue; |
550 | } | 550 | } |
551 | } | 551 | } |
552 | switch (rq_data_dir(req)) { | 552 | switch (rq_data_dir(req)) { |
553 | case WRITE: | 553 | case WRITE: |
554 | /* NOT IMPLEMENTED */ | 554 | /* NOT IMPLEMENTED */ |
555 | end_request(req, 0); | 555 | __blk_end_request_cur(req, -EIO); |
556 | break; | 556 | break; |
557 | case READ: | 557 | case READ: |
558 | if (floppy_read_sectors(fs, req->sector, | 558 | if (floppy_read_sectors(fs, req->sector, |
559 | req->current_nr_sectors, | 559 | req->current_nr_sectors, |
560 | req->buffer)) { | 560 | req->buffer)) { |
561 | end_request(req, 0); | 561 | __blk_end_request_cur(req, -EIO); |
562 | continue; | 562 | continue; |
563 | } | 563 | } |
564 | req->nr_sectors -= req->current_nr_sectors; | 564 | req->nr_sectors -= req->current_nr_sectors; |
565 | req->sector += req->current_nr_sectors; | 565 | req->sector += req->current_nr_sectors; |
566 | req->buffer += req->current_nr_sectors * 512; | 566 | req->buffer += req->current_nr_sectors * 512; |
567 | end_request(req, 1); | 567 | __blk_end_request_cur(req, 0); |
568 | break; | 568 | break; |
569 | } | 569 | } |
570 | } | 570 | } |