diff options
author | Tejun Heo <tj@kernel.org> | 2011-03-09 13:54:27 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2011-03-09 13:54:27 -0500 |
commit | 1a8a74f03fcde1725ff26520220f3d21dbd8faa1 (patch) | |
tree | 5ac4195f4b34f815261ec243357f81967e4384c0 /drivers/block/floppy.c | |
parent | 5b03a1b140e13a28ff6be1526892a9dc538ddef6 (diff) |
floppy,{ami|ata}flop: Convert to bdops->check_events()
Convert the floppy drivers from ->media_changed() to ->check_events().
Both floppy and ataflop buffer media changed state bit and clear them
on revalidation and will behave correctly with kernel event polling.
I can't tell how amiflop clears its event and it's possible that it
may generate spurious events when polled.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Diffstat (limited to 'drivers/block/floppy.c')
-rw-r--r-- | drivers/block/floppy.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 77fc76f8aea9..3851dbc03e05 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c | |||
@@ -3770,13 +3770,14 @@ out2: | |||
3770 | /* | 3770 | /* |
3771 | * Check if the disk has been changed or if a change has been faked. | 3771 | * Check if the disk has been changed or if a change has been faked. |
3772 | */ | 3772 | */ |
3773 | static int check_floppy_change(struct gendisk *disk) | 3773 | static unsigned int floppy_check_events(struct gendisk *disk, |
3774 | unsigned int clearing) | ||
3774 | { | 3775 | { |
3775 | int drive = (long)disk->private_data; | 3776 | int drive = (long)disk->private_data; |
3776 | 3777 | ||
3777 | if (test_bit(FD_DISK_CHANGED_BIT, &UDRS->flags) || | 3778 | if (test_bit(FD_DISK_CHANGED_BIT, &UDRS->flags) || |
3778 | test_bit(FD_VERIFY_BIT, &UDRS->flags)) | 3779 | test_bit(FD_VERIFY_BIT, &UDRS->flags)) |
3779 | return 1; | 3780 | return DISK_EVENT_MEDIA_CHANGE; |
3780 | 3781 | ||
3781 | if (time_after(jiffies, UDRS->last_checked + UDP->checkfreq)) { | 3782 | if (time_after(jiffies, UDRS->last_checked + UDP->checkfreq)) { |
3782 | lock_fdc(drive, false); | 3783 | lock_fdc(drive, false); |
@@ -3788,7 +3789,7 @@ static int check_floppy_change(struct gendisk *disk) | |||
3788 | test_bit(FD_VERIFY_BIT, &UDRS->flags) || | 3789 | test_bit(FD_VERIFY_BIT, &UDRS->flags) || |
3789 | test_bit(drive, &fake_change) || | 3790 | test_bit(drive, &fake_change) || |
3790 | drive_no_geom(drive)) | 3791 | drive_no_geom(drive)) |
3791 | return 1; | 3792 | return DISK_EVENT_MEDIA_CHANGE; |
3792 | return 0; | 3793 | return 0; |
3793 | } | 3794 | } |
3794 | 3795 | ||
@@ -3898,7 +3899,7 @@ static const struct block_device_operations floppy_fops = { | |||
3898 | .release = floppy_release, | 3899 | .release = floppy_release, |
3899 | .ioctl = fd_ioctl, | 3900 | .ioctl = fd_ioctl, |
3900 | .getgeo = fd_getgeo, | 3901 | .getgeo = fd_getgeo, |
3901 | .media_changed = check_floppy_change, | 3902 | .check_events = floppy_check_events, |
3902 | .revalidate_disk = floppy_revalidate, | 3903 | .revalidate_disk = floppy_revalidate, |
3903 | }; | 3904 | }; |
3904 | 3905 | ||
@@ -4205,6 +4206,7 @@ static int __init floppy_init(void) | |||
4205 | disks[dr]->major = FLOPPY_MAJOR; | 4206 | disks[dr]->major = FLOPPY_MAJOR; |
4206 | disks[dr]->first_minor = TOMINOR(dr); | 4207 | disks[dr]->first_minor = TOMINOR(dr); |
4207 | disks[dr]->fops = &floppy_fops; | 4208 | disks[dr]->fops = &floppy_fops; |
4209 | disks[dr]->events = DISK_EVENT_MEDIA_CHANGE; | ||
4208 | sprintf(disks[dr]->disk_name, "fd%d", dr); | 4210 | sprintf(disks[dr]->disk_name, "fd%d", dr); |
4209 | 4211 | ||
4210 | init_timer(&motor_off_timer[dr]); | 4212 | init_timer(&motor_off_timer[dr]); |