diff options
author | Philipp Reisner <philipp.reisner@linbit.com> | 2010-06-23 05:20:05 -0400 |
---|---|---|
committer | Philipp Reisner <philipp.reisner@linbit.com> | 2010-10-14 09:04:46 -0400 |
commit | 84dfb9f564208a0331131d1ab922382c7d61a553 (patch) | |
tree | 1506d6c318afa4a94b13bab6af983031eac5e3cd /drivers/block/drbd/drbd_receiver.c | |
parent | 65d922c33ebd359db25d5846929b2eafc4238fcc (diff) |
drbd: Fixed a deadlock, probably only affected UP machines
After disconnect (most likely mdev->net_cnt == 0) and we are
still in an unstable state (!drbd_state_is_stable()). When we
get an IO request in drbd_get_max_buffers() (called from
__inc_ap_bio_cond(), called from inc_ap_bio()) we wake up
misc_wait. Misc_wait is also used in inc_ap_bio() to sleep
until the outcome of __inc_ap_bio_cond() changes. => Busy loop!
Solution: Have a dedicated wait queue for get_net_conf() and
put_net_conf().
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block/drbd/drbd_receiver.c')
-rw-r--r-- | drivers/block/drbd/drbd_receiver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 224c79ed16e9..22d74d79ba42 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c | |||
@@ -3775,7 +3775,7 @@ static void drbd_disconnect(struct drbd_conf *mdev) | |||
3775 | 3775 | ||
3776 | if (os.conn == C_DISCONNECTING) { | 3776 | if (os.conn == C_DISCONNECTING) { |
3777 | struct hlist_head *h; | 3777 | struct hlist_head *h; |
3778 | wait_event(mdev->misc_wait, atomic_read(&mdev->net_cnt) == 0); | 3778 | wait_event(mdev->net_cnt_wait, atomic_read(&mdev->net_cnt) == 0); |
3779 | 3779 | ||
3780 | /* we must not free the tl_hash | 3780 | /* we must not free the tl_hash |
3781 | * while application io is still on the fly */ | 3781 | * while application io is still on the fly */ |