aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/block/drbd/drbd_receiver.c
diff options
context:
space:
mode:
authorPhilipp Reisner <philipp.reisner@linbit.com>2012-11-09 08:18:43 -0500
committerPhilipp Reisner <philipp.reisner@linbit.com>2012-11-09 08:20:23 -0500
commit986836503e49ccf7e84b813715d344964ec93566 (patch)
treeb3bea7428efde5b77096cef80e5b6bfee494cc12 /drivers/block/drbd/drbd_receiver.c
parentccae7868b0c5697508a541c531cf96b361d62c1c (diff)
parent328e0f125bf41f4f33f684db22015f92cb44fe56 (diff)
Merge branch 'drbd-8.4_ed6' into for-3.8-drivers-drbd-8.4_ed6
Diffstat (limited to 'drivers/block/drbd/drbd_receiver.c')
-rw-r--r--drivers/block/drbd/drbd_receiver.c3869
1 files changed, 2252 insertions, 1617 deletions
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
index eb0cafea1423..0331ad0b61e1 100644
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -48,17 +48,25 @@
48 48
49#include "drbd_vli.h" 49#include "drbd_vli.h"
50 50
51struct packet_info {
52 enum drbd_packet cmd;
53 unsigned int size;
54 unsigned int vnr;
55 void *data;
56};
57
51enum finish_epoch { 58enum finish_epoch {
52 FE_STILL_LIVE, 59 FE_STILL_LIVE,
53 FE_DESTROYED, 60 FE_DESTROYED,
54 FE_RECYCLED, 61 FE_RECYCLED,
55}; 62};
56 63
57static int drbd_do_handshake(struct drbd_conf *mdev); 64static int drbd_do_features(struct drbd_tconn *tconn);
58static int drbd_do_auth(struct drbd_conf *mdev); 65static int drbd_do_auth(struct drbd_tconn *tconn);
66static int drbd_disconnected(struct drbd_conf *mdev);
59 67
60static enum finish_epoch drbd_may_finish_epoch(struct drbd_conf *, struct drbd_epoch *, enum epoch_event); 68static enum finish_epoch drbd_may_finish_epoch(struct drbd_tconn *, struct drbd_epoch *, enum epoch_event);
61static int e_end_block(struct drbd_conf *, struct drbd_work *, int); 69static int e_end_block(struct drbd_work *, int);
62 70
63 71
64#define GFP_TRY (__GFP_HIGHMEM | __GFP_NOWARN) 72#define GFP_TRY (__GFP_HIGHMEM | __GFP_NOWARN)
@@ -142,11 +150,12 @@ static void page_chain_add(struct page **head,
142 *head = chain_first; 150 *head = chain_first;
143} 151}
144 152
145static struct page *drbd_pp_first_pages_or_try_alloc(struct drbd_conf *mdev, int number) 153static struct page *__drbd_alloc_pages(struct drbd_conf *mdev,
154 unsigned int number)
146{ 155{
147 struct page *page = NULL; 156 struct page *page = NULL;
148 struct page *tmp = NULL; 157 struct page *tmp = NULL;
149 int i = 0; 158 unsigned int i = 0;
150 159
151 /* Yes, testing drbd_pp_vacant outside the lock is racy. 160 /* Yes, testing drbd_pp_vacant outside the lock is racy.
152 * So what. It saves a spin_lock. */ 161 * So what. It saves a spin_lock. */
@@ -175,7 +184,7 @@ static struct page *drbd_pp_first_pages_or_try_alloc(struct drbd_conf *mdev, int
175 return page; 184 return page;
176 185
177 /* Not enough pages immediately available this time. 186 /* Not enough pages immediately available this time.
178 * No need to jump around here, drbd_pp_alloc will retry this 187 * No need to jump around here, drbd_alloc_pages will retry this
179 * function "soon". */ 188 * function "soon". */
180 if (page) { 189 if (page) {
181 tmp = page_chain_tail(page, NULL); 190 tmp = page_chain_tail(page, NULL);
@@ -187,9 +196,10 @@ static struct page *drbd_pp_first_pages_or_try_alloc(struct drbd_conf *mdev, int
187 return NULL; 196 return NULL;
188} 197}
189 198
190static void reclaim_net_ee(struct drbd_conf *mdev, struct list_head *to_be_freed) 199static void reclaim_finished_net_peer_reqs(struct drbd_conf *mdev,
200 struct list_head *to_be_freed)
191{ 201{
192 struct drbd_epoch_entry *e; 202 struct drbd_peer_request *peer_req;
193 struct list_head *le, *tle; 203 struct list_head *le, *tle;
194 204
195 /* The EEs are always appended to the end of the list. Since 205 /* The EEs are always appended to the end of the list. Since
@@ -198,8 +208,8 @@ static void reclaim_net_ee(struct drbd_conf *mdev, struct list_head *to_be_freed
198 stop to examine the list... */ 208 stop to examine the list... */
199 209
200 list_for_each_safe(le, tle, &mdev->net_ee) { 210 list_for_each_safe(le, tle, &mdev->net_ee) {
201 e = list_entry(le, struct drbd_epoch_entry, w.list); 211 peer_req = list_entry(le, struct drbd_peer_request, w.list);
202 if (drbd_ee_has_active_page(e)) 212 if (drbd_peer_req_has_active_page(peer_req))
203 break; 213 break;
204 list_move(le, to_be_freed); 214 list_move(le, to_be_freed);
205 } 215 }
@@ -208,18 +218,18 @@ static void reclaim_net_ee(struct drbd_conf *mdev, struct list_head *to_be_freed
208static void drbd_kick_lo_and_reclaim_net(struct drbd_conf *mdev) 218static void drbd_kick_lo_and_reclaim_net(struct drbd_conf *mdev)
209{ 219{
210 LIST_HEAD(reclaimed); 220 LIST_HEAD(reclaimed);
211 struct drbd_epoch_entry *e, *t; 221 struct drbd_peer_request *peer_req, *t;
212 222
213 spin_lock_irq(&mdev->req_lock); 223 spin_lock_irq(&mdev->tconn->req_lock);
214 reclaim_net_ee(mdev, &reclaimed); 224 reclaim_finished_net_peer_reqs(mdev, &reclaimed);
215 spin_unlock_irq(&mdev->req_lock); 225 spin_unlock_irq(&mdev->tconn->req_lock);
216 226
217 list_for_each_entry_safe(e, t, &reclaimed, w.list) 227 list_for_each_entry_safe(peer_req, t, &reclaimed, w.list)
218 drbd_free_net_ee(mdev, e); 228 drbd_free_net_peer_req(mdev, peer_req);
219} 229}
220 230
221/** 231/**
222 * drbd_pp_alloc() - Returns @number pages, retries forever (or until signalled) 232 * drbd_alloc_pages() - Returns @number pages, retries forever (or until signalled)
223 * @mdev: DRBD device. 233 * @mdev: DRBD device.
224 * @number: number of pages requested 234 * @number: number of pages requested
225 * @retry: whether to retry, if not enough pages are available right now 235 * @retry: whether to retry, if not enough pages are available right now
@@ -230,23 +240,31 @@ static void drbd_kick_lo_and_reclaim_net(struct drbd_conf *mdev)
230 * 240 *
231 * Returns a page chain linked via page->private. 241 * Returns a page chain linked via page->private.
232 */ 242 */
233static struct page *drbd_pp_alloc(struct drbd_conf *mdev, unsigned number, bool retry) 243struct page *drbd_alloc_pages(struct drbd_conf *mdev, unsigned int number,
244 bool retry)
234{ 245{
235 struct page *page = NULL; 246 struct page *page = NULL;
247 struct net_conf *nc;
236 DEFINE_WAIT(wait); 248 DEFINE_WAIT(wait);
249 int mxb;
237 250
238 /* Yes, we may run up to @number over max_buffers. If we 251 /* Yes, we may run up to @number over max_buffers. If we
239 * follow it strictly, the admin will get it wrong anyways. */ 252 * follow it strictly, the admin will get it wrong anyways. */
240 if (atomic_read(&mdev->pp_in_use) < mdev->net_conf->max_buffers) 253 rcu_read_lock();
241 page = drbd_pp_first_pages_or_try_alloc(mdev, number); 254 nc = rcu_dereference(mdev->tconn->net_conf);
255 mxb = nc ? nc->max_buffers : 1000000;
256 rcu_read_unlock();
257
258 if (atomic_read(&mdev->pp_in_use) < mxb)
259 page = __drbd_alloc_pages(mdev, number);
242 260
243 while (page == NULL) { 261 while (page == NULL) {
244 prepare_to_wait(&drbd_pp_wait, &wait, TASK_INTERRUPTIBLE); 262 prepare_to_wait(&drbd_pp_wait, &wait, TASK_INTERRUPTIBLE);
245 263
246 drbd_kick_lo_and_reclaim_net(mdev); 264 drbd_kick_lo_and_reclaim_net(mdev);
247 265
248 if (atomic_read(&mdev->pp_in_use) < mdev->net_conf->max_buffers) { 266 if (atomic_read(&mdev->pp_in_use) < mxb) {
249 page = drbd_pp_first_pages_or_try_alloc(mdev, number); 267 page = __drbd_alloc_pages(mdev, number);
250 if (page) 268 if (page)
251 break; 269 break;
252 } 270 }
@@ -255,7 +273,7 @@ static struct page *drbd_pp_alloc(struct drbd_conf *mdev, unsigned number, bool
255 break; 273 break;
256 274
257 if (signal_pending(current)) { 275 if (signal_pending(current)) {
258 dev_warn(DEV, "drbd_pp_alloc interrupted!\n"); 276 dev_warn(DEV, "drbd_alloc_pages interrupted!\n");
259 break; 277 break;
260 } 278 }
261 279
@@ -268,11 +286,11 @@ static struct page *drbd_pp_alloc(struct drbd_conf *mdev, unsigned number, bool
268 return page; 286 return page;
269} 287}
270 288
271/* Must not be used from irq, as that may deadlock: see drbd_pp_alloc. 289/* Must not be used from irq, as that may deadlock: see drbd_alloc_pages.
272 * Is also used from inside an other spin_lock_irq(&mdev->req_lock); 290 * Is also used from inside an other spin_lock_irq(&mdev->tconn->req_lock);
273 * Either links the page chain back to the global pool, 291 * Either links the page chain back to the global pool,
274 * or returns all pages to the system. */ 292 * or returns all pages to the system. */
275static void drbd_pp_free(struct drbd_conf *mdev, struct page *page, int is_net) 293static void drbd_free_pages(struct drbd_conf *mdev, struct page *page, int is_net)
276{ 294{
277 atomic_t *a = is_net ? &mdev->pp_in_use_by_net : &mdev->pp_in_use; 295 atomic_t *a = is_net ? &mdev->pp_in_use_by_net : &mdev->pp_in_use;
278 int i; 296 int i;
@@ -280,7 +298,7 @@ static void drbd_pp_free(struct drbd_conf *mdev, struct page *page, int is_net)
280 if (page == NULL) 298 if (page == NULL)
281 return; 299 return;
282 300
283 if (drbd_pp_vacant > (DRBD_MAX_BIO_SIZE/PAGE_SIZE)*minor_count) 301 if (drbd_pp_vacant > (DRBD_MAX_BIO_SIZE/PAGE_SIZE) * minor_count)
284 i = page_chain_free(page); 302 i = page_chain_free(page);
285 else { 303 else {
286 struct page *tmp; 304 struct page *tmp;
@@ -302,127 +320,130 @@ You need to hold the req_lock:
302 _drbd_wait_ee_list_empty() 320 _drbd_wait_ee_list_empty()
303 321
304You must not have the req_lock: 322You must not have the req_lock:
305 drbd_free_ee() 323 drbd_free_peer_req()
306 drbd_alloc_ee() 324 drbd_alloc_peer_req()
307 drbd_init_ee() 325 drbd_free_peer_reqs()
308 drbd_release_ee()
309 drbd_ee_fix_bhs() 326 drbd_ee_fix_bhs()
310 drbd_process_done_ee() 327 drbd_finish_peer_reqs()
311 drbd_clear_done_ee() 328 drbd_clear_done_ee()
312 drbd_wait_ee_list_empty() 329 drbd_wait_ee_list_empty()
313*/ 330*/
314 331
315struct drbd_epoch_entry *drbd_alloc_ee(struct drbd_conf *mdev, 332struct drbd_peer_request *
316 u64 id, 333drbd_alloc_peer_req(struct drbd_conf *mdev, u64 id, sector_t sector,
317 sector_t sector, 334 unsigned int data_size, gfp_t gfp_mask) __must_hold(local)
318 unsigned int data_size,
319 gfp_t gfp_mask) __must_hold(local)
320{ 335{
321 struct drbd_epoch_entry *e; 336 struct drbd_peer_request *peer_req;
322 struct page *page = NULL; 337 struct page *page = NULL;
323 unsigned nr_pages = (data_size + PAGE_SIZE -1) >> PAGE_SHIFT; 338 unsigned nr_pages = (data_size + PAGE_SIZE -1) >> PAGE_SHIFT;
324 339
325 if (drbd_insert_fault(mdev, DRBD_FAULT_AL_EE)) 340 if (drbd_insert_fault(mdev, DRBD_FAULT_AL_EE))
326 return NULL; 341 return NULL;
327 342
328 e = mempool_alloc(drbd_ee_mempool, gfp_mask & ~__GFP_HIGHMEM); 343 peer_req = mempool_alloc(drbd_ee_mempool, gfp_mask & ~__GFP_HIGHMEM);
329 if (!e) { 344 if (!peer_req) {
330 if (!(gfp_mask & __GFP_NOWARN)) 345 if (!(gfp_mask & __GFP_NOWARN))
331 dev_err(DEV, "alloc_ee: Allocation of an EE failed\n"); 346 dev_err(DEV, "%s: allocation failed\n", __func__);
332 return NULL; 347 return NULL;
333 } 348 }
334 349
335 if (data_size) { 350 if (data_size) {
336 page = drbd_pp_alloc(mdev, nr_pages, (gfp_mask & __GFP_WAIT)); 351 page = drbd_alloc_pages(mdev, nr_pages, (gfp_mask & __GFP_WAIT));
337 if (!page) 352 if (!page)
338 goto fail; 353 goto fail;
339 } 354 }
340 355
341 INIT_HLIST_NODE(&e->collision); 356 drbd_clear_interval(&peer_req->i);
342 e->epoch = NULL; 357 peer_req->i.size = data_size;
343 e->mdev = mdev; 358 peer_req->i.sector = sector;
344 e->pages = page; 359 peer_req->i.local = false;
345 atomic_set(&e->pending_bios, 0); 360 peer_req->i.waiting = false;
346 e->size = data_size; 361
347 e->flags = 0; 362 peer_req->epoch = NULL;
348 e->sector = sector; 363 peer_req->w.mdev = mdev;
349 e->block_id = id; 364 peer_req->pages = page;
365 atomic_set(&peer_req->pending_bios, 0);
366 peer_req->flags = 0;
367 /*
368 * The block_id is opaque to the receiver. It is not endianness
369 * converted, and sent back to the sender unchanged.
370 */
371 peer_req->block_id = id;
350 372
351 return e; 373 return peer_req;
352 374
353 fail: 375 fail:
354 mempool_free(e, drbd_ee_mempool); 376 mempool_free(peer_req, drbd_ee_mempool);
355 return NULL; 377 return NULL;
356} 378}
357 379
358void drbd_free_some_ee(struct drbd_conf *mdev, struct drbd_epoch_entry *e, int is_net) 380void __drbd_free_peer_req(struct drbd_conf *mdev, struct drbd_peer_request *peer_req,
381 int is_net)
359{ 382{
360 if (e->flags & EE_HAS_DIGEST) 383 if (peer_req->flags & EE_HAS_DIGEST)
361 kfree(e->digest); 384 kfree(peer_req->digest);
362 drbd_pp_free(mdev, e->pages, is_net); 385 drbd_free_pages(mdev, peer_req->pages, is_net);
363 D_ASSERT(atomic_read(&e->pending_bios) == 0); 386 D_ASSERT(atomic_read(&peer_req->pending_bios) == 0);
364 D_ASSERT(hlist_unhashed(&e->collision)); 387 D_ASSERT(drbd_interval_empty(&peer_req->i));
365 mempool_free(e, drbd_ee_mempool); 388 mempool_free(peer_req, drbd_ee_mempool);
366} 389}
367 390
368int drbd_release_ee(struct drbd_conf *mdev, struct list_head *list) 391int drbd_free_peer_reqs(struct drbd_conf *mdev, struct list_head *list)
369{ 392{
370 LIST_HEAD(work_list); 393 LIST_HEAD(work_list);
371 struct drbd_epoch_entry *e, *t; 394 struct drbd_peer_request *peer_req, *t;
372 int count = 0; 395 int count = 0;
373 int is_net = list == &mdev->net_ee; 396 int is_net = list == &mdev->net_ee;
374 397
375 spin_lock_irq(&mdev->req_lock); 398 spin_lock_irq(&mdev->tconn->req_lock);
376 list_splice_init(list, &work_list); 399 list_splice_init(list, &work_list);
377 spin_unlock_irq(&mdev->req_lock); 400 spin_unlock_irq(&mdev->tconn->req_lock);
378 401
379 list_for_each_entry_safe(e, t, &work_list, w.list) { 402 list_for_each_entry_safe(peer_req, t, &work_list, w.list) {
380 drbd_free_some_ee(mdev, e, is_net); 403 __drbd_free_peer_req(mdev, peer_req, is_net);
381 count++; 404 count++;
382 } 405 }
383 return count; 406 return count;
384} 407}
385 408
386
387/* 409/*
388 * This function is called from _asender only_ 410 * See also comments in _req_mod(,BARRIER_ACKED) and receive_Barrier.
389 * but see also comments in _req_mod(,barrier_acked)
390 * and receive_Barrier.
391 *
392 * Move entries from net_ee to done_ee, if ready.
393 * Grab done_ee, call all callbacks, free the entries.
394 * The callbacks typically send out ACKs.
395 */ 411 */
396static int drbd_process_done_ee(struct drbd_conf *mdev) 412static int drbd_finish_peer_reqs(struct drbd_conf *mdev)
397{ 413{
398 LIST_HEAD(work_list); 414 LIST_HEAD(work_list);
399 LIST_HEAD(reclaimed); 415 LIST_HEAD(reclaimed);
400 struct drbd_epoch_entry *e, *t; 416 struct drbd_peer_request *peer_req, *t;
401 int ok = (mdev->state.conn >= C_WF_REPORT_PARAMS); 417 int err = 0;
402 418
403 spin_lock_irq(&mdev->req_lock); 419 spin_lock_irq(&mdev->tconn->req_lock);
404 reclaim_net_ee(mdev, &reclaimed); 420 reclaim_finished_net_peer_reqs(mdev, &reclaimed);
405 list_splice_init(&mdev->done_ee, &work_list); 421 list_splice_init(&mdev->done_ee, &work_list);
406 spin_unlock_irq(&mdev->req_lock); 422 spin_unlock_irq(&mdev->tconn->req_lock);
407 423
408 list_for_each_entry_safe(e, t, &reclaimed, w.list) 424 list_for_each_entry_safe(peer_req, t, &reclaimed, w.list)
409 drbd_free_net_ee(mdev, e); 425 drbd_free_net_peer_req(mdev, peer_req);
410 426
411 /* possible callbacks here: 427 /* possible callbacks here:
412 * e_end_block, and e_end_resync_block, e_send_discard_ack. 428 * e_end_block, and e_end_resync_block, e_send_superseded.
413 * all ignore the last argument. 429 * all ignore the last argument.
414 */ 430 */
415 list_for_each_entry_safe(e, t, &work_list, w.list) { 431 list_for_each_entry_safe(peer_req, t, &work_list, w.list) {
432 int err2;
433
416 /* list_del not necessary, next/prev members not touched */ 434 /* list_del not necessary, next/prev members not touched */
417 ok = e->w.cb(mdev, &e->w, !ok) && ok; 435 err2 = peer_req->w.cb(&peer_req->w, !!err);
418 drbd_free_ee(mdev, e); 436 if (!err)
437 err = err2;
438 drbd_free_peer_req(mdev, peer_req);
419 } 439 }
420 wake_up(&mdev->ee_wait); 440 wake_up(&mdev->ee_wait);
421 441
422 return ok; 442 return err;
423} 443}
424 444
425void _drbd_wait_ee_list_empty(struct drbd_conf *mdev, struct list_head *head) 445static void _drbd_wait_ee_list_empty(struct drbd_conf *mdev,
446 struct list_head *head)
426{ 447{
427 DEFINE_WAIT(wait); 448 DEFINE_WAIT(wait);
428 449
@@ -430,55 +451,22 @@ void _drbd_wait_ee_list_empty(struct drbd_conf *mdev, struct list_head *head)
430 * and calling prepare_to_wait in the fast path */ 451 * and calling prepare_to_wait in the fast path */
431 while (!list_empty(head)) { 452 while (!list_empty(head)) {
432 prepare_to_wait(&mdev->ee_wait, &wait, TASK_UNINTERRUPTIBLE); 453 prepare_to_wait(&mdev->ee_wait, &wait, TASK_UNINTERRUPTIBLE);
433 spin_unlock_irq(&mdev->req_lock); 454 spin_unlock_irq(&mdev->tconn->req_lock);
434 io_schedule(); 455 io_schedule();
435 finish_wait(&mdev->ee_wait, &wait); 456 finish_wait(&mdev->ee_wait, &wait);
436 spin_lock_irq(&mdev->req_lock); 457 spin_lock_irq(&mdev->tconn->req_lock);
437 } 458 }
438} 459}
439 460
440void drbd_wait_ee_list_empty(struct drbd_conf *mdev, struct list_head *head) 461static void drbd_wait_ee_list_empty(struct drbd_conf *mdev,
462 struct list_head *head)
441{ 463{
442 spin_lock_irq(&mdev->req_lock); 464 spin_lock_irq(&mdev->tconn->req_lock);
443 _drbd_wait_ee_list_empty(mdev, head); 465 _drbd_wait_ee_list_empty(mdev, head);
444 spin_unlock_irq(&mdev->req_lock); 466 spin_unlock_irq(&mdev->tconn->req_lock);
445}
446
447/* see also kernel_accept; which is only present since 2.6.18.
448 * also we want to log which part of it failed, exactly */
449static int drbd_accept(struct drbd_conf *mdev, const char **what,
450 struct socket *sock, struct socket **newsock)
451{
452 struct sock *sk = sock->sk;
453 int err = 0;
454
455 *what = "listen";
456 err = sock->ops->listen(sock, 5);
457 if (err < 0)
458 goto out;
459
460 *what = "sock_create_lite";
461 err = sock_create_lite(sk->sk_family, sk->sk_type, sk->sk_protocol,
462 newsock);
463 if (err < 0)
464 goto out;
465
466 *what = "accept";
467 err = sock->ops->accept(sock, *newsock, 0);
468 if (err < 0) {
469 sock_release(*newsock);
470 *newsock = NULL;
471 goto out;
472 }
473 (*newsock)->ops = sock->ops;
474 __module_get((*newsock)->ops->owner);
475
476out:
477 return err;
478} 467}
479 468
480static int drbd_recv_short(struct drbd_conf *mdev, struct socket *sock, 469static int drbd_recv_short(struct socket *sock, void *buf, size_t size, int flags)
481 void *buf, size_t size, int flags)
482{ 470{
483 mm_segment_t oldfs; 471 mm_segment_t oldfs;
484 struct kvec iov = { 472 struct kvec iov = {
@@ -500,48 +488,62 @@ static int drbd_recv_short(struct drbd_conf *mdev, struct socket *sock,
500 return rv; 488 return rv;
501} 489}
502 490
503static int drbd_recv(struct drbd_conf *mdev, void *buf, size_t size) 491static int drbd_recv(struct drbd_tconn *tconn, void *buf, size_t size)
504{ 492{
505 mm_segment_t oldfs;
506 struct kvec iov = {
507 .iov_base = buf,
508 .iov_len = size,
509 };
510 struct msghdr msg = {
511 .msg_iovlen = 1,
512 .msg_iov = (struct iovec *)&iov,
513 .msg_flags = MSG_WAITALL | MSG_NOSIGNAL
514 };
515 int rv; 493 int rv;
516 494
517 oldfs = get_fs(); 495 rv = drbd_recv_short(tconn->data.socket, buf, size, 0);
518 set_fs(KERNEL_DS);
519 rv = sock_recvmsg(mdev->data.socket, &msg, size, msg.msg_flags);
520 set_fs(oldfs);
521 496
522 if (rv < 0) { 497 if (rv < 0) {
523 if (rv == -ECONNRESET) 498 if (rv == -ECONNRESET)
524 dev_info(DEV, "sock was reset by peer\n"); 499 conn_info(tconn, "sock was reset by peer\n");
525 else if (rv != -ERESTARTSYS) 500 else if (rv != -ERESTARTSYS)
526 dev_err(DEV, "sock_recvmsg returned %d\n", rv); 501 conn_err(tconn, "sock_recvmsg returned %d\n", rv);
527 } else if (rv == 0) { 502 } else if (rv == 0) {
528 if (drbd_test_flag(mdev, DISCONNECT_SENT)) { 503 if (test_bit(DISCONNECT_SENT, &tconn->flags)) {
529 long t; /* time_left */ 504 long t;
530 t = wait_event_timeout(mdev->state_wait, mdev->state.conn < C_CONNECTED, 505 rcu_read_lock();
531 mdev->net_conf->ping_timeo * HZ/10); 506 t = rcu_dereference(tconn->net_conf)->ping_timeo * HZ/10;
507 rcu_read_unlock();
508
509 t = wait_event_timeout(tconn->ping_wait, tconn->cstate < C_WF_REPORT_PARAMS, t);
510
532 if (t) 511 if (t)
533 goto out; 512 goto out;
534 } 513 }
535 dev_info(DEV, "sock was shut down by peer\n"); 514 conn_info(tconn, "sock was shut down by peer\n");
536 } 515 }
537 516
538 if (rv != size) 517 if (rv != size)
539 drbd_force_state(mdev, NS(conn, C_BROKEN_PIPE)); 518 conn_request_state(tconn, NS(conn, C_BROKEN_PIPE), CS_HARD);
540 519
541out: 520out:
542 return rv; 521 return rv;
543} 522}
544 523
524static int drbd_recv_all(struct drbd_tconn *tconn, void *buf, size_t size)
525{
526 int err;
527
528 err = drbd_recv(tconn, buf, size);
529 if (err != size) {
530 if (err >= 0)
531 err = -EIO;
532 } else
533 err = 0;
534 return err;
535}
536
537static int drbd_recv_all_warn(struct drbd_tconn *tconn, void *buf, size_t size)
538{
539 int err;
540
541 err = drbd_recv_all(tconn, buf, size);
542 if (err && !signal_pending(current))
543 conn_warn(tconn, "short read (expected size %d)\n", (int)size);
544 return err;
545}
546
545/* quoting tcp(7): 547/* quoting tcp(7):
546 * On individual connections, the socket buffer size must be set prior to the 548 * On individual connections, the socket buffer size must be set prior to the
547 * listen(2) or connect(2) calls in order to have it take effect. 549 * listen(2) or connect(2) calls in order to have it take effect.
@@ -561,29 +563,50 @@ static void drbd_setbufsize(struct socket *sock, unsigned int snd,
561 } 563 }
562} 564}
563 565
564static struct socket *drbd_try_connect(struct drbd_conf *mdev) 566static struct socket *drbd_try_connect(struct drbd_tconn *tconn)
565{ 567{
566 const char *what; 568 const char *what;
567 struct socket *sock; 569 struct socket *sock;
568 struct sockaddr_in6 src_in6; 570 struct sockaddr_in6 src_in6;
569 int err; 571 struct sockaddr_in6 peer_in6;
572 struct net_conf *nc;
573 int err, peer_addr_len, my_addr_len;
574 int sndbuf_size, rcvbuf_size, connect_int;
570 int disconnect_on_error = 1; 575 int disconnect_on_error = 1;
571 576
572 if (!get_net_conf(mdev)) 577 rcu_read_lock();
578 nc = rcu_dereference(tconn->net_conf);
579 if (!nc) {
580 rcu_read_unlock();
573 return NULL; 581 return NULL;
582 }
583 sndbuf_size = nc->sndbuf_size;
584 rcvbuf_size = nc->rcvbuf_size;
585 connect_int = nc->connect_int;
586 rcu_read_unlock();
587
588 my_addr_len = min_t(int, tconn->my_addr_len, sizeof(src_in6));
589 memcpy(&src_in6, &tconn->my_addr, my_addr_len);
590
591 if (((struct sockaddr *)&tconn->my_addr)->sa_family == AF_INET6)
592 src_in6.sin6_port = 0;
593 else
594 ((struct sockaddr_in *)&src_in6)->sin_port = 0; /* AF_INET & AF_SCI */
595
596 peer_addr_len = min_t(int, tconn->peer_addr_len, sizeof(src_in6));
597 memcpy(&peer_in6, &tconn->peer_addr, peer_addr_len);
574 598
575 what = "sock_create_kern"; 599 what = "sock_create_kern";
576 err = sock_create_kern(((struct sockaddr *)mdev->net_conf->my_addr)->sa_family, 600 err = sock_create_kern(((struct sockaddr *)&src_in6)->sa_family,
577 SOCK_STREAM, IPPROTO_TCP, &sock); 601 SOCK_STREAM, IPPROTO_TCP, &sock);
578 if (err < 0) { 602 if (err < 0) {
579 sock = NULL; 603 sock = NULL;
580 goto out; 604 goto out;
581 } 605 }
582 606
583 sock->sk->sk_rcvtimeo = 607 sock->sk->sk_rcvtimeo =
584 sock->sk->sk_sndtimeo = mdev->net_conf->try_connect_int*HZ; 608 sock->sk->sk_sndtimeo = connect_int * HZ;
585 drbd_setbufsize(sock, mdev->net_conf->sndbuf_size, 609 drbd_setbufsize(sock, sndbuf_size, rcvbuf_size);
586 mdev->net_conf->rcvbuf_size);
587 610
588 /* explicitly bind to the configured IP as source IP 611 /* explicitly bind to the configured IP as source IP
589 * for the outgoing connections. 612 * for the outgoing connections.
@@ -592,17 +615,8 @@ static struct socket *drbd_try_connect(struct drbd_conf *mdev)
592 * Make sure to use 0 as port number, so linux selects 615 * Make sure to use 0 as port number, so linux selects
593 * a free one dynamically. 616 * a free one dynamically.
594 */ 617 */
595 memcpy(&src_in6, mdev->net_conf->my_addr,
596 min_t(int, mdev->net_conf->my_addr_len, sizeof(src_in6)));
597 if (((struct sockaddr *)mdev->net_conf->my_addr)->sa_family == AF_INET6)
598 src_in6.sin6_port = 0;
599 else
600 ((struct sockaddr_in *)&src_in6)->sin_port = 0; /* AF_INET & AF_SCI */
601
602 what = "bind before connect"; 618 what = "bind before connect";
603 err = sock->ops->bind(sock, 619 err = sock->ops->bind(sock, (struct sockaddr *) &src_in6, my_addr_len);
604 (struct sockaddr *) &src_in6,
605 mdev->net_conf->my_addr_len);
606 if (err < 0) 620 if (err < 0)
607 goto out; 621 goto out;
608 622
@@ -610,9 +624,7 @@ static struct socket *drbd_try_connect(struct drbd_conf *mdev)
610 * stay C_WF_CONNECTION, don't go Disconnecting! */ 624 * stay C_WF_CONNECTION, don't go Disconnecting! */
611 disconnect_on_error = 0; 625 disconnect_on_error = 0;
612 what = "connect"; 626 what = "connect";
613 err = sock->ops->connect(sock, 627 err = sock->ops->connect(sock, (struct sockaddr *) &peer_in6, peer_addr_len, 0);
614 (struct sockaddr *)mdev->net_conf->peer_addr,
615 mdev->net_conf->peer_addr_len, 0);
616 628
617out: 629out:
618 if (err < 0) { 630 if (err < 0) {
@@ -630,91 +642,174 @@ out:
630 disconnect_on_error = 0; 642 disconnect_on_error = 0;
631 break; 643 break;
632 default: 644 default:
633 dev_err(DEV, "%s failed, err = %d\n", what, err); 645 conn_err(tconn, "%s failed, err = %d\n", what, err);
634 } 646 }
635 if (disconnect_on_error) 647 if (disconnect_on_error)
636 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 648 conn_request_state(tconn, NS(conn, C_DISCONNECTING), CS_HARD);
637 } 649 }
638 put_net_conf(mdev); 650
639 return sock; 651 return sock;
640} 652}
641 653
642static struct socket *drbd_wait_for_connect(struct drbd_conf *mdev) 654struct accept_wait_data {
655 struct drbd_tconn *tconn;
656 struct socket *s_listen;
657 struct completion door_bell;
658 void (*original_sk_state_change)(struct sock *sk);
659
660};
661
662static void drbd_incoming_connection(struct sock *sk)
663{
664 struct accept_wait_data *ad = sk->sk_user_data;
665 void (*state_change)(struct sock *sk);
666
667 state_change = ad->original_sk_state_change;
668 if (sk->sk_state == TCP_ESTABLISHED)
669 complete(&ad->door_bell);
670 state_change(sk);
671}
672
673static int prepare_listen_socket(struct drbd_tconn *tconn, struct accept_wait_data *ad)
643{ 674{
644 int timeo, err; 675 int err, sndbuf_size, rcvbuf_size, my_addr_len;
645 struct socket *s_estab = NULL, *s_listen; 676 struct sockaddr_in6 my_addr;
677 struct socket *s_listen;
678 struct net_conf *nc;
646 const char *what; 679 const char *what;
647 680
648 if (!get_net_conf(mdev)) 681 rcu_read_lock();
649 return NULL; 682 nc = rcu_dereference(tconn->net_conf);
683 if (!nc) {
684 rcu_read_unlock();
685 return -EIO;
686 }
687 sndbuf_size = nc->sndbuf_size;
688 rcvbuf_size = nc->rcvbuf_size;
689 rcu_read_unlock();
690
691 my_addr_len = min_t(int, tconn->my_addr_len, sizeof(struct sockaddr_in6));
692 memcpy(&my_addr, &tconn->my_addr, my_addr_len);
650 693
651 what = "sock_create_kern"; 694 what = "sock_create_kern";
652 err = sock_create_kern(((struct sockaddr *)mdev->net_conf->my_addr)->sa_family, 695 err = sock_create_kern(((struct sockaddr *)&my_addr)->sa_family,
653 SOCK_STREAM, IPPROTO_TCP, &s_listen); 696 SOCK_STREAM, IPPROTO_TCP, &s_listen);
654 if (err) { 697 if (err) {
655 s_listen = NULL; 698 s_listen = NULL;
656 goto out; 699 goto out;
657 } 700 }
658 701
659 timeo = mdev->net_conf->try_connect_int * HZ; 702 s_listen->sk->sk_reuse = SK_CAN_REUSE; /* SO_REUSEADDR */
660 timeo += (random32() & 1) ? timeo / 7 : -timeo / 7; /* 28.5% random jitter */ 703 drbd_setbufsize(s_listen, sndbuf_size, rcvbuf_size);
661
662 s_listen->sk->sk_reuse = SK_CAN_REUSE; /* SO_REUSEADDR */
663 s_listen->sk->sk_rcvtimeo = timeo;
664 s_listen->sk->sk_sndtimeo = timeo;
665 drbd_setbufsize(s_listen, mdev->net_conf->sndbuf_size,
666 mdev->net_conf->rcvbuf_size);
667 704
668 what = "bind before listen"; 705 what = "bind before listen";
669 err = s_listen->ops->bind(s_listen, 706 err = s_listen->ops->bind(s_listen, (struct sockaddr *)&my_addr, my_addr_len);
670 (struct sockaddr *) mdev->net_conf->my_addr,
671 mdev->net_conf->my_addr_len);
672 if (err < 0) 707 if (err < 0)
673 goto out; 708 goto out;
674 709
675 err = drbd_accept(mdev, &what, s_listen, &s_estab); 710 ad->s_listen = s_listen;
711 write_lock_bh(&s_listen->sk->sk_callback_lock);
712 ad->original_sk_state_change = s_listen->sk->sk_state_change;
713 s_listen->sk->sk_state_change = drbd_incoming_connection;
714 s_listen->sk->sk_user_data = ad;
715 write_unlock_bh(&s_listen->sk->sk_callback_lock);
716
717 what = "listen";
718 err = s_listen->ops->listen(s_listen, 5);
719 if (err < 0)
720 goto out;
676 721
722 return 0;
677out: 723out:
678 if (s_listen) 724 if (s_listen)
679 sock_release(s_listen); 725 sock_release(s_listen);
680 if (err < 0) { 726 if (err < 0) {
681 if (err != -EAGAIN && err != -EINTR && err != -ERESTARTSYS) { 727 if (err != -EAGAIN && err != -EINTR && err != -ERESTARTSYS) {
682 dev_err(DEV, "%s failed, err = %d\n", what, err); 728 conn_err(tconn, "%s failed, err = %d\n", what, err);
683 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 729 conn_request_state(tconn, NS(conn, C_DISCONNECTING), CS_HARD);
684 } 730 }
685 } 731 }
686 put_net_conf(mdev);
687 732
688 return s_estab; 733 return -EIO;
689} 734}
690 735
691static int drbd_send_fp(struct drbd_conf *mdev, 736static void unregister_state_change(struct sock *sk, struct accept_wait_data *ad)
692 struct socket *sock, enum drbd_packets cmd)
693{ 737{
694 struct p_header80 *h = &mdev->data.sbuf.header.h80; 738 write_lock_bh(&sk->sk_callback_lock);
695 739 sk->sk_state_change = ad->original_sk_state_change;
696 return _drbd_send_cmd(mdev, sock, cmd, h, sizeof(*h), 0); 740 sk->sk_user_data = NULL;
741 write_unlock_bh(&sk->sk_callback_lock);
697} 742}
698 743
699static enum drbd_packets drbd_recv_fp(struct drbd_conf *mdev, struct socket *sock) 744static struct socket *drbd_wait_for_connect(struct drbd_tconn *tconn, struct accept_wait_data *ad)
700{ 745{
701 struct p_header80 *h = &mdev->data.rbuf.header.h80; 746 int timeo, connect_int, err = 0;
702 int rr; 747 struct socket *s_estab = NULL;
748 struct net_conf *nc;
749
750 rcu_read_lock();
751 nc = rcu_dereference(tconn->net_conf);
752 if (!nc) {
753 rcu_read_unlock();
754 return NULL;
755 }
756 connect_int = nc->connect_int;
757 rcu_read_unlock();
758
759 timeo = connect_int * HZ;
760 timeo += (random32() & 1) ? timeo / 7 : -timeo / 7; /* 28.5% random jitter */
703 761
704 rr = drbd_recv_short(mdev, sock, h, sizeof(*h), 0); 762 err = wait_for_completion_interruptible_timeout(&ad->door_bell, timeo);
763 if (err <= 0)
764 return NULL;
705 765
706 if (rr == sizeof(*h) && h->magic == BE_DRBD_MAGIC) 766 err = kernel_accept(ad->s_listen, &s_estab, 0);
707 return be16_to_cpu(h->command); 767 if (err < 0) {
768 if (err != -EAGAIN && err != -EINTR && err != -ERESTARTSYS) {
769 conn_err(tconn, "accept failed, err = %d\n", err);
770 conn_request_state(tconn, NS(conn, C_DISCONNECTING), CS_HARD);
771 }
772 }
708 773
709 return 0xffff; 774 if (s_estab)
775 unregister_state_change(s_estab->sk, ad);
776
777 return s_estab;
778}
779
780static int decode_header(struct drbd_tconn *, void *, struct packet_info *);
781
782static int send_first_packet(struct drbd_tconn *tconn, struct drbd_socket *sock,
783 enum drbd_packet cmd)
784{
785 if (!conn_prepare_command(tconn, sock))
786 return -EIO;
787 return conn_send_command(tconn, sock, cmd, 0, NULL, 0);
788}
789
790static int receive_first_packet(struct drbd_tconn *tconn, struct socket *sock)
791{
792 unsigned int header_size = drbd_header_size(tconn);
793 struct packet_info pi;
794 int err;
795
796 err = drbd_recv_short(sock, tconn->data.rbuf, header_size, 0);
797 if (err != header_size) {
798 if (err >= 0)
799 err = -EIO;
800 return err;
801 }
802 err = decode_header(tconn, tconn->data.rbuf, &pi);
803 if (err)
804 return err;
805 return pi.cmd;
710} 806}
711 807
712/** 808/**
713 * drbd_socket_okay() - Free the socket if its connection is not okay 809 * drbd_socket_okay() - Free the socket if its connection is not okay
714 * @mdev: DRBD device.
715 * @sock: pointer to the pointer to the socket. 810 * @sock: pointer to the pointer to the socket.
716 */ 811 */
717static int drbd_socket_okay(struct drbd_conf *mdev, struct socket **sock) 812static int drbd_socket_okay(struct socket **sock)
718{ 813{
719 int rr; 814 int rr;
720 char tb[4]; 815 char tb[4];
@@ -722,7 +817,7 @@ static int drbd_socket_okay(struct drbd_conf *mdev, struct socket **sock)
722 if (!*sock) 817 if (!*sock)
723 return false; 818 return false;
724 819
725 rr = drbd_recv_short(mdev, *sock, tb, 4, MSG_DONTWAIT | MSG_PEEK); 820 rr = drbd_recv_short(*sock, tb, 4, MSG_DONTWAIT | MSG_PEEK);
726 821
727 if (rr > 0 || rr == -EAGAIN) { 822 if (rr > 0 || rr == -EAGAIN) {
728 return true; 823 return true;
@@ -732,6 +827,31 @@ static int drbd_socket_okay(struct drbd_conf *mdev, struct socket **sock)
732 return false; 827 return false;
733 } 828 }
734} 829}
830/* Gets called if a connection is established, or if a new minor gets created
831 in a connection */
832int drbd_connected(struct drbd_conf *mdev)
833{
834 int err;
835
836 atomic_set(&mdev->packet_seq, 0);
837 mdev->peer_seq = 0;
838
839 mdev->state_mutex = mdev->tconn->agreed_pro_version < 100 ?
840 &mdev->tconn->cstate_mutex :
841 &mdev->own_state_mutex;
842
843 err = drbd_send_sync_param(mdev);
844 if (!err)
845 err = drbd_send_sizes(mdev, 0, 0);
846 if (!err)
847 err = drbd_send_uuids(mdev);
848 if (!err)
849 err = drbd_send_current_state(mdev);
850 clear_bit(USE_DEGR_WFC_T, &mdev->flags);
851 clear_bit(RESIZE_PENDING, &mdev->flags);
852 mod_timer(&mdev->request_timer, jiffies + HZ); /* just start it here. */
853 return err;
854}
735 855
736/* 856/*
737 * return values: 857 * return values:
@@ -741,232 +861,305 @@ static int drbd_socket_okay(struct drbd_conf *mdev, struct socket **sock)
741 * no point in trying again, please go standalone. 861 * no point in trying again, please go standalone.
742 * -2 We do not have a network config... 862 * -2 We do not have a network config...
743 */ 863 */
744static int drbd_connect(struct drbd_conf *mdev) 864static int conn_connect(struct drbd_tconn *tconn)
745{ 865{
746 struct socket *s, *sock, *msock; 866 struct drbd_socket sock, msock;
747 int try, h, ok; 867 struct drbd_conf *mdev;
868 struct net_conf *nc;
869 int vnr, timeout, h, ok;
870 bool discard_my_data;
748 enum drbd_state_rv rv; 871 enum drbd_state_rv rv;
872 struct accept_wait_data ad = {
873 .tconn = tconn,
874 .door_bell = COMPLETION_INITIALIZER_ONSTACK(ad.door_bell),
875 };
749 876
750 D_ASSERT(!mdev->data.socket); 877 clear_bit(DISCONNECT_SENT, &tconn->flags);
751 878 if (conn_request_state(tconn, NS(conn, C_WF_CONNECTION), CS_VERBOSE) < SS_SUCCESS)
752 drbd_clear_flag(mdev, DISCONNECT_SENT);
753 if (drbd_request_state(mdev, NS(conn, C_WF_CONNECTION)) < SS_SUCCESS)
754 return -2; 879 return -2;
755 880
756 sock = NULL; 881 mutex_init(&sock.mutex);
757 msock = NULL; 882 sock.sbuf = tconn->data.sbuf;
883 sock.rbuf = tconn->data.rbuf;
884 sock.socket = NULL;
885 mutex_init(&msock.mutex);
886 msock.sbuf = tconn->meta.sbuf;
887 msock.rbuf = tconn->meta.rbuf;
888 msock.socket = NULL;
889
890 /* Assume that the peer only understands protocol 80 until we know better. */
891 tconn->agreed_pro_version = 80;
892
893 if (prepare_listen_socket(tconn, &ad))
894 return 0;
758 895
759 do { 896 do {
760 for (try = 0;;) { 897 struct socket *s;
761 /* 3 tries, this should take less than a second! */
762 s = drbd_try_connect(mdev);
763 if (s || ++try >= 3)
764 break;
765 /* give the other side time to call bind() & listen() */
766 schedule_timeout_interruptible(HZ / 10);
767 }
768 898
899 s = drbd_try_connect(tconn);
769 if (s) { 900 if (s) {
770 if (!sock) { 901 if (!sock.socket) {
771 drbd_send_fp(mdev, s, P_HAND_SHAKE_S); 902 sock.socket = s;
772 sock = s; 903 send_first_packet(tconn, &sock, P_INITIAL_DATA);
773 s = NULL; 904 } else if (!msock.socket) {
774 } else if (!msock) { 905 clear_bit(RESOLVE_CONFLICTS, &tconn->flags);
775 drbd_clear_flag(mdev, DISCARD_CONCURRENT); 906 msock.socket = s;
776 drbd_send_fp(mdev, s, P_HAND_SHAKE_M); 907 send_first_packet(tconn, &msock, P_INITIAL_META);
777 msock = s;
778 s = NULL;
779 } else { 908 } else {
780 dev_err(DEV, "Logic error in drbd_connect()\n"); 909 conn_err(tconn, "Logic error in conn_connect()\n");
781 goto out_release_sockets; 910 goto out_release_sockets;
782 } 911 }
783 } 912 }
784 913
785 if (sock && msock) { 914 if (sock.socket && msock.socket) {
786 schedule_timeout_interruptible(mdev->net_conf->ping_timeo*HZ/10); 915 rcu_read_lock();
787 ok = drbd_socket_okay(mdev, &sock); 916 nc = rcu_dereference(tconn->net_conf);
788 ok = drbd_socket_okay(mdev, &msock) && ok; 917 timeout = nc->ping_timeo * HZ / 10;
918 rcu_read_unlock();
919 schedule_timeout_interruptible(timeout);
920 ok = drbd_socket_okay(&sock.socket);
921 ok = drbd_socket_okay(&msock.socket) && ok;
789 if (ok) 922 if (ok)
790 break; 923 break;
791 } 924 }
792 925
793retry: 926retry:
794 s = drbd_wait_for_connect(mdev); 927 s = drbd_wait_for_connect(tconn, &ad);
795 if (s) { 928 if (s) {
796 try = drbd_recv_fp(mdev, s); 929 int fp = receive_first_packet(tconn, s);
797 drbd_socket_okay(mdev, &sock); 930 drbd_socket_okay(&sock.socket);
798 drbd_socket_okay(mdev, &msock); 931 drbd_socket_okay(&msock.socket);
799 switch (try) { 932 switch (fp) {
800 case P_HAND_SHAKE_S: 933 case P_INITIAL_DATA:
801 if (sock) { 934 if (sock.socket) {
802 dev_warn(DEV, "initial packet S crossed\n"); 935 conn_warn(tconn, "initial packet S crossed\n");
803 sock_release(sock); 936 sock_release(sock.socket);
937 sock.socket = s;
938 goto randomize;
804 } 939 }
805 sock = s; 940 sock.socket = s;
806 break; 941 break;
807 case P_HAND_SHAKE_M: 942 case P_INITIAL_META:
808 if (msock) { 943 set_bit(RESOLVE_CONFLICTS, &tconn->flags);
809 dev_warn(DEV, "initial packet M crossed\n"); 944 if (msock.socket) {
810 sock_release(msock); 945 conn_warn(tconn, "initial packet M crossed\n");
946 sock_release(msock.socket);
947 msock.socket = s;
948 goto randomize;
811 } 949 }
812 msock = s; 950 msock.socket = s;
813 drbd_set_flag(mdev, DISCARD_CONCURRENT);
814 break; 951 break;
815 default: 952 default:
816 dev_warn(DEV, "Error receiving initial packet\n"); 953 conn_warn(tconn, "Error receiving initial packet\n");
817 sock_release(s); 954 sock_release(s);
955randomize:
818 if (random32() & 1) 956 if (random32() & 1)
819 goto retry; 957 goto retry;
820 } 958 }
821 } 959 }
822 960
823 if (mdev->state.conn <= C_DISCONNECTING) 961 if (tconn->cstate <= C_DISCONNECTING)
824 goto out_release_sockets; 962 goto out_release_sockets;
825 if (signal_pending(current)) { 963 if (signal_pending(current)) {
826 flush_signals(current); 964 flush_signals(current);
827 smp_rmb(); 965 smp_rmb();
828 if (get_t_state(&mdev->receiver) == Exiting) 966 if (get_t_state(&tconn->receiver) == EXITING)
829 goto out_release_sockets; 967 goto out_release_sockets;
830 } 968 }
831 969
832 if (sock && msock) { 970 ok = drbd_socket_okay(&sock.socket);
833 ok = drbd_socket_okay(mdev, &sock); 971 ok = drbd_socket_okay(&msock.socket) && ok;
834 ok = drbd_socket_okay(mdev, &msock) && ok; 972 } while (!ok);
835 if (ok)
836 break;
837 }
838 } while (1);
839 973
840 msock->sk->sk_reuse = SK_CAN_REUSE; /* SO_REUSEADDR */ 974 if (ad.s_listen)
841 sock->sk->sk_reuse = SK_CAN_REUSE; /* SO_REUSEADDR */ 975 sock_release(ad.s_listen);
842 976
843 sock->sk->sk_allocation = GFP_NOIO; 977 sock.socket->sk->sk_reuse = SK_CAN_REUSE; /* SO_REUSEADDR */
844 msock->sk->sk_allocation = GFP_NOIO; 978 msock.socket->sk->sk_reuse = SK_CAN_REUSE; /* SO_REUSEADDR */
845 979
846 sock->sk->sk_priority = TC_PRIO_INTERACTIVE_BULK; 980 sock.socket->sk->sk_allocation = GFP_NOIO;
847 msock->sk->sk_priority = TC_PRIO_INTERACTIVE; 981 msock.socket->sk->sk_allocation = GFP_NOIO;
982
983 sock.socket->sk->sk_priority = TC_PRIO_INTERACTIVE_BULK;
984 msock.socket->sk->sk_priority = TC_PRIO_INTERACTIVE;
848 985
849 /* NOT YET ... 986 /* NOT YET ...
850 * sock->sk->sk_sndtimeo = mdev->net_conf->timeout*HZ/10; 987 * sock.socket->sk->sk_sndtimeo = tconn->net_conf->timeout*HZ/10;
851 * sock->sk->sk_rcvtimeo = MAX_SCHEDULE_TIMEOUT; 988 * sock.socket->sk->sk_rcvtimeo = MAX_SCHEDULE_TIMEOUT;
852 * first set it to the P_HAND_SHAKE timeout, 989 * first set it to the P_CONNECTION_FEATURES timeout,
853 * which we set to 4x the configured ping_timeout. */ 990 * which we set to 4x the configured ping_timeout. */
854 sock->sk->sk_sndtimeo = 991 rcu_read_lock();
855 sock->sk->sk_rcvtimeo = mdev->net_conf->ping_timeo*4*HZ/10; 992 nc = rcu_dereference(tconn->net_conf);
993
994 sock.socket->sk->sk_sndtimeo =
995 sock.socket->sk->sk_rcvtimeo = nc->ping_timeo*4*HZ/10;
996
997 msock.socket->sk->sk_rcvtimeo = nc->ping_int*HZ;
998 timeout = nc->timeout * HZ / 10;
999 discard_my_data = nc->discard_my_data;
1000 rcu_read_unlock();
856 1001
857 msock->sk->sk_sndtimeo = mdev->net_conf->timeout*HZ/10; 1002 msock.socket->sk->sk_sndtimeo = timeout;
858 msock->sk->sk_rcvtimeo = mdev->net_conf->ping_int*HZ;
859 1003
860 /* we don't want delays. 1004 /* we don't want delays.
861 * we use TCP_CORK where appropriate, though */ 1005 * we use TCP_CORK where appropriate, though */
862 drbd_tcp_nodelay(sock); 1006 drbd_tcp_nodelay(sock.socket);
863 drbd_tcp_nodelay(msock); 1007 drbd_tcp_nodelay(msock.socket);
864 1008
865 mdev->data.socket = sock; 1009 tconn->data.socket = sock.socket;
866 mdev->meta.socket = msock; 1010 tconn->meta.socket = msock.socket;
867 mdev->last_received = jiffies; 1011 tconn->last_received = jiffies;
868 1012
869 D_ASSERT(mdev->asender.task == NULL); 1013 h = drbd_do_features(tconn);
870
871 h = drbd_do_handshake(mdev);
872 if (h <= 0) 1014 if (h <= 0)
873 return h; 1015 return h;
874 1016
875 if (mdev->cram_hmac_tfm) { 1017 if (tconn->cram_hmac_tfm) {
876 /* drbd_request_state(mdev, NS(conn, WFAuth)); */ 1018 /* drbd_request_state(mdev, NS(conn, WFAuth)); */
877 switch (drbd_do_auth(mdev)) { 1019 switch (drbd_do_auth(tconn)) {
878 case -1: 1020 case -1:
879 dev_err(DEV, "Authentication of peer failed\n"); 1021 conn_err(tconn, "Authentication of peer failed\n");
880 return -1; 1022 return -1;
881 case 0: 1023 case 0:
882 dev_err(DEV, "Authentication of peer failed, trying again.\n"); 1024 conn_err(tconn, "Authentication of peer failed, trying again.\n");
883 return 0; 1025 return 0;
884 } 1026 }
885 } 1027 }
886 1028
887 sock->sk->sk_sndtimeo = mdev->net_conf->timeout*HZ/10; 1029 tconn->data.socket->sk->sk_sndtimeo = timeout;
888 sock->sk->sk_rcvtimeo = MAX_SCHEDULE_TIMEOUT; 1030 tconn->data.socket->sk->sk_rcvtimeo = MAX_SCHEDULE_TIMEOUT;
889
890 atomic_set(&mdev->packet_seq, 0);
891 mdev->peer_seq = 0;
892 1031
893 if (drbd_send_protocol(mdev) == -1) 1032 if (drbd_send_protocol(tconn) == -EOPNOTSUPP)
894 return -1; 1033 return -1;
895 drbd_set_flag(mdev, STATE_SENT); 1034
896 drbd_send_sync_param(mdev, &mdev->sync_conf); 1035 set_bit(STATE_SENT, &tconn->flags);
897 drbd_send_sizes(mdev, 0, 0); 1036
898 drbd_send_uuids(mdev); 1037 rcu_read_lock();
899 drbd_send_current_state(mdev); 1038 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
900 drbd_clear_flag(mdev, USE_DEGR_WFC_T); 1039 kref_get(&mdev->kref);
901 drbd_clear_flag(mdev, RESIZE_PENDING); 1040 rcu_read_unlock();
902 1041
903 spin_lock_irq(&mdev->req_lock); 1042 if (discard_my_data)
904 rv = _drbd_set_state(_NS(mdev, conn, C_WF_REPORT_PARAMS), CS_VERBOSE, NULL); 1043 set_bit(DISCARD_MY_DATA, &mdev->flags);
905 if (mdev->state.conn != C_WF_REPORT_PARAMS) 1044 else
906 drbd_clear_flag(mdev, STATE_SENT); 1045 clear_bit(DISCARD_MY_DATA, &mdev->flags);
907 spin_unlock_irq(&mdev->req_lock); 1046
908 1047 drbd_connected(mdev);
909 if (rv < SS_SUCCESS) 1048 kref_put(&mdev->kref, &drbd_minor_destroy);
1049 rcu_read_lock();
1050 }
1051 rcu_read_unlock();
1052
1053 rv = conn_request_state(tconn, NS(conn, C_WF_REPORT_PARAMS), CS_VERBOSE);
1054 if (rv < SS_SUCCESS) {
1055 clear_bit(STATE_SENT, &tconn->flags);
910 return 0; 1056 return 0;
1057 }
911 1058
912 drbd_thread_start(&mdev->asender); 1059 drbd_thread_start(&tconn->asender);
913 mod_timer(&mdev->request_timer, jiffies + HZ); /* just start it here. */
914 1060
915 return 1; 1061 mutex_lock(&tconn->conf_update);
1062 /* The discard_my_data flag is a single-shot modifier to the next
1063 * connection attempt, the handshake of which is now well underway.
1064 * No need for rcu style copying of the whole struct
1065 * just to clear a single value. */
1066 tconn->net_conf->discard_my_data = 0;
1067 mutex_unlock(&tconn->conf_update);
1068
1069 return h;
916 1070
917out_release_sockets: 1071out_release_sockets:
918 if (sock) 1072 if (ad.s_listen)
919 sock_release(sock); 1073 sock_release(ad.s_listen);
920 if (msock) 1074 if (sock.socket)
921 sock_release(msock); 1075 sock_release(sock.socket);
1076 if (msock.socket)
1077 sock_release(msock.socket);
922 return -1; 1078 return -1;
923} 1079}
924 1080
925static int drbd_recv_header(struct drbd_conf *mdev, enum drbd_packets *cmd, unsigned int *packet_size) 1081static int decode_header(struct drbd_tconn *tconn, void *header, struct packet_info *pi)
926{ 1082{
927 union p_header *h = &mdev->data.rbuf.header; 1083 unsigned int header_size = drbd_header_size(tconn);
928 int r; 1084
929 1085 if (header_size == sizeof(struct p_header100) &&
930 r = drbd_recv(mdev, h, sizeof(*h)); 1086 *(__be32 *)header == cpu_to_be32(DRBD_MAGIC_100)) {
931 if (unlikely(r != sizeof(*h))) { 1087 struct p_header100 *h = header;
932 if (!signal_pending(current)) 1088 if (h->pad != 0) {
933 dev_warn(DEV, "short read expecting header on sock: r=%d\n", r); 1089 conn_err(tconn, "Header padding is not zero\n");
934 return false; 1090 return -EINVAL;
935 } 1091 }
936 1092 pi->vnr = be16_to_cpu(h->volume);
937 if (likely(h->h80.magic == BE_DRBD_MAGIC)) { 1093 pi->cmd = be16_to_cpu(h->command);
938 *cmd = be16_to_cpu(h->h80.command); 1094 pi->size = be32_to_cpu(h->length);
939 *packet_size = be16_to_cpu(h->h80.length); 1095 } else if (header_size == sizeof(struct p_header95) &&
940 } else if (h->h95.magic == BE_DRBD_MAGIC_BIG) { 1096 *(__be16 *)header == cpu_to_be16(DRBD_MAGIC_BIG)) {
941 *cmd = be16_to_cpu(h->h95.command); 1097 struct p_header95 *h = header;
942 *packet_size = be32_to_cpu(h->h95.length); 1098 pi->cmd = be16_to_cpu(h->command);
1099 pi->size = be32_to_cpu(h->length);
1100 pi->vnr = 0;
1101 } else if (header_size == sizeof(struct p_header80) &&
1102 *(__be32 *)header == cpu_to_be32(DRBD_MAGIC)) {
1103 struct p_header80 *h = header;
1104 pi->cmd = be16_to_cpu(h->command);
1105 pi->size = be16_to_cpu(h->length);
1106 pi->vnr = 0;
943 } else { 1107 } else {
944 dev_err(DEV, "magic?? on data m: 0x%08x c: %d l: %d\n", 1108 conn_err(tconn, "Wrong magic value 0x%08x in protocol version %d\n",
945 be32_to_cpu(h->h80.magic), 1109 be32_to_cpu(*(__be32 *)header),
946 be16_to_cpu(h->h80.command), 1110 tconn->agreed_pro_version);
947 be16_to_cpu(h->h80.length)); 1111 return -EINVAL;
948 return false;
949 } 1112 }
950 mdev->last_received = jiffies; 1113 pi->data = header + header_size;
1114 return 0;
1115}
1116
1117static int drbd_recv_header(struct drbd_tconn *tconn, struct packet_info *pi)
1118{
1119 void *buffer = tconn->data.rbuf;
1120 int err;
1121
1122 err = drbd_recv_all_warn(tconn, buffer, drbd_header_size(tconn));
1123 if (err)
1124 return err;
1125
1126 err = decode_header(tconn, buffer, pi);
1127 tconn->last_received = jiffies;
951 1128
952 return true; 1129 return err;
953} 1130}
954 1131
955static void drbd_flush(struct drbd_conf *mdev) 1132static void drbd_flush(struct drbd_tconn *tconn)
956{ 1133{
957 int rv; 1134 int rv;
1135 struct drbd_conf *mdev;
1136 int vnr;
958 1137
959 if (mdev->write_ordering >= WO_bdev_flush && get_ldev(mdev)) { 1138 if (tconn->write_ordering >= WO_bdev_flush) {
960 rv = blkdev_issue_flush(mdev->ldev->backing_bdev, GFP_NOIO, 1139 rcu_read_lock();
961 NULL); 1140 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
962 if (rv) { 1141 if (!get_ldev(mdev))
963 dev_info(DEV, "local disk flush failed with status %d\n", rv); 1142 continue;
964 /* would rather check on EOPNOTSUPP, but that is not reliable. 1143 kref_get(&mdev->kref);
965 * don't try again for ANY return value != 0 1144 rcu_read_unlock();
966 * if (rv == -EOPNOTSUPP) */ 1145
967 drbd_bump_write_ordering(mdev, WO_drain_io); 1146 rv = blkdev_issue_flush(mdev->ldev->backing_bdev,
1147 GFP_NOIO, NULL);
1148 if (rv) {
1149 dev_info(DEV, "local disk flush failed with status %d\n", rv);
1150 /* would rather check on EOPNOTSUPP, but that is not reliable.
1151 * don't try again for ANY return value != 0
1152 * if (rv == -EOPNOTSUPP) */
1153 drbd_bump_write_ordering(tconn, WO_drain_io);
1154 }
1155 put_ldev(mdev);
1156 kref_put(&mdev->kref, &drbd_minor_destroy);
1157
1158 rcu_read_lock();
1159 if (rv)
1160 break;
968 } 1161 }
969 put_ldev(mdev); 1162 rcu_read_unlock();
970 } 1163 }
971} 1164}
972 1165
@@ -976,7 +1169,7 @@ static void drbd_flush(struct drbd_conf *mdev)
976 * @epoch: Epoch object. 1169 * @epoch: Epoch object.
977 * @ev: Epoch event. 1170 * @ev: Epoch event.
978 */ 1171 */
979static enum finish_epoch drbd_may_finish_epoch(struct drbd_conf *mdev, 1172static enum finish_epoch drbd_may_finish_epoch(struct drbd_tconn *tconn,
980 struct drbd_epoch *epoch, 1173 struct drbd_epoch *epoch,
981 enum epoch_event ev) 1174 enum epoch_event ev)
982{ 1175{
@@ -984,7 +1177,7 @@ static enum finish_epoch drbd_may_finish_epoch(struct drbd_conf *mdev,
984 struct drbd_epoch *next_epoch; 1177 struct drbd_epoch *next_epoch;
985 enum finish_epoch rv = FE_STILL_LIVE; 1178 enum finish_epoch rv = FE_STILL_LIVE;
986 1179
987 spin_lock(&mdev->epoch_lock); 1180 spin_lock(&tconn->epoch_lock);
988 do { 1181 do {
989 next_epoch = NULL; 1182 next_epoch = NULL;
990 1183
@@ -1006,18 +1199,22 @@ static enum finish_epoch drbd_may_finish_epoch(struct drbd_conf *mdev,
1006 atomic_read(&epoch->active) == 0 && 1199 atomic_read(&epoch->active) == 0 &&
1007 (test_bit(DE_HAVE_BARRIER_NUMBER, &epoch->flags) || ev & EV_CLEANUP)) { 1200 (test_bit(DE_HAVE_BARRIER_NUMBER, &epoch->flags) || ev & EV_CLEANUP)) {
1008 if (!(ev & EV_CLEANUP)) { 1201 if (!(ev & EV_CLEANUP)) {
1009 spin_unlock(&mdev->epoch_lock); 1202 spin_unlock(&tconn->epoch_lock);
1010 drbd_send_b_ack(mdev, epoch->barrier_nr, epoch_size); 1203 drbd_send_b_ack(epoch->tconn, epoch->barrier_nr, epoch_size);
1011 spin_lock(&mdev->epoch_lock); 1204 spin_lock(&tconn->epoch_lock);
1012 } 1205 }
1206#if 0
1207 /* FIXME: dec unacked on connection, once we have
1208 * something to count pending connection packets in. */
1013 if (test_bit(DE_HAVE_BARRIER_NUMBER, &epoch->flags)) 1209 if (test_bit(DE_HAVE_BARRIER_NUMBER, &epoch->flags))
1014 dec_unacked(mdev); 1210 dec_unacked(epoch->tconn);
1211#endif
1015 1212
1016 if (mdev->current_epoch != epoch) { 1213 if (tconn->current_epoch != epoch) {
1017 next_epoch = list_entry(epoch->list.next, struct drbd_epoch, list); 1214 next_epoch = list_entry(epoch->list.next, struct drbd_epoch, list);
1018 list_del(&epoch->list); 1215 list_del(&epoch->list);
1019 ev = EV_BECAME_LAST | (ev & EV_CLEANUP); 1216 ev = EV_BECAME_LAST | (ev & EV_CLEANUP);
1020 mdev->epochs--; 1217 tconn->epochs--;
1021 kfree(epoch); 1218 kfree(epoch);
1022 1219
1023 if (rv == FE_STILL_LIVE) 1220 if (rv == FE_STILL_LIVE)
@@ -1028,7 +1225,6 @@ static enum finish_epoch drbd_may_finish_epoch(struct drbd_conf *mdev,
1028 /* atomic_set(&epoch->active, 0); is already zero */ 1225 /* atomic_set(&epoch->active, 0); is already zero */
1029 if (rv == FE_STILL_LIVE) 1226 if (rv == FE_STILL_LIVE)
1030 rv = FE_RECYCLED; 1227 rv = FE_RECYCLED;
1031 wake_up(&mdev->ee_wait);
1032 } 1228 }
1033 } 1229 }
1034 1230
@@ -1038,40 +1234,52 @@ static enum finish_epoch drbd_may_finish_epoch(struct drbd_conf *mdev,
1038 epoch = next_epoch; 1234 epoch = next_epoch;
1039 } while (1); 1235 } while (1);
1040 1236
1041 spin_unlock(&mdev->epoch_lock); 1237 spin_unlock(&tconn->epoch_lock);
1042 1238
1043 return rv; 1239 return rv;
1044} 1240}
1045 1241
1046/** 1242/**
1047 * drbd_bump_write_ordering() - Fall back to an other write ordering method 1243 * drbd_bump_write_ordering() - Fall back to an other write ordering method
1048 * @mdev: DRBD device. 1244 * @tconn: DRBD connection.
1049 * @wo: Write ordering method to try. 1245 * @wo: Write ordering method to try.
1050 */ 1246 */
1051void drbd_bump_write_ordering(struct drbd_conf *mdev, enum write_ordering_e wo) __must_hold(local) 1247void drbd_bump_write_ordering(struct drbd_tconn *tconn, enum write_ordering_e wo)
1052{ 1248{
1249 struct disk_conf *dc;
1250 struct drbd_conf *mdev;
1053 enum write_ordering_e pwo; 1251 enum write_ordering_e pwo;
1252 int vnr;
1054 static char *write_ordering_str[] = { 1253 static char *write_ordering_str[] = {
1055 [WO_none] = "none", 1254 [WO_none] = "none",
1056 [WO_drain_io] = "drain", 1255 [WO_drain_io] = "drain",
1057 [WO_bdev_flush] = "flush", 1256 [WO_bdev_flush] = "flush",
1058 }; 1257 };
1059 1258
1060 pwo = mdev->write_ordering; 1259 pwo = tconn->write_ordering;
1061 wo = min(pwo, wo); 1260 wo = min(pwo, wo);
1062 if (wo == WO_bdev_flush && mdev->ldev->dc.no_disk_flush) 1261 rcu_read_lock();
1063 wo = WO_drain_io; 1262 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
1064 if (wo == WO_drain_io && mdev->ldev->dc.no_disk_drain) 1263 if (!get_ldev_if_state(mdev, D_ATTACHING))
1065 wo = WO_none; 1264 continue;
1066 mdev->write_ordering = wo; 1265 dc = rcu_dereference(mdev->ldev->disk_conf);
1067 if (pwo != mdev->write_ordering || wo == WO_bdev_flush) 1266
1068 dev_info(DEV, "Method to ensure write ordering: %s\n", write_ordering_str[mdev->write_ordering]); 1267 if (wo == WO_bdev_flush && !dc->disk_flushes)
1268 wo = WO_drain_io;
1269 if (wo == WO_drain_io && !dc->disk_drain)
1270 wo = WO_none;
1271 put_ldev(mdev);
1272 }
1273 rcu_read_unlock();
1274 tconn->write_ordering = wo;
1275 if (pwo != tconn->write_ordering || wo == WO_bdev_flush)
1276 conn_info(tconn, "Method to ensure write ordering: %s\n", write_ordering_str[tconn->write_ordering]);
1069} 1277}
1070 1278
1071/** 1279/**
1072 * drbd_submit_ee() 1280 * drbd_submit_peer_request()
1073 * @mdev: DRBD device. 1281 * @mdev: DRBD device.
1074 * @e: epoch entry 1282 * @peer_req: peer request
1075 * @rw: flag field, see bio->bi_rw 1283 * @rw: flag field, see bio->bi_rw
1076 * 1284 *
1077 * May spread the pages to multiple bios, 1285 * May spread the pages to multiple bios,
@@ -1085,14 +1293,15 @@ void drbd_bump_write_ordering(struct drbd_conf *mdev, enum write_ordering_e wo)
1085 * on certain Xen deployments. 1293 * on certain Xen deployments.
1086 */ 1294 */
1087/* TODO allocate from our own bio_set. */ 1295/* TODO allocate from our own bio_set. */
1088int drbd_submit_ee(struct drbd_conf *mdev, struct drbd_epoch_entry *e, 1296int drbd_submit_peer_request(struct drbd_conf *mdev,
1089 const unsigned rw, const int fault_type) 1297 struct drbd_peer_request *peer_req,
1298 const unsigned rw, const int fault_type)
1090{ 1299{
1091 struct bio *bios = NULL; 1300 struct bio *bios = NULL;
1092 struct bio *bio; 1301 struct bio *bio;
1093 struct page *page = e->pages; 1302 struct page *page = peer_req->pages;
1094 sector_t sector = e->sector; 1303 sector_t sector = peer_req->i.sector;
1095 unsigned ds = e->size; 1304 unsigned ds = peer_req->i.size;
1096 unsigned n_bios = 0; 1305 unsigned n_bios = 0;
1097 unsigned nr_pages = (ds + PAGE_SIZE -1) >> PAGE_SHIFT; 1306 unsigned nr_pages = (ds + PAGE_SIZE -1) >> PAGE_SHIFT;
1098 int err = -ENOMEM; 1307 int err = -ENOMEM;
@@ -1111,12 +1320,12 @@ next_bio:
1111 dev_err(DEV, "submit_ee: Allocation of a bio failed\n"); 1320 dev_err(DEV, "submit_ee: Allocation of a bio failed\n");
1112 goto fail; 1321 goto fail;
1113 } 1322 }
1114 /* > e->sector, unless this is the first bio */ 1323 /* > peer_req->i.sector, unless this is the first bio */
1115 bio->bi_sector = sector; 1324 bio->bi_sector = sector;
1116 bio->bi_bdev = mdev->ldev->backing_bdev; 1325 bio->bi_bdev = mdev->ldev->backing_bdev;
1117 bio->bi_rw = rw; 1326 bio->bi_rw = rw;
1118 bio->bi_private = e; 1327 bio->bi_private = peer_req;
1119 bio->bi_end_io = drbd_endio_sec; 1328 bio->bi_end_io = drbd_peer_request_endio;
1120 1329
1121 bio->bi_next = bios; 1330 bio->bi_next = bios;
1122 bios = bio; 1331 bios = bio;
@@ -1145,7 +1354,7 @@ next_bio:
1145 D_ASSERT(page == NULL); 1354 D_ASSERT(page == NULL);
1146 D_ASSERT(ds == 0); 1355 D_ASSERT(ds == 0);
1147 1356
1148 atomic_set(&e->pending_bios, n_bios); 1357 atomic_set(&peer_req->pending_bios, n_bios);
1149 do { 1358 do {
1150 bio = bios; 1359 bio = bios;
1151 bios = bios->bi_next; 1360 bios = bios->bi_next;
@@ -1164,26 +1373,57 @@ fail:
1164 return err; 1373 return err;
1165} 1374}
1166 1375
1167static int receive_Barrier(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 1376static void drbd_remove_epoch_entry_interval(struct drbd_conf *mdev,
1377 struct drbd_peer_request *peer_req)
1378{
1379 struct drbd_interval *i = &peer_req->i;
1380
1381 drbd_remove_interval(&mdev->write_requests, i);
1382 drbd_clear_interval(i);
1383
1384 /* Wake up any processes waiting for this peer request to complete. */
1385 if (i->waiting)
1386 wake_up(&mdev->misc_wait);
1387}
1388
1389void conn_wait_active_ee_empty(struct drbd_tconn *tconn)
1390{
1391 struct drbd_conf *mdev;
1392 int vnr;
1393
1394 rcu_read_lock();
1395 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
1396 kref_get(&mdev->kref);
1397 rcu_read_unlock();
1398 drbd_wait_ee_list_empty(mdev, &mdev->active_ee);
1399 kref_put(&mdev->kref, &drbd_minor_destroy);
1400 rcu_read_lock();
1401 }
1402 rcu_read_unlock();
1403}
1404
1405static int receive_Barrier(struct drbd_tconn *tconn, struct packet_info *pi)
1168{ 1406{
1169 int rv; 1407 int rv;
1170 struct p_barrier *p = &mdev->data.rbuf.barrier; 1408 struct p_barrier *p = pi->data;
1171 struct drbd_epoch *epoch; 1409 struct drbd_epoch *epoch;
1172 1410
1173 inc_unacked(mdev); 1411 /* FIXME these are unacked on connection,
1174 1412 * not a specific (peer)device.
1175 mdev->current_epoch->barrier_nr = p->barrier; 1413 */
1176 rv = drbd_may_finish_epoch(mdev, mdev->current_epoch, EV_GOT_BARRIER_NR); 1414 tconn->current_epoch->barrier_nr = p->barrier;
1415 tconn->current_epoch->tconn = tconn;
1416 rv = drbd_may_finish_epoch(tconn, tconn->current_epoch, EV_GOT_BARRIER_NR);
1177 1417
1178 /* P_BARRIER_ACK may imply that the corresponding extent is dropped from 1418 /* P_BARRIER_ACK may imply that the corresponding extent is dropped from
1179 * the activity log, which means it would not be resynced in case the 1419 * the activity log, which means it would not be resynced in case the
1180 * R_PRIMARY crashes now. 1420 * R_PRIMARY crashes now.
1181 * Therefore we must send the barrier_ack after the barrier request was 1421 * Therefore we must send the barrier_ack after the barrier request was
1182 * completed. */ 1422 * completed. */
1183 switch (mdev->write_ordering) { 1423 switch (tconn->write_ordering) {
1184 case WO_none: 1424 case WO_none:
1185 if (rv == FE_RECYCLED) 1425 if (rv == FE_RECYCLED)
1186 return true; 1426 return 0;
1187 1427
1188 /* receiver context, in the writeout path of the other node. 1428 /* receiver context, in the writeout path of the other node.
1189 * avoid potential distributed deadlock */ 1429 * avoid potential distributed deadlock */
@@ -1191,81 +1431,75 @@ static int receive_Barrier(struct drbd_conf *mdev, enum drbd_packets cmd, unsign
1191 if (epoch) 1431 if (epoch)
1192 break; 1432 break;
1193 else 1433 else
1194 dev_warn(DEV, "Allocation of an epoch failed, slowing down\n"); 1434 conn_warn(tconn, "Allocation of an epoch failed, slowing down\n");
1195 /* Fall through */ 1435 /* Fall through */
1196 1436
1197 case WO_bdev_flush: 1437 case WO_bdev_flush:
1198 case WO_drain_io: 1438 case WO_drain_io:
1199 drbd_wait_ee_list_empty(mdev, &mdev->active_ee); 1439 conn_wait_active_ee_empty(tconn);
1200 drbd_flush(mdev); 1440 drbd_flush(tconn);
1201 1441
1202 if (atomic_read(&mdev->current_epoch->epoch_size)) { 1442 if (atomic_read(&tconn->current_epoch->epoch_size)) {
1203 epoch = kmalloc(sizeof(struct drbd_epoch), GFP_NOIO); 1443 epoch = kmalloc(sizeof(struct drbd_epoch), GFP_NOIO);
1204 if (epoch) 1444 if (epoch)
1205 break; 1445 break;
1206 } 1446 }
1207 1447
1208 epoch = mdev->current_epoch; 1448 return 0;
1209 wait_event(mdev->ee_wait, atomic_read(&epoch->epoch_size) == 0);
1210
1211 D_ASSERT(atomic_read(&epoch->active) == 0);
1212 D_ASSERT(epoch->flags == 0);
1213
1214 return true;
1215 default: 1449 default:
1216 dev_err(DEV, "Strangeness in mdev->write_ordering %d\n", mdev->write_ordering); 1450 conn_err(tconn, "Strangeness in tconn->write_ordering %d\n", tconn->write_ordering);
1217 return false; 1451 return -EIO;
1218 } 1452 }
1219 1453
1220 epoch->flags = 0; 1454 epoch->flags = 0;
1221 atomic_set(&epoch->epoch_size, 0); 1455 atomic_set(&epoch->epoch_size, 0);
1222 atomic_set(&epoch->active, 0); 1456 atomic_set(&epoch->active, 0);
1223 1457
1224 spin_lock(&mdev->epoch_lock); 1458 spin_lock(&tconn->epoch_lock);
1225 if (atomic_read(&mdev->current_epoch->epoch_size)) { 1459 if (atomic_read(&tconn->current_epoch->epoch_size)) {
1226 list_add(&epoch->list, &mdev->current_epoch->list); 1460 list_add(&epoch->list, &tconn->current_epoch->list);
1227 mdev->current_epoch = epoch; 1461 tconn->current_epoch = epoch;
1228 mdev->epochs++; 1462 tconn->epochs++;
1229 } else { 1463 } else {
1230 /* The current_epoch got recycled while we allocated this one... */ 1464 /* The current_epoch got recycled while we allocated this one... */
1231 kfree(epoch); 1465 kfree(epoch);
1232 } 1466 }
1233 spin_unlock(&mdev->epoch_lock); 1467 spin_unlock(&tconn->epoch_lock);
1234 1468
1235 return true; 1469 return 0;
1236} 1470}
1237 1471
1238/* used from receive_RSDataReply (recv_resync_read) 1472/* used from receive_RSDataReply (recv_resync_read)
1239 * and from receive_Data */ 1473 * and from receive_Data */
1240static struct drbd_epoch_entry * 1474static struct drbd_peer_request *
1241read_in_block(struct drbd_conf *mdev, u64 id, sector_t sector, int data_size) __must_hold(local) 1475read_in_block(struct drbd_conf *mdev, u64 id, sector_t sector,
1476 int data_size) __must_hold(local)
1242{ 1477{
1243 const sector_t capacity = drbd_get_capacity(mdev->this_bdev); 1478 const sector_t capacity = drbd_get_capacity(mdev->this_bdev);
1244 struct drbd_epoch_entry *e; 1479 struct drbd_peer_request *peer_req;
1245 struct page *page; 1480 struct page *page;
1246 int dgs, ds, rr; 1481 int dgs, ds, err;
1247 void *dig_in = mdev->int_dig_in; 1482 void *dig_in = mdev->tconn->int_dig_in;
1248 void *dig_vv = mdev->int_dig_vv; 1483 void *dig_vv = mdev->tconn->int_dig_vv;
1249 unsigned long *data; 1484 unsigned long *data;
1250 1485
1251 dgs = (mdev->agreed_pro_version >= 87 && mdev->integrity_r_tfm) ? 1486 dgs = 0;
1252 crypto_hash_digestsize(mdev->integrity_r_tfm) : 0; 1487 if (mdev->tconn->peer_integrity_tfm) {
1253 1488 dgs = crypto_hash_digestsize(mdev->tconn->peer_integrity_tfm);
1254 if (dgs) { 1489 /*
1255 rr = drbd_recv(mdev, dig_in, dgs); 1490 * FIXME: Receive the incoming digest into the receive buffer
1256 if (rr != dgs) { 1491 * here, together with its struct p_data?
1257 if (!signal_pending(current)) 1492 */
1258 dev_warn(DEV, 1493 err = drbd_recv_all_warn(mdev->tconn, dig_in, dgs);
1259 "short read receiving data digest: read %d expected %d\n", 1494 if (err)
1260 rr, dgs);
1261 return NULL; 1495 return NULL;
1262 } 1496 data_size -= dgs;
1263 } 1497 }
1264 1498
1265 data_size -= dgs; 1499 if (!expect(IS_ALIGNED(data_size, 512)))
1266 1500 return NULL;
1267 ERR_IF(data_size & 0x1ff) return NULL; 1501 if (!expect(data_size <= DRBD_MAX_BIO_SIZE))
1268 ERR_IF(data_size > DRBD_MAX_BIO_SIZE) return NULL; 1502 return NULL;
1269 1503
1270 /* even though we trust out peer, 1504 /* even though we trust out peer,
1271 * we sometimes have to double check. */ 1505 * we sometimes have to double check. */
@@ -1280,47 +1514,42 @@ read_in_block(struct drbd_conf *mdev, u64 id, sector_t sector, int data_size) __
1280 /* GFP_NOIO, because we must not cause arbitrary write-out: in a DRBD 1514 /* GFP_NOIO, because we must not cause arbitrary write-out: in a DRBD
1281 * "criss-cross" setup, that might cause write-out on some other DRBD, 1515 * "criss-cross" setup, that might cause write-out on some other DRBD,
1282 * which in turn might block on the other node at this very place. */ 1516 * which in turn might block on the other node at this very place. */
1283 e = drbd_alloc_ee(mdev, id, sector, data_size, GFP_NOIO); 1517 peer_req = drbd_alloc_peer_req(mdev, id, sector, data_size, GFP_NOIO);
1284 if (!e) 1518 if (!peer_req)
1285 return NULL; 1519 return NULL;
1286 1520
1287 if (!data_size) 1521 if (!data_size)
1288 return e; 1522 return peer_req;
1289 1523
1290 ds = data_size; 1524 ds = data_size;
1291 page = e->pages; 1525 page = peer_req->pages;
1292 page_chain_for_each(page) { 1526 page_chain_for_each(page) {
1293 unsigned len = min_t(int, ds, PAGE_SIZE); 1527 unsigned len = min_t(int, ds, PAGE_SIZE);
1294 data = kmap(page); 1528 data = kmap(page);
1295 rr = drbd_recv(mdev, data, len); 1529 err = drbd_recv_all_warn(mdev->tconn, data, len);
1296 if (drbd_insert_fault(mdev, DRBD_FAULT_RECEIVE)) { 1530 if (drbd_insert_fault(mdev, DRBD_FAULT_RECEIVE)) {
1297 dev_err(DEV, "Fault injection: Corrupting data on receive\n"); 1531 dev_err(DEV, "Fault injection: Corrupting data on receive\n");
1298 data[0] = data[0] ^ (unsigned long)-1; 1532 data[0] = data[0] ^ (unsigned long)-1;
1299 } 1533 }
1300 kunmap(page); 1534 kunmap(page);
1301 if (rr != len) { 1535 if (err) {
1302 drbd_free_ee(mdev, e); 1536 drbd_free_peer_req(mdev, peer_req);
1303 if (!signal_pending(current))
1304 dev_warn(DEV, "short read receiving data: read %d expected %d\n",
1305 rr, len);
1306 return NULL; 1537 return NULL;
1307 } 1538 }
1308 ds -= rr; 1539 ds -= len;
1309 } 1540 }
1310 1541
1311 if (dgs) { 1542 if (dgs) {
1312 drbd_csum_ee(mdev, mdev->integrity_r_tfm, e, dig_vv); 1543 drbd_csum_ee(mdev, mdev->tconn->peer_integrity_tfm, peer_req, dig_vv);
1313 if (memcmp(dig_in, dig_vv, dgs)) { 1544 if (memcmp(dig_in, dig_vv, dgs)) {
1314 dev_err(DEV, "Digest integrity check FAILED: %llus +%u\n", 1545 dev_err(DEV, "Digest integrity check FAILED: %llus +%u\n",
1315 (unsigned long long)sector, data_size); 1546 (unsigned long long)sector, data_size);
1316 drbd_bcast_ee(mdev, "digest failed", 1547 drbd_free_peer_req(mdev, peer_req);
1317 dgs, dig_in, dig_vv, e);
1318 drbd_free_ee(mdev, e);
1319 return NULL; 1548 return NULL;
1320 } 1549 }
1321 } 1550 }
1322 mdev->recv_cnt += data_size>>9; 1551 mdev->recv_cnt += data_size>>9;
1323 return e; 1552 return peer_req;
1324} 1553}
1325 1554
1326/* drbd_drain_block() just takes a data block 1555/* drbd_drain_block() just takes a data block
@@ -1329,30 +1558,26 @@ read_in_block(struct drbd_conf *mdev, u64 id, sector_t sector, int data_size) __
1329static int drbd_drain_block(struct drbd_conf *mdev, int data_size) 1558static int drbd_drain_block(struct drbd_conf *mdev, int data_size)
1330{ 1559{
1331 struct page *page; 1560 struct page *page;
1332 int rr, rv = 1; 1561 int err = 0;
1333 void *data; 1562 void *data;
1334 1563
1335 if (!data_size) 1564 if (!data_size)
1336 return true; 1565 return 0;
1337 1566
1338 page = drbd_pp_alloc(mdev, 1, 1); 1567 page = drbd_alloc_pages(mdev, 1, 1);
1339 1568
1340 data = kmap(page); 1569 data = kmap(page);
1341 while (data_size) { 1570 while (data_size) {
1342 rr = drbd_recv(mdev, data, min_t(int, data_size, PAGE_SIZE)); 1571 unsigned int len = min_t(int, data_size, PAGE_SIZE);
1343 if (rr != min_t(int, data_size, PAGE_SIZE)) { 1572
1344 rv = 0; 1573 err = drbd_recv_all_warn(mdev->tconn, data, len);
1345 if (!signal_pending(current)) 1574 if (err)
1346 dev_warn(DEV,
1347 "short read receiving data: read %d expected %d\n",
1348 rr, min_t(int, data_size, PAGE_SIZE));
1349 break; 1575 break;
1350 } 1576 data_size -= len;
1351 data_size -= rr;
1352 } 1577 }
1353 kunmap(page); 1578 kunmap(page);
1354 drbd_pp_free(mdev, page, 0); 1579 drbd_free_pages(mdev, page, 0);
1355 return rv; 1580 return err;
1356} 1581}
1357 1582
1358static int recv_dless_read(struct drbd_conf *mdev, struct drbd_request *req, 1583static int recv_dless_read(struct drbd_conf *mdev, struct drbd_request *req,
@@ -1360,26 +1585,19 @@ static int recv_dless_read(struct drbd_conf *mdev, struct drbd_request *req,
1360{ 1585{
1361 struct bio_vec *bvec; 1586 struct bio_vec *bvec;
1362 struct bio *bio; 1587 struct bio *bio;
1363 int dgs, rr, i, expect; 1588 int dgs, err, i, expect;
1364 void *dig_in = mdev->int_dig_in; 1589 void *dig_in = mdev->tconn->int_dig_in;
1365 void *dig_vv = mdev->int_dig_vv; 1590 void *dig_vv = mdev->tconn->int_dig_vv;
1366
1367 dgs = (mdev->agreed_pro_version >= 87 && mdev->integrity_r_tfm) ?
1368 crypto_hash_digestsize(mdev->integrity_r_tfm) : 0;
1369 1591
1370 if (dgs) { 1592 dgs = 0;
1371 rr = drbd_recv(mdev, dig_in, dgs); 1593 if (mdev->tconn->peer_integrity_tfm) {
1372 if (rr != dgs) { 1594 dgs = crypto_hash_digestsize(mdev->tconn->peer_integrity_tfm);
1373 if (!signal_pending(current)) 1595 err = drbd_recv_all_warn(mdev->tconn, dig_in, dgs);
1374 dev_warn(DEV, 1596 if (err)
1375 "short read receiving data reply digest: read %d expected %d\n", 1597 return err;
1376 rr, dgs); 1598 data_size -= dgs;
1377 return 0;
1378 }
1379 } 1599 }
1380 1600
1381 data_size -= dgs;
1382
1383 /* optimistically update recv_cnt. if receiving fails below, 1601 /* optimistically update recv_cnt. if receiving fails below,
1384 * we disconnect anyways, and counters will be reset. */ 1602 * we disconnect anyways, and counters will be reset. */
1385 mdev->recv_cnt += data_size>>9; 1603 mdev->recv_cnt += data_size>>9;
@@ -1388,63 +1606,61 @@ static int recv_dless_read(struct drbd_conf *mdev, struct drbd_request *req,
1388 D_ASSERT(sector == bio->bi_sector); 1606 D_ASSERT(sector == bio->bi_sector);
1389 1607
1390 bio_for_each_segment(bvec, bio, i) { 1608 bio_for_each_segment(bvec, bio, i) {
1609 void *mapped = kmap(bvec->bv_page) + bvec->bv_offset;
1391 expect = min_t(int, data_size, bvec->bv_len); 1610 expect = min_t(int, data_size, bvec->bv_len);
1392 rr = drbd_recv(mdev, 1611 err = drbd_recv_all_warn(mdev->tconn, mapped, expect);
1393 kmap(bvec->bv_page)+bvec->bv_offset,
1394 expect);
1395 kunmap(bvec->bv_page); 1612 kunmap(bvec->bv_page);
1396 if (rr != expect) { 1613 if (err)
1397 if (!signal_pending(current)) 1614 return err;
1398 dev_warn(DEV, "short read receiving data reply: " 1615 data_size -= expect;
1399 "read %d expected %d\n",
1400 rr, expect);
1401 return 0;
1402 }
1403 data_size -= rr;
1404 } 1616 }
1405 1617
1406 if (dgs) { 1618 if (dgs) {
1407 drbd_csum_bio(mdev, mdev->integrity_r_tfm, bio, dig_vv); 1619 drbd_csum_bio(mdev, mdev->tconn->peer_integrity_tfm, bio, dig_vv);
1408 if (memcmp(dig_in, dig_vv, dgs)) { 1620 if (memcmp(dig_in, dig_vv, dgs)) {
1409 dev_err(DEV, "Digest integrity check FAILED. Broken NICs?\n"); 1621 dev_err(DEV, "Digest integrity check FAILED. Broken NICs?\n");
1410 return 0; 1622 return -EINVAL;
1411 } 1623 }
1412 } 1624 }
1413 1625
1414 D_ASSERT(data_size == 0); 1626 D_ASSERT(data_size == 0);
1415 return 1; 1627 return 0;
1416} 1628}
1417 1629
1418/* e_end_resync_block() is called via 1630/*
1419 * drbd_process_done_ee() by asender only */ 1631 * e_end_resync_block() is called in asender context via
1420static int e_end_resync_block(struct drbd_conf *mdev, struct drbd_work *w, int unused) 1632 * drbd_finish_peer_reqs().
1633 */
1634static int e_end_resync_block(struct drbd_work *w, int unused)
1421{ 1635{
1422 struct drbd_epoch_entry *e = (struct drbd_epoch_entry *)w; 1636 struct drbd_peer_request *peer_req =
1423 sector_t sector = e->sector; 1637 container_of(w, struct drbd_peer_request, w);
1424 int ok; 1638 struct drbd_conf *mdev = w->mdev;
1639 sector_t sector = peer_req->i.sector;
1640 int err;
1425 1641
1426 D_ASSERT(hlist_unhashed(&e->collision)); 1642 D_ASSERT(drbd_interval_empty(&peer_req->i));
1427 1643
1428 if (likely((e->flags & EE_WAS_ERROR) == 0)) { 1644 if (likely((peer_req->flags & EE_WAS_ERROR) == 0)) {
1429 drbd_set_in_sync(mdev, sector, e->size); 1645 drbd_set_in_sync(mdev, sector, peer_req->i.size);
1430 ok = drbd_send_ack(mdev, P_RS_WRITE_ACK, e); 1646 err = drbd_send_ack(mdev, P_RS_WRITE_ACK, peer_req);
1431 } else { 1647 } else {
1432 /* Record failure to sync */ 1648 /* Record failure to sync */
1433 drbd_rs_failed_io(mdev, sector, e->size); 1649 drbd_rs_failed_io(mdev, sector, peer_req->i.size);
1434 1650
1435 ok = drbd_send_ack(mdev, P_NEG_ACK, e); 1651 err = drbd_send_ack(mdev, P_NEG_ACK, peer_req);
1436 } 1652 }
1437 dec_unacked(mdev); 1653 dec_unacked(mdev);
1438 1654
1439 return ok; 1655 return err;
1440} 1656}
1441 1657
1442static int recv_resync_read(struct drbd_conf *mdev, sector_t sector, int data_size) __releases(local) 1658static int recv_resync_read(struct drbd_conf *mdev, sector_t sector, int data_size) __releases(local)
1443{ 1659{
1444 struct drbd_epoch_entry *e; 1660 struct drbd_peer_request *peer_req;
1445 1661
1446 e = read_in_block(mdev, ID_SYNCER, sector, data_size); 1662 peer_req = read_in_block(mdev, ID_SYNCER, sector, data_size);
1447 if (!e) 1663 if (!peer_req)
1448 goto fail; 1664 goto fail;
1449 1665
1450 dec_rs_pending(mdev); 1666 dec_rs_pending(mdev);
@@ -1453,64 +1669,88 @@ static int recv_resync_read(struct drbd_conf *mdev, sector_t sector, int data_si
1453 /* corresponding dec_unacked() in e_end_resync_block() 1669 /* corresponding dec_unacked() in e_end_resync_block()
1454 * respective _drbd_clear_done_ee */ 1670 * respective _drbd_clear_done_ee */
1455 1671
1456 e->w.cb = e_end_resync_block; 1672 peer_req->w.cb = e_end_resync_block;
1457 1673
1458 spin_lock_irq(&mdev->req_lock); 1674 spin_lock_irq(&mdev->tconn->req_lock);
1459 list_add(&e->w.list, &mdev->sync_ee); 1675 list_add(&peer_req->w.list, &mdev->sync_ee);
1460 spin_unlock_irq(&mdev->req_lock); 1676 spin_unlock_irq(&mdev->tconn->req_lock);
1461 1677
1462 atomic_add(data_size >> 9, &mdev->rs_sect_ev); 1678 atomic_add(data_size >> 9, &mdev->rs_sect_ev);
1463 if (drbd_submit_ee(mdev, e, WRITE, DRBD_FAULT_RS_WR) == 0) 1679 if (drbd_submit_peer_request(mdev, peer_req, WRITE, DRBD_FAULT_RS_WR) == 0)
1464 return true; 1680 return 0;
1465 1681
1466 /* don't care for the reason here */ 1682 /* don't care for the reason here */
1467 dev_err(DEV, "submit failed, triggering re-connect\n"); 1683 dev_err(DEV, "submit failed, triggering re-connect\n");
1468 spin_lock_irq(&mdev->req_lock); 1684 spin_lock_irq(&mdev->tconn->req_lock);
1469 list_del(&e->w.list); 1685 list_del(&peer_req->w.list);
1470 spin_unlock_irq(&mdev->req_lock); 1686 spin_unlock_irq(&mdev->tconn->req_lock);
1471 1687
1472 drbd_free_ee(mdev, e); 1688 drbd_free_peer_req(mdev, peer_req);
1473fail: 1689fail:
1474 put_ldev(mdev); 1690 put_ldev(mdev);
1475 return false; 1691 return -EIO;
1692}
1693
1694static struct drbd_request *
1695find_request(struct drbd_conf *mdev, struct rb_root *root, u64 id,
1696 sector_t sector, bool missing_ok, const char *func)
1697{
1698 struct drbd_request *req;
1699
1700 /* Request object according to our peer */
1701 req = (struct drbd_request *)(unsigned long)id;
1702 if (drbd_contains_interval(root, sector, &req->i) && req->i.local)
1703 return req;
1704 if (!missing_ok) {
1705 dev_err(DEV, "%s: failed to find request 0x%lx, sector %llus\n", func,
1706 (unsigned long)id, (unsigned long long)sector);
1707 }
1708 return NULL;
1476} 1709}
1477 1710
1478static int receive_DataReply(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 1711static int receive_DataReply(struct drbd_tconn *tconn, struct packet_info *pi)
1479{ 1712{
1713 struct drbd_conf *mdev;
1480 struct drbd_request *req; 1714 struct drbd_request *req;
1481 sector_t sector; 1715 sector_t sector;
1482 int ok; 1716 int err;
1483 struct p_data *p = &mdev->data.rbuf.data; 1717 struct p_data *p = pi->data;
1718
1719 mdev = vnr_to_mdev(tconn, pi->vnr);
1720 if (!mdev)
1721 return -EIO;
1484 1722
1485 sector = be64_to_cpu(p->sector); 1723 sector = be64_to_cpu(p->sector);
1486 1724
1487 spin_lock_irq(&mdev->req_lock); 1725 spin_lock_irq(&mdev->tconn->req_lock);
1488 req = _ar_id_to_req(mdev, p->block_id, sector); 1726 req = find_request(mdev, &mdev->read_requests, p->block_id, sector, false, __func__);
1489 spin_unlock_irq(&mdev->req_lock); 1727 spin_unlock_irq(&mdev->tconn->req_lock);
1490 if (unlikely(!req)) { 1728 if (unlikely(!req))
1491 dev_err(DEV, "Got a corrupt block_id/sector pair(1).\n"); 1729 return -EIO;
1492 return false;
1493 }
1494 1730
1495 /* hlist_del(&req->collision) is done in _req_may_be_done, to avoid 1731 /* hlist_del(&req->collision) is done in _req_may_be_done, to avoid
1496 * special casing it there for the various failure cases. 1732 * special casing it there for the various failure cases.
1497 * still no race with drbd_fail_pending_reads */ 1733 * still no race with drbd_fail_pending_reads */
1498 ok = recv_dless_read(mdev, req, sector, data_size); 1734 err = recv_dless_read(mdev, req, sector, pi->size);
1499 1735 if (!err)
1500 if (ok) 1736 req_mod(req, DATA_RECEIVED);
1501 req_mod(req, data_received);
1502 /* else: nothing. handled from drbd_disconnect... 1737 /* else: nothing. handled from drbd_disconnect...
1503 * I don't think we may complete this just yet 1738 * I don't think we may complete this just yet
1504 * in case we are "on-disconnect: freeze" */ 1739 * in case we are "on-disconnect: freeze" */
1505 1740
1506 return ok; 1741 return err;
1507} 1742}
1508 1743
1509static int receive_RSDataReply(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 1744static int receive_RSDataReply(struct drbd_tconn *tconn, struct packet_info *pi)
1510{ 1745{
1746 struct drbd_conf *mdev;
1511 sector_t sector; 1747 sector_t sector;
1512 int ok; 1748 int err;
1513 struct p_data *p = &mdev->data.rbuf.data; 1749 struct p_data *p = pi->data;
1750
1751 mdev = vnr_to_mdev(tconn, pi->vnr);
1752 if (!mdev)
1753 return -EIO;
1514 1754
1515 sector = be64_to_cpu(p->sector); 1755 sector = be64_to_cpu(p->sector);
1516 D_ASSERT(p->block_id == ID_SYNCER); 1756 D_ASSERT(p->block_id == ID_SYNCER);
@@ -1518,42 +1758,63 @@ static int receive_RSDataReply(struct drbd_conf *mdev, enum drbd_packets cmd, un
1518 if (get_ldev(mdev)) { 1758 if (get_ldev(mdev)) {
1519 /* data is submitted to disk within recv_resync_read. 1759 /* data is submitted to disk within recv_resync_read.
1520 * corresponding put_ldev done below on error, 1760 * corresponding put_ldev done below on error,
1521 * or in drbd_endio_write_sec. */ 1761 * or in drbd_peer_request_endio. */
1522 ok = recv_resync_read(mdev, sector, data_size); 1762 err = recv_resync_read(mdev, sector, pi->size);
1523 } else { 1763 } else {
1524 if (__ratelimit(&drbd_ratelimit_state)) 1764 if (__ratelimit(&drbd_ratelimit_state))
1525 dev_err(DEV, "Can not write resync data to local disk.\n"); 1765 dev_err(DEV, "Can not write resync data to local disk.\n");
1526 1766
1527 ok = drbd_drain_block(mdev, data_size); 1767 err = drbd_drain_block(mdev, pi->size);
1528 1768
1529 drbd_send_ack_dp(mdev, P_NEG_ACK, p, data_size); 1769 drbd_send_ack_dp(mdev, P_NEG_ACK, p, pi->size);
1530 } 1770 }
1531 1771
1532 atomic_add(data_size >> 9, &mdev->rs_sect_in); 1772 atomic_add(pi->size >> 9, &mdev->rs_sect_in);
1533 1773
1534 return ok; 1774 return err;
1535} 1775}
1536 1776
1537/* e_end_block() is called via drbd_process_done_ee(). 1777static void restart_conflicting_writes(struct drbd_conf *mdev,
1538 * this means this function only runs in the asender thread 1778 sector_t sector, int size)
1539 */
1540static int e_end_block(struct drbd_conf *mdev, struct drbd_work *w, int cancel)
1541{ 1779{
1542 struct drbd_epoch_entry *e = (struct drbd_epoch_entry *)w; 1780 struct drbd_interval *i;
1543 sector_t sector = e->sector; 1781 struct drbd_request *req;
1544 int ok = 1, pcmd;
1545 1782
1546 if (mdev->net_conf->wire_protocol == DRBD_PROT_C) { 1783 drbd_for_each_overlap(i, &mdev->write_requests, sector, size) {
1547 if (likely((e->flags & EE_WAS_ERROR) == 0)) { 1784 if (!i->local)
1785 continue;
1786 req = container_of(i, struct drbd_request, i);
1787 if (req->rq_state & RQ_LOCAL_PENDING ||
1788 !(req->rq_state & RQ_POSTPONED))
1789 continue;
1790 /* as it is RQ_POSTPONED, this will cause it to
1791 * be queued on the retry workqueue. */
1792 __req_mod(req, CONFLICT_RESOLVED, NULL);
1793 }
1794}
1795
1796/*
1797 * e_end_block() is called in asender context via drbd_finish_peer_reqs().
1798 */
1799static int e_end_block(struct drbd_work *w, int cancel)
1800{
1801 struct drbd_peer_request *peer_req =
1802 container_of(w, struct drbd_peer_request, w);
1803 struct drbd_conf *mdev = w->mdev;
1804 sector_t sector = peer_req->i.sector;
1805 int err = 0, pcmd;
1806
1807 if (peer_req->flags & EE_SEND_WRITE_ACK) {
1808 if (likely((peer_req->flags & EE_WAS_ERROR) == 0)) {
1548 pcmd = (mdev->state.conn >= C_SYNC_SOURCE && 1809 pcmd = (mdev->state.conn >= C_SYNC_SOURCE &&
1549 mdev->state.conn <= C_PAUSED_SYNC_T && 1810 mdev->state.conn <= C_PAUSED_SYNC_T &&
1550 e->flags & EE_MAY_SET_IN_SYNC) ? 1811 peer_req->flags & EE_MAY_SET_IN_SYNC) ?
1551 P_RS_WRITE_ACK : P_WRITE_ACK; 1812 P_RS_WRITE_ACK : P_WRITE_ACK;
1552 ok &= drbd_send_ack(mdev, pcmd, e); 1813 err = drbd_send_ack(mdev, pcmd, peer_req);
1553 if (pcmd == P_RS_WRITE_ACK) 1814 if (pcmd == P_RS_WRITE_ACK)
1554 drbd_set_in_sync(mdev, sector, e->size); 1815 drbd_set_in_sync(mdev, sector, peer_req->i.size);
1555 } else { 1816 } else {
1556 ok = drbd_send_ack(mdev, P_NEG_ACK, e); 1817 err = drbd_send_ack(mdev, P_NEG_ACK, peer_req);
1557 /* we expect it to be marked out of sync anyways... 1818 /* we expect it to be marked out of sync anyways...
1558 * maybe assert this? */ 1819 * maybe assert this? */
1559 } 1820 }
@@ -1561,52 +1822,115 @@ static int e_end_block(struct drbd_conf *mdev, struct drbd_work *w, int cancel)
1561 } 1822 }
1562 /* we delete from the conflict detection hash _after_ we sent out the 1823 /* we delete from the conflict detection hash _after_ we sent out the
1563 * P_WRITE_ACK / P_NEG_ACK, to get the sequence number right. */ 1824 * P_WRITE_ACK / P_NEG_ACK, to get the sequence number right. */
1564 if (mdev->net_conf->two_primaries) { 1825 if (peer_req->flags & EE_IN_INTERVAL_TREE) {
1565 spin_lock_irq(&mdev->req_lock); 1826 spin_lock_irq(&mdev->tconn->req_lock);
1566 D_ASSERT(!hlist_unhashed(&e->collision)); 1827 D_ASSERT(!drbd_interval_empty(&peer_req->i));
1567 hlist_del_init(&e->collision); 1828 drbd_remove_epoch_entry_interval(mdev, peer_req);
1568 spin_unlock_irq(&mdev->req_lock); 1829 if (peer_req->flags & EE_RESTART_REQUESTS)
1569 } else { 1830 restart_conflicting_writes(mdev, sector, peer_req->i.size);
1570 D_ASSERT(hlist_unhashed(&e->collision)); 1831 spin_unlock_irq(&mdev->tconn->req_lock);
1571 } 1832 } else
1833 D_ASSERT(drbd_interval_empty(&peer_req->i));
1572 1834
1573 drbd_may_finish_epoch(mdev, e->epoch, EV_PUT + (cancel ? EV_CLEANUP : 0)); 1835 drbd_may_finish_epoch(mdev->tconn, peer_req->epoch, EV_PUT + (cancel ? EV_CLEANUP : 0));
1574 1836
1575 return ok; 1837 return err;
1576} 1838}
1577 1839
1578static int e_send_discard_ack(struct drbd_conf *mdev, struct drbd_work *w, int unused) 1840static int e_send_ack(struct drbd_work *w, enum drbd_packet ack)
1579{ 1841{
1580 struct drbd_epoch_entry *e = (struct drbd_epoch_entry *)w; 1842 struct drbd_conf *mdev = w->mdev;
1581 int ok = 1; 1843 struct drbd_peer_request *peer_req =
1844 container_of(w, struct drbd_peer_request, w);
1845 int err;
1582 1846
1583 D_ASSERT(mdev->net_conf->wire_protocol == DRBD_PROT_C); 1847 err = drbd_send_ack(mdev, ack, peer_req);
1584 ok = drbd_send_ack(mdev, P_DISCARD_ACK, e); 1848 dec_unacked(mdev);
1585 1849
1586 spin_lock_irq(&mdev->req_lock); 1850 return err;
1587 D_ASSERT(!hlist_unhashed(&e->collision)); 1851}
1588 hlist_del_init(&e->collision);
1589 spin_unlock_irq(&mdev->req_lock);
1590 1852
1591 dec_unacked(mdev); 1853static int e_send_superseded(struct drbd_work *w, int unused)
1854{
1855 return e_send_ack(w, P_SUPERSEDED);
1856}
1857
1858static int e_send_retry_write(struct drbd_work *w, int unused)
1859{
1860 struct drbd_tconn *tconn = w->mdev->tconn;
1861
1862 return e_send_ack(w, tconn->agreed_pro_version >= 100 ?
1863 P_RETRY_WRITE : P_SUPERSEDED);
1864}
1865
1866static bool seq_greater(u32 a, u32 b)
1867{
1868 /*
1869 * We assume 32-bit wrap-around here.
1870 * For 24-bit wrap-around, we would have to shift:
1871 * a <<= 8; b <<= 8;
1872 */
1873 return (s32)a - (s32)b > 0;
1874}
1875
1876static u32 seq_max(u32 a, u32 b)
1877{
1878 return seq_greater(a, b) ? a : b;
1879}
1880
1881static bool need_peer_seq(struct drbd_conf *mdev)
1882{
1883 struct drbd_tconn *tconn = mdev->tconn;
1884 int tp;
1885
1886 /*
1887 * We only need to keep track of the last packet_seq number of our peer
1888 * if we are in dual-primary mode and we have the resolve-conflicts flag set; see
1889 * handle_write_conflicts().
1890 */
1891
1892 rcu_read_lock();
1893 tp = rcu_dereference(mdev->tconn->net_conf)->two_primaries;
1894 rcu_read_unlock();
1895
1896 return tp && test_bit(RESOLVE_CONFLICTS, &tconn->flags);
1897}
1898
1899static void update_peer_seq(struct drbd_conf *mdev, unsigned int peer_seq)
1900{
1901 unsigned int newest_peer_seq;
1592 1902
1593 return ok; 1903 if (need_peer_seq(mdev)) {
1904 spin_lock(&mdev->peer_seq_lock);
1905 newest_peer_seq = seq_max(mdev->peer_seq, peer_seq);
1906 mdev->peer_seq = newest_peer_seq;
1907 spin_unlock(&mdev->peer_seq_lock);
1908 /* wake up only if we actually changed mdev->peer_seq */
1909 if (peer_seq == newest_peer_seq)
1910 wake_up(&mdev->seq_wait);
1911 }
1594} 1912}
1595 1913
1596static bool overlapping_resync_write(struct drbd_conf *mdev, struct drbd_epoch_entry *data_e) 1914static inline int overlaps(sector_t s1, int l1, sector_t s2, int l2)
1597{ 1915{
1916 return !((s1 + (l1>>9) <= s2) || (s1 >= s2 + (l2>>9)));
1917}
1598 1918
1599 struct drbd_epoch_entry *rs_e; 1919/* maybe change sync_ee into interval trees as well? */
1920static bool overlapping_resync_write(struct drbd_conf *mdev, struct drbd_peer_request *peer_req)
1921{
1922 struct drbd_peer_request *rs_req;
1600 bool rv = 0; 1923 bool rv = 0;
1601 1924
1602 spin_lock_irq(&mdev->req_lock); 1925 spin_lock_irq(&mdev->tconn->req_lock);
1603 list_for_each_entry(rs_e, &mdev->sync_ee, w.list) { 1926 list_for_each_entry(rs_req, &mdev->sync_ee, w.list) {
1604 if (overlaps(data_e->sector, data_e->size, rs_e->sector, rs_e->size)) { 1927 if (overlaps(peer_req->i.sector, peer_req->i.size,
1928 rs_req->i.sector, rs_req->i.size)) {
1605 rv = 1; 1929 rv = 1;
1606 break; 1930 break;
1607 } 1931 }
1608 } 1932 }
1609 spin_unlock_irq(&mdev->req_lock); 1933 spin_unlock_irq(&mdev->tconn->req_lock);
1610 1934
1611 return rv; 1935 return rv;
1612} 1936}
@@ -1632,35 +1956,41 @@ static bool overlapping_resync_write(struct drbd_conf *mdev, struct drbd_epoch_e
1632 * 1956 *
1633 * returns 0 if we may process the packet, 1957 * returns 0 if we may process the packet,
1634 * -ERESTARTSYS if we were interrupted (by disconnect signal). */ 1958 * -ERESTARTSYS if we were interrupted (by disconnect signal). */
1635static int drbd_wait_peer_seq(struct drbd_conf *mdev, const u32 packet_seq) 1959static int wait_for_and_update_peer_seq(struct drbd_conf *mdev, const u32 peer_seq)
1636{ 1960{
1637 DEFINE_WAIT(wait); 1961 DEFINE_WAIT(wait);
1638 unsigned int p_seq;
1639 long timeout; 1962 long timeout;
1640 int ret = 0; 1963 int ret;
1964
1965 if (!need_peer_seq(mdev))
1966 return 0;
1967
1641 spin_lock(&mdev->peer_seq_lock); 1968 spin_lock(&mdev->peer_seq_lock);
1642 for (;;) { 1969 for (;;) {
1643 prepare_to_wait(&mdev->seq_wait, &wait, TASK_INTERRUPTIBLE); 1970 if (!seq_greater(peer_seq - 1, mdev->peer_seq)) {
1644 if (seq_le(packet_seq, mdev->peer_seq+1)) 1971 mdev->peer_seq = seq_max(mdev->peer_seq, peer_seq);
1972 ret = 0;
1645 break; 1973 break;
1974 }
1646 if (signal_pending(current)) { 1975 if (signal_pending(current)) {
1647 ret = -ERESTARTSYS; 1976 ret = -ERESTARTSYS;
1648 break; 1977 break;
1649 } 1978 }
1650 p_seq = mdev->peer_seq; 1979 prepare_to_wait(&mdev->seq_wait, &wait, TASK_INTERRUPTIBLE);
1651 spin_unlock(&mdev->peer_seq_lock); 1980 spin_unlock(&mdev->peer_seq_lock);
1652 timeout = schedule_timeout(30*HZ); 1981 rcu_read_lock();
1982 timeout = rcu_dereference(mdev->tconn->net_conf)->ping_timeo*HZ/10;
1983 rcu_read_unlock();
1984 timeout = schedule_timeout(timeout);
1653 spin_lock(&mdev->peer_seq_lock); 1985 spin_lock(&mdev->peer_seq_lock);
1654 if (timeout == 0 && p_seq == mdev->peer_seq) { 1986 if (!timeout) {
1655 ret = -ETIMEDOUT; 1987 ret = -ETIMEDOUT;
1656 dev_err(DEV, "ASSERT FAILED waited 30 seconds for sequence update, forcing reconnect\n"); 1988 dev_err(DEV, "Timed out waiting for missing ack packets; disconnecting\n");
1657 break; 1989 break;
1658 } 1990 }
1659 } 1991 }
1660 finish_wait(&mdev->seq_wait, &wait);
1661 if (mdev->peer_seq+1 == packet_seq)
1662 mdev->peer_seq++;
1663 spin_unlock(&mdev->peer_seq_lock); 1992 spin_unlock(&mdev->peer_seq_lock);
1993 finish_wait(&mdev->seq_wait, &wait);
1664 return ret; 1994 return ret;
1665} 1995}
1666 1996
@@ -1675,233 +2005,277 @@ static unsigned long wire_flags_to_bio(struct drbd_conf *mdev, u32 dpf)
1675 (dpf & DP_DISCARD ? REQ_DISCARD : 0); 2005 (dpf & DP_DISCARD ? REQ_DISCARD : 0);
1676} 2006}
1677 2007
2008static void fail_postponed_requests(struct drbd_conf *mdev, sector_t sector,
2009 unsigned int size)
2010{
2011 struct drbd_interval *i;
2012
2013 repeat:
2014 drbd_for_each_overlap(i, &mdev->write_requests, sector, size) {
2015 struct drbd_request *req;
2016 struct bio_and_error m;
2017
2018 if (!i->local)
2019 continue;
2020 req = container_of(i, struct drbd_request, i);
2021 if (!(req->rq_state & RQ_POSTPONED))
2022 continue;
2023 req->rq_state &= ~RQ_POSTPONED;
2024 __req_mod(req, NEG_ACKED, &m);
2025 spin_unlock_irq(&mdev->tconn->req_lock);
2026 if (m.bio)
2027 complete_master_bio(mdev, &m);
2028 spin_lock_irq(&mdev->tconn->req_lock);
2029 goto repeat;
2030 }
2031}
2032
2033static int handle_write_conflicts(struct drbd_conf *mdev,
2034 struct drbd_peer_request *peer_req)
2035{
2036 struct drbd_tconn *tconn = mdev->tconn;
2037 bool resolve_conflicts = test_bit(RESOLVE_CONFLICTS, &tconn->flags);
2038 sector_t sector = peer_req->i.sector;
2039 const unsigned int size = peer_req->i.size;
2040 struct drbd_interval *i;
2041 bool equal;
2042 int err;
2043
2044 /*
2045 * Inserting the peer request into the write_requests tree will prevent
2046 * new conflicting local requests from being added.
2047 */
2048 drbd_insert_interval(&mdev->write_requests, &peer_req->i);
2049
2050 repeat:
2051 drbd_for_each_overlap(i, &mdev->write_requests, sector, size) {
2052 if (i == &peer_req->i)
2053 continue;
2054
2055 if (!i->local) {
2056 /*
2057 * Our peer has sent a conflicting remote request; this
2058 * should not happen in a two-node setup. Wait for the
2059 * earlier peer request to complete.
2060 */
2061 err = drbd_wait_misc(mdev, i);
2062 if (err)
2063 goto out;
2064 goto repeat;
2065 }
2066
2067 equal = i->sector == sector && i->size == size;
2068 if (resolve_conflicts) {
2069 /*
2070 * If the peer request is fully contained within the
2071 * overlapping request, it can be considered overwritten
2072 * and thus superseded; otherwise, it will be retried
2073 * once all overlapping requests have completed.
2074 */
2075 bool superseded = i->sector <= sector && i->sector +
2076 (i->size >> 9) >= sector + (size >> 9);
2077
2078 if (!equal)
2079 dev_alert(DEV, "Concurrent writes detected: "
2080 "local=%llus +%u, remote=%llus +%u, "
2081 "assuming %s came first\n",
2082 (unsigned long long)i->sector, i->size,
2083 (unsigned long long)sector, size,
2084 superseded ? "local" : "remote");
2085
2086 inc_unacked(mdev);
2087 peer_req->w.cb = superseded ? e_send_superseded :
2088 e_send_retry_write;
2089 list_add_tail(&peer_req->w.list, &mdev->done_ee);
2090 wake_asender(mdev->tconn);
2091
2092 err = -ENOENT;
2093 goto out;
2094 } else {
2095 struct drbd_request *req =
2096 container_of(i, struct drbd_request, i);
2097
2098 if (!equal)
2099 dev_alert(DEV, "Concurrent writes detected: "
2100 "local=%llus +%u, remote=%llus +%u\n",
2101 (unsigned long long)i->sector, i->size,
2102 (unsigned long long)sector, size);
2103
2104 if (req->rq_state & RQ_LOCAL_PENDING ||
2105 !(req->rq_state & RQ_POSTPONED)) {
2106 /*
2107 * Wait for the node with the discard flag to
2108 * decide if this request has been superseded
2109 * or needs to be retried.
2110 * Requests that have been superseded will
2111 * disappear from the write_requests tree.
2112 *
2113 * In addition, wait for the conflicting
2114 * request to finish locally before submitting
2115 * the conflicting peer request.
2116 */
2117 err = drbd_wait_misc(mdev, &req->i);
2118 if (err) {
2119 _conn_request_state(mdev->tconn,
2120 NS(conn, C_TIMEOUT),
2121 CS_HARD);
2122 fail_postponed_requests(mdev, sector, size);
2123 goto out;
2124 }
2125 goto repeat;
2126 }
2127 /*
2128 * Remember to restart the conflicting requests after
2129 * the new peer request has completed.
2130 */
2131 peer_req->flags |= EE_RESTART_REQUESTS;
2132 }
2133 }
2134 err = 0;
2135
2136 out:
2137 if (err)
2138 drbd_remove_epoch_entry_interval(mdev, peer_req);
2139 return err;
2140}
2141
1678/* mirrored write */ 2142/* mirrored write */
1679static int receive_Data(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 2143static int receive_Data(struct drbd_tconn *tconn, struct packet_info *pi)
1680{ 2144{
2145 struct drbd_conf *mdev;
1681 sector_t sector; 2146 sector_t sector;
1682 struct drbd_epoch_entry *e; 2147 struct drbd_peer_request *peer_req;
1683 struct p_data *p = &mdev->data.rbuf.data; 2148 struct p_data *p = pi->data;
2149 u32 peer_seq = be32_to_cpu(p->seq_num);
1684 int rw = WRITE; 2150 int rw = WRITE;
1685 u32 dp_flags; 2151 u32 dp_flags;
2152 int err, tp;
1686 2153
1687 if (!get_ldev(mdev)) { 2154 mdev = vnr_to_mdev(tconn, pi->vnr);
1688 spin_lock(&mdev->peer_seq_lock); 2155 if (!mdev)
1689 if (mdev->peer_seq+1 == be32_to_cpu(p->seq_num)) 2156 return -EIO;
1690 mdev->peer_seq++;
1691 spin_unlock(&mdev->peer_seq_lock);
1692 2157
1693 drbd_send_ack_dp(mdev, P_NEG_ACK, p, data_size); 2158 if (!get_ldev(mdev)) {
1694 atomic_inc(&mdev->current_epoch->epoch_size); 2159 int err2;
1695 return drbd_drain_block(mdev, data_size); 2160
2161 err = wait_for_and_update_peer_seq(mdev, peer_seq);
2162 drbd_send_ack_dp(mdev, P_NEG_ACK, p, pi->size);
2163 atomic_inc(&tconn->current_epoch->epoch_size);
2164 err2 = drbd_drain_block(mdev, pi->size);
2165 if (!err)
2166 err = err2;
2167 return err;
1696 } 2168 }
1697 2169
1698 /* get_ldev(mdev) successful. 2170 /*
1699 * Corresponding put_ldev done either below (on various errors), 2171 * Corresponding put_ldev done either below (on various errors), or in
1700 * or in drbd_endio_write_sec, if we successfully submit the data at 2172 * drbd_peer_request_endio, if we successfully submit the data at the
1701 * the end of this function. */ 2173 * end of this function.
2174 */
1702 2175
1703 sector = be64_to_cpu(p->sector); 2176 sector = be64_to_cpu(p->sector);
1704 e = read_in_block(mdev, p->block_id, sector, data_size); 2177 peer_req = read_in_block(mdev, p->block_id, sector, pi->size);
1705 if (!e) { 2178 if (!peer_req) {
1706 put_ldev(mdev); 2179 put_ldev(mdev);
1707 return false; 2180 return -EIO;
1708 } 2181 }
1709 2182
1710 e->w.cb = e_end_block; 2183 peer_req->w.cb = e_end_block;
1711 2184
1712 dp_flags = be32_to_cpu(p->dp_flags); 2185 dp_flags = be32_to_cpu(p->dp_flags);
1713 rw |= wire_flags_to_bio(mdev, dp_flags); 2186 rw |= wire_flags_to_bio(mdev, dp_flags);
1714 if (e->pages == NULL) { 2187 if (peer_req->pages == NULL) {
1715 D_ASSERT(e->size == 0); 2188 D_ASSERT(peer_req->i.size == 0);
1716 D_ASSERT(dp_flags & DP_FLUSH); 2189 D_ASSERT(dp_flags & DP_FLUSH);
1717 } 2190 }
1718 2191
1719 if (dp_flags & DP_MAY_SET_IN_SYNC) 2192 if (dp_flags & DP_MAY_SET_IN_SYNC)
1720 e->flags |= EE_MAY_SET_IN_SYNC; 2193 peer_req->flags |= EE_MAY_SET_IN_SYNC;
1721 2194
1722 spin_lock(&mdev->epoch_lock); 2195 spin_lock(&tconn->epoch_lock);
1723 e->epoch = mdev->current_epoch; 2196 peer_req->epoch = tconn->current_epoch;
1724 atomic_inc(&e->epoch->epoch_size); 2197 atomic_inc(&peer_req->epoch->epoch_size);
1725 atomic_inc(&e->epoch->active); 2198 atomic_inc(&peer_req->epoch->active);
1726 spin_unlock(&mdev->epoch_lock); 2199 spin_unlock(&tconn->epoch_lock);
1727 2200
1728 /* I'm the receiver, I do hold a net_cnt reference. */ 2201 rcu_read_lock();
1729 if (!mdev->net_conf->two_primaries) { 2202 tp = rcu_dereference(mdev->tconn->net_conf)->two_primaries;
1730 spin_lock_irq(&mdev->req_lock); 2203 rcu_read_unlock();
1731 } else { 2204 if (tp) {
1732 /* don't get the req_lock yet, 2205 peer_req->flags |= EE_IN_INTERVAL_TREE;
1733 * we may sleep in drbd_wait_peer_seq */ 2206 err = wait_for_and_update_peer_seq(mdev, peer_seq);
1734 const int size = e->size; 2207 if (err)
1735 const int discard = drbd_test_flag(mdev, DISCARD_CONCURRENT);
1736 DEFINE_WAIT(wait);
1737 struct drbd_request *i;
1738 struct hlist_node *n;
1739 struct hlist_head *slot;
1740 int first;
1741
1742 D_ASSERT(mdev->net_conf->wire_protocol == DRBD_PROT_C);
1743 BUG_ON(mdev->ee_hash == NULL);
1744 BUG_ON(mdev->tl_hash == NULL);
1745
1746 /* conflict detection and handling:
1747 * 1. wait on the sequence number,
1748 * in case this data packet overtook ACK packets.
1749 * 2. check our hash tables for conflicting requests.
1750 * we only need to walk the tl_hash, since an ee can not
1751 * have a conflict with an other ee: on the submitting
1752 * node, the corresponding req had already been conflicting,
1753 * and a conflicting req is never sent.
1754 *
1755 * Note: for two_primaries, we are protocol C,
1756 * so there cannot be any request that is DONE
1757 * but still on the transfer log.
1758 *
1759 * unconditionally add to the ee_hash.
1760 *
1761 * if no conflicting request is found:
1762 * submit.
1763 *
1764 * if any conflicting request is found
1765 * that has not yet been acked,
1766 * AND I have the "discard concurrent writes" flag:
1767 * queue (via done_ee) the P_DISCARD_ACK; OUT.
1768 *
1769 * if any conflicting request is found:
1770 * block the receiver, waiting on misc_wait
1771 * until no more conflicting requests are there,
1772 * or we get interrupted (disconnect).
1773 *
1774 * we do not just write after local io completion of those
1775 * requests, but only after req is done completely, i.e.
1776 * we wait for the P_DISCARD_ACK to arrive!
1777 *
1778 * then proceed normally, i.e. submit.
1779 */
1780 if (drbd_wait_peer_seq(mdev, be32_to_cpu(p->seq_num)))
1781 goto out_interrupted; 2208 goto out_interrupted;
1782 2209 spin_lock_irq(&mdev->tconn->req_lock);
1783 spin_lock_irq(&mdev->req_lock); 2210 err = handle_write_conflicts(mdev, peer_req);
1784 2211 if (err) {
1785 hlist_add_head(&e->collision, ee_hash_slot(mdev, sector)); 2212 spin_unlock_irq(&mdev->tconn->req_lock);
1786 2213 if (err == -ENOENT) {
1787#define OVERLAPS overlaps(i->sector, i->size, sector, size)
1788 slot = tl_hash_slot(mdev, sector);
1789 first = 1;
1790 for (;;) {
1791 int have_unacked = 0;
1792 int have_conflict = 0;
1793 prepare_to_wait(&mdev->misc_wait, &wait,
1794 TASK_INTERRUPTIBLE);
1795 hlist_for_each_entry(i, n, slot, collision) {
1796 if (OVERLAPS) {
1797 /* only ALERT on first iteration,
1798 * we may be woken up early... */
1799 if (first)
1800 dev_alert(DEV, "%s[%u] Concurrent local write detected!"
1801 " new: %llus +%u; pending: %llus +%u\n",
1802 current->comm, current->pid,
1803 (unsigned long long)sector, size,
1804 (unsigned long long)i->sector, i->size);
1805 if (i->rq_state & RQ_NET_PENDING)
1806 ++have_unacked;
1807 ++have_conflict;
1808 }
1809 }
1810#undef OVERLAPS
1811 if (!have_conflict)
1812 break;
1813
1814 /* Discard Ack only for the _first_ iteration */
1815 if (first && discard && have_unacked) {
1816 dev_alert(DEV, "Concurrent write! [DISCARD BY FLAG] sec=%llus\n",
1817 (unsigned long long)sector);
1818 inc_unacked(mdev);
1819 e->w.cb = e_send_discard_ack;
1820 list_add_tail(&e->w.list, &mdev->done_ee);
1821
1822 spin_unlock_irq(&mdev->req_lock);
1823
1824 /* we could probably send that P_DISCARD_ACK ourselves,
1825 * but I don't like the receiver using the msock */
1826
1827 put_ldev(mdev); 2214 put_ldev(mdev);
1828 wake_asender(mdev); 2215 return 0;
1829 finish_wait(&mdev->misc_wait, &wait);
1830 return true;
1831 } 2216 }
2217 goto out_interrupted;
2218 }
2219 } else
2220 spin_lock_irq(&mdev->tconn->req_lock);
2221 list_add(&peer_req->w.list, &mdev->active_ee);
2222 spin_unlock_irq(&mdev->tconn->req_lock);
1832 2223
1833 if (signal_pending(current)) { 2224 if (mdev->state.conn == C_SYNC_TARGET)
1834 hlist_del_init(&e->collision); 2225 wait_event(mdev->ee_wait, !overlapping_resync_write(mdev, peer_req));
1835
1836 spin_unlock_irq(&mdev->req_lock);
1837
1838 finish_wait(&mdev->misc_wait, &wait);
1839 goto out_interrupted;
1840 }
1841 2226
1842 spin_unlock_irq(&mdev->req_lock); 2227 if (mdev->tconn->agreed_pro_version < 100) {
1843 if (first) { 2228 rcu_read_lock();
1844 first = 0; 2229 switch (rcu_dereference(mdev->tconn->net_conf)->wire_protocol) {
1845 dev_alert(DEV, "Concurrent write! [W AFTERWARDS] " 2230 case DRBD_PROT_C:
1846 "sec=%llus\n", (unsigned long long)sector); 2231 dp_flags |= DP_SEND_WRITE_ACK;
1847 } else if (discard) { 2232 break;
1848 /* we had none on the first iteration. 2233 case DRBD_PROT_B:
1849 * there must be none now. */ 2234 dp_flags |= DP_SEND_RECEIVE_ACK;
1850 D_ASSERT(have_unacked == 0); 2235 break;
1851 }
1852 schedule();
1853 spin_lock_irq(&mdev->req_lock);
1854 } 2236 }
1855 finish_wait(&mdev->misc_wait, &wait); 2237 rcu_read_unlock();
1856 } 2238 }
1857 2239
1858 list_add(&e->w.list, &mdev->active_ee); 2240 if (dp_flags & DP_SEND_WRITE_ACK) {
1859 spin_unlock_irq(&mdev->req_lock); 2241 peer_req->flags |= EE_SEND_WRITE_ACK;
1860
1861 if (mdev->state.conn == C_SYNC_TARGET)
1862 wait_event(mdev->ee_wait, !overlapping_resync_write(mdev, e));
1863
1864 switch (mdev->net_conf->wire_protocol) {
1865 case DRBD_PROT_C:
1866 inc_unacked(mdev); 2242 inc_unacked(mdev);
1867 /* corresponding dec_unacked() in e_end_block() 2243 /* corresponding dec_unacked() in e_end_block()
1868 * respective _drbd_clear_done_ee */ 2244 * respective _drbd_clear_done_ee */
1869 break; 2245 }
1870 case DRBD_PROT_B: 2246
2247 if (dp_flags & DP_SEND_RECEIVE_ACK) {
1871 /* I really don't like it that the receiver thread 2248 /* I really don't like it that the receiver thread
1872 * sends on the msock, but anyways */ 2249 * sends on the msock, but anyways */
1873 drbd_send_ack(mdev, P_RECV_ACK, e); 2250 drbd_send_ack(mdev, P_RECV_ACK, peer_req);
1874 break;
1875 case DRBD_PROT_A:
1876 /* nothing to do */
1877 break;
1878 } 2251 }
1879 2252
1880 if (mdev->state.pdsk < D_INCONSISTENT) { 2253 if (mdev->state.pdsk < D_INCONSISTENT) {
1881 /* In case we have the only disk of the cluster, */ 2254 /* In case we have the only disk of the cluster, */
1882 drbd_set_out_of_sync(mdev, e->sector, e->size); 2255 drbd_set_out_of_sync(mdev, peer_req->i.sector, peer_req->i.size);
1883 e->flags |= EE_CALL_AL_COMPLETE_IO; 2256 peer_req->flags |= EE_CALL_AL_COMPLETE_IO;
1884 e->flags &= ~EE_MAY_SET_IN_SYNC; 2257 peer_req->flags &= ~EE_MAY_SET_IN_SYNC;
1885 drbd_al_begin_io(mdev, e->sector); 2258 drbd_al_begin_io(mdev, &peer_req->i);
1886 } 2259 }
1887 2260
1888 if (drbd_submit_ee(mdev, e, rw, DRBD_FAULT_DT_WR) == 0) 2261 err = drbd_submit_peer_request(mdev, peer_req, rw, DRBD_FAULT_DT_WR);
1889 return true; 2262 if (!err)
2263 return 0;
1890 2264
1891 /* don't care for the reason here */ 2265 /* don't care for the reason here */
1892 dev_err(DEV, "submit failed, triggering re-connect\n"); 2266 dev_err(DEV, "submit failed, triggering re-connect\n");
1893 spin_lock_irq(&mdev->req_lock); 2267 spin_lock_irq(&mdev->tconn->req_lock);
1894 list_del(&e->w.list); 2268 list_del(&peer_req->w.list);
1895 hlist_del_init(&e->collision); 2269 drbd_remove_epoch_entry_interval(mdev, peer_req);
1896 spin_unlock_irq(&mdev->req_lock); 2270 spin_unlock_irq(&mdev->tconn->req_lock);
1897 if (e->flags & EE_CALL_AL_COMPLETE_IO) 2271 if (peer_req->flags & EE_CALL_AL_COMPLETE_IO)
1898 drbd_al_complete_io(mdev, e->sector); 2272 drbd_al_complete_io(mdev, &peer_req->i);
1899 2273
1900out_interrupted: 2274out_interrupted:
1901 drbd_may_finish_epoch(mdev, e->epoch, EV_PUT + EV_CLEANUP); 2275 drbd_may_finish_epoch(tconn, peer_req->epoch, EV_PUT + EV_CLEANUP);
1902 put_ldev(mdev); 2276 put_ldev(mdev);
1903 drbd_free_ee(mdev, e); 2277 drbd_free_peer_req(mdev, peer_req);
1904 return false; 2278 return err;
1905} 2279}
1906 2280
1907/* We may throttle resync, if the lower device seems to be busy, 2281/* We may throttle resync, if the lower device seems to be busy,
@@ -1922,9 +2296,14 @@ int drbd_rs_should_slow_down(struct drbd_conf *mdev, sector_t sector)
1922 struct lc_element *tmp; 2296 struct lc_element *tmp;
1923 int curr_events; 2297 int curr_events;
1924 int throttle = 0; 2298 int throttle = 0;
2299 unsigned int c_min_rate;
2300
2301 rcu_read_lock();
2302 c_min_rate = rcu_dereference(mdev->ldev->disk_conf)->c_min_rate;
2303 rcu_read_unlock();
1925 2304
1926 /* feature disabled? */ 2305 /* feature disabled? */
1927 if (mdev->sync_conf.c_min_rate == 0) 2306 if (c_min_rate == 0)
1928 return 0; 2307 return 0;
1929 2308
1930 spin_lock_irq(&mdev->al_lock); 2309 spin_lock_irq(&mdev->al_lock);
@@ -1964,40 +2343,46 @@ int drbd_rs_should_slow_down(struct drbd_conf *mdev, sector_t sector)
1964 db = mdev->rs_mark_left[i] - rs_left; 2343 db = mdev->rs_mark_left[i] - rs_left;
1965 dbdt = Bit2KB(db/dt); 2344 dbdt = Bit2KB(db/dt);
1966 2345
1967 if (dbdt > mdev->sync_conf.c_min_rate) 2346 if (dbdt > c_min_rate)
1968 throttle = 1; 2347 throttle = 1;
1969 } 2348 }
1970 return throttle; 2349 return throttle;
1971} 2350}
1972 2351
1973 2352
1974static int receive_DataRequest(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int digest_size) 2353static int receive_DataRequest(struct drbd_tconn *tconn, struct packet_info *pi)
1975{ 2354{
2355 struct drbd_conf *mdev;
1976 sector_t sector; 2356 sector_t sector;
1977 const sector_t capacity = drbd_get_capacity(mdev->this_bdev); 2357 sector_t capacity;
1978 struct drbd_epoch_entry *e; 2358 struct drbd_peer_request *peer_req;
1979 struct digest_info *di = NULL; 2359 struct digest_info *di = NULL;
1980 int size, verb; 2360 int size, verb;
1981 unsigned int fault_type; 2361 unsigned int fault_type;
1982 struct p_block_req *p = &mdev->data.rbuf.block_req; 2362 struct p_block_req *p = pi->data;
2363
2364 mdev = vnr_to_mdev(tconn, pi->vnr);
2365 if (!mdev)
2366 return -EIO;
2367 capacity = drbd_get_capacity(mdev->this_bdev);
1983 2368
1984 sector = be64_to_cpu(p->sector); 2369 sector = be64_to_cpu(p->sector);
1985 size = be32_to_cpu(p->blksize); 2370 size = be32_to_cpu(p->blksize);
1986 2371
1987 if (size <= 0 || (size & 0x1ff) != 0 || size > DRBD_MAX_BIO_SIZE) { 2372 if (size <= 0 || !IS_ALIGNED(size, 512) || size > DRBD_MAX_BIO_SIZE) {
1988 dev_err(DEV, "%s:%d: sector: %llus, size: %u\n", __FILE__, __LINE__, 2373 dev_err(DEV, "%s:%d: sector: %llus, size: %u\n", __FILE__, __LINE__,
1989 (unsigned long long)sector, size); 2374 (unsigned long long)sector, size);
1990 return false; 2375 return -EINVAL;
1991 } 2376 }
1992 if (sector + (size>>9) > capacity) { 2377 if (sector + (size>>9) > capacity) {
1993 dev_err(DEV, "%s:%d: sector: %llus, size: %u\n", __FILE__, __LINE__, 2378 dev_err(DEV, "%s:%d: sector: %llus, size: %u\n", __FILE__, __LINE__,
1994 (unsigned long long)sector, size); 2379 (unsigned long long)sector, size);
1995 return false; 2380 return -EINVAL;
1996 } 2381 }
1997 2382
1998 if (!get_ldev_if_state(mdev, D_UP_TO_DATE)) { 2383 if (!get_ldev_if_state(mdev, D_UP_TO_DATE)) {
1999 verb = 1; 2384 verb = 1;
2000 switch (cmd) { 2385 switch (pi->cmd) {
2001 case P_DATA_REQUEST: 2386 case P_DATA_REQUEST:
2002 drbd_send_ack_rp(mdev, P_NEG_DREPLY, p); 2387 drbd_send_ack_rp(mdev, P_NEG_DREPLY, p);
2003 break; 2388 break;
@@ -2012,35 +2397,34 @@ static int receive_DataRequest(struct drbd_conf *mdev, enum drbd_packets cmd, un
2012 drbd_send_ack_ex(mdev, P_OV_RESULT, sector, size, ID_IN_SYNC); 2397 drbd_send_ack_ex(mdev, P_OV_RESULT, sector, size, ID_IN_SYNC);
2013 break; 2398 break;
2014 default: 2399 default:
2015 dev_err(DEV, "unexpected command (%s) in receive_DataRequest\n", 2400 BUG();
2016 cmdname(cmd));
2017 } 2401 }
2018 if (verb && __ratelimit(&drbd_ratelimit_state)) 2402 if (verb && __ratelimit(&drbd_ratelimit_state))
2019 dev_err(DEV, "Can not satisfy peer's read request, " 2403 dev_err(DEV, "Can not satisfy peer's read request, "
2020 "no local data.\n"); 2404 "no local data.\n");
2021 2405
2022 /* drain possibly payload */ 2406 /* drain possibly payload */
2023 return drbd_drain_block(mdev, digest_size); 2407 return drbd_drain_block(mdev, pi->size);
2024 } 2408 }
2025 2409
2026 /* GFP_NOIO, because we must not cause arbitrary write-out: in a DRBD 2410 /* GFP_NOIO, because we must not cause arbitrary write-out: in a DRBD
2027 * "criss-cross" setup, that might cause write-out on some other DRBD, 2411 * "criss-cross" setup, that might cause write-out on some other DRBD,
2028 * which in turn might block on the other node at this very place. */ 2412 * which in turn might block on the other node at this very place. */
2029 e = drbd_alloc_ee(mdev, p->block_id, sector, size, GFP_NOIO); 2413 peer_req = drbd_alloc_peer_req(mdev, p->block_id, sector, size, GFP_NOIO);
2030 if (!e) { 2414 if (!peer_req) {
2031 put_ldev(mdev); 2415 put_ldev(mdev);
2032 return false; 2416 return -ENOMEM;
2033 } 2417 }
2034 2418
2035 switch (cmd) { 2419 switch (pi->cmd) {
2036 case P_DATA_REQUEST: 2420 case P_DATA_REQUEST:
2037 e->w.cb = w_e_end_data_req; 2421 peer_req->w.cb = w_e_end_data_req;
2038 fault_type = DRBD_FAULT_DT_RD; 2422 fault_type = DRBD_FAULT_DT_RD;
2039 /* application IO, don't drbd_rs_begin_io */ 2423 /* application IO, don't drbd_rs_begin_io */
2040 goto submit; 2424 goto submit;
2041 2425
2042 case P_RS_DATA_REQUEST: 2426 case P_RS_DATA_REQUEST:
2043 e->w.cb = w_e_end_rsdata_req; 2427 peer_req->w.cb = w_e_end_rsdata_req;
2044 fault_type = DRBD_FAULT_RS_RD; 2428 fault_type = DRBD_FAULT_RS_RD;
2045 /* used in the sector offset progress display */ 2429 /* used in the sector offset progress display */
2046 mdev->bm_resync_fo = BM_SECT_TO_BIT(sector); 2430 mdev->bm_resync_fo = BM_SECT_TO_BIT(sector);
@@ -2049,28 +2433,28 @@ static int receive_DataRequest(struct drbd_conf *mdev, enum drbd_packets cmd, un
2049 case P_OV_REPLY: 2433 case P_OV_REPLY:
2050 case P_CSUM_RS_REQUEST: 2434 case P_CSUM_RS_REQUEST:
2051 fault_type = DRBD_FAULT_RS_RD; 2435 fault_type = DRBD_FAULT_RS_RD;
2052 di = kmalloc(sizeof(*di) + digest_size, GFP_NOIO); 2436 di = kmalloc(sizeof(*di) + pi->size, GFP_NOIO);
2053 if (!di) 2437 if (!di)
2054 goto out_free_e; 2438 goto out_free_e;
2055 2439
2056 di->digest_size = digest_size; 2440 di->digest_size = pi->size;
2057 di->digest = (((char *)di)+sizeof(struct digest_info)); 2441 di->digest = (((char *)di)+sizeof(struct digest_info));
2058 2442
2059 e->digest = di; 2443 peer_req->digest = di;
2060 e->flags |= EE_HAS_DIGEST; 2444 peer_req->flags |= EE_HAS_DIGEST;
2061 2445
2062 if (drbd_recv(mdev, di->digest, digest_size) != digest_size) 2446 if (drbd_recv_all(mdev->tconn, di->digest, pi->size))
2063 goto out_free_e; 2447 goto out_free_e;
2064 2448
2065 if (cmd == P_CSUM_RS_REQUEST) { 2449 if (pi->cmd == P_CSUM_RS_REQUEST) {
2066 D_ASSERT(mdev->agreed_pro_version >= 89); 2450 D_ASSERT(mdev->tconn->agreed_pro_version >= 89);
2067 e->w.cb = w_e_end_csum_rs_req; 2451 peer_req->w.cb = w_e_end_csum_rs_req;
2068 /* used in the sector offset progress display */ 2452 /* used in the sector offset progress display */
2069 mdev->bm_resync_fo = BM_SECT_TO_BIT(sector); 2453 mdev->bm_resync_fo = BM_SECT_TO_BIT(sector);
2070 } else if (cmd == P_OV_REPLY) { 2454 } else if (pi->cmd == P_OV_REPLY) {
2071 /* track progress, we may need to throttle */ 2455 /* track progress, we may need to throttle */
2072 atomic_add(size >> 9, &mdev->rs_sect_in); 2456 atomic_add(size >> 9, &mdev->rs_sect_in);
2073 e->w.cb = w_e_end_ov_reply; 2457 peer_req->w.cb = w_e_end_ov_reply;
2074 dec_rs_pending(mdev); 2458 dec_rs_pending(mdev);
2075 /* drbd_rs_begin_io done when we sent this request, 2459 /* drbd_rs_begin_io done when we sent this request,
2076 * but accounting still needs to be done. */ 2460 * but accounting still needs to be done. */
@@ -2080,7 +2464,7 @@ static int receive_DataRequest(struct drbd_conf *mdev, enum drbd_packets cmd, un
2080 2464
2081 case P_OV_REQUEST: 2465 case P_OV_REQUEST:
2082 if (mdev->ov_start_sector == ~(sector_t)0 && 2466 if (mdev->ov_start_sector == ~(sector_t)0 &&
2083 mdev->agreed_pro_version >= 90) { 2467 mdev->tconn->agreed_pro_version >= 90) {
2084 unsigned long now = jiffies; 2468 unsigned long now = jiffies;
2085 int i; 2469 int i;
2086 mdev->ov_start_sector = sector; 2470 mdev->ov_start_sector = sector;
@@ -2094,15 +2478,12 @@ static int receive_DataRequest(struct drbd_conf *mdev, enum drbd_packets cmd, un
2094 dev_info(DEV, "Online Verify start sector: %llu\n", 2478 dev_info(DEV, "Online Verify start sector: %llu\n",
2095 (unsigned long long)sector); 2479 (unsigned long long)sector);
2096 } 2480 }
2097 e->w.cb = w_e_end_ov_req; 2481 peer_req->w.cb = w_e_end_ov_req;
2098 fault_type = DRBD_FAULT_RS_RD; 2482 fault_type = DRBD_FAULT_RS_RD;
2099 break; 2483 break;
2100 2484
2101 default: 2485 default:
2102 dev_err(DEV, "unexpected command (%s) in receive_DataRequest\n", 2486 BUG();
2103 cmdname(cmd));
2104 fault_type = DRBD_FAULT_MAX;
2105 goto out_free_e;
2106 } 2487 }
2107 2488
2108 /* Throttle, drbd_rs_begin_io and submit should become asynchronous 2489 /* Throttle, drbd_rs_begin_io and submit should become asynchronous
@@ -2137,30 +2518,31 @@ submit_for_resync:
2137 2518
2138submit: 2519submit:
2139 inc_unacked(mdev); 2520 inc_unacked(mdev);
2140 spin_lock_irq(&mdev->req_lock); 2521 spin_lock_irq(&mdev->tconn->req_lock);
2141 list_add_tail(&e->w.list, &mdev->read_ee); 2522 list_add_tail(&peer_req->w.list, &mdev->read_ee);
2142 spin_unlock_irq(&mdev->req_lock); 2523 spin_unlock_irq(&mdev->tconn->req_lock);
2143 2524
2144 if (drbd_submit_ee(mdev, e, READ, fault_type) == 0) 2525 if (drbd_submit_peer_request(mdev, peer_req, READ, fault_type) == 0)
2145 return true; 2526 return 0;
2146 2527
2147 /* don't care for the reason here */ 2528 /* don't care for the reason here */
2148 dev_err(DEV, "submit failed, triggering re-connect\n"); 2529 dev_err(DEV, "submit failed, triggering re-connect\n");
2149 spin_lock_irq(&mdev->req_lock); 2530 spin_lock_irq(&mdev->tconn->req_lock);
2150 list_del(&e->w.list); 2531 list_del(&peer_req->w.list);
2151 spin_unlock_irq(&mdev->req_lock); 2532 spin_unlock_irq(&mdev->tconn->req_lock);
2152 /* no drbd_rs_complete_io(), we are dropping the connection anyways */ 2533 /* no drbd_rs_complete_io(), we are dropping the connection anyways */
2153 2534
2154out_free_e: 2535out_free_e:
2155 put_ldev(mdev); 2536 put_ldev(mdev);
2156 drbd_free_ee(mdev, e); 2537 drbd_free_peer_req(mdev, peer_req);
2157 return false; 2538 return -EIO;
2158} 2539}
2159 2540
2160static int drbd_asb_recover_0p(struct drbd_conf *mdev) __must_hold(local) 2541static int drbd_asb_recover_0p(struct drbd_conf *mdev) __must_hold(local)
2161{ 2542{
2162 int self, peer, rv = -100; 2543 int self, peer, rv = -100;
2163 unsigned long ch_self, ch_peer; 2544 unsigned long ch_self, ch_peer;
2545 enum drbd_after_sb_p after_sb_0p;
2164 2546
2165 self = mdev->ldev->md.uuid[UI_BITMAP] & 1; 2547 self = mdev->ldev->md.uuid[UI_BITMAP] & 1;
2166 peer = mdev->p_uuid[UI_BITMAP] & 1; 2548 peer = mdev->p_uuid[UI_BITMAP] & 1;
@@ -2168,10 +2550,14 @@ static int drbd_asb_recover_0p(struct drbd_conf *mdev) __must_hold(local)
2168 ch_peer = mdev->p_uuid[UI_SIZE]; 2550 ch_peer = mdev->p_uuid[UI_SIZE];
2169 ch_self = mdev->comm_bm_set; 2551 ch_self = mdev->comm_bm_set;
2170 2552
2171 switch (mdev->net_conf->after_sb_0p) { 2553 rcu_read_lock();
2554 after_sb_0p = rcu_dereference(mdev->tconn->net_conf)->after_sb_0p;
2555 rcu_read_unlock();
2556 switch (after_sb_0p) {
2172 case ASB_CONSENSUS: 2557 case ASB_CONSENSUS:
2173 case ASB_DISCARD_SECONDARY: 2558 case ASB_DISCARD_SECONDARY:
2174 case ASB_CALL_HELPER: 2559 case ASB_CALL_HELPER:
2560 case ASB_VIOLENTLY:
2175 dev_err(DEV, "Configuration error.\n"); 2561 dev_err(DEV, "Configuration error.\n");
2176 break; 2562 break;
2177 case ASB_DISCONNECT: 2563 case ASB_DISCONNECT:
@@ -2200,14 +2586,14 @@ static int drbd_asb_recover_0p(struct drbd_conf *mdev) __must_hold(local)
2200 "Using discard-least-changes instead\n"); 2586 "Using discard-least-changes instead\n");
2201 case ASB_DISCARD_ZERO_CHG: 2587 case ASB_DISCARD_ZERO_CHG:
2202 if (ch_peer == 0 && ch_self == 0) { 2588 if (ch_peer == 0 && ch_self == 0) {
2203 rv = drbd_test_flag(mdev, DISCARD_CONCURRENT) 2589 rv = test_bit(RESOLVE_CONFLICTS, &mdev->tconn->flags)
2204 ? -1 : 1; 2590 ? -1 : 1;
2205 break; 2591 break;
2206 } else { 2592 } else {
2207 if (ch_peer == 0) { rv = 1; break; } 2593 if (ch_peer == 0) { rv = 1; break; }
2208 if (ch_self == 0) { rv = -1; break; } 2594 if (ch_self == 0) { rv = -1; break; }
2209 } 2595 }
2210 if (mdev->net_conf->after_sb_0p == ASB_DISCARD_ZERO_CHG) 2596 if (after_sb_0p == ASB_DISCARD_ZERO_CHG)
2211 break; 2597 break;
2212 case ASB_DISCARD_LEAST_CHG: 2598 case ASB_DISCARD_LEAST_CHG:
2213 if (ch_self < ch_peer) 2599 if (ch_self < ch_peer)
@@ -2216,7 +2602,7 @@ static int drbd_asb_recover_0p(struct drbd_conf *mdev) __must_hold(local)
2216 rv = 1; 2602 rv = 1;
2217 else /* ( ch_self == ch_peer ) */ 2603 else /* ( ch_self == ch_peer ) */
2218 /* Well, then use something else. */ 2604 /* Well, then use something else. */
2219 rv = drbd_test_flag(mdev, DISCARD_CONCURRENT) 2605 rv = test_bit(RESOLVE_CONFLICTS, &mdev->tconn->flags)
2220 ? -1 : 1; 2606 ? -1 : 1;
2221 break; 2607 break;
2222 case ASB_DISCARD_LOCAL: 2608 case ASB_DISCARD_LOCAL:
@@ -2232,13 +2618,18 @@ static int drbd_asb_recover_0p(struct drbd_conf *mdev) __must_hold(local)
2232static int drbd_asb_recover_1p(struct drbd_conf *mdev) __must_hold(local) 2618static int drbd_asb_recover_1p(struct drbd_conf *mdev) __must_hold(local)
2233{ 2619{
2234 int hg, rv = -100; 2620 int hg, rv = -100;
2621 enum drbd_after_sb_p after_sb_1p;
2235 2622
2236 switch (mdev->net_conf->after_sb_1p) { 2623 rcu_read_lock();
2624 after_sb_1p = rcu_dereference(mdev->tconn->net_conf)->after_sb_1p;
2625 rcu_read_unlock();
2626 switch (after_sb_1p) {
2237 case ASB_DISCARD_YOUNGER_PRI: 2627 case ASB_DISCARD_YOUNGER_PRI:
2238 case ASB_DISCARD_OLDER_PRI: 2628 case ASB_DISCARD_OLDER_PRI:
2239 case ASB_DISCARD_LEAST_CHG: 2629 case ASB_DISCARD_LEAST_CHG:
2240 case ASB_DISCARD_LOCAL: 2630 case ASB_DISCARD_LOCAL:
2241 case ASB_DISCARD_REMOTE: 2631 case ASB_DISCARD_REMOTE:
2632 case ASB_DISCARD_ZERO_CHG:
2242 dev_err(DEV, "Configuration error.\n"); 2633 dev_err(DEV, "Configuration error.\n");
2243 break; 2634 break;
2244 case ASB_DISCONNECT: 2635 case ASB_DISCONNECT:
@@ -2281,8 +2672,12 @@ static int drbd_asb_recover_1p(struct drbd_conf *mdev) __must_hold(local)
2281static int drbd_asb_recover_2p(struct drbd_conf *mdev) __must_hold(local) 2672static int drbd_asb_recover_2p(struct drbd_conf *mdev) __must_hold(local)
2282{ 2673{
2283 int hg, rv = -100; 2674 int hg, rv = -100;
2675 enum drbd_after_sb_p after_sb_2p;
2284 2676
2285 switch (mdev->net_conf->after_sb_2p) { 2677 rcu_read_lock();
2678 after_sb_2p = rcu_dereference(mdev->tconn->net_conf)->after_sb_2p;
2679 rcu_read_unlock();
2680 switch (after_sb_2p) {
2286 case ASB_DISCARD_YOUNGER_PRI: 2681 case ASB_DISCARD_YOUNGER_PRI:
2287 case ASB_DISCARD_OLDER_PRI: 2682 case ASB_DISCARD_OLDER_PRI:
2288 case ASB_DISCARD_LEAST_CHG: 2683 case ASB_DISCARD_LEAST_CHG:
@@ -2290,6 +2685,7 @@ static int drbd_asb_recover_2p(struct drbd_conf *mdev) __must_hold(local)
2290 case ASB_DISCARD_REMOTE: 2685 case ASB_DISCARD_REMOTE:
2291 case ASB_CONSENSUS: 2686 case ASB_CONSENSUS:
2292 case ASB_DISCARD_SECONDARY: 2687 case ASB_DISCARD_SECONDARY:
2688 case ASB_DISCARD_ZERO_CHG:
2293 dev_err(DEV, "Configuration error.\n"); 2689 dev_err(DEV, "Configuration error.\n");
2294 break; 2690 break;
2295 case ASB_VIOLENTLY: 2691 case ASB_VIOLENTLY:
@@ -2375,7 +2771,7 @@ static int drbd_uuid_compare(struct drbd_conf *mdev, int *rule_nr) __must_hold(l
2375 2771
2376 if (mdev->p_uuid[UI_BITMAP] == (u64)0 && mdev->ldev->md.uuid[UI_BITMAP] != (u64)0) { 2772 if (mdev->p_uuid[UI_BITMAP] == (u64)0 && mdev->ldev->md.uuid[UI_BITMAP] != (u64)0) {
2377 2773
2378 if (mdev->agreed_pro_version < 91) 2774 if (mdev->tconn->agreed_pro_version < 91)
2379 return -1091; 2775 return -1091;
2380 2776
2381 if ((mdev->ldev->md.uuid[UI_BITMAP] & ~((u64)1)) == (mdev->p_uuid[UI_HISTORY_START] & ~((u64)1)) && 2777 if ((mdev->ldev->md.uuid[UI_BITMAP] & ~((u64)1)) == (mdev->p_uuid[UI_HISTORY_START] & ~((u64)1)) &&
@@ -2398,7 +2794,7 @@ static int drbd_uuid_compare(struct drbd_conf *mdev, int *rule_nr) __must_hold(l
2398 2794
2399 if (mdev->ldev->md.uuid[UI_BITMAP] == (u64)0 && mdev->p_uuid[UI_BITMAP] != (u64)0) { 2795 if (mdev->ldev->md.uuid[UI_BITMAP] == (u64)0 && mdev->p_uuid[UI_BITMAP] != (u64)0) {
2400 2796
2401 if (mdev->agreed_pro_version < 91) 2797 if (mdev->tconn->agreed_pro_version < 91)
2402 return -1091; 2798 return -1091;
2403 2799
2404 if ((mdev->ldev->md.uuid[UI_HISTORY_START] & ~((u64)1)) == (mdev->p_uuid[UI_BITMAP] & ~((u64)1)) && 2800 if ((mdev->ldev->md.uuid[UI_HISTORY_START] & ~((u64)1)) == (mdev->p_uuid[UI_BITMAP] & ~((u64)1)) &&
@@ -2420,7 +2816,7 @@ static int drbd_uuid_compare(struct drbd_conf *mdev, int *rule_nr) __must_hold(l
2420 } 2816 }
2421 2817
2422 /* Common power [off|failure] */ 2818 /* Common power [off|failure] */
2423 rct = (drbd_test_flag(mdev, CRASHED_PRIMARY) ? 1 : 0) + 2819 rct = (test_bit(CRASHED_PRIMARY, &mdev->flags) ? 1 : 0) +
2424 (mdev->p_uuid[UI_FLAGS] & 2); 2820 (mdev->p_uuid[UI_FLAGS] & 2);
2425 /* lowest bit is set when we were primary, 2821 /* lowest bit is set when we were primary,
2426 * next bit (weight 2) is set when peer was primary */ 2822 * next bit (weight 2) is set when peer was primary */
@@ -2431,7 +2827,7 @@ static int drbd_uuid_compare(struct drbd_conf *mdev, int *rule_nr) __must_hold(l
2431 case 1: /* self_pri && !peer_pri */ return 1; 2827 case 1: /* self_pri && !peer_pri */ return 1;
2432 case 2: /* !self_pri && peer_pri */ return -1; 2828 case 2: /* !self_pri && peer_pri */ return -1;
2433 case 3: /* self_pri && peer_pri */ 2829 case 3: /* self_pri && peer_pri */
2434 dc = drbd_test_flag(mdev, DISCARD_CONCURRENT); 2830 dc = test_bit(RESOLVE_CONFLICTS, &mdev->tconn->flags);
2435 return dc ? -1 : 1; 2831 return dc ? -1 : 1;
2436 } 2832 }
2437 } 2833 }
@@ -2444,14 +2840,14 @@ static int drbd_uuid_compare(struct drbd_conf *mdev, int *rule_nr) __must_hold(l
2444 *rule_nr = 51; 2840 *rule_nr = 51;
2445 peer = mdev->p_uuid[UI_HISTORY_START] & ~((u64)1); 2841 peer = mdev->p_uuid[UI_HISTORY_START] & ~((u64)1);
2446 if (self == peer) { 2842 if (self == peer) {
2447 if (mdev->agreed_pro_version < 96 ? 2843 if (mdev->tconn->agreed_pro_version < 96 ?
2448 (mdev->ldev->md.uuid[UI_HISTORY_START] & ~((u64)1)) == 2844 (mdev->ldev->md.uuid[UI_HISTORY_START] & ~((u64)1)) ==
2449 (mdev->p_uuid[UI_HISTORY_START + 1] & ~((u64)1)) : 2845 (mdev->p_uuid[UI_HISTORY_START + 1] & ~((u64)1)) :
2450 peer + UUID_NEW_BM_OFFSET == (mdev->p_uuid[UI_BITMAP] & ~((u64)1))) { 2846 peer + UUID_NEW_BM_OFFSET == (mdev->p_uuid[UI_BITMAP] & ~((u64)1))) {
2451 /* The last P_SYNC_UUID did not get though. Undo the last start of 2847 /* The last P_SYNC_UUID did not get though. Undo the last start of
2452 resync as sync source modifications of the peer's UUIDs. */ 2848 resync as sync source modifications of the peer's UUIDs. */
2453 2849
2454 if (mdev->agreed_pro_version < 91) 2850 if (mdev->tconn->agreed_pro_version < 91)
2455 return -1091; 2851 return -1091;
2456 2852
2457 mdev->p_uuid[UI_BITMAP] = mdev->p_uuid[UI_HISTORY_START]; 2853 mdev->p_uuid[UI_BITMAP] = mdev->p_uuid[UI_HISTORY_START];
@@ -2481,14 +2877,14 @@ static int drbd_uuid_compare(struct drbd_conf *mdev, int *rule_nr) __must_hold(l
2481 *rule_nr = 71; 2877 *rule_nr = 71;
2482 self = mdev->ldev->md.uuid[UI_HISTORY_START] & ~((u64)1); 2878 self = mdev->ldev->md.uuid[UI_HISTORY_START] & ~((u64)1);
2483 if (self == peer) { 2879 if (self == peer) {
2484 if (mdev->agreed_pro_version < 96 ? 2880 if (mdev->tconn->agreed_pro_version < 96 ?
2485 (mdev->ldev->md.uuid[UI_HISTORY_START + 1] & ~((u64)1)) == 2881 (mdev->ldev->md.uuid[UI_HISTORY_START + 1] & ~((u64)1)) ==
2486 (mdev->p_uuid[UI_HISTORY_START] & ~((u64)1)) : 2882 (mdev->p_uuid[UI_HISTORY_START] & ~((u64)1)) :
2487 self + UUID_NEW_BM_OFFSET == (mdev->ldev->md.uuid[UI_BITMAP] & ~((u64)1))) { 2883 self + UUID_NEW_BM_OFFSET == (mdev->ldev->md.uuid[UI_BITMAP] & ~((u64)1))) {
2488 /* The last P_SYNC_UUID did not get though. Undo the last start of 2884 /* The last P_SYNC_UUID did not get though. Undo the last start of
2489 resync as sync source modifications of our UUIDs. */ 2885 resync as sync source modifications of our UUIDs. */
2490 2886
2491 if (mdev->agreed_pro_version < 91) 2887 if (mdev->tconn->agreed_pro_version < 91)
2492 return -1091; 2888 return -1091;
2493 2889
2494 __drbd_uuid_set(mdev, UI_BITMAP, mdev->ldev->md.uuid[UI_HISTORY_START]); 2890 __drbd_uuid_set(mdev, UI_BITMAP, mdev->ldev->md.uuid[UI_HISTORY_START]);
@@ -2536,9 +2932,10 @@ static int drbd_uuid_compare(struct drbd_conf *mdev, int *rule_nr) __must_hold(l
2536static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_role peer_role, 2932static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_role peer_role,
2537 enum drbd_disk_state peer_disk) __must_hold(local) 2933 enum drbd_disk_state peer_disk) __must_hold(local)
2538{ 2934{
2539 int hg, rule_nr;
2540 enum drbd_conns rv = C_MASK; 2935 enum drbd_conns rv = C_MASK;
2541 enum drbd_disk_state mydisk; 2936 enum drbd_disk_state mydisk;
2937 struct net_conf *nc;
2938 int hg, rule_nr, rr_conflict, tentative;
2542 2939
2543 mydisk = mdev->state.disk; 2940 mydisk = mdev->state.disk;
2544 if (mydisk == D_NEGOTIATING) 2941 if (mydisk == D_NEGOTIATING)
@@ -2578,7 +2975,10 @@ static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_rol
2578 if (abs(hg) == 100) 2975 if (abs(hg) == 100)
2579 drbd_khelper(mdev, "initial-split-brain"); 2976 drbd_khelper(mdev, "initial-split-brain");
2580 2977
2581 if (hg == 100 || (hg == -100 && mdev->net_conf->always_asbp)) { 2978 rcu_read_lock();
2979 nc = rcu_dereference(mdev->tconn->net_conf);
2980
2981 if (hg == 100 || (hg == -100 && nc->always_asbp)) {
2582 int pcount = (mdev->state.role == R_PRIMARY) 2982 int pcount = (mdev->state.role == R_PRIMARY)
2583 + (peer_role == R_PRIMARY); 2983 + (peer_role == R_PRIMARY);
2584 int forced = (hg == -100); 2984 int forced = (hg == -100);
@@ -2607,9 +3007,9 @@ static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_rol
2607 } 3007 }
2608 3008
2609 if (hg == -100) { 3009 if (hg == -100) {
2610 if (mdev->net_conf->want_lose && !(mdev->p_uuid[UI_FLAGS]&1)) 3010 if (test_bit(DISCARD_MY_DATA, &mdev->flags) && !(mdev->p_uuid[UI_FLAGS]&1))
2611 hg = -1; 3011 hg = -1;
2612 if (!mdev->net_conf->want_lose && (mdev->p_uuid[UI_FLAGS]&1)) 3012 if (!test_bit(DISCARD_MY_DATA, &mdev->flags) && (mdev->p_uuid[UI_FLAGS]&1))
2613 hg = 1; 3013 hg = 1;
2614 3014
2615 if (abs(hg) < 100) 3015 if (abs(hg) < 100)
@@ -2617,6 +3017,9 @@ static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_rol
2617 "Sync from %s node\n", 3017 "Sync from %s node\n",
2618 (hg < 0) ? "peer" : "this"); 3018 (hg < 0) ? "peer" : "this");
2619 } 3019 }
3020 rr_conflict = nc->rr_conflict;
3021 tentative = nc->tentative;
3022 rcu_read_unlock();
2620 3023
2621 if (hg == -100) { 3024 if (hg == -100) {
2622 /* FIXME this log message is not correct if we end up here 3025 /* FIXME this log message is not correct if we end up here
@@ -2635,7 +3038,7 @@ static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_rol
2635 3038
2636 if (hg < 0 && /* by intention we do not use mydisk here. */ 3039 if (hg < 0 && /* by intention we do not use mydisk here. */
2637 mdev->state.role == R_PRIMARY && mdev->state.disk >= D_CONSISTENT) { 3040 mdev->state.role == R_PRIMARY && mdev->state.disk >= D_CONSISTENT) {
2638 switch (mdev->net_conf->rr_conflict) { 3041 switch (rr_conflict) {
2639 case ASB_CALL_HELPER: 3042 case ASB_CALL_HELPER:
2640 drbd_khelper(mdev, "pri-lost"); 3043 drbd_khelper(mdev, "pri-lost");
2641 /* fall through */ 3044 /* fall through */
@@ -2648,7 +3051,7 @@ static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_rol
2648 } 3051 }
2649 } 3052 }
2650 3053
2651 if (mdev->net_conf->dry_run || drbd_test_flag(mdev, CONN_DRY_RUN)) { 3054 if (tentative || test_bit(CONN_DRY_RUN, &mdev->tconn->flags)) {
2652 if (hg == 0) 3055 if (hg == 0)
2653 dev_info(DEV, "dry-run connect: No resync, would become Connected immediately.\n"); 3056 dev_info(DEV, "dry-run connect: No resync, would become Connected immediately.\n");
2654 else 3057 else
@@ -2680,33 +3083,29 @@ static enum drbd_conns drbd_sync_handshake(struct drbd_conf *mdev, enum drbd_rol
2680 return rv; 3083 return rv;
2681} 3084}
2682 3085
2683/* returns 1 if invalid */ 3086static enum drbd_after_sb_p convert_after_sb(enum drbd_after_sb_p peer)
2684static int cmp_after_sb(enum drbd_after_sb_p peer, enum drbd_after_sb_p self)
2685{ 3087{
2686 /* ASB_DISCARD_REMOTE - ASB_DISCARD_LOCAL is valid */ 3088 /* ASB_DISCARD_REMOTE - ASB_DISCARD_LOCAL is valid */
2687 if ((peer == ASB_DISCARD_REMOTE && self == ASB_DISCARD_LOCAL) || 3089 if (peer == ASB_DISCARD_REMOTE)
2688 (self == ASB_DISCARD_REMOTE && peer == ASB_DISCARD_LOCAL)) 3090 return ASB_DISCARD_LOCAL;
2689 return 0;
2690 3091
2691 /* any other things with ASB_DISCARD_REMOTE or ASB_DISCARD_LOCAL are invalid */ 3092 /* any other things with ASB_DISCARD_REMOTE or ASB_DISCARD_LOCAL are invalid */
2692 if (peer == ASB_DISCARD_REMOTE || peer == ASB_DISCARD_LOCAL || 3093 if (peer == ASB_DISCARD_LOCAL)
2693 self == ASB_DISCARD_REMOTE || self == ASB_DISCARD_LOCAL) 3094 return ASB_DISCARD_REMOTE;
2694 return 1;
2695 3095
2696 /* everything else is valid if they are equal on both sides. */ 3096 /* everything else is valid if they are equal on both sides. */
2697 if (peer == self) 3097 return peer;
2698 return 0;
2699
2700 /* everything es is invalid. */
2701 return 1;
2702} 3098}
2703 3099
2704static int receive_protocol(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 3100static int receive_protocol(struct drbd_tconn *tconn, struct packet_info *pi)
2705{ 3101{
2706 struct p_protocol *p = &mdev->data.rbuf.protocol; 3102 struct p_protocol *p = pi->data;
2707 int p_proto, p_after_sb_0p, p_after_sb_1p, p_after_sb_2p; 3103 enum drbd_after_sb_p p_after_sb_0p, p_after_sb_1p, p_after_sb_2p;
2708 int p_want_lose, p_two_primaries, cf; 3104 int p_proto, p_discard_my_data, p_two_primaries, cf;
2709 char p_integrity_alg[SHARED_SECRET_MAX] = ""; 3105 struct net_conf *nc, *old_net_conf, *new_net_conf = NULL;
3106 char integrity_alg[SHARED_SECRET_MAX] = "";
3107 struct crypto_hash *peer_integrity_tfm = NULL;
3108 void *int_dig_in = NULL, *int_dig_vv = NULL;
2710 3109
2711 p_proto = be32_to_cpu(p->protocol); 3110 p_proto = be32_to_cpu(p->protocol);
2712 p_after_sb_0p = be32_to_cpu(p->after_sb_0p); 3111 p_after_sb_0p = be32_to_cpu(p->after_sb_0p);
@@ -2714,63 +3113,138 @@ static int receive_protocol(struct drbd_conf *mdev, enum drbd_packets cmd, unsig
2714 p_after_sb_2p = be32_to_cpu(p->after_sb_2p); 3113 p_after_sb_2p = be32_to_cpu(p->after_sb_2p);
2715 p_two_primaries = be32_to_cpu(p->two_primaries); 3114 p_two_primaries = be32_to_cpu(p->two_primaries);
2716 cf = be32_to_cpu(p->conn_flags); 3115 cf = be32_to_cpu(p->conn_flags);
2717 p_want_lose = cf & CF_WANT_LOSE; 3116 p_discard_my_data = cf & CF_DISCARD_MY_DATA;
2718
2719 drbd_clear_flag(mdev, CONN_DRY_RUN);
2720 3117
2721 if (cf & CF_DRY_RUN) 3118 if (tconn->agreed_pro_version >= 87) {
2722 drbd_set_flag(mdev, CONN_DRY_RUN); 3119 int err;
2723 3120
2724 if (p_proto != mdev->net_conf->wire_protocol) { 3121 if (pi->size > sizeof(integrity_alg))
2725 dev_err(DEV, "incompatible communication protocols\n"); 3122 return -EIO;
2726 goto disconnect; 3123 err = drbd_recv_all(tconn, integrity_alg, pi->size);
3124 if (err)
3125 return err;
3126 integrity_alg[SHARED_SECRET_MAX - 1] = 0;
2727 } 3127 }
2728 3128
2729 if (cmp_after_sb(p_after_sb_0p, mdev->net_conf->after_sb_0p)) { 3129 if (pi->cmd != P_PROTOCOL_UPDATE) {
2730 dev_err(DEV, "incompatible after-sb-0pri settings\n"); 3130 clear_bit(CONN_DRY_RUN, &tconn->flags);
2731 goto disconnect;
2732 }
2733 3131
2734 if (cmp_after_sb(p_after_sb_1p, mdev->net_conf->after_sb_1p)) { 3132 if (cf & CF_DRY_RUN)
2735 dev_err(DEV, "incompatible after-sb-1pri settings\n"); 3133 set_bit(CONN_DRY_RUN, &tconn->flags);
2736 goto disconnect;
2737 }
2738 3134
2739 if (cmp_after_sb(p_after_sb_2p, mdev->net_conf->after_sb_2p)) { 3135 rcu_read_lock();
2740 dev_err(DEV, "incompatible after-sb-2pri settings\n"); 3136 nc = rcu_dereference(tconn->net_conf);
2741 goto disconnect;
2742 }
2743 3137
2744 if (p_want_lose && mdev->net_conf->want_lose) { 3138 if (p_proto != nc->wire_protocol) {
2745 dev_err(DEV, "both sides have the 'want_lose' flag set\n"); 3139 conn_err(tconn, "incompatible %s settings\n", "protocol");
2746 goto disconnect; 3140 goto disconnect_rcu_unlock;
2747 } 3141 }
2748 3142
2749 if (p_two_primaries != mdev->net_conf->two_primaries) { 3143 if (convert_after_sb(p_after_sb_0p) != nc->after_sb_0p) {
2750 dev_err(DEV, "incompatible setting of the two-primaries options\n"); 3144 conn_err(tconn, "incompatible %s settings\n", "after-sb-0pri");
2751 goto disconnect; 3145 goto disconnect_rcu_unlock;
3146 }
3147
3148 if (convert_after_sb(p_after_sb_1p) != nc->after_sb_1p) {
3149 conn_err(tconn, "incompatible %s settings\n", "after-sb-1pri");
3150 goto disconnect_rcu_unlock;
3151 }
3152
3153 if (convert_after_sb(p_after_sb_2p) != nc->after_sb_2p) {
3154 conn_err(tconn, "incompatible %s settings\n", "after-sb-2pri");
3155 goto disconnect_rcu_unlock;
3156 }
3157
3158 if (p_discard_my_data && nc->discard_my_data) {
3159 conn_err(tconn, "incompatible %s settings\n", "discard-my-data");
3160 goto disconnect_rcu_unlock;
3161 }
3162
3163 if (p_two_primaries != nc->two_primaries) {
3164 conn_err(tconn, "incompatible %s settings\n", "allow-two-primaries");
3165 goto disconnect_rcu_unlock;
3166 }
3167
3168 if (strcmp(integrity_alg, nc->integrity_alg)) {
3169 conn_err(tconn, "incompatible %s settings\n", "data-integrity-alg");
3170 goto disconnect_rcu_unlock;
3171 }
3172
3173 rcu_read_unlock();
2752 } 3174 }
2753 3175
2754 if (mdev->agreed_pro_version >= 87) { 3176 if (integrity_alg[0]) {
2755 unsigned char *my_alg = mdev->net_conf->integrity_alg; 3177 int hash_size;
3178
3179 /*
3180 * We can only change the peer data integrity algorithm
3181 * here. Changing our own data integrity algorithm
3182 * requires that we send a P_PROTOCOL_UPDATE packet at
3183 * the same time; otherwise, the peer has no way to
3184 * tell between which packets the algorithm should
3185 * change.
3186 */
2756 3187
2757 if (drbd_recv(mdev, p_integrity_alg, data_size) != data_size) 3188 peer_integrity_tfm = crypto_alloc_hash(integrity_alg, 0, CRYPTO_ALG_ASYNC);
2758 return false; 3189 if (!peer_integrity_tfm) {
3190 conn_err(tconn, "peer data-integrity-alg %s not supported\n",
3191 integrity_alg);
3192 goto disconnect;
3193 }
2759 3194
2760 p_integrity_alg[SHARED_SECRET_MAX-1] = 0; 3195 hash_size = crypto_hash_digestsize(peer_integrity_tfm);
2761 if (strcmp(p_integrity_alg, my_alg)) { 3196 int_dig_in = kmalloc(hash_size, GFP_KERNEL);
2762 dev_err(DEV, "incompatible setting of the data-integrity-alg\n"); 3197 int_dig_vv = kmalloc(hash_size, GFP_KERNEL);
3198 if (!(int_dig_in && int_dig_vv)) {
3199 conn_err(tconn, "Allocation of buffers for data integrity checking failed\n");
2763 goto disconnect; 3200 goto disconnect;
2764 } 3201 }
2765 dev_info(DEV, "data-integrity-alg: %s\n",
2766 my_alg[0] ? my_alg : (unsigned char *)"<not-used>");
2767 } 3202 }
2768 3203
2769 return true; 3204 new_net_conf = kmalloc(sizeof(struct net_conf), GFP_KERNEL);
3205 if (!new_net_conf) {
3206 conn_err(tconn, "Allocation of new net_conf failed\n");
3207 goto disconnect;
3208 }
3209
3210 mutex_lock(&tconn->data.mutex);
3211 mutex_lock(&tconn->conf_update);
3212 old_net_conf = tconn->net_conf;
3213 *new_net_conf = *old_net_conf;
3214
3215 new_net_conf->wire_protocol = p_proto;
3216 new_net_conf->after_sb_0p = convert_after_sb(p_after_sb_0p);
3217 new_net_conf->after_sb_1p = convert_after_sb(p_after_sb_1p);
3218 new_net_conf->after_sb_2p = convert_after_sb(p_after_sb_2p);
3219 new_net_conf->two_primaries = p_two_primaries;
3220
3221 rcu_assign_pointer(tconn->net_conf, new_net_conf);
3222 mutex_unlock(&tconn->conf_update);
3223 mutex_unlock(&tconn->data.mutex);
3224
3225 crypto_free_hash(tconn->peer_integrity_tfm);
3226 kfree(tconn->int_dig_in);
3227 kfree(tconn->int_dig_vv);
3228 tconn->peer_integrity_tfm = peer_integrity_tfm;
3229 tconn->int_dig_in = int_dig_in;
3230 tconn->int_dig_vv = int_dig_vv;
3231
3232 if (strcmp(old_net_conf->integrity_alg, integrity_alg))
3233 conn_info(tconn, "peer data-integrity-alg: %s\n",
3234 integrity_alg[0] ? integrity_alg : "(none)");
2770 3235
3236 synchronize_rcu();
3237 kfree(old_net_conf);
3238 return 0;
3239
3240disconnect_rcu_unlock:
3241 rcu_read_unlock();
2771disconnect: 3242disconnect:
2772 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 3243 crypto_free_hash(peer_integrity_tfm);
2773 return false; 3244 kfree(int_dig_in);
3245 kfree(int_dig_vv);
3246 conn_request_state(tconn, NS(conn, C_DISCONNECTING), CS_HARD);
3247 return -EIO;
2774} 3248}
2775 3249
2776/* helper function 3250/* helper function
@@ -2792,24 +3266,64 @@ struct crypto_hash *drbd_crypto_alloc_digest_safe(const struct drbd_conf *mdev,
2792 alg, name, PTR_ERR(tfm)); 3266 alg, name, PTR_ERR(tfm));
2793 return tfm; 3267 return tfm;
2794 } 3268 }
2795 if (!drbd_crypto_is_hash(crypto_hash_tfm(tfm))) {
2796 crypto_free_hash(tfm);
2797 dev_err(DEV, "\"%s\" is not a digest (%s)\n", alg, name);
2798 return ERR_PTR(-EINVAL);
2799 }
2800 return tfm; 3269 return tfm;
2801} 3270}
2802 3271
2803static int receive_SyncParam(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int packet_size) 3272static int ignore_remaining_packet(struct drbd_tconn *tconn, struct packet_info *pi)
2804{ 3273{
2805 int ok = true; 3274 void *buffer = tconn->data.rbuf;
2806 struct p_rs_param_95 *p = &mdev->data.rbuf.rs_param_95; 3275 int size = pi->size;
3276
3277 while (size) {
3278 int s = min_t(int, size, DRBD_SOCKET_BUFFER_SIZE);
3279 s = drbd_recv(tconn, buffer, s);
3280 if (s <= 0) {
3281 if (s < 0)
3282 return s;
3283 break;
3284 }
3285 size -= s;
3286 }
3287 if (size)
3288 return -EIO;
3289 return 0;
3290}
3291
3292/*
3293 * config_unknown_volume - device configuration command for unknown volume
3294 *
3295 * When a device is added to an existing connection, the node on which the
3296 * device is added first will send configuration commands to its peer but the
3297 * peer will not know about the device yet. It will warn and ignore these
3298 * commands. Once the device is added on the second node, the second node will
3299 * send the same device configuration commands, but in the other direction.
3300 *
3301 * (We can also end up here if drbd is misconfigured.)
3302 */
3303static int config_unknown_volume(struct drbd_tconn *tconn, struct packet_info *pi)
3304{
3305 conn_warn(tconn, "%s packet received for volume %u, which is not configured locally\n",
3306 cmdname(pi->cmd), pi->vnr);
3307 return ignore_remaining_packet(tconn, pi);
3308}
3309
3310static int receive_SyncParam(struct drbd_tconn *tconn, struct packet_info *pi)
3311{
3312 struct drbd_conf *mdev;
3313 struct p_rs_param_95 *p;
2807 unsigned int header_size, data_size, exp_max_sz; 3314 unsigned int header_size, data_size, exp_max_sz;
2808 struct crypto_hash *verify_tfm = NULL; 3315 struct crypto_hash *verify_tfm = NULL;
2809 struct crypto_hash *csums_tfm = NULL; 3316 struct crypto_hash *csums_tfm = NULL;
2810 const int apv = mdev->agreed_pro_version; 3317 struct net_conf *old_net_conf, *new_net_conf = NULL;
2811 int *rs_plan_s = NULL; 3318 struct disk_conf *old_disk_conf = NULL, *new_disk_conf = NULL;
3319 const int apv = tconn->agreed_pro_version;
3320 struct fifo_buffer *old_plan = NULL, *new_plan = NULL;
2812 int fifo_size = 0; 3321 int fifo_size = 0;
3322 int err;
3323
3324 mdev = vnr_to_mdev(tconn, pi->vnr);
3325 if (!mdev)
3326 return config_unknown_volume(tconn, pi);
2813 3327
2814 exp_max_sz = apv <= 87 ? sizeof(struct p_rs_param) 3328 exp_max_sz = apv <= 87 ? sizeof(struct p_rs_param)
2815 : apv == 88 ? sizeof(struct p_rs_param) 3329 : apv == 88 ? sizeof(struct p_rs_param)
@@ -2817,32 +3331,49 @@ static int receive_SyncParam(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
2817 : apv <= 94 ? sizeof(struct p_rs_param_89) 3331 : apv <= 94 ? sizeof(struct p_rs_param_89)
2818 : /* apv >= 95 */ sizeof(struct p_rs_param_95); 3332 : /* apv >= 95 */ sizeof(struct p_rs_param_95);
2819 3333
2820 if (packet_size > exp_max_sz) { 3334 if (pi->size > exp_max_sz) {
2821 dev_err(DEV, "SyncParam packet too long: received %u, expected <= %u bytes\n", 3335 dev_err(DEV, "SyncParam packet too long: received %u, expected <= %u bytes\n",
2822 packet_size, exp_max_sz); 3336 pi->size, exp_max_sz);
2823 return false; 3337 return -EIO;
2824 } 3338 }
2825 3339
2826 if (apv <= 88) { 3340 if (apv <= 88) {
2827 header_size = sizeof(struct p_rs_param) - sizeof(struct p_header80); 3341 header_size = sizeof(struct p_rs_param);
2828 data_size = packet_size - header_size; 3342 data_size = pi->size - header_size;
2829 } else if (apv <= 94) { 3343 } else if (apv <= 94) {
2830 header_size = sizeof(struct p_rs_param_89) - sizeof(struct p_header80); 3344 header_size = sizeof(struct p_rs_param_89);
2831 data_size = packet_size - header_size; 3345 data_size = pi->size - header_size;
2832 D_ASSERT(data_size == 0); 3346 D_ASSERT(data_size == 0);
2833 } else { 3347 } else {
2834 header_size = sizeof(struct p_rs_param_95) - sizeof(struct p_header80); 3348 header_size = sizeof(struct p_rs_param_95);
2835 data_size = packet_size - header_size; 3349 data_size = pi->size - header_size;
2836 D_ASSERT(data_size == 0); 3350 D_ASSERT(data_size == 0);
2837 } 3351 }
2838 3352
2839 /* initialize verify_alg and csums_alg */ 3353 /* initialize verify_alg and csums_alg */
3354 p = pi->data;
2840 memset(p->verify_alg, 0, 2 * SHARED_SECRET_MAX); 3355 memset(p->verify_alg, 0, 2 * SHARED_SECRET_MAX);
2841 3356
2842 if (drbd_recv(mdev, &p->head.payload, header_size) != header_size) 3357 err = drbd_recv_all(mdev->tconn, p, header_size);
2843 return false; 3358 if (err)
3359 return err;
2844 3360
2845 mdev->sync_conf.rate = be32_to_cpu(p->rate); 3361 mutex_lock(&mdev->tconn->conf_update);
3362 old_net_conf = mdev->tconn->net_conf;
3363 if (get_ldev(mdev)) {
3364 new_disk_conf = kzalloc(sizeof(struct disk_conf), GFP_KERNEL);
3365 if (!new_disk_conf) {
3366 put_ldev(mdev);
3367 mutex_unlock(&mdev->tconn->conf_update);
3368 dev_err(DEV, "Allocation of new disk_conf failed\n");
3369 return -ENOMEM;
3370 }
3371
3372 old_disk_conf = mdev->ldev->disk_conf;
3373 *new_disk_conf = *old_disk_conf;
3374
3375 new_disk_conf->resync_rate = be32_to_cpu(p->resync_rate);
3376 }
2846 3377
2847 if (apv >= 88) { 3378 if (apv >= 88) {
2848 if (apv == 88) { 3379 if (apv == 88) {
@@ -2850,12 +3381,13 @@ static int receive_SyncParam(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
2850 dev_err(DEV, "verify-alg of wrong size, " 3381 dev_err(DEV, "verify-alg of wrong size, "
2851 "peer wants %u, accepting only up to %u byte\n", 3382 "peer wants %u, accepting only up to %u byte\n",
2852 data_size, SHARED_SECRET_MAX); 3383 data_size, SHARED_SECRET_MAX);
2853 return false; 3384 err = -EIO;
3385 goto reconnect;
2854 } 3386 }
2855 3387
2856 if (drbd_recv(mdev, p->verify_alg, data_size) != data_size) 3388 err = drbd_recv_all(mdev->tconn, p->verify_alg, data_size);
2857 return false; 3389 if (err)
2858 3390 goto reconnect;
2859 /* we expect NUL terminated string */ 3391 /* we expect NUL terminated string */
2860 /* but just in case someone tries to be evil */ 3392 /* but just in case someone tries to be evil */
2861 D_ASSERT(p->verify_alg[data_size-1] == 0); 3393 D_ASSERT(p->verify_alg[data_size-1] == 0);
@@ -2870,10 +3402,10 @@ static int receive_SyncParam(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
2870 p->csums_alg[SHARED_SECRET_MAX-1] = 0; 3402 p->csums_alg[SHARED_SECRET_MAX-1] = 0;
2871 } 3403 }
2872 3404
2873 if (strcmp(mdev->sync_conf.verify_alg, p->verify_alg)) { 3405 if (strcmp(old_net_conf->verify_alg, p->verify_alg)) {
2874 if (mdev->state.conn == C_WF_REPORT_PARAMS) { 3406 if (mdev->state.conn == C_WF_REPORT_PARAMS) {
2875 dev_err(DEV, "Different verify-alg settings. me=\"%s\" peer=\"%s\"\n", 3407 dev_err(DEV, "Different verify-alg settings. me=\"%s\" peer=\"%s\"\n",
2876 mdev->sync_conf.verify_alg, p->verify_alg); 3408 old_net_conf->verify_alg, p->verify_alg);
2877 goto disconnect; 3409 goto disconnect;
2878 } 3410 }
2879 verify_tfm = drbd_crypto_alloc_digest_safe(mdev, 3411 verify_tfm = drbd_crypto_alloc_digest_safe(mdev,
@@ -2884,10 +3416,10 @@ static int receive_SyncParam(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
2884 } 3416 }
2885 } 3417 }
2886 3418
2887 if (apv >= 89 && strcmp(mdev->sync_conf.csums_alg, p->csums_alg)) { 3419 if (apv >= 89 && strcmp(old_net_conf->csums_alg, p->csums_alg)) {
2888 if (mdev->state.conn == C_WF_REPORT_PARAMS) { 3420 if (mdev->state.conn == C_WF_REPORT_PARAMS) {
2889 dev_err(DEV, "Different csums-alg settings. me=\"%s\" peer=\"%s\"\n", 3421 dev_err(DEV, "Different csums-alg settings. me=\"%s\" peer=\"%s\"\n",
2890 mdev->sync_conf.csums_alg, p->csums_alg); 3422 old_net_conf->csums_alg, p->csums_alg);
2891 goto disconnect; 3423 goto disconnect;
2892 } 3424 }
2893 csums_tfm = drbd_crypto_alloc_digest_safe(mdev, 3425 csums_tfm = drbd_crypto_alloc_digest_safe(mdev,
@@ -2898,57 +3430,91 @@ static int receive_SyncParam(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
2898 } 3430 }
2899 } 3431 }
2900 3432
2901 if (apv > 94) { 3433 if (apv > 94 && new_disk_conf) {
2902 mdev->sync_conf.rate = be32_to_cpu(p->rate); 3434 new_disk_conf->c_plan_ahead = be32_to_cpu(p->c_plan_ahead);
2903 mdev->sync_conf.c_plan_ahead = be32_to_cpu(p->c_plan_ahead); 3435 new_disk_conf->c_delay_target = be32_to_cpu(p->c_delay_target);
2904 mdev->sync_conf.c_delay_target = be32_to_cpu(p->c_delay_target); 3436 new_disk_conf->c_fill_target = be32_to_cpu(p->c_fill_target);
2905 mdev->sync_conf.c_fill_target = be32_to_cpu(p->c_fill_target); 3437 new_disk_conf->c_max_rate = be32_to_cpu(p->c_max_rate);
2906 mdev->sync_conf.c_max_rate = be32_to_cpu(p->c_max_rate); 3438
2907 3439 fifo_size = (new_disk_conf->c_plan_ahead * 10 * SLEEP_TIME) / HZ;
2908 fifo_size = (mdev->sync_conf.c_plan_ahead * 10 * SLEEP_TIME) / HZ; 3440 if (fifo_size != mdev->rs_plan_s->size) {
2909 if (fifo_size != mdev->rs_plan_s.size && fifo_size > 0) { 3441 new_plan = fifo_alloc(fifo_size);
2910 rs_plan_s = kzalloc(sizeof(int) * fifo_size, GFP_NOIO); 3442 if (!new_plan) {
2911 if (!rs_plan_s) {
2912 dev_err(DEV, "kmalloc of fifo_buffer failed"); 3443 dev_err(DEV, "kmalloc of fifo_buffer failed");
3444 put_ldev(mdev);
2913 goto disconnect; 3445 goto disconnect;
2914 } 3446 }
2915 } 3447 }
2916 } 3448 }
2917 3449
2918 spin_lock(&mdev->peer_seq_lock); 3450 if (verify_tfm || csums_tfm) {
2919 /* lock against drbd_nl_syncer_conf() */ 3451 new_net_conf = kzalloc(sizeof(struct net_conf), GFP_KERNEL);
2920 if (verify_tfm) { 3452 if (!new_net_conf) {
2921 strcpy(mdev->sync_conf.verify_alg, p->verify_alg); 3453 dev_err(DEV, "Allocation of new net_conf failed\n");
2922 mdev->sync_conf.verify_alg_len = strlen(p->verify_alg) + 1; 3454 goto disconnect;
2923 crypto_free_hash(mdev->verify_tfm); 3455 }
2924 mdev->verify_tfm = verify_tfm; 3456
2925 dev_info(DEV, "using verify-alg: \"%s\"\n", p->verify_alg); 3457 *new_net_conf = *old_net_conf;
2926 } 3458
2927 if (csums_tfm) { 3459 if (verify_tfm) {
2928 strcpy(mdev->sync_conf.csums_alg, p->csums_alg); 3460 strcpy(new_net_conf->verify_alg, p->verify_alg);
2929 mdev->sync_conf.csums_alg_len = strlen(p->csums_alg) + 1; 3461 new_net_conf->verify_alg_len = strlen(p->verify_alg) + 1;
2930 crypto_free_hash(mdev->csums_tfm); 3462 crypto_free_hash(mdev->tconn->verify_tfm);
2931 mdev->csums_tfm = csums_tfm; 3463 mdev->tconn->verify_tfm = verify_tfm;
2932 dev_info(DEV, "using csums-alg: \"%s\"\n", p->csums_alg); 3464 dev_info(DEV, "using verify-alg: \"%s\"\n", p->verify_alg);
2933 } 3465 }
2934 if (fifo_size != mdev->rs_plan_s.size) { 3466 if (csums_tfm) {
2935 kfree(mdev->rs_plan_s.values); 3467 strcpy(new_net_conf->csums_alg, p->csums_alg);
2936 mdev->rs_plan_s.values = rs_plan_s; 3468 new_net_conf->csums_alg_len = strlen(p->csums_alg) + 1;
2937 mdev->rs_plan_s.size = fifo_size; 3469 crypto_free_hash(mdev->tconn->csums_tfm);
2938 mdev->rs_planed = 0; 3470 mdev->tconn->csums_tfm = csums_tfm;
3471 dev_info(DEV, "using csums-alg: \"%s\"\n", p->csums_alg);
3472 }
3473 rcu_assign_pointer(tconn->net_conf, new_net_conf);
2939 } 3474 }
2940 spin_unlock(&mdev->peer_seq_lock);
2941 } 3475 }
2942 3476
2943 return ok; 3477 if (new_disk_conf) {
3478 rcu_assign_pointer(mdev->ldev->disk_conf, new_disk_conf);
3479 put_ldev(mdev);
3480 }
3481
3482 if (new_plan) {
3483 old_plan = mdev->rs_plan_s;
3484 rcu_assign_pointer(mdev->rs_plan_s, new_plan);
3485 }
3486
3487 mutex_unlock(&mdev->tconn->conf_update);
3488 synchronize_rcu();
3489 if (new_net_conf)
3490 kfree(old_net_conf);
3491 kfree(old_disk_conf);
3492 kfree(old_plan);
3493
3494 return 0;
3495
3496reconnect:
3497 if (new_disk_conf) {
3498 put_ldev(mdev);
3499 kfree(new_disk_conf);
3500 }
3501 mutex_unlock(&mdev->tconn->conf_update);
3502 return -EIO;
3503
2944disconnect: 3504disconnect:
3505 kfree(new_plan);
3506 if (new_disk_conf) {
3507 put_ldev(mdev);
3508 kfree(new_disk_conf);
3509 }
3510 mutex_unlock(&mdev->tconn->conf_update);
2945 /* just for completeness: actually not needed, 3511 /* just for completeness: actually not needed,
2946 * as this is not reached if csums_tfm was ok. */ 3512 * as this is not reached if csums_tfm was ok. */
2947 crypto_free_hash(csums_tfm); 3513 crypto_free_hash(csums_tfm);
2948 /* but free the verify_tfm again, if csums_tfm did not work out */ 3514 /* but free the verify_tfm again, if csums_tfm did not work out */
2949 crypto_free_hash(verify_tfm); 3515 crypto_free_hash(verify_tfm);
2950 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 3516 conn_request_state(mdev->tconn, NS(conn, C_DISCONNECTING), CS_HARD);
2951 return false; 3517 return -EIO;
2952} 3518}
2953 3519
2954/* warn if the arguments differ by more than 12.5% */ 3520/* warn if the arguments differ by more than 12.5% */
@@ -2964,59 +3530,77 @@ static void warn_if_differ_considerably(struct drbd_conf *mdev,
2964 (unsigned long long)a, (unsigned long long)b); 3530 (unsigned long long)a, (unsigned long long)b);
2965} 3531}
2966 3532
2967static int receive_sizes(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 3533static int receive_sizes(struct drbd_tconn *tconn, struct packet_info *pi)
2968{ 3534{
2969 struct p_sizes *p = &mdev->data.rbuf.sizes; 3535 struct drbd_conf *mdev;
3536 struct p_sizes *p = pi->data;
2970 enum determine_dev_size dd = unchanged; 3537 enum determine_dev_size dd = unchanged;
2971 sector_t p_size, p_usize, my_usize; 3538 sector_t p_size, p_usize, my_usize;
2972 int ldsc = 0; /* local disk size changed */ 3539 int ldsc = 0; /* local disk size changed */
2973 enum dds_flags ddsf; 3540 enum dds_flags ddsf;
2974 3541
3542 mdev = vnr_to_mdev(tconn, pi->vnr);
3543 if (!mdev)
3544 return config_unknown_volume(tconn, pi);
3545
2975 p_size = be64_to_cpu(p->d_size); 3546 p_size = be64_to_cpu(p->d_size);
2976 p_usize = be64_to_cpu(p->u_size); 3547 p_usize = be64_to_cpu(p->u_size);
2977 3548
2978 if (p_size == 0 && mdev->state.disk == D_DISKLESS) {
2979 dev_err(DEV, "some backing storage is needed\n");
2980 drbd_force_state(mdev, NS(conn, C_DISCONNECTING));
2981 return false;
2982 }
2983
2984 /* just store the peer's disk size for now. 3549 /* just store the peer's disk size for now.
2985 * we still need to figure out whether we accept that. */ 3550 * we still need to figure out whether we accept that. */
2986 mdev->p_size = p_size; 3551 mdev->p_size = p_size;
2987 3552
2988 if (get_ldev(mdev)) { 3553 if (get_ldev(mdev)) {
3554 rcu_read_lock();
3555 my_usize = rcu_dereference(mdev->ldev->disk_conf)->disk_size;
3556 rcu_read_unlock();
3557
2989 warn_if_differ_considerably(mdev, "lower level device sizes", 3558 warn_if_differ_considerably(mdev, "lower level device sizes",
2990 p_size, drbd_get_max_capacity(mdev->ldev)); 3559 p_size, drbd_get_max_capacity(mdev->ldev));
2991 warn_if_differ_considerably(mdev, "user requested size", 3560 warn_if_differ_considerably(mdev, "user requested size",
2992 p_usize, mdev->ldev->dc.disk_size); 3561 p_usize, my_usize);
2993 3562
2994 /* if this is the first connect, or an otherwise expected 3563 /* if this is the first connect, or an otherwise expected
2995 * param exchange, choose the minimum */ 3564 * param exchange, choose the minimum */
2996 if (mdev->state.conn == C_WF_REPORT_PARAMS) 3565 if (mdev->state.conn == C_WF_REPORT_PARAMS)
2997 p_usize = min_not_zero((sector_t)mdev->ldev->dc.disk_size, 3566 p_usize = min_not_zero(my_usize, p_usize);
2998 p_usize);
2999
3000 my_usize = mdev->ldev->dc.disk_size;
3001
3002 if (mdev->ldev->dc.disk_size != p_usize) {
3003 mdev->ldev->dc.disk_size = p_usize;
3004 dev_info(DEV, "Peer sets u_size to %lu sectors\n",
3005 (unsigned long)mdev->ldev->dc.disk_size);
3006 }
3007 3567
3008 /* Never shrink a device with usable data during connect. 3568 /* Never shrink a device with usable data during connect.
3009 But allow online shrinking if we are connected. */ 3569 But allow online shrinking if we are connected. */
3010 if (drbd_new_dev_size(mdev, mdev->ldev, 0) < 3570 if (drbd_new_dev_size(mdev, mdev->ldev, p_usize, 0) <
3011 drbd_get_capacity(mdev->this_bdev) && 3571 drbd_get_capacity(mdev->this_bdev) &&
3012 mdev->state.disk >= D_OUTDATED && 3572 mdev->state.disk >= D_OUTDATED &&
3013 mdev->state.conn < C_CONNECTED) { 3573 mdev->state.conn < C_CONNECTED) {
3014 dev_err(DEV, "The peer's disk size is too small!\n"); 3574 dev_err(DEV, "The peer's disk size is too small!\n");
3015 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 3575 conn_request_state(mdev->tconn, NS(conn, C_DISCONNECTING), CS_HARD);
3016 mdev->ldev->dc.disk_size = my_usize;
3017 put_ldev(mdev); 3576 put_ldev(mdev);
3018 return false; 3577 return -EIO;
3578 }
3579
3580 if (my_usize != p_usize) {
3581 struct disk_conf *old_disk_conf, *new_disk_conf = NULL;
3582
3583 new_disk_conf = kzalloc(sizeof(struct disk_conf), GFP_KERNEL);
3584 if (!new_disk_conf) {
3585 dev_err(DEV, "Allocation of new disk_conf failed\n");
3586 put_ldev(mdev);
3587 return -ENOMEM;
3588 }
3589
3590 mutex_lock(&mdev->tconn->conf_update);
3591 old_disk_conf = mdev->ldev->disk_conf;
3592 *new_disk_conf = *old_disk_conf;
3593 new_disk_conf->disk_size = p_usize;
3594
3595 rcu_assign_pointer(mdev->ldev->disk_conf, new_disk_conf);
3596 mutex_unlock(&mdev->tconn->conf_update);
3597 synchronize_rcu();
3598 kfree(old_disk_conf);
3599
3600 dev_info(DEV, "Peer sets u_size to %lu sectors\n",
3601 (unsigned long)my_usize);
3019 } 3602 }
3603
3020 put_ldev(mdev); 3604 put_ldev(mdev);
3021 } 3605 }
3022 3606
@@ -3025,7 +3609,7 @@ static int receive_sizes(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3025 dd = drbd_determine_dev_size(mdev, ddsf); 3609 dd = drbd_determine_dev_size(mdev, ddsf);
3026 put_ldev(mdev); 3610 put_ldev(mdev);
3027 if (dd == dev_size_error) 3611 if (dd == dev_size_error)
3028 return false; 3612 return -EIO;
3029 drbd_md_sync(mdev); 3613 drbd_md_sync(mdev);
3030 } else { 3614 } else {
3031 /* I am diskless, need to accept the peer's size. */ 3615 /* I am diskless, need to accept the peer's size. */
@@ -3051,7 +3635,7 @@ static int receive_sizes(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3051 * needs to know my new size... */ 3635 * needs to know my new size... */
3052 drbd_send_sizes(mdev, 0, ddsf); 3636 drbd_send_sizes(mdev, 0, ddsf);
3053 } 3637 }
3054 if (drbd_test_and_clear_flag(mdev, RESIZE_PENDING) || 3638 if (test_and_clear_bit(RESIZE_PENDING, &mdev->flags) ||
3055 (dd == grew && mdev->state.conn == C_CONNECTED)) { 3639 (dd == grew && mdev->state.conn == C_CONNECTED)) {
3056 if (mdev->state.pdsk >= D_INCONSISTENT && 3640 if (mdev->state.pdsk >= D_INCONSISTENT &&
3057 mdev->state.disk >= D_INCONSISTENT) { 3641 mdev->state.disk >= D_INCONSISTENT) {
@@ -3060,19 +3644,24 @@ static int receive_sizes(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3060 else 3644 else
3061 resync_after_online_grow(mdev); 3645 resync_after_online_grow(mdev);
3062 } else 3646 } else
3063 drbd_set_flag(mdev, RESYNC_AFTER_NEG); 3647 set_bit(RESYNC_AFTER_NEG, &mdev->flags);
3064 } 3648 }
3065 } 3649 }
3066 3650
3067 return true; 3651 return 0;
3068} 3652}
3069 3653
3070static int receive_uuids(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 3654static int receive_uuids(struct drbd_tconn *tconn, struct packet_info *pi)
3071{ 3655{
3072 struct p_uuids *p = &mdev->data.rbuf.uuids; 3656 struct drbd_conf *mdev;
3657 struct p_uuids *p = pi->data;
3073 u64 *p_uuid; 3658 u64 *p_uuid;
3074 int i, updated_uuids = 0; 3659 int i, updated_uuids = 0;
3075 3660
3661 mdev = vnr_to_mdev(tconn, pi->vnr);
3662 if (!mdev)
3663 return config_unknown_volume(tconn, pi);
3664
3076 p_uuid = kmalloc(sizeof(u64)*UI_EXTENDED_SIZE, GFP_NOIO); 3665 p_uuid = kmalloc(sizeof(u64)*UI_EXTENDED_SIZE, GFP_NOIO);
3077 3666
3078 for (i = UI_CURRENT; i < UI_EXTENDED_SIZE; i++) 3667 for (i = UI_CURRENT; i < UI_EXTENDED_SIZE; i++)
@@ -3087,14 +3676,14 @@ static int receive_uuids(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3087 (mdev->ed_uuid & ~((u64)1)) != (p_uuid[UI_CURRENT] & ~((u64)1))) { 3676 (mdev->ed_uuid & ~((u64)1)) != (p_uuid[UI_CURRENT] & ~((u64)1))) {
3088 dev_err(DEV, "Can only connect to data with current UUID=%016llX\n", 3677 dev_err(DEV, "Can only connect to data with current UUID=%016llX\n",
3089 (unsigned long long)mdev->ed_uuid); 3678 (unsigned long long)mdev->ed_uuid);
3090 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 3679 conn_request_state(mdev->tconn, NS(conn, C_DISCONNECTING), CS_HARD);
3091 return false; 3680 return -EIO;
3092 } 3681 }
3093 3682
3094 if (get_ldev(mdev)) { 3683 if (get_ldev(mdev)) {
3095 int skip_initial_sync = 3684 int skip_initial_sync =
3096 mdev->state.conn == C_CONNECTED && 3685 mdev->state.conn == C_CONNECTED &&
3097 mdev->agreed_pro_version >= 90 && 3686 mdev->tconn->agreed_pro_version >= 90 &&
3098 mdev->ldev->md.uuid[UI_CURRENT] == UUID_JUST_CREATED && 3687 mdev->ldev->md.uuid[UI_CURRENT] == UUID_JUST_CREATED &&
3099 (p_uuid[UI_FLAGS] & 8); 3688 (p_uuid[UI_FLAGS] & 8);
3100 if (skip_initial_sync) { 3689 if (skip_initial_sync) {
@@ -3121,14 +3710,15 @@ static int receive_uuids(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3121 ongoing cluster wide state change is finished. That is important if 3710 ongoing cluster wide state change is finished. That is important if
3122 we are primary and are detaching from our disk. We need to see the 3711 we are primary and are detaching from our disk. We need to see the
3123 new disk state... */ 3712 new disk state... */
3124 wait_event(mdev->misc_wait, !drbd_test_flag(mdev, CLUSTER_ST_CHANGE)); 3713 mutex_lock(mdev->state_mutex);
3714 mutex_unlock(mdev->state_mutex);
3125 if (mdev->state.conn >= C_CONNECTED && mdev->state.disk < D_INCONSISTENT) 3715 if (mdev->state.conn >= C_CONNECTED && mdev->state.disk < D_INCONSISTENT)
3126 updated_uuids |= drbd_set_ed_uuid(mdev, p_uuid[UI_CURRENT]); 3716 updated_uuids |= drbd_set_ed_uuid(mdev, p_uuid[UI_CURRENT]);
3127 3717
3128 if (updated_uuids) 3718 if (updated_uuids)
3129 drbd_print_uuids(mdev, "receiver updated UUIDs to"); 3719 drbd_print_uuids(mdev, "receiver updated UUIDs to");
3130 3720
3131 return true; 3721 return 0;
3132} 3722}
3133 3723
3134/** 3724/**
@@ -3140,6 +3730,7 @@ static union drbd_state convert_state(union drbd_state ps)
3140 union drbd_state ms; 3730 union drbd_state ms;
3141 3731
3142 static enum drbd_conns c_tab[] = { 3732 static enum drbd_conns c_tab[] = {
3733 [C_WF_REPORT_PARAMS] = C_WF_REPORT_PARAMS,
3143 [C_CONNECTED] = C_CONNECTED, 3734 [C_CONNECTED] = C_CONNECTED,
3144 3735
3145 [C_STARTING_SYNC_S] = C_STARTING_SYNC_T, 3736 [C_STARTING_SYNC_S] = C_STARTING_SYNC_T,
@@ -3161,40 +3752,74 @@ static union drbd_state convert_state(union drbd_state ps)
3161 return ms; 3752 return ms;
3162} 3753}
3163 3754
3164static int receive_req_state(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 3755static int receive_req_state(struct drbd_tconn *tconn, struct packet_info *pi)
3165{ 3756{
3166 struct p_req_state *p = &mdev->data.rbuf.req_state; 3757 struct drbd_conf *mdev;
3758 struct p_req_state *p = pi->data;
3167 union drbd_state mask, val; 3759 union drbd_state mask, val;
3168 enum drbd_state_rv rv; 3760 enum drbd_state_rv rv;
3169 3761
3762 mdev = vnr_to_mdev(tconn, pi->vnr);
3763 if (!mdev)
3764 return -EIO;
3765
3170 mask.i = be32_to_cpu(p->mask); 3766 mask.i = be32_to_cpu(p->mask);
3171 val.i = be32_to_cpu(p->val); 3767 val.i = be32_to_cpu(p->val);
3172 3768
3173 if (drbd_test_flag(mdev, DISCARD_CONCURRENT) && 3769 if (test_bit(RESOLVE_CONFLICTS, &mdev->tconn->flags) &&
3174 drbd_test_flag(mdev, CLUSTER_ST_CHANGE)) { 3770 mutex_is_locked(mdev->state_mutex)) {
3175 drbd_send_sr_reply(mdev, SS_CONCURRENT_ST_CHG); 3771 drbd_send_sr_reply(mdev, SS_CONCURRENT_ST_CHG);
3176 return true; 3772 return 0;
3177 } 3773 }
3178 3774
3179 mask = convert_state(mask); 3775 mask = convert_state(mask);
3180 val = convert_state(val); 3776 val = convert_state(val);
3181 3777
3182 rv = drbd_change_state(mdev, CS_VERBOSE, mask, val); 3778 rv = drbd_change_state(mdev, CS_VERBOSE, mask, val);
3183
3184 drbd_send_sr_reply(mdev, rv); 3779 drbd_send_sr_reply(mdev, rv);
3780
3185 drbd_md_sync(mdev); 3781 drbd_md_sync(mdev);
3186 3782
3187 return true; 3783 return 0;
3188} 3784}
3189 3785
3190static int receive_state(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 3786static int receive_req_conn_state(struct drbd_tconn *tconn, struct packet_info *pi)
3191{ 3787{
3192 struct p_state *p = &mdev->data.rbuf.state; 3788 struct p_req_state *p = pi->data;
3789 union drbd_state mask, val;
3790 enum drbd_state_rv rv;
3791
3792 mask.i = be32_to_cpu(p->mask);
3793 val.i = be32_to_cpu(p->val);
3794
3795 if (test_bit(RESOLVE_CONFLICTS, &tconn->flags) &&
3796 mutex_is_locked(&tconn->cstate_mutex)) {
3797 conn_send_sr_reply(tconn, SS_CONCURRENT_ST_CHG);
3798 return 0;
3799 }
3800
3801 mask = convert_state(mask);
3802 val = convert_state(val);
3803
3804 rv = conn_request_state(tconn, mask, val, CS_VERBOSE | CS_LOCAL_ONLY | CS_IGN_OUTD_FAIL);
3805 conn_send_sr_reply(tconn, rv);
3806
3807 return 0;
3808}
3809
3810static int receive_state(struct drbd_tconn *tconn, struct packet_info *pi)
3811{
3812 struct drbd_conf *mdev;
3813 struct p_state *p = pi->data;
3193 union drbd_state os, ns, peer_state; 3814 union drbd_state os, ns, peer_state;
3194 enum drbd_disk_state real_peer_disk; 3815 enum drbd_disk_state real_peer_disk;
3195 enum chg_state_flags cs_flags; 3816 enum chg_state_flags cs_flags;
3196 int rv; 3817 int rv;
3197 3818
3819 mdev = vnr_to_mdev(tconn, pi->vnr);
3820 if (!mdev)
3821 return config_unknown_volume(tconn, pi);
3822
3198 peer_state.i = be32_to_cpu(p->state); 3823 peer_state.i = be32_to_cpu(p->state);
3199 3824
3200 real_peer_disk = peer_state.disk; 3825 real_peer_disk = peer_state.disk;
@@ -3203,16 +3828,16 @@ static int receive_state(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3203 dev_info(DEV, "real peer disk state = %s\n", drbd_disk_str(real_peer_disk)); 3828 dev_info(DEV, "real peer disk state = %s\n", drbd_disk_str(real_peer_disk));
3204 } 3829 }
3205 3830
3206 spin_lock_irq(&mdev->req_lock); 3831 spin_lock_irq(&mdev->tconn->req_lock);
3207 retry: 3832 retry:
3208 os = ns = mdev->state; 3833 os = ns = drbd_read_state(mdev);
3209 spin_unlock_irq(&mdev->req_lock); 3834 spin_unlock_irq(&mdev->tconn->req_lock);
3210 3835
3211 /* If some other part of the code (asender thread, timeout) 3836 /* If some other part of the code (asender thread, timeout)
3212 * already decided to close the connection again, 3837 * already decided to close the connection again,
3213 * we must not "re-establish" it here. */ 3838 * we must not "re-establish" it here. */
3214 if (os.conn <= C_TEAR_DOWN) 3839 if (os.conn <= C_TEAR_DOWN)
3215 return false; 3840 return -ECONNRESET;
3216 3841
3217 /* If this is the "end of sync" confirmation, usually the peer disk 3842 /* If this is the "end of sync" confirmation, usually the peer disk
3218 * transitions from D_INCONSISTENT to D_UP_TO_DATE. For empty (0 bits 3843 * transitions from D_INCONSISTENT to D_UP_TO_DATE. For empty (0 bits
@@ -3240,16 +3865,16 @@ static int receive_state(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3240 peer_state.conn == C_CONNECTED) { 3865 peer_state.conn == C_CONNECTED) {
3241 if (drbd_bm_total_weight(mdev) <= mdev->rs_failed) 3866 if (drbd_bm_total_weight(mdev) <= mdev->rs_failed)
3242 drbd_resync_finished(mdev); 3867 drbd_resync_finished(mdev);
3243 return true; 3868 return 0;
3244 } 3869 }
3245 } 3870 }
3246 3871
3247 /* explicit verify finished notification, stop sector reached. */ 3872 /* explicit verify finished notification, stop sector reached. */
3248 if (os.conn == C_VERIFY_T && os.disk == D_UP_TO_DATE && 3873 if (os.conn == C_VERIFY_T && os.disk == D_UP_TO_DATE &&
3249 peer_state.conn == C_CONNECTED && real_peer_disk == D_UP_TO_DATE) { 3874 peer_state.conn == C_CONNECTED && real_peer_disk == D_UP_TO_DATE) {
3250 ov_oos_print(mdev); 3875 ov_out_of_sync_print(mdev);
3251 drbd_resync_finished(mdev); 3876 drbd_resync_finished(mdev);
3252 return true; 3877 return 0;
3253 } 3878 }
3254 3879
3255 /* peer says his disk is inconsistent, while we think it is uptodate, 3880 /* peer says his disk is inconsistent, while we think it is uptodate,
@@ -3280,7 +3905,7 @@ static int receive_state(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3280 os.disk == D_NEGOTIATING)); 3905 os.disk == D_NEGOTIATING));
3281 /* if we have both been inconsistent, and the peer has been 3906 /* if we have both been inconsistent, and the peer has been
3282 * forced to be UpToDate with --overwrite-data */ 3907 * forced to be UpToDate with --overwrite-data */
3283 cr |= drbd_test_flag(mdev, CONSIDER_RESYNC); 3908 cr |= test_bit(CONSIDER_RESYNC, &mdev->flags);
3284 /* if we had been plain connected, and the admin requested to 3909 /* if we had been plain connected, and the admin requested to
3285 * start a sync by "invalidate" or "invalidate-remote" */ 3910 * start a sync by "invalidate" or "invalidate-remote" */
3286 cr |= (os.conn == C_CONNECTED && 3911 cr |= (os.conn == C_CONNECTED &&
@@ -3300,44 +3925,44 @@ static int receive_state(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3300 peer_state.disk = D_DISKLESS; 3925 peer_state.disk = D_DISKLESS;
3301 real_peer_disk = D_DISKLESS; 3926 real_peer_disk = D_DISKLESS;
3302 } else { 3927 } else {
3303 if (drbd_test_and_clear_flag(mdev, CONN_DRY_RUN)) 3928 if (test_and_clear_bit(CONN_DRY_RUN, &mdev->tconn->flags))
3304 return false; 3929 return -EIO;
3305 D_ASSERT(os.conn == C_WF_REPORT_PARAMS); 3930 D_ASSERT(os.conn == C_WF_REPORT_PARAMS);
3306 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 3931 conn_request_state(mdev->tconn, NS(conn, C_DISCONNECTING), CS_HARD);
3307 return false; 3932 return -EIO;
3308 } 3933 }
3309 } 3934 }
3310 } 3935 }
3311 3936
3312 spin_lock_irq(&mdev->req_lock); 3937 spin_lock_irq(&mdev->tconn->req_lock);
3313 if (mdev->state.i != os.i) 3938 if (os.i != drbd_read_state(mdev).i)
3314 goto retry; 3939 goto retry;
3315 drbd_clear_flag(mdev, CONSIDER_RESYNC); 3940 clear_bit(CONSIDER_RESYNC, &mdev->flags);
3316 ns.peer = peer_state.role; 3941 ns.peer = peer_state.role;
3317 ns.pdsk = real_peer_disk; 3942 ns.pdsk = real_peer_disk;
3318 ns.peer_isp = (peer_state.aftr_isp | peer_state.user_isp); 3943 ns.peer_isp = (peer_state.aftr_isp | peer_state.user_isp);
3319 if ((ns.conn == C_CONNECTED || ns.conn == C_WF_BITMAP_S) && ns.disk == D_NEGOTIATING) 3944 if ((ns.conn == C_CONNECTED || ns.conn == C_WF_BITMAP_S) && ns.disk == D_NEGOTIATING)
3320 ns.disk = mdev->new_state_tmp.disk; 3945 ns.disk = mdev->new_state_tmp.disk;
3321 cs_flags = CS_VERBOSE + (os.conn < C_CONNECTED && ns.conn >= C_CONNECTED ? 0 : CS_HARD); 3946 cs_flags = CS_VERBOSE + (os.conn < C_CONNECTED && ns.conn >= C_CONNECTED ? 0 : CS_HARD);
3322 if (ns.pdsk == D_CONSISTENT && is_susp(ns) && ns.conn == C_CONNECTED && os.conn < C_CONNECTED && 3947 if (ns.pdsk == D_CONSISTENT && drbd_suspended(mdev) && ns.conn == C_CONNECTED && os.conn < C_CONNECTED &&
3323 drbd_test_flag(mdev, NEW_CUR_UUID)) { 3948 test_bit(NEW_CUR_UUID, &mdev->flags)) {
3324 /* Do not allow tl_restart(resend) for a rebooted peer. We can only allow this 3949 /* Do not allow tl_restart(RESEND) for a rebooted peer. We can only allow this
3325 for temporal network outages! */ 3950 for temporal network outages! */
3326 spin_unlock_irq(&mdev->req_lock); 3951 spin_unlock_irq(&mdev->tconn->req_lock);
3327 dev_err(DEV, "Aborting Connect, can not thaw IO with an only Consistent peer\n"); 3952 dev_err(DEV, "Aborting Connect, can not thaw IO with an only Consistent peer\n");
3328 tl_clear(mdev); 3953 tl_clear(mdev->tconn);
3329 drbd_uuid_new_current(mdev); 3954 drbd_uuid_new_current(mdev);
3330 drbd_clear_flag(mdev, NEW_CUR_UUID); 3955 clear_bit(NEW_CUR_UUID, &mdev->flags);
3331 drbd_force_state(mdev, NS2(conn, C_PROTOCOL_ERROR, susp, 0)); 3956 conn_request_state(mdev->tconn, NS2(conn, C_PROTOCOL_ERROR, susp, 0), CS_HARD);
3332 return false; 3957 return -EIO;
3333 } 3958 }
3334 rv = _drbd_set_state(mdev, ns, cs_flags, NULL); 3959 rv = _drbd_set_state(mdev, ns, cs_flags, NULL);
3335 ns = mdev->state; 3960 ns = drbd_read_state(mdev);
3336 spin_unlock_irq(&mdev->req_lock); 3961 spin_unlock_irq(&mdev->tconn->req_lock);
3337 3962
3338 if (rv < SS_SUCCESS) { 3963 if (rv < SS_SUCCESS) {
3339 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 3964 conn_request_state(mdev->tconn, NS(conn, C_DISCONNECTING), CS_HARD);
3340 return false; 3965 return -EIO;
3341 } 3966 }
3342 3967
3343 if (os.conn > C_WF_REPORT_PARAMS) { 3968 if (os.conn > C_WF_REPORT_PARAMS) {
@@ -3351,16 +3976,21 @@ static int receive_state(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned
3351 } 3976 }
3352 } 3977 }
3353 3978
3354 mdev->net_conf->want_lose = 0; 3979 clear_bit(DISCARD_MY_DATA, &mdev->flags);
3355 3980
3356 drbd_md_sync(mdev); /* update connected indicator, la_size, ... */ 3981 drbd_md_sync(mdev); /* update connected indicator, la_size, ... */
3357 3982
3358 return true; 3983 return 0;
3359} 3984}
3360 3985
3361static int receive_sync_uuid(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 3986static int receive_sync_uuid(struct drbd_tconn *tconn, struct packet_info *pi)
3362{ 3987{
3363 struct p_rs_uuid *p = &mdev->data.rbuf.rs_uuid; 3988 struct drbd_conf *mdev;
3989 struct p_rs_uuid *p = pi->data;
3990
3991 mdev = vnr_to_mdev(tconn, pi->vnr);
3992 if (!mdev)
3993 return -EIO;
3364 3994
3365 wait_event(mdev->misc_wait, 3995 wait_event(mdev->misc_wait,
3366 mdev->state.conn == C_WF_SYNC_UUID || 3996 mdev->state.conn == C_WF_SYNC_UUID ||
@@ -3383,7 +4013,7 @@ static int receive_sync_uuid(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
3383 } else 4013 } else
3384 dev_err(DEV, "Ignoring SyncUUID packet!\n"); 4014 dev_err(DEV, "Ignoring SyncUUID packet!\n");
3385 4015
3386 return true; 4016 return 0;
3387} 4017}
3388 4018
3389/** 4019/**
@@ -3393,27 +4023,27 @@ static int receive_sync_uuid(struct drbd_conf *mdev, enum drbd_packets cmd, unsi
3393 * code upon failure. 4023 * code upon failure.
3394 */ 4024 */
3395static int 4025static int
3396receive_bitmap_plain(struct drbd_conf *mdev, unsigned int data_size, 4026receive_bitmap_plain(struct drbd_conf *mdev, unsigned int size,
3397 unsigned long *buffer, struct bm_xfer_ctx *c) 4027 unsigned long *p, struct bm_xfer_ctx *c)
3398{ 4028{
3399 unsigned num_words = min_t(size_t, BM_PACKET_WORDS, c->bm_words - c->word_offset); 4029 unsigned int data_size = DRBD_SOCKET_BUFFER_SIZE -
3400 unsigned want = num_words * sizeof(long); 4030 drbd_header_size(mdev->tconn);
4031 unsigned int num_words = min_t(size_t, data_size / sizeof(*p),
4032 c->bm_words - c->word_offset);
4033 unsigned int want = num_words * sizeof(*p);
3401 int err; 4034 int err;
3402 4035
3403 if (want != data_size) { 4036 if (want != size) {
3404 dev_err(DEV, "%s:want (%u) != data_size (%u)\n", __func__, want, data_size); 4037 dev_err(DEV, "%s:want (%u) != size (%u)\n", __func__, want, size);
3405 return -EIO; 4038 return -EIO;
3406 } 4039 }
3407 if (want == 0) 4040 if (want == 0)
3408 return 0; 4041 return 0;
3409 err = drbd_recv(mdev, buffer, want); 4042 err = drbd_recv_all(mdev->tconn, p, want);
3410 if (err != want) { 4043 if (err)
3411 if (err >= 0)
3412 err = -EIO;
3413 return err; 4044 return err;
3414 }
3415 4045
3416 drbd_bm_merge_lel(mdev, c->word_offset, num_words, buffer); 4046 drbd_bm_merge_lel(mdev, c->word_offset, num_words, p);
3417 4047
3418 c->word_offset += num_words; 4048 c->word_offset += num_words;
3419 c->bit_offset = c->word_offset * BITS_PER_LONG; 4049 c->bit_offset = c->word_offset * BITS_PER_LONG;
@@ -3423,6 +4053,21 @@ receive_bitmap_plain(struct drbd_conf *mdev, unsigned int data_size,
3423 return 1; 4053 return 1;
3424} 4054}
3425 4055
4056static enum drbd_bitmap_code dcbp_get_code(struct p_compressed_bm *p)
4057{
4058 return (enum drbd_bitmap_code)(p->encoding & 0x0f);
4059}
4060
4061static int dcbp_get_start(struct p_compressed_bm *p)
4062{
4063 return (p->encoding & 0x80) != 0;
4064}
4065
4066static int dcbp_get_pad_bits(struct p_compressed_bm *p)
4067{
4068 return (p->encoding >> 4) & 0x7;
4069}
4070
3426/** 4071/**
3427 * recv_bm_rle_bits 4072 * recv_bm_rle_bits
3428 * 4073 *
@@ -3432,7 +4077,8 @@ receive_bitmap_plain(struct drbd_conf *mdev, unsigned int data_size,
3432static int 4077static int
3433recv_bm_rle_bits(struct drbd_conf *mdev, 4078recv_bm_rle_bits(struct drbd_conf *mdev,
3434 struct p_compressed_bm *p, 4079 struct p_compressed_bm *p,
3435 struct bm_xfer_ctx *c) 4080 struct bm_xfer_ctx *c,
4081 unsigned int len)
3436{ 4082{
3437 struct bitstream bs; 4083 struct bitstream bs;
3438 u64 look_ahead; 4084 u64 look_ahead;
@@ -3440,12 +4086,11 @@ recv_bm_rle_bits(struct drbd_conf *mdev,
3440 u64 tmp; 4086 u64 tmp;
3441 unsigned long s = c->bit_offset; 4087 unsigned long s = c->bit_offset;
3442 unsigned long e; 4088 unsigned long e;
3443 int len = be16_to_cpu(p->head.length) - (sizeof(*p) - sizeof(p->head)); 4089 int toggle = dcbp_get_start(p);
3444 int toggle = DCBP_get_start(p);
3445 int have; 4090 int have;
3446 int bits; 4091 int bits;
3447 4092
3448 bitstream_init(&bs, p->code, len, DCBP_get_pad_bits(p)); 4093 bitstream_init(&bs, p->code, len, dcbp_get_pad_bits(p));
3449 4094
3450 bits = bitstream_get_bits(&bs, &look_ahead, 64); 4095 bits = bitstream_get_bits(&bs, &look_ahead, 64);
3451 if (bits < 0) 4096 if (bits < 0)
@@ -3497,17 +4142,18 @@ recv_bm_rle_bits(struct drbd_conf *mdev,
3497static int 4142static int
3498decode_bitmap_c(struct drbd_conf *mdev, 4143decode_bitmap_c(struct drbd_conf *mdev,
3499 struct p_compressed_bm *p, 4144 struct p_compressed_bm *p,
3500 struct bm_xfer_ctx *c) 4145 struct bm_xfer_ctx *c,
4146 unsigned int len)
3501{ 4147{
3502 if (DCBP_get_code(p) == RLE_VLI_Bits) 4148 if (dcbp_get_code(p) == RLE_VLI_Bits)
3503 return recv_bm_rle_bits(mdev, p, c); 4149 return recv_bm_rle_bits(mdev, p, c, len - sizeof(*p));
3504 4150
3505 /* other variants had been implemented for evaluation, 4151 /* other variants had been implemented for evaluation,
3506 * but have been dropped as this one turned out to be "best" 4152 * but have been dropped as this one turned out to be "best"
3507 * during all our tests. */ 4153 * during all our tests. */
3508 4154
3509 dev_err(DEV, "receive_bitmap_c: unknown encoding %u\n", p->encoding); 4155 dev_err(DEV, "receive_bitmap_c: unknown encoding %u\n", p->encoding);
3510 drbd_force_state(mdev, NS(conn, C_PROTOCOL_ERROR)); 4156 conn_request_state(mdev->tconn, NS(conn, C_PROTOCOL_ERROR), CS_HARD);
3511 return -EIO; 4157 return -EIO;
3512} 4158}
3513 4159
@@ -3515,11 +4161,13 @@ void INFO_bm_xfer_stats(struct drbd_conf *mdev,
3515 const char *direction, struct bm_xfer_ctx *c) 4161 const char *direction, struct bm_xfer_ctx *c)
3516{ 4162{
3517 /* what would it take to transfer it "plaintext" */ 4163 /* what would it take to transfer it "plaintext" */
3518 unsigned plain = sizeof(struct p_header80) * 4164 unsigned int header_size = drbd_header_size(mdev->tconn);
3519 ((c->bm_words+BM_PACKET_WORDS-1)/BM_PACKET_WORDS+1) 4165 unsigned int data_size = DRBD_SOCKET_BUFFER_SIZE - header_size;
3520 + c->bm_words * sizeof(long); 4166 unsigned int plain =
3521 unsigned total = c->bytes[0] + c->bytes[1]; 4167 header_size * (DIV_ROUND_UP(c->bm_words, data_size) + 1) +
3522 unsigned r; 4168 c->bm_words * sizeof(unsigned long);
4169 unsigned int total = c->bytes[0] + c->bytes[1];
4170 unsigned int r;
3523 4171
3524 /* total can not be zero. but just in case: */ 4172 /* total can not be zero. but just in case: */
3525 if (total == 0) 4173 if (total == 0)
@@ -3553,67 +4201,63 @@ void INFO_bm_xfer_stats(struct drbd_conf *mdev,
3553 in order to be agnostic to the 32 vs 64 bits issue. 4201 in order to be agnostic to the 32 vs 64 bits issue.
3554 4202
3555 returns 0 on failure, 1 if we successfully received it. */ 4203 returns 0 on failure, 1 if we successfully received it. */
3556static int receive_bitmap(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 4204static int receive_bitmap(struct drbd_tconn *tconn, struct packet_info *pi)
3557{ 4205{
4206 struct drbd_conf *mdev;
3558 struct bm_xfer_ctx c; 4207 struct bm_xfer_ctx c;
3559 void *buffer;
3560 int err; 4208 int err;
3561 int ok = false; 4209
3562 struct p_header80 *h = &mdev->data.rbuf.header.h80; 4210 mdev = vnr_to_mdev(tconn, pi->vnr);
4211 if (!mdev)
4212 return -EIO;
3563 4213
3564 drbd_bm_lock(mdev, "receive bitmap", BM_LOCKED_SET_ALLOWED); 4214 drbd_bm_lock(mdev, "receive bitmap", BM_LOCKED_SET_ALLOWED);
3565 /* you are supposed to send additional out-of-sync information 4215 /* you are supposed to send additional out-of-sync information
3566 * if you actually set bits during this phase */ 4216 * if you actually set bits during this phase */
3567 4217
3568 /* maybe we should use some per thread scratch page,
3569 * and allocate that during initial device creation? */
3570 buffer = (unsigned long *) __get_free_page(GFP_NOIO);
3571 if (!buffer) {
3572 dev_err(DEV, "failed to allocate one page buffer in %s\n", __func__);
3573 goto out;
3574 }
3575
3576 c = (struct bm_xfer_ctx) { 4218 c = (struct bm_xfer_ctx) {
3577 .bm_bits = drbd_bm_bits(mdev), 4219 .bm_bits = drbd_bm_bits(mdev),
3578 .bm_words = drbd_bm_words(mdev), 4220 .bm_words = drbd_bm_words(mdev),
3579 }; 4221 };
3580 4222
3581 for(;;) { 4223 for(;;) {
3582 if (cmd == P_BITMAP) { 4224 if (pi->cmd == P_BITMAP)
3583 err = receive_bitmap_plain(mdev, data_size, buffer, &c); 4225 err = receive_bitmap_plain(mdev, pi->size, pi->data, &c);
3584 } else if (cmd == P_COMPRESSED_BITMAP) { 4226 else if (pi->cmd == P_COMPRESSED_BITMAP) {
3585 /* MAYBE: sanity check that we speak proto >= 90, 4227 /* MAYBE: sanity check that we speak proto >= 90,
3586 * and the feature is enabled! */ 4228 * and the feature is enabled! */
3587 struct p_compressed_bm *p; 4229 struct p_compressed_bm *p = pi->data;
3588 4230
3589 if (data_size > BM_PACKET_PAYLOAD_BYTES) { 4231 if (pi->size > DRBD_SOCKET_BUFFER_SIZE - drbd_header_size(tconn)) {
3590 dev_err(DEV, "ReportCBitmap packet too large\n"); 4232 dev_err(DEV, "ReportCBitmap packet too large\n");
4233 err = -EIO;
3591 goto out; 4234 goto out;
3592 } 4235 }
3593 /* use the page buff */ 4236 if (pi->size <= sizeof(*p)) {
3594 p = buffer; 4237 dev_err(DEV, "ReportCBitmap packet too small (l:%u)\n", pi->size);
3595 memcpy(p, h, sizeof(*h)); 4238 err = -EIO;
3596 if (drbd_recv(mdev, p->head.payload, data_size) != data_size)
3597 goto out;
3598 if (data_size <= (sizeof(*p) - sizeof(p->head))) {
3599 dev_err(DEV, "ReportCBitmap packet too small (l:%u)\n", data_size);
3600 goto out; 4239 goto out;
3601 } 4240 }
3602 err = decode_bitmap_c(mdev, p, &c); 4241 err = drbd_recv_all(mdev->tconn, p, pi->size);
4242 if (err)
4243 goto out;
4244 err = decode_bitmap_c(mdev, p, &c, pi->size);
3603 } else { 4245 } else {
3604 dev_warn(DEV, "receive_bitmap: cmd neither ReportBitMap nor ReportCBitMap (is 0x%x)", cmd); 4246 dev_warn(DEV, "receive_bitmap: cmd neither ReportBitMap nor ReportCBitMap (is 0x%x)", pi->cmd);
4247 err = -EIO;
3605 goto out; 4248 goto out;
3606 } 4249 }
3607 4250
3608 c.packets[cmd == P_BITMAP]++; 4251 c.packets[pi->cmd == P_BITMAP]++;
3609 c.bytes[cmd == P_BITMAP] += sizeof(struct p_header80) + data_size; 4252 c.bytes[pi->cmd == P_BITMAP] += drbd_header_size(tconn) + pi->size;
3610 4253
3611 if (err <= 0) { 4254 if (err <= 0) {
3612 if (err < 0) 4255 if (err < 0)
3613 goto out; 4256 goto out;
3614 break; 4257 break;
3615 } 4258 }
3616 if (!drbd_recv_header(mdev, &cmd, &data_size)) 4259 err = drbd_recv_header(mdev->tconn, pi);
4260 if (err)
3617 goto out; 4261 goto out;
3618 } 4262 }
3619 4263
@@ -3622,8 +4266,8 @@ static int receive_bitmap(struct drbd_conf *mdev, enum drbd_packets cmd, unsigne
3622 if (mdev->state.conn == C_WF_BITMAP_T) { 4266 if (mdev->state.conn == C_WF_BITMAP_T) {
3623 enum drbd_state_rv rv; 4267 enum drbd_state_rv rv;
3624 4268
3625 ok = !drbd_send_bitmap(mdev); 4269 err = drbd_send_bitmap(mdev);
3626 if (!ok) 4270 if (err)
3627 goto out; 4271 goto out;
3628 /* Omit CS_ORDERED with this state transition to avoid deadlocks. */ 4272 /* Omit CS_ORDERED with this state transition to avoid deadlocks. */
3629 rv = _drbd_request_state(mdev, NS(conn, C_WF_SYNC_UUID), CS_VERBOSE); 4273 rv = _drbd_request_state(mdev, NS(conn, C_WF_SYNC_UUID), CS_VERBOSE);
@@ -3634,47 +4278,40 @@ static int receive_bitmap(struct drbd_conf *mdev, enum drbd_packets cmd, unsigne
3634 dev_info(DEV, "unexpected cstate (%s) in receive_bitmap\n", 4278 dev_info(DEV, "unexpected cstate (%s) in receive_bitmap\n",
3635 drbd_conn_str(mdev->state.conn)); 4279 drbd_conn_str(mdev->state.conn));
3636 } 4280 }
4281 err = 0;
3637 4282
3638 ok = true;
3639 out: 4283 out:
3640 drbd_bm_unlock(mdev); 4284 drbd_bm_unlock(mdev);
3641 if (ok && mdev->state.conn == C_WF_BITMAP_S) 4285 if (!err && mdev->state.conn == C_WF_BITMAP_S)
3642 drbd_start_resync(mdev, C_SYNC_SOURCE); 4286 drbd_start_resync(mdev, C_SYNC_SOURCE);
3643 free_page((unsigned long) buffer); 4287 return err;
3644 return ok;
3645} 4288}
3646 4289
3647static int receive_skip(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 4290static int receive_skip(struct drbd_tconn *tconn, struct packet_info *pi)
3648{ 4291{
3649 /* TODO zero copy sink :) */ 4292 conn_warn(tconn, "skipping unknown optional packet type %d, l: %d!\n",
3650 static char sink[128]; 4293 pi->cmd, pi->size);
3651 int size, want, r;
3652 4294
3653 dev_warn(DEV, "skipping unknown optional packet type %d, l: %d!\n", 4295 return ignore_remaining_packet(tconn, pi);
3654 cmd, data_size);
3655
3656 size = data_size;
3657 while (size > 0) {
3658 want = min_t(int, size, sizeof(sink));
3659 r = drbd_recv(mdev, sink, want);
3660 ERR_IF(r <= 0) break;
3661 size -= r;
3662 }
3663 return size == 0;
3664} 4296}
3665 4297
3666static int receive_UnplugRemote(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 4298static int receive_UnplugRemote(struct drbd_tconn *tconn, struct packet_info *pi)
3667{ 4299{
3668 /* Make sure we've acked all the TCP data associated 4300 /* Make sure we've acked all the TCP data associated
3669 * with the data requests being unplugged */ 4301 * with the data requests being unplugged */
3670 drbd_tcp_quickack(mdev->data.socket); 4302 drbd_tcp_quickack(tconn->data.socket);
3671 4303
3672 return true; 4304 return 0;
3673} 4305}
3674 4306
3675static int receive_out_of_sync(struct drbd_conf *mdev, enum drbd_packets cmd, unsigned int data_size) 4307static int receive_out_of_sync(struct drbd_tconn *tconn, struct packet_info *pi)
3676{ 4308{
3677 struct p_block_desc *p = &mdev->data.rbuf.block_desc; 4309 struct drbd_conf *mdev;
4310 struct p_block_desc *p = pi->data;
4311
4312 mdev = vnr_to_mdev(tconn, pi->vnr);
4313 if (!mdev)
4314 return -EIO;
3678 4315
3679 switch (mdev->state.conn) { 4316 switch (mdev->state.conn) {
3680 case C_WF_SYNC_UUID: 4317 case C_WF_SYNC_UUID:
@@ -3688,15 +4325,13 @@ static int receive_out_of_sync(struct drbd_conf *mdev, enum drbd_packets cmd, un
3688 4325
3689 drbd_set_out_of_sync(mdev, be64_to_cpu(p->sector), be32_to_cpu(p->blksize)); 4326 drbd_set_out_of_sync(mdev, be64_to_cpu(p->sector), be32_to_cpu(p->blksize));
3690 4327
3691 return true; 4328 return 0;
3692} 4329}
3693 4330
3694typedef int (*drbd_cmd_handler_f)(struct drbd_conf *, enum drbd_packets cmd, unsigned int to_receive);
3695
3696struct data_cmd { 4331struct data_cmd {
3697 int expect_payload; 4332 int expect_payload;
3698 size_t pkt_size; 4333 size_t pkt_size;
3699 drbd_cmd_handler_f function; 4334 int (*fn)(struct drbd_tconn *, struct packet_info *);
3700}; 4335};
3701 4336
3702static struct data_cmd drbd_cmd_handler[] = { 4337static struct data_cmd drbd_cmd_handler[] = {
@@ -3704,13 +4339,13 @@ static struct data_cmd drbd_cmd_handler[] = {
3704 [P_DATA_REPLY] = { 1, sizeof(struct p_data), receive_DataReply }, 4339 [P_DATA_REPLY] = { 1, sizeof(struct p_data), receive_DataReply },
3705 [P_RS_DATA_REPLY] = { 1, sizeof(struct p_data), receive_RSDataReply } , 4340 [P_RS_DATA_REPLY] = { 1, sizeof(struct p_data), receive_RSDataReply } ,
3706 [P_BARRIER] = { 0, sizeof(struct p_barrier), receive_Barrier } , 4341 [P_BARRIER] = { 0, sizeof(struct p_barrier), receive_Barrier } ,
3707 [P_BITMAP] = { 1, sizeof(struct p_header80), receive_bitmap } , 4342 [P_BITMAP] = { 1, 0, receive_bitmap } ,
3708 [P_COMPRESSED_BITMAP] = { 1, sizeof(struct p_header80), receive_bitmap } , 4343 [P_COMPRESSED_BITMAP] = { 1, 0, receive_bitmap } ,
3709 [P_UNPLUG_REMOTE] = { 0, sizeof(struct p_header80), receive_UnplugRemote }, 4344 [P_UNPLUG_REMOTE] = { 0, 0, receive_UnplugRemote },
3710 [P_DATA_REQUEST] = { 0, sizeof(struct p_block_req), receive_DataRequest }, 4345 [P_DATA_REQUEST] = { 0, sizeof(struct p_block_req), receive_DataRequest },
3711 [P_RS_DATA_REQUEST] = { 0, sizeof(struct p_block_req), receive_DataRequest }, 4346 [P_RS_DATA_REQUEST] = { 0, sizeof(struct p_block_req), receive_DataRequest },
3712 [P_SYNC_PARAM] = { 1, sizeof(struct p_header80), receive_SyncParam }, 4347 [P_SYNC_PARAM] = { 1, 0, receive_SyncParam },
3713 [P_SYNC_PARAM89] = { 1, sizeof(struct p_header80), receive_SyncParam }, 4348 [P_SYNC_PARAM89] = { 1, 0, receive_SyncParam },
3714 [P_PROTOCOL] = { 1, sizeof(struct p_protocol), receive_protocol }, 4349 [P_PROTOCOL] = { 1, sizeof(struct p_protocol), receive_protocol },
3715 [P_UUIDS] = { 0, sizeof(struct p_uuids), receive_uuids }, 4350 [P_UUIDS] = { 0, sizeof(struct p_uuids), receive_uuids },
3716 [P_SIZES] = { 0, sizeof(struct p_sizes), receive_sizes }, 4351 [P_SIZES] = { 0, sizeof(struct p_sizes), receive_sizes },
@@ -3722,124 +4357,75 @@ static struct data_cmd drbd_cmd_handler[] = {
3722 [P_CSUM_RS_REQUEST] = { 1, sizeof(struct p_block_req), receive_DataRequest }, 4357 [P_CSUM_RS_REQUEST] = { 1, sizeof(struct p_block_req), receive_DataRequest },
3723 [P_DELAY_PROBE] = { 0, sizeof(struct p_delay_probe93), receive_skip }, 4358 [P_DELAY_PROBE] = { 0, sizeof(struct p_delay_probe93), receive_skip },
3724 [P_OUT_OF_SYNC] = { 0, sizeof(struct p_block_desc), receive_out_of_sync }, 4359 [P_OUT_OF_SYNC] = { 0, sizeof(struct p_block_desc), receive_out_of_sync },
3725 /* anything missing from this table is in 4360 [P_CONN_ST_CHG_REQ] = { 0, sizeof(struct p_req_state), receive_req_conn_state },
3726 * the asender_tbl, see get_asender_cmd */ 4361 [P_PROTOCOL_UPDATE] = { 1, sizeof(struct p_protocol), receive_protocol },
3727 [P_MAX_CMD] = { 0, 0, NULL },
3728}; 4362};
3729 4363
3730/* All handler functions that expect a sub-header get that sub-heder in 4364static void drbdd(struct drbd_tconn *tconn)
3731 mdev->data.rbuf.header.head.payload.
3732
3733 Usually in mdev->data.rbuf.header.head the callback can find the usual
3734 p_header, but they may not rely on that. Since there is also p_header95 !
3735 */
3736
3737static void drbdd(struct drbd_conf *mdev)
3738{ 4365{
3739 union p_header *header = &mdev->data.rbuf.header; 4366 struct packet_info pi;
3740 unsigned int packet_size;
3741 enum drbd_packets cmd;
3742 size_t shs; /* sub header size */ 4367 size_t shs; /* sub header size */
3743 int rv; 4368 int err;
4369
4370 while (get_t_state(&tconn->receiver) == RUNNING) {
4371 struct data_cmd *cmd;
3744 4372
3745 while (get_t_state(&mdev->receiver) == Running) { 4373 drbd_thread_current_set_cpu(&tconn->receiver);
3746 drbd_thread_current_set_cpu(mdev); 4374 if (drbd_recv_header(tconn, &pi))
3747 if (!drbd_recv_header(mdev, &cmd, &packet_size))
3748 goto err_out; 4375 goto err_out;
3749 4376
3750 if (unlikely(cmd >= P_MAX_CMD || !drbd_cmd_handler[cmd].function)) { 4377 cmd = &drbd_cmd_handler[pi.cmd];
3751 dev_err(DEV, "unknown packet type %d, l: %d!\n", cmd, packet_size); 4378 if (unlikely(pi.cmd >= ARRAY_SIZE(drbd_cmd_handler) || !cmd->fn)) {
4379 conn_err(tconn, "Unexpected data packet %s (0x%04x)",
4380 cmdname(pi.cmd), pi.cmd);
3752 goto err_out; 4381 goto err_out;
3753 } 4382 }
3754 4383
3755 shs = drbd_cmd_handler[cmd].pkt_size - sizeof(union p_header); 4384 shs = cmd->pkt_size;
3756 if (packet_size - shs > 0 && !drbd_cmd_handler[cmd].expect_payload) { 4385 if (pi.size > shs && !cmd->expect_payload) {
3757 dev_err(DEV, "No payload expected %s l:%d\n", cmdname(cmd), packet_size); 4386 conn_err(tconn, "No payload expected %s l:%d\n",
4387 cmdname(pi.cmd), pi.size);
3758 goto err_out; 4388 goto err_out;
3759 } 4389 }
3760 4390
3761 if (shs) { 4391 if (shs) {
3762 rv = drbd_recv(mdev, &header->h80.payload, shs); 4392 err = drbd_recv_all_warn(tconn, pi.data, shs);
3763 if (unlikely(rv != shs)) { 4393 if (err)
3764 if (!signal_pending(current))
3765 dev_warn(DEV, "short read while reading sub header: rv=%d\n", rv);
3766 goto err_out; 4394 goto err_out;
3767 } 4395 pi.size -= shs;
3768 } 4396 }
3769 4397
3770 rv = drbd_cmd_handler[cmd].function(mdev, cmd, packet_size - shs); 4398 err = cmd->fn(tconn, &pi);
3771 4399 if (err) {
3772 if (unlikely(!rv)) { 4400 conn_err(tconn, "error receiving %s, e: %d l: %d!\n",
3773 dev_err(DEV, "error receiving %s, l: %d!\n", 4401 cmdname(pi.cmd), err, pi.size);
3774 cmdname(cmd), packet_size);
3775 goto err_out; 4402 goto err_out;
3776 } 4403 }
3777 } 4404 }
4405 return;
3778 4406
3779 if (0) { 4407 err_out:
3780 err_out: 4408 conn_request_state(tconn, NS(conn, C_PROTOCOL_ERROR), CS_HARD);
3781 drbd_force_state(mdev, NS(conn, C_PROTOCOL_ERROR));
3782 }
3783 /* If we leave here, we probably want to update at least the
3784 * "Connected" indicator on stable storage. Do so explicitly here. */
3785 drbd_md_sync(mdev);
3786} 4409}
3787 4410
3788void drbd_flush_workqueue(struct drbd_conf *mdev) 4411void conn_flush_workqueue(struct drbd_tconn *tconn)
3789{ 4412{
3790 struct drbd_wq_barrier barr; 4413 struct drbd_wq_barrier barr;
3791 4414
3792 barr.w.cb = w_prev_work_done; 4415 barr.w.cb = w_prev_work_done;
4416 barr.w.tconn = tconn;
3793 init_completion(&barr.done); 4417 init_completion(&barr.done);
3794 drbd_queue_work(&mdev->data.work, &barr.w); 4418 drbd_queue_work(&tconn->sender_work, &barr.w);
3795 wait_for_completion(&barr.done); 4419 wait_for_completion(&barr.done);
3796} 4420}
3797 4421
3798void drbd_free_tl_hash(struct drbd_conf *mdev) 4422static void conn_disconnect(struct drbd_tconn *tconn)
3799{ 4423{
3800 struct hlist_head *h; 4424 struct drbd_conf *mdev;
3801 4425 enum drbd_conns oc;
3802 spin_lock_irq(&mdev->req_lock); 4426 int vnr;
3803 4427
3804 if (!mdev->tl_hash || mdev->state.conn != C_STANDALONE) { 4428 if (tconn->cstate == C_STANDALONE)
3805 spin_unlock_irq(&mdev->req_lock);
3806 return;
3807 }
3808 /* paranoia code */
3809 for (h = mdev->ee_hash; h < mdev->ee_hash + mdev->ee_hash_s; h++)
3810 if (h->first)
3811 dev_err(DEV, "ASSERT FAILED ee_hash[%u].first == %p, expected NULL\n",
3812 (int)(h - mdev->ee_hash), h->first);
3813 kfree(mdev->ee_hash);
3814 mdev->ee_hash = NULL;
3815 mdev->ee_hash_s = 0;
3816
3817 /* We may not have had the chance to wait for all locally pending
3818 * application requests. The hlist_add_fake() prevents access after
3819 * free on master bio completion. */
3820 for (h = mdev->tl_hash; h < mdev->tl_hash + mdev->tl_hash_s; h++) {
3821 struct drbd_request *req;
3822 struct hlist_node *pos, *n;
3823 hlist_for_each_entry_safe(req, pos, n, h, collision) {
3824 hlist_del_init(&req->collision);
3825 hlist_add_fake(&req->collision);
3826 }
3827 }
3828
3829 kfree(mdev->tl_hash);
3830 mdev->tl_hash = NULL;
3831 mdev->tl_hash_s = 0;
3832 spin_unlock_irq(&mdev->req_lock);
3833}
3834
3835static void drbd_disconnect(struct drbd_conf *mdev)
3836{
3837 enum drbd_fencing_p fp;
3838 union drbd_state os, ns;
3839 int rv = SS_UNKNOWN_ERROR;
3840 unsigned int i;
3841
3842 if (mdev->state.conn == C_STANDALONE)
3843 return; 4429 return;
3844 4430
3845 /* We are about to start the cleanup after connection loss. 4431 /* We are about to start the cleanup after connection loss.
@@ -3847,18 +4433,54 @@ static void drbd_disconnect(struct drbd_conf *mdev)
3847 * Usually we should be in some network failure state already, 4433 * Usually we should be in some network failure state already,
3848 * but just in case we are not, we fix it up here. 4434 * but just in case we are not, we fix it up here.
3849 */ 4435 */
3850 drbd_force_state(mdev, NS(conn, C_NETWORK_FAILURE)); 4436 conn_request_state(tconn, NS(conn, C_NETWORK_FAILURE), CS_HARD);
3851 4437
3852 /* asender does not clean up anything. it must not interfere, either */ 4438 /* asender does not clean up anything. it must not interfere, either */
3853 drbd_thread_stop(&mdev->asender); 4439 drbd_thread_stop(&tconn->asender);
3854 drbd_free_sock(mdev); 4440 drbd_free_sock(tconn);
4441
4442 rcu_read_lock();
4443 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
4444 kref_get(&mdev->kref);
4445 rcu_read_unlock();
4446 drbd_disconnected(mdev);
4447 kref_put(&mdev->kref, &drbd_minor_destroy);
4448 rcu_read_lock();
4449 }
4450 rcu_read_unlock();
4451
4452 if (!list_empty(&tconn->current_epoch->list))
4453 conn_err(tconn, "ASSERTION FAILED: tconn->current_epoch->list not empty\n");
4454 /* ok, no more ee's on the fly, it is safe to reset the epoch_size */
4455 atomic_set(&tconn->current_epoch->epoch_size, 0);
4456 tconn->send.seen_any_write_yet = false;
4457
4458 conn_info(tconn, "Connection closed\n");
4459
4460 if (conn_highest_role(tconn) == R_PRIMARY && conn_highest_pdsk(tconn) >= D_UNKNOWN)
4461 conn_try_outdate_peer_async(tconn);
4462
4463 spin_lock_irq(&tconn->req_lock);
4464 oc = tconn->cstate;
4465 if (oc >= C_UNCONNECTED)
4466 _conn_request_state(tconn, NS(conn, C_UNCONNECTED), CS_VERBOSE);
4467
4468 spin_unlock_irq(&tconn->req_lock);
4469
4470 if (oc == C_DISCONNECTING)
4471 conn_request_state(tconn, NS(conn, C_STANDALONE), CS_VERBOSE | CS_HARD);
4472}
4473
4474static int drbd_disconnected(struct drbd_conf *mdev)
4475{
4476 unsigned int i;
3855 4477
3856 /* wait for current activity to cease. */ 4478 /* wait for current activity to cease. */
3857 spin_lock_irq(&mdev->req_lock); 4479 spin_lock_irq(&mdev->tconn->req_lock);
3858 _drbd_wait_ee_list_empty(mdev, &mdev->active_ee); 4480 _drbd_wait_ee_list_empty(mdev, &mdev->active_ee);
3859 _drbd_wait_ee_list_empty(mdev, &mdev->sync_ee); 4481 _drbd_wait_ee_list_empty(mdev, &mdev->sync_ee);
3860 _drbd_wait_ee_list_empty(mdev, &mdev->read_ee); 4482 _drbd_wait_ee_list_empty(mdev, &mdev->read_ee);
3861 spin_unlock_irq(&mdev->req_lock); 4483 spin_unlock_irq(&mdev->tconn->req_lock);
3862 4484
3863 /* We do not have data structures that would allow us to 4485 /* We do not have data structures that would allow us to
3864 * get the rs_pending_cnt down to 0 again. 4486 * get the rs_pending_cnt down to 0 again.
@@ -3876,7 +4498,6 @@ static void drbd_disconnect(struct drbd_conf *mdev)
3876 atomic_set(&mdev->rs_pending_cnt, 0); 4498 atomic_set(&mdev->rs_pending_cnt, 0);
3877 wake_up(&mdev->misc_wait); 4499 wake_up(&mdev->misc_wait);
3878 4500
3879 /* make sure syncer is stopped and w_resume_next_sg queued */
3880 del_timer_sync(&mdev->resync_timer); 4501 del_timer_sync(&mdev->resync_timer);
3881 resync_timer_fn((unsigned long)mdev); 4502 resync_timer_fn((unsigned long)mdev);
3882 4503
@@ -3885,53 +4506,28 @@ static void drbd_disconnect(struct drbd_conf *mdev)
3885 * to be "canceled" */ 4506 * to be "canceled" */
3886 drbd_flush_workqueue(mdev); 4507 drbd_flush_workqueue(mdev);
3887 4508
3888 /* This also does reclaim_net_ee(). If we do this too early, we might 4509 drbd_finish_peer_reqs(mdev);
3889 * miss some resync ee and pages.*/ 4510
3890 drbd_process_done_ee(mdev); 4511 /* This second workqueue flush is necessary, since drbd_finish_peer_reqs()
4512 might have issued a work again. The one before drbd_finish_peer_reqs() is
4513 necessary to reclain net_ee in drbd_finish_peer_reqs(). */
4514 drbd_flush_workqueue(mdev);
4515
4516 /* need to do it again, drbd_finish_peer_reqs() may have populated it
4517 * again via drbd_try_clear_on_disk_bm(). */
4518 drbd_rs_cancel_all(mdev);
3891 4519
3892 kfree(mdev->p_uuid); 4520 kfree(mdev->p_uuid);
3893 mdev->p_uuid = NULL; 4521 mdev->p_uuid = NULL;
3894 4522
3895 if (!is_susp(mdev->state)) 4523 if (!drbd_suspended(mdev))
3896 tl_clear(mdev); 4524 tl_clear(mdev->tconn);
3897
3898 dev_info(DEV, "Connection closed\n");
3899 4525
3900 drbd_md_sync(mdev); 4526 drbd_md_sync(mdev);
3901 4527
3902 fp = FP_DONT_CARE;
3903 if (get_ldev(mdev)) {
3904 fp = mdev->ldev->dc.fencing;
3905 put_ldev(mdev);
3906 }
3907
3908 if (mdev->state.role == R_PRIMARY && fp >= FP_RESOURCE && mdev->state.pdsk >= D_UNKNOWN)
3909 drbd_try_outdate_peer_async(mdev);
3910
3911 spin_lock_irq(&mdev->req_lock);
3912 os = mdev->state;
3913 if (os.conn >= C_UNCONNECTED) {
3914 /* Do not restart in case we are C_DISCONNECTING */
3915 ns = os;
3916 ns.conn = C_UNCONNECTED;
3917 rv = _drbd_set_state(mdev, ns, CS_VERBOSE, NULL);
3918 }
3919 spin_unlock_irq(&mdev->req_lock);
3920
3921 if (os.conn == C_DISCONNECTING) {
3922 wait_event(mdev->net_cnt_wait, atomic_read(&mdev->net_cnt) == 0);
3923
3924 crypto_free_hash(mdev->cram_hmac_tfm);
3925 mdev->cram_hmac_tfm = NULL;
3926
3927 kfree(mdev->net_conf);
3928 mdev->net_conf = NULL;
3929 drbd_request_state(mdev, NS(conn, C_STANDALONE));
3930 }
3931
3932 /* serialize with bitmap writeout triggered by the state change, 4528 /* serialize with bitmap writeout triggered by the state change,
3933 * if any. */ 4529 * if any. */
3934 wait_event(mdev->misc_wait, !drbd_test_flag(mdev, BITMAP_IO)); 4530 wait_event(mdev->misc_wait, !test_bit(BITMAP_IO, &mdev->flags));
3935 4531
3936 /* tcp_close and release of sendpage pages can be deferred. I don't 4532 /* tcp_close and release of sendpage pages can be deferred. I don't
3937 * want to use SO_LINGER, because apparently it can be deferred for 4533 * want to use SO_LINGER, because apparently it can be deferred for
@@ -3940,7 +4536,7 @@ static void drbd_disconnect(struct drbd_conf *mdev)
3940 * Actually we don't care for exactly when the network stack does its 4536 * Actually we don't care for exactly when the network stack does its
3941 * put_page(), but release our reference on these pages right here. 4537 * put_page(), but release our reference on these pages right here.
3942 */ 4538 */
3943 i = drbd_release_ee(mdev, &mdev->net_ee); 4539 i = drbd_free_peer_reqs(mdev, &mdev->net_ee);
3944 if (i) 4540 if (i)
3945 dev_info(DEV, "net_ee not empty, killed %u entries\n", i); 4541 dev_info(DEV, "net_ee not empty, killed %u entries\n", i);
3946 i = atomic_read(&mdev->pp_in_use_by_net); 4542 i = atomic_read(&mdev->pp_in_use_by_net);
@@ -3955,9 +4551,7 @@ static void drbd_disconnect(struct drbd_conf *mdev)
3955 D_ASSERT(list_empty(&mdev->sync_ee)); 4551 D_ASSERT(list_empty(&mdev->sync_ee));
3956 D_ASSERT(list_empty(&mdev->done_ee)); 4552 D_ASSERT(list_empty(&mdev->done_ee));
3957 4553
3958 /* ok, no more ee's on the fly, it is safe to reset the epoch_size */ 4554 return 0;
3959 atomic_set(&mdev->current_epoch->epoch_size, 0);
3960 D_ASSERT(list_empty(&mdev->current_epoch->list));
3961} 4555}
3962 4556
3963/* 4557/*
@@ -3969,29 +4563,19 @@ static void drbd_disconnect(struct drbd_conf *mdev)
3969 * 4563 *
3970 * for now, they are expected to be zero, but ignored. 4564 * for now, they are expected to be zero, but ignored.
3971 */ 4565 */
3972static int drbd_send_handshake(struct drbd_conf *mdev) 4566static int drbd_send_features(struct drbd_tconn *tconn)
3973{ 4567{
3974 /* ASSERT current == mdev->receiver ... */ 4568 struct drbd_socket *sock;
3975 struct p_handshake *p = &mdev->data.sbuf.handshake; 4569 struct p_connection_features *p;
3976 int ok;
3977
3978 if (mutex_lock_interruptible(&mdev->data.mutex)) {
3979 dev_err(DEV, "interrupted during initial handshake\n");
3980 return 0; /* interrupted. not ok. */
3981 }
3982
3983 if (mdev->data.socket == NULL) {
3984 mutex_unlock(&mdev->data.mutex);
3985 return 0;
3986 }
3987 4570
4571 sock = &tconn->data;
4572 p = conn_prepare_command(tconn, sock);
4573 if (!p)
4574 return -EIO;
3988 memset(p, 0, sizeof(*p)); 4575 memset(p, 0, sizeof(*p));
3989 p->protocol_min = cpu_to_be32(PRO_VERSION_MIN); 4576 p->protocol_min = cpu_to_be32(PRO_VERSION_MIN);
3990 p->protocol_max = cpu_to_be32(PRO_VERSION_MAX); 4577 p->protocol_max = cpu_to_be32(PRO_VERSION_MAX);
3991 ok = _drbd_send_cmd( mdev, mdev->data.socket, P_HAND_SHAKE, 4578 return conn_send_command(tconn, sock, P_CONNECTION_FEATURES, sizeof(*p), NULL, 0);
3992 (struct p_header80 *)p, sizeof(*p), 0 );
3993 mutex_unlock(&mdev->data.mutex);
3994 return ok;
3995} 4579}
3996 4580
3997/* 4581/*
@@ -4001,42 +4585,38 @@ static int drbd_send_handshake(struct drbd_conf *mdev)
4001 * -1 peer talks different language, 4585 * -1 peer talks different language,
4002 * no point in trying again, please go standalone. 4586 * no point in trying again, please go standalone.
4003 */ 4587 */
4004static int drbd_do_handshake(struct drbd_conf *mdev) 4588static int drbd_do_features(struct drbd_tconn *tconn)
4005{ 4589{
4006 /* ASSERT current == mdev->receiver ... */ 4590 /* ASSERT current == tconn->receiver ... */
4007 struct p_handshake *p = &mdev->data.rbuf.handshake; 4591 struct p_connection_features *p;
4008 const int expect = sizeof(struct p_handshake) - sizeof(struct p_header80); 4592 const int expect = sizeof(struct p_connection_features);
4009 unsigned int length; 4593 struct packet_info pi;
4010 enum drbd_packets cmd; 4594 int err;
4011 int rv;
4012 4595
4013 rv = drbd_send_handshake(mdev); 4596 err = drbd_send_features(tconn);
4014 if (!rv) 4597 if (err)
4015 return 0; 4598 return 0;
4016 4599
4017 rv = drbd_recv_header(mdev, &cmd, &length); 4600 err = drbd_recv_header(tconn, &pi);
4018 if (!rv) 4601 if (err)
4019 return 0; 4602 return 0;
4020 4603
4021 if (cmd != P_HAND_SHAKE) { 4604 if (pi.cmd != P_CONNECTION_FEATURES) {
4022 dev_err(DEV, "expected HandShake packet, received: %s (0x%04x)\n", 4605 conn_err(tconn, "expected ConnectionFeatures packet, received: %s (0x%04x)\n",
4023 cmdname(cmd), cmd); 4606 cmdname(pi.cmd), pi.cmd);
4024 return -1; 4607 return -1;
4025 } 4608 }
4026 4609
4027 if (length != expect) { 4610 if (pi.size != expect) {
4028 dev_err(DEV, "expected HandShake length: %u, received: %u\n", 4611 conn_err(tconn, "expected ConnectionFeatures length: %u, received: %u\n",
4029 expect, length); 4612 expect, pi.size);
4030 return -1; 4613 return -1;
4031 } 4614 }
4032 4615
4033 rv = drbd_recv(mdev, &p->head.payload, expect); 4616 p = pi.data;
4034 4617 err = drbd_recv_all_warn(tconn, p, expect);
4035 if (rv != expect) { 4618 if (err)
4036 if (!signal_pending(current))
4037 dev_warn(DEV, "short read receiving handshake packet: l=%u\n", rv);
4038 return 0; 4619 return 0;
4039 }
4040 4620
4041 p->protocol_min = be32_to_cpu(p->protocol_min); 4621 p->protocol_min = be32_to_cpu(p->protocol_min);
4042 p->protocol_max = be32_to_cpu(p->protocol_max); 4622 p->protocol_max = be32_to_cpu(p->protocol_max);
@@ -4047,15 +4627,15 @@ static int drbd_do_handshake(struct drbd_conf *mdev)
4047 PRO_VERSION_MIN > p->protocol_max) 4627 PRO_VERSION_MIN > p->protocol_max)
4048 goto incompat; 4628 goto incompat;
4049 4629
4050 mdev->agreed_pro_version = min_t(int, PRO_VERSION_MAX, p->protocol_max); 4630 tconn->agreed_pro_version = min_t(int, PRO_VERSION_MAX, p->protocol_max);
4051 4631
4052 dev_info(DEV, "Handshake successful: " 4632 conn_info(tconn, "Handshake successful: "
4053 "Agreed network protocol version %d\n", mdev->agreed_pro_version); 4633 "Agreed network protocol version %d\n", tconn->agreed_pro_version);
4054 4634
4055 return 1; 4635 return 1;
4056 4636
4057 incompat: 4637 incompat:
4058 dev_err(DEV, "incompatible DRBD dialects: " 4638 conn_err(tconn, "incompatible DRBD dialects: "
4059 "I support %d-%d, peer supports %d-%d\n", 4639 "I support %d-%d, peer supports %d-%d\n",
4060 PRO_VERSION_MIN, PRO_VERSION_MAX, 4640 PRO_VERSION_MIN, PRO_VERSION_MAX,
4061 p->protocol_min, p->protocol_max); 4641 p->protocol_min, p->protocol_max);
@@ -4063,7 +4643,7 @@ static int drbd_do_handshake(struct drbd_conf *mdev)
4063} 4643}
4064 4644
4065#if !defined(CONFIG_CRYPTO_HMAC) && !defined(CONFIG_CRYPTO_HMAC_MODULE) 4645#if !defined(CONFIG_CRYPTO_HMAC) && !defined(CONFIG_CRYPTO_HMAC_MODULE)
4066static int drbd_do_auth(struct drbd_conf *mdev) 4646static int drbd_do_auth(struct drbd_tconn *tconn)
4067{ 4647{
4068 dev_err(DEV, "This kernel was build without CONFIG_CRYPTO_HMAC.\n"); 4648 dev_err(DEV, "This kernel was build without CONFIG_CRYPTO_HMAC.\n");
4069 dev_err(DEV, "You need to disable 'cram-hmac-alg' in drbd.conf.\n"); 4649 dev_err(DEV, "You need to disable 'cram-hmac-alg' in drbd.conf.\n");
@@ -4078,121 +4658,139 @@ static int drbd_do_auth(struct drbd_conf *mdev)
4078 -1 - auth failed, don't try again. 4658 -1 - auth failed, don't try again.
4079*/ 4659*/
4080 4660
4081static int drbd_do_auth(struct drbd_conf *mdev) 4661static int drbd_do_auth(struct drbd_tconn *tconn)
4082{ 4662{
4663 struct drbd_socket *sock;
4083 char my_challenge[CHALLENGE_LEN]; /* 64 Bytes... */ 4664 char my_challenge[CHALLENGE_LEN]; /* 64 Bytes... */
4084 struct scatterlist sg; 4665 struct scatterlist sg;
4085 char *response = NULL; 4666 char *response = NULL;
4086 char *right_response = NULL; 4667 char *right_response = NULL;
4087 char *peers_ch = NULL; 4668 char *peers_ch = NULL;
4088 unsigned int key_len = strlen(mdev->net_conf->shared_secret); 4669 unsigned int key_len;
4670 char secret[SHARED_SECRET_MAX]; /* 64 byte */
4089 unsigned int resp_size; 4671 unsigned int resp_size;
4090 struct hash_desc desc; 4672 struct hash_desc desc;
4091 enum drbd_packets cmd; 4673 struct packet_info pi;
4092 unsigned int length; 4674 struct net_conf *nc;
4093 int rv; 4675 int err, rv;
4676
4677 /* FIXME: Put the challenge/response into the preallocated socket buffer. */
4094 4678
4095 desc.tfm = mdev->cram_hmac_tfm; 4679 rcu_read_lock();
4680 nc = rcu_dereference(tconn->net_conf);
4681 key_len = strlen(nc->shared_secret);
4682 memcpy(secret, nc->shared_secret, key_len);
4683 rcu_read_unlock();
4684
4685 desc.tfm = tconn->cram_hmac_tfm;
4096 desc.flags = 0; 4686 desc.flags = 0;
4097 4687
4098 rv = crypto_hash_setkey(mdev->cram_hmac_tfm, 4688 rv = crypto_hash_setkey(tconn->cram_hmac_tfm, (u8 *)secret, key_len);
4099 (u8 *)mdev->net_conf->shared_secret, key_len);
4100 if (rv) { 4689 if (rv) {
4101 dev_err(DEV, "crypto_hash_setkey() failed with %d\n", rv); 4690 conn_err(tconn, "crypto_hash_setkey() failed with %d\n", rv);
4102 rv = -1; 4691 rv = -1;
4103 goto fail; 4692 goto fail;
4104 } 4693 }
4105 4694
4106 get_random_bytes(my_challenge, CHALLENGE_LEN); 4695 get_random_bytes(my_challenge, CHALLENGE_LEN);
4107 4696
4108 rv = drbd_send_cmd2(mdev, P_AUTH_CHALLENGE, my_challenge, CHALLENGE_LEN); 4697 sock = &tconn->data;
4698 if (!conn_prepare_command(tconn, sock)) {
4699 rv = 0;
4700 goto fail;
4701 }
4702 rv = !conn_send_command(tconn, sock, P_AUTH_CHALLENGE, 0,
4703 my_challenge, CHALLENGE_LEN);
4109 if (!rv) 4704 if (!rv)
4110 goto fail; 4705 goto fail;
4111 4706
4112 rv = drbd_recv_header(mdev, &cmd, &length); 4707 err = drbd_recv_header(tconn, &pi);
4113 if (!rv) 4708 if (err) {
4709 rv = 0;
4114 goto fail; 4710 goto fail;
4711 }
4115 4712
4116 if (cmd != P_AUTH_CHALLENGE) { 4713 if (pi.cmd != P_AUTH_CHALLENGE) {
4117 dev_err(DEV, "expected AuthChallenge packet, received: %s (0x%04x)\n", 4714 conn_err(tconn, "expected AuthChallenge packet, received: %s (0x%04x)\n",
4118 cmdname(cmd), cmd); 4715 cmdname(pi.cmd), pi.cmd);
4119 rv = 0; 4716 rv = 0;
4120 goto fail; 4717 goto fail;
4121 } 4718 }
4122 4719
4123 if (length > CHALLENGE_LEN * 2) { 4720 if (pi.size > CHALLENGE_LEN * 2) {
4124 dev_err(DEV, "expected AuthChallenge payload too big.\n"); 4721 conn_err(tconn, "expected AuthChallenge payload too big.\n");
4125 rv = -1; 4722 rv = -1;
4126 goto fail; 4723 goto fail;
4127 } 4724 }
4128 4725
4129 peers_ch = kmalloc(length, GFP_NOIO); 4726 peers_ch = kmalloc(pi.size, GFP_NOIO);
4130 if (peers_ch == NULL) { 4727 if (peers_ch == NULL) {
4131 dev_err(DEV, "kmalloc of peers_ch failed\n"); 4728 conn_err(tconn, "kmalloc of peers_ch failed\n");
4132 rv = -1; 4729 rv = -1;
4133 goto fail; 4730 goto fail;
4134 } 4731 }
4135 4732
4136 rv = drbd_recv(mdev, peers_ch, length); 4733 err = drbd_recv_all_warn(tconn, peers_ch, pi.size);
4137 4734 if (err) {
4138 if (rv != length) {
4139 if (!signal_pending(current))
4140 dev_warn(DEV, "short read AuthChallenge: l=%u\n", rv);
4141 rv = 0; 4735 rv = 0;
4142 goto fail; 4736 goto fail;
4143 } 4737 }
4144 4738
4145 resp_size = crypto_hash_digestsize(mdev->cram_hmac_tfm); 4739 resp_size = crypto_hash_digestsize(tconn->cram_hmac_tfm);
4146 response = kmalloc(resp_size, GFP_NOIO); 4740 response = kmalloc(resp_size, GFP_NOIO);
4147 if (response == NULL) { 4741 if (response == NULL) {
4148 dev_err(DEV, "kmalloc of response failed\n"); 4742 conn_err(tconn, "kmalloc of response failed\n");
4149 rv = -1; 4743 rv = -1;
4150 goto fail; 4744 goto fail;
4151 } 4745 }
4152 4746
4153 sg_init_table(&sg, 1); 4747 sg_init_table(&sg, 1);
4154 sg_set_buf(&sg, peers_ch, length); 4748 sg_set_buf(&sg, peers_ch, pi.size);
4155 4749
4156 rv = crypto_hash_digest(&desc, &sg, sg.length, response); 4750 rv = crypto_hash_digest(&desc, &sg, sg.length, response);
4157 if (rv) { 4751 if (rv) {
4158 dev_err(DEV, "crypto_hash_digest() failed with %d\n", rv); 4752 conn_err(tconn, "crypto_hash_digest() failed with %d\n", rv);
4159 rv = -1; 4753 rv = -1;
4160 goto fail; 4754 goto fail;
4161 } 4755 }
4162 4756
4163 rv = drbd_send_cmd2(mdev, P_AUTH_RESPONSE, response, resp_size); 4757 if (!conn_prepare_command(tconn, sock)) {
4164 if (!rv) 4758 rv = 0;
4165 goto fail; 4759 goto fail;
4166 4760 }
4167 rv = drbd_recv_header(mdev, &cmd, &length); 4761 rv = !conn_send_command(tconn, sock, P_AUTH_RESPONSE, 0,
4762 response, resp_size);
4168 if (!rv) 4763 if (!rv)
4169 goto fail; 4764 goto fail;
4170 4765
4171 if (cmd != P_AUTH_RESPONSE) { 4766 err = drbd_recv_header(tconn, &pi);
4172 dev_err(DEV, "expected AuthResponse packet, received: %s (0x%04x)\n", 4767 if (err) {
4173 cmdname(cmd), cmd);
4174 rv = 0; 4768 rv = 0;
4175 goto fail; 4769 goto fail;
4176 } 4770 }
4177 4771
4178 if (length != resp_size) { 4772 if (pi.cmd != P_AUTH_RESPONSE) {
4179 dev_err(DEV, "expected AuthResponse payload of wrong size\n"); 4773 conn_err(tconn, "expected AuthResponse packet, received: %s (0x%04x)\n",
4774 cmdname(pi.cmd), pi.cmd);
4180 rv = 0; 4775 rv = 0;
4181 goto fail; 4776 goto fail;
4182 } 4777 }
4183 4778
4184 rv = drbd_recv(mdev, response , resp_size); 4779 if (pi.size != resp_size) {
4780 conn_err(tconn, "expected AuthResponse payload of wrong size\n");
4781 rv = 0;
4782 goto fail;
4783 }
4185 4784
4186 if (rv != resp_size) { 4785 err = drbd_recv_all_warn(tconn, response , resp_size);
4187 if (!signal_pending(current)) 4786 if (err) {
4188 dev_warn(DEV, "short read receiving AuthResponse: l=%u\n", rv);
4189 rv = 0; 4787 rv = 0;
4190 goto fail; 4788 goto fail;
4191 } 4789 }
4192 4790
4193 right_response = kmalloc(resp_size, GFP_NOIO); 4791 right_response = kmalloc(resp_size, GFP_NOIO);
4194 if (right_response == NULL) { 4792 if (right_response == NULL) {
4195 dev_err(DEV, "kmalloc of right_response failed\n"); 4793 conn_err(tconn, "kmalloc of right_response failed\n");
4196 rv = -1; 4794 rv = -1;
4197 goto fail; 4795 goto fail;
4198 } 4796 }
@@ -4201,7 +4799,7 @@ static int drbd_do_auth(struct drbd_conf *mdev)
4201 4799
4202 rv = crypto_hash_digest(&desc, &sg, sg.length, right_response); 4800 rv = crypto_hash_digest(&desc, &sg, sg.length, right_response);
4203 if (rv) { 4801 if (rv) {
4204 dev_err(DEV, "crypto_hash_digest() failed with %d\n", rv); 4802 conn_err(tconn, "crypto_hash_digest() failed with %d\n", rv);
4205 rv = -1; 4803 rv = -1;
4206 goto fail; 4804 goto fail;
4207 } 4805 }
@@ -4209,8 +4807,8 @@ static int drbd_do_auth(struct drbd_conf *mdev)
4209 rv = !memcmp(response, right_response, resp_size); 4807 rv = !memcmp(response, right_response, resp_size);
4210 4808
4211 if (rv) 4809 if (rv)
4212 dev_info(DEV, "Peer authenticated using %d bytes of '%s' HMAC\n", 4810 conn_info(tconn, "Peer authenticated using %d bytes HMAC\n",
4213 resp_size, mdev->net_conf->cram_hmac_alg); 4811 resp_size);
4214 else 4812 else
4215 rv = -1; 4813 rv = -1;
4216 4814
@@ -4225,82 +4823,106 @@ static int drbd_do_auth(struct drbd_conf *mdev)
4225 4823
4226int drbdd_init(struct drbd_thread *thi) 4824int drbdd_init(struct drbd_thread *thi)
4227{ 4825{
4228 struct drbd_conf *mdev = thi->mdev; 4826 struct drbd_tconn *tconn = thi->tconn;
4229 unsigned int minor = mdev_to_minor(mdev);
4230 int h; 4827 int h;
4231 4828
4232 sprintf(current->comm, "drbd%d_receiver", minor); 4829 conn_info(tconn, "receiver (re)started\n");
4233
4234 dev_info(DEV, "receiver (re)started\n");
4235 4830
4236 do { 4831 do {
4237 h = drbd_connect(mdev); 4832 h = conn_connect(tconn);
4238 if (h == 0) { 4833 if (h == 0) {
4239 drbd_disconnect(mdev); 4834 conn_disconnect(tconn);
4240 schedule_timeout_interruptible(HZ); 4835 schedule_timeout_interruptible(HZ);
4241 } 4836 }
4242 if (h == -1) { 4837 if (h == -1) {
4243 dev_warn(DEV, "Discarding network configuration.\n"); 4838 conn_warn(tconn, "Discarding network configuration.\n");
4244 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 4839 conn_request_state(tconn, NS(conn, C_DISCONNECTING), CS_HARD);
4245 } 4840 }
4246 } while (h == 0); 4841 } while (h == 0);
4247 4842
4248 if (h > 0) { 4843 if (h > 0)
4249 if (get_net_conf(mdev)) { 4844 drbdd(tconn);
4250 drbdd(mdev);
4251 put_net_conf(mdev);
4252 }
4253 }
4254 4845
4255 drbd_disconnect(mdev); 4846 conn_disconnect(tconn);
4256 4847
4257 dev_info(DEV, "receiver terminated\n"); 4848 conn_info(tconn, "receiver terminated\n");
4258 return 0; 4849 return 0;
4259} 4850}
4260 4851
4261/* ********* acknowledge sender ******** */ 4852/* ********* acknowledge sender ******** */
4262 4853
4263static int got_RqSReply(struct drbd_conf *mdev, struct p_header80 *h) 4854static int got_conn_RqSReply(struct drbd_tconn *tconn, struct packet_info *pi)
4264{ 4855{
4265 struct p_req_state_reply *p = (struct p_req_state_reply *)h; 4856 struct p_req_state_reply *p = pi->data;
4857 int retcode = be32_to_cpu(p->retcode);
4858
4859 if (retcode >= SS_SUCCESS) {
4860 set_bit(CONN_WD_ST_CHG_OKAY, &tconn->flags);
4861 } else {
4862 set_bit(CONN_WD_ST_CHG_FAIL, &tconn->flags);
4863 conn_err(tconn, "Requested state change failed by peer: %s (%d)\n",
4864 drbd_set_st_err_str(retcode), retcode);
4865 }
4866 wake_up(&tconn->ping_wait);
4266 4867
4868 return 0;
4869}
4870
4871static int got_RqSReply(struct drbd_tconn *tconn, struct packet_info *pi)
4872{
4873 struct drbd_conf *mdev;
4874 struct p_req_state_reply *p = pi->data;
4267 int retcode = be32_to_cpu(p->retcode); 4875 int retcode = be32_to_cpu(p->retcode);
4268 4876
4877 mdev = vnr_to_mdev(tconn, pi->vnr);
4878 if (!mdev)
4879 return -EIO;
4880
4881 if (test_bit(CONN_WD_ST_CHG_REQ, &tconn->flags)) {
4882 D_ASSERT(tconn->agreed_pro_version < 100);
4883 return got_conn_RqSReply(tconn, pi);
4884 }
4885
4269 if (retcode >= SS_SUCCESS) { 4886 if (retcode >= SS_SUCCESS) {
4270 drbd_set_flag(mdev, CL_ST_CHG_SUCCESS); 4887 set_bit(CL_ST_CHG_SUCCESS, &mdev->flags);
4271 } else { 4888 } else {
4272 drbd_set_flag(mdev, CL_ST_CHG_FAIL); 4889 set_bit(CL_ST_CHG_FAIL, &mdev->flags);
4273 dev_err(DEV, "Requested state change failed by peer: %s (%d)\n", 4890 dev_err(DEV, "Requested state change failed by peer: %s (%d)\n",
4274 drbd_set_st_err_str(retcode), retcode); 4891 drbd_set_st_err_str(retcode), retcode);
4275 } 4892 }
4276 wake_up(&mdev->state_wait); 4893 wake_up(&mdev->state_wait);
4277 4894
4278 return true; 4895 return 0;
4279} 4896}
4280 4897
4281static int got_Ping(struct drbd_conf *mdev, struct p_header80 *h) 4898static int got_Ping(struct drbd_tconn *tconn, struct packet_info *pi)
4282{ 4899{
4283 return drbd_send_ping_ack(mdev); 4900 return drbd_send_ping_ack(tconn);
4284 4901
4285} 4902}
4286 4903
4287static int got_PingAck(struct drbd_conf *mdev, struct p_header80 *h) 4904static int got_PingAck(struct drbd_tconn *tconn, struct packet_info *pi)
4288{ 4905{
4289 /* restore idle timeout */ 4906 /* restore idle timeout */
4290 mdev->meta.socket->sk->sk_rcvtimeo = mdev->net_conf->ping_int*HZ; 4907 tconn->meta.socket->sk->sk_rcvtimeo = tconn->net_conf->ping_int*HZ;
4291 if (!drbd_test_and_set_flag(mdev, GOT_PING_ACK)) 4908 if (!test_and_set_bit(GOT_PING_ACK, &tconn->flags))
4292 wake_up(&mdev->misc_wait); 4909 wake_up(&tconn->ping_wait);
4293 4910
4294 return true; 4911 return 0;
4295} 4912}
4296 4913
4297static int got_IsInSync(struct drbd_conf *mdev, struct p_header80 *h) 4914static int got_IsInSync(struct drbd_tconn *tconn, struct packet_info *pi)
4298{ 4915{
4299 struct p_block_ack *p = (struct p_block_ack *)h; 4916 struct drbd_conf *mdev;
4917 struct p_block_ack *p = pi->data;
4300 sector_t sector = be64_to_cpu(p->sector); 4918 sector_t sector = be64_to_cpu(p->sector);
4301 int blksize = be32_to_cpu(p->blksize); 4919 int blksize = be32_to_cpu(p->blksize);
4302 4920
4303 D_ASSERT(mdev->agreed_pro_version >= 89); 4921 mdev = vnr_to_mdev(tconn, pi->vnr);
4922 if (!mdev)
4923 return -EIO;
4924
4925 D_ASSERT(mdev->tconn->agreed_pro_version >= 89);
4304 4926
4305 update_peer_seq(mdev, be32_to_cpu(p->seq_num)); 4927 update_peer_seq(mdev, be32_to_cpu(p->seq_num));
4306 4928
@@ -4314,162 +4936,139 @@ static int got_IsInSync(struct drbd_conf *mdev, struct p_header80 *h)
4314 dec_rs_pending(mdev); 4936 dec_rs_pending(mdev);
4315 atomic_add(blksize >> 9, &mdev->rs_sect_in); 4937 atomic_add(blksize >> 9, &mdev->rs_sect_in);
4316 4938
4317 return true; 4939 return 0;
4318}
4319
4320/* when we receive the ACK for a write request,
4321 * verify that we actually know about it */
4322static struct drbd_request *_ack_id_to_req(struct drbd_conf *mdev,
4323 u64 id, sector_t sector)
4324{
4325 struct hlist_head *slot = tl_hash_slot(mdev, sector);
4326 struct hlist_node *n;
4327 struct drbd_request *req;
4328
4329 hlist_for_each_entry(req, n, slot, collision) {
4330 if ((unsigned long)req == (unsigned long)id) {
4331 if (req->sector != sector) {
4332 dev_err(DEV, "_ack_id_to_req: found req %p but it has "
4333 "wrong sector (%llus versus %llus)\n", req,
4334 (unsigned long long)req->sector,
4335 (unsigned long long)sector);
4336 break;
4337 }
4338 return req;
4339 }
4340 }
4341 return NULL;
4342} 4940}
4343 4941
4344typedef struct drbd_request *(req_validator_fn) 4942static int
4345 (struct drbd_conf *mdev, u64 id, sector_t sector); 4943validate_req_change_req_state(struct drbd_conf *mdev, u64 id, sector_t sector,
4346 4944 struct rb_root *root, const char *func,
4347static int validate_req_change_req_state(struct drbd_conf *mdev, 4945 enum drbd_req_event what, bool missing_ok)
4348 u64 id, sector_t sector, req_validator_fn validator,
4349 const char *func, enum drbd_req_event what)
4350{ 4946{
4351 struct drbd_request *req; 4947 struct drbd_request *req;
4352 struct bio_and_error m; 4948 struct bio_and_error m;
4353 4949
4354 spin_lock_irq(&mdev->req_lock); 4950 spin_lock_irq(&mdev->tconn->req_lock);
4355 req = validator(mdev, id, sector); 4951 req = find_request(mdev, root, id, sector, missing_ok, func);
4356 if (unlikely(!req)) { 4952 if (unlikely(!req)) {
4357 spin_unlock_irq(&mdev->req_lock); 4953 spin_unlock_irq(&mdev->tconn->req_lock);
4358 4954 return -EIO;
4359 dev_err(DEV, "%s: failed to find req %p, sector %llus\n", func,
4360 (void *)(unsigned long)id, (unsigned long long)sector);
4361 return false;
4362 } 4955 }
4363 __req_mod(req, what, &m); 4956 __req_mod(req, what, &m);
4364 spin_unlock_irq(&mdev->req_lock); 4957 spin_unlock_irq(&mdev->tconn->req_lock);
4365 4958
4366 if (m.bio) 4959 if (m.bio)
4367 complete_master_bio(mdev, &m); 4960 complete_master_bio(mdev, &m);
4368 return true; 4961 return 0;
4369} 4962}
4370 4963
4371static int got_BlockAck(struct drbd_conf *mdev, struct p_header80 *h) 4964static int got_BlockAck(struct drbd_tconn *tconn, struct packet_info *pi)
4372{ 4965{
4373 struct p_block_ack *p = (struct p_block_ack *)h; 4966 struct drbd_conf *mdev;
4967 struct p_block_ack *p = pi->data;
4374 sector_t sector = be64_to_cpu(p->sector); 4968 sector_t sector = be64_to_cpu(p->sector);
4375 int blksize = be32_to_cpu(p->blksize); 4969 int blksize = be32_to_cpu(p->blksize);
4376 enum drbd_req_event what; 4970 enum drbd_req_event what;
4377 4971
4972 mdev = vnr_to_mdev(tconn, pi->vnr);
4973 if (!mdev)
4974 return -EIO;
4975
4378 update_peer_seq(mdev, be32_to_cpu(p->seq_num)); 4976 update_peer_seq(mdev, be32_to_cpu(p->seq_num));
4379 4977
4380 if (is_syncer_block_id(p->block_id)) { 4978 if (p->block_id == ID_SYNCER) {
4381 drbd_set_in_sync(mdev, sector, blksize); 4979 drbd_set_in_sync(mdev, sector, blksize);
4382 dec_rs_pending(mdev); 4980 dec_rs_pending(mdev);
4383 return true; 4981 return 0;
4384 } 4982 }
4385 switch (be16_to_cpu(h->command)) { 4983 switch (pi->cmd) {
4386 case P_RS_WRITE_ACK: 4984 case P_RS_WRITE_ACK:
4387 D_ASSERT(mdev->net_conf->wire_protocol == DRBD_PROT_C); 4985 what = WRITE_ACKED_BY_PEER_AND_SIS;
4388 what = write_acked_by_peer_and_sis;
4389 break; 4986 break;
4390 case P_WRITE_ACK: 4987 case P_WRITE_ACK:
4391 D_ASSERT(mdev->net_conf->wire_protocol == DRBD_PROT_C); 4988 what = WRITE_ACKED_BY_PEER;
4392 what = write_acked_by_peer;
4393 break; 4989 break;
4394 case P_RECV_ACK: 4990 case P_RECV_ACK:
4395 D_ASSERT(mdev->net_conf->wire_protocol == DRBD_PROT_B); 4991 what = RECV_ACKED_BY_PEER;
4396 what = recv_acked_by_peer; 4992 break;
4993 case P_SUPERSEDED:
4994 what = CONFLICT_RESOLVED;
4397 break; 4995 break;
4398 case P_DISCARD_ACK: 4996 case P_RETRY_WRITE:
4399 D_ASSERT(mdev->net_conf->wire_protocol == DRBD_PROT_C); 4997 what = POSTPONE_WRITE;
4400 what = conflict_discarded_by_peer;
4401 break; 4998 break;
4402 default: 4999 default:
4403 D_ASSERT(0); 5000 BUG();
4404 return false;
4405 } 5001 }
4406 5002
4407 return validate_req_change_req_state(mdev, p->block_id, sector, 5003 return validate_req_change_req_state(mdev, p->block_id, sector,
4408 _ack_id_to_req, __func__ , what); 5004 &mdev->write_requests, __func__,
5005 what, false);
4409} 5006}
4410 5007
4411static int got_NegAck(struct drbd_conf *mdev, struct p_header80 *h) 5008static int got_NegAck(struct drbd_tconn *tconn, struct packet_info *pi)
4412{ 5009{
4413 struct p_block_ack *p = (struct p_block_ack *)h; 5010 struct drbd_conf *mdev;
5011 struct p_block_ack *p = pi->data;
4414 sector_t sector = be64_to_cpu(p->sector); 5012 sector_t sector = be64_to_cpu(p->sector);
4415 int size = be32_to_cpu(p->blksize); 5013 int size = be32_to_cpu(p->blksize);
4416 struct drbd_request *req; 5014 int err;
4417 struct bio_and_error m; 5015
5016 mdev = vnr_to_mdev(tconn, pi->vnr);
5017 if (!mdev)
5018 return -EIO;
4418 5019
4419 update_peer_seq(mdev, be32_to_cpu(p->seq_num)); 5020 update_peer_seq(mdev, be32_to_cpu(p->seq_num));
4420 5021
4421 if (is_syncer_block_id(p->block_id)) { 5022 if (p->block_id == ID_SYNCER) {
4422 dec_rs_pending(mdev); 5023 dec_rs_pending(mdev);
4423 drbd_rs_failed_io(mdev, sector, size); 5024 drbd_rs_failed_io(mdev, sector, size);
4424 return true; 5025 return 0;
4425 } 5026 }
4426 5027
4427 spin_lock_irq(&mdev->req_lock); 5028 err = validate_req_change_req_state(mdev, p->block_id, sector,
4428 req = _ack_id_to_req(mdev, p->block_id, sector); 5029 &mdev->write_requests, __func__,
4429 if (!req) { 5030 NEG_ACKED, true);
4430 spin_unlock_irq(&mdev->req_lock); 5031 if (err) {
4431 if (mdev->net_conf->wire_protocol == DRBD_PROT_A || 5032 /* Protocol A has no P_WRITE_ACKs, but has P_NEG_ACKs.
4432 mdev->net_conf->wire_protocol == DRBD_PROT_B) { 5033 The master bio might already be completed, therefore the
4433 /* Protocol A has no P_WRITE_ACKs, but has P_NEG_ACKs. 5034 request is no longer in the collision hash. */
4434 The master bio might already be completed, therefore the 5035 /* In Protocol B we might already have got a P_RECV_ACK
4435 request is no longer in the collision hash. 5036 but then get a P_NEG_ACK afterwards. */
4436 => Do not try to validate block_id as request. */ 5037 drbd_set_out_of_sync(mdev, sector, size);
4437 /* In Protocol B we might already have got a P_RECV_ACK
4438 but then get a P_NEG_ACK after wards. */
4439 drbd_set_out_of_sync(mdev, sector, size);
4440 return true;
4441 } else {
4442 dev_err(DEV, "%s: failed to find req %p, sector %llus\n", __func__,
4443 (void *)(unsigned long)p->block_id, (unsigned long long)sector);
4444 return false;
4445 }
4446 } 5038 }
4447 __req_mod(req, neg_acked, &m); 5039 return 0;
4448 spin_unlock_irq(&mdev->req_lock);
4449
4450 if (m.bio)
4451 complete_master_bio(mdev, &m);
4452 return true;
4453} 5040}
4454 5041
4455static int got_NegDReply(struct drbd_conf *mdev, struct p_header80 *h) 5042static int got_NegDReply(struct drbd_tconn *tconn, struct packet_info *pi)
4456{ 5043{
4457 struct p_block_ack *p = (struct p_block_ack *)h; 5044 struct drbd_conf *mdev;
5045 struct p_block_ack *p = pi->data;
4458 sector_t sector = be64_to_cpu(p->sector); 5046 sector_t sector = be64_to_cpu(p->sector);
4459 5047
5048 mdev = vnr_to_mdev(tconn, pi->vnr);
5049 if (!mdev)
5050 return -EIO;
5051
4460 update_peer_seq(mdev, be32_to_cpu(p->seq_num)); 5052 update_peer_seq(mdev, be32_to_cpu(p->seq_num));
4461 dev_err(DEV, "Got NegDReply; Sector %llus, len %u; Fail original request.\n", 5053
5054 dev_err(DEV, "Got NegDReply; Sector %llus, len %u.\n",
4462 (unsigned long long)sector, be32_to_cpu(p->blksize)); 5055 (unsigned long long)sector, be32_to_cpu(p->blksize));
4463 5056
4464 return validate_req_change_req_state(mdev, p->block_id, sector, 5057 return validate_req_change_req_state(mdev, p->block_id, sector,
4465 _ar_id_to_req, __func__ , neg_acked); 5058 &mdev->read_requests, __func__,
5059 NEG_ACKED, false);
4466} 5060}
4467 5061
4468static int got_NegRSDReply(struct drbd_conf *mdev, struct p_header80 *h) 5062static int got_NegRSDReply(struct drbd_tconn *tconn, struct packet_info *pi)
4469{ 5063{
5064 struct drbd_conf *mdev;
4470 sector_t sector; 5065 sector_t sector;
4471 int size; 5066 int size;
4472 struct p_block_ack *p = (struct p_block_ack *)h; 5067 struct p_block_ack *p = pi->data;
5068
5069 mdev = vnr_to_mdev(tconn, pi->vnr);
5070 if (!mdev)
5071 return -EIO;
4473 5072
4474 sector = be64_to_cpu(p->sector); 5073 sector = be64_to_cpu(p->sector);
4475 size = be32_to_cpu(p->blksize); 5074 size = be32_to_cpu(p->blksize);
@@ -4480,57 +5079,66 @@ static int got_NegRSDReply(struct drbd_conf *mdev, struct p_header80 *h)
4480 5079
4481 if (get_ldev_if_state(mdev, D_FAILED)) { 5080 if (get_ldev_if_state(mdev, D_FAILED)) {
4482 drbd_rs_complete_io(mdev, sector); 5081 drbd_rs_complete_io(mdev, sector);
4483 switch (be16_to_cpu(h->command)) { 5082 switch (pi->cmd) {
4484 case P_NEG_RS_DREPLY: 5083 case P_NEG_RS_DREPLY:
4485 drbd_rs_failed_io(mdev, sector, size); 5084 drbd_rs_failed_io(mdev, sector, size);
4486 case P_RS_CANCEL: 5085 case P_RS_CANCEL:
4487 break; 5086 break;
4488 default: 5087 default:
4489 D_ASSERT(0); 5088 BUG();
4490 put_ldev(mdev);
4491 return false;
4492 } 5089 }
4493 put_ldev(mdev); 5090 put_ldev(mdev);
4494 } 5091 }
4495 5092
4496 return true; 5093 return 0;
4497} 5094}
4498 5095
4499static int got_BarrierAck(struct drbd_conf *mdev, struct p_header80 *h) 5096static int got_BarrierAck(struct drbd_tconn *tconn, struct packet_info *pi)
4500{ 5097{
4501 struct p_barrier_ack *p = (struct p_barrier_ack *)h; 5098 struct p_barrier_ack *p = pi->data;
4502 5099 struct drbd_conf *mdev;
4503 tl_release(mdev, p->barrier, be32_to_cpu(p->set_size)); 5100 int vnr;
4504 5101
4505 if (mdev->state.conn == C_AHEAD && 5102 tl_release(tconn, p->barrier, be32_to_cpu(p->set_size));
4506 atomic_read(&mdev->ap_in_flight) == 0 && 5103
4507 !drbd_test_and_set_flag(mdev, AHEAD_TO_SYNC_SOURCE)) { 5104 rcu_read_lock();
4508 mdev->start_resync_timer.expires = jiffies + HZ; 5105 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
4509 add_timer(&mdev->start_resync_timer); 5106 if (mdev->state.conn == C_AHEAD &&
5107 atomic_read(&mdev->ap_in_flight) == 0 &&
5108 !test_and_set_bit(AHEAD_TO_SYNC_SOURCE, &mdev->flags)) {
5109 mdev->start_resync_timer.expires = jiffies + HZ;
5110 add_timer(&mdev->start_resync_timer);
5111 }
4510 } 5112 }
5113 rcu_read_unlock();
4511 5114
4512 return true; 5115 return 0;
4513} 5116}
4514 5117
4515static int got_OVResult(struct drbd_conf *mdev, struct p_header80 *h) 5118static int got_OVResult(struct drbd_tconn *tconn, struct packet_info *pi)
4516{ 5119{
4517 struct p_block_ack *p = (struct p_block_ack *)h; 5120 struct drbd_conf *mdev;
5121 struct p_block_ack *p = pi->data;
4518 struct drbd_work *w; 5122 struct drbd_work *w;
4519 sector_t sector; 5123 sector_t sector;
4520 int size; 5124 int size;
4521 5125
5126 mdev = vnr_to_mdev(tconn, pi->vnr);
5127 if (!mdev)
5128 return -EIO;
5129
4522 sector = be64_to_cpu(p->sector); 5130 sector = be64_to_cpu(p->sector);
4523 size = be32_to_cpu(p->blksize); 5131 size = be32_to_cpu(p->blksize);
4524 5132
4525 update_peer_seq(mdev, be32_to_cpu(p->seq_num)); 5133 update_peer_seq(mdev, be32_to_cpu(p->seq_num));
4526 5134
4527 if (be64_to_cpu(p->block_id) == ID_OUT_OF_SYNC) 5135 if (be64_to_cpu(p->block_id) == ID_OUT_OF_SYNC)
4528 drbd_ov_oos_found(mdev, sector, size); 5136 drbd_ov_out_of_sync_found(mdev, sector, size);
4529 else 5137 else
4530 ov_oos_print(mdev); 5138 ov_out_of_sync_print(mdev);
4531 5139
4532 if (!get_ldev(mdev)) 5140 if (!get_ldev(mdev))
4533 return true; 5141 return 0;
4534 5142
4535 drbd_rs_complete_io(mdev, sector); 5143 drbd_rs_complete_io(mdev, sector);
4536 dec_rs_pending(mdev); 5144 dec_rs_pending(mdev);
@@ -4545,114 +5153,137 @@ static int got_OVResult(struct drbd_conf *mdev, struct p_header80 *h)
4545 w = kmalloc(sizeof(*w), GFP_NOIO); 5153 w = kmalloc(sizeof(*w), GFP_NOIO);
4546 if (w) { 5154 if (w) {
4547 w->cb = w_ov_finished; 5155 w->cb = w_ov_finished;
4548 drbd_queue_work_front(&mdev->data.work, w); 5156 w->mdev = mdev;
5157 drbd_queue_work(&mdev->tconn->sender_work, w);
4549 } else { 5158 } else {
4550 dev_err(DEV, "kmalloc(w) failed."); 5159 dev_err(DEV, "kmalloc(w) failed.");
4551 ov_oos_print(mdev); 5160 ov_out_of_sync_print(mdev);
4552 drbd_resync_finished(mdev); 5161 drbd_resync_finished(mdev);
4553 } 5162 }
4554 } 5163 }
4555 put_ldev(mdev); 5164 put_ldev(mdev);
4556 return true; 5165 return 0;
4557} 5166}
4558 5167
4559static int got_skip(struct drbd_conf *mdev, struct p_header80 *h) 5168static int got_skip(struct drbd_tconn *tconn, struct packet_info *pi)
4560{ 5169{
4561 return true; 5170 return 0;
5171}
5172
5173static int tconn_finish_peer_reqs(struct drbd_tconn *tconn)
5174{
5175 struct drbd_conf *mdev;
5176 int vnr, not_empty = 0;
5177
5178 do {
5179 clear_bit(SIGNAL_ASENDER, &tconn->flags);
5180 flush_signals(current);
5181
5182 rcu_read_lock();
5183 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
5184 kref_get(&mdev->kref);
5185 rcu_read_unlock();
5186 if (drbd_finish_peer_reqs(mdev)) {
5187 kref_put(&mdev->kref, &drbd_minor_destroy);
5188 return 1;
5189 }
5190 kref_put(&mdev->kref, &drbd_minor_destroy);
5191 rcu_read_lock();
5192 }
5193 set_bit(SIGNAL_ASENDER, &tconn->flags);
5194
5195 spin_lock_irq(&tconn->req_lock);
5196 idr_for_each_entry(&tconn->volumes, mdev, vnr) {
5197 not_empty = !list_empty(&mdev->done_ee);
5198 if (not_empty)
5199 break;
5200 }
5201 spin_unlock_irq(&tconn->req_lock);
5202 rcu_read_unlock();
5203 } while (not_empty);
5204
5205 return 0;
4562} 5206}
4563 5207
4564struct asender_cmd { 5208struct asender_cmd {
4565 size_t pkt_size; 5209 size_t pkt_size;
4566 int (*process)(struct drbd_conf *mdev, struct p_header80 *h); 5210 int (*fn)(struct drbd_tconn *tconn, struct packet_info *);
4567}; 5211};
4568 5212
4569static struct asender_cmd *get_asender_cmd(int cmd) 5213static struct asender_cmd asender_tbl[] = {
4570{ 5214 [P_PING] = { 0, got_Ping },
4571 static struct asender_cmd asender_tbl[] = { 5215 [P_PING_ACK] = { 0, got_PingAck },
4572 /* anything missing from this table is in
4573 * the drbd_cmd_handler (drbd_default_handler) table,
4574 * see the beginning of drbdd() */
4575 [P_PING] = { sizeof(struct p_header80), got_Ping },
4576 [P_PING_ACK] = { sizeof(struct p_header80), got_PingAck },
4577 [P_RECV_ACK] = { sizeof(struct p_block_ack), got_BlockAck }, 5216 [P_RECV_ACK] = { sizeof(struct p_block_ack), got_BlockAck },
4578 [P_WRITE_ACK] = { sizeof(struct p_block_ack), got_BlockAck }, 5217 [P_WRITE_ACK] = { sizeof(struct p_block_ack), got_BlockAck },
4579 [P_RS_WRITE_ACK] = { sizeof(struct p_block_ack), got_BlockAck }, 5218 [P_RS_WRITE_ACK] = { sizeof(struct p_block_ack), got_BlockAck },
4580 [P_DISCARD_ACK] = { sizeof(struct p_block_ack), got_BlockAck }, 5219 [P_SUPERSEDED] = { sizeof(struct p_block_ack), got_BlockAck },
4581 [P_NEG_ACK] = { sizeof(struct p_block_ack), got_NegAck }, 5220 [P_NEG_ACK] = { sizeof(struct p_block_ack), got_NegAck },
4582 [P_NEG_DREPLY] = { sizeof(struct p_block_ack), got_NegDReply }, 5221 [P_NEG_DREPLY] = { sizeof(struct p_block_ack), got_NegDReply },
4583 [P_NEG_RS_DREPLY] = { sizeof(struct p_block_ack), got_NegRSDReply}, 5222 [P_NEG_RS_DREPLY] = { sizeof(struct p_block_ack), got_NegRSDReply },
4584 [P_OV_RESULT] = { sizeof(struct p_block_ack), got_OVResult }, 5223 [P_OV_RESULT] = { sizeof(struct p_block_ack), got_OVResult },
4585 [P_BARRIER_ACK] = { sizeof(struct p_barrier_ack), got_BarrierAck }, 5224 [P_BARRIER_ACK] = { sizeof(struct p_barrier_ack), got_BarrierAck },
4586 [P_STATE_CHG_REPLY] = { sizeof(struct p_req_state_reply), got_RqSReply }, 5225 [P_STATE_CHG_REPLY] = { sizeof(struct p_req_state_reply), got_RqSReply },
4587 [P_RS_IS_IN_SYNC] = { sizeof(struct p_block_ack), got_IsInSync }, 5226 [P_RS_IS_IN_SYNC] = { sizeof(struct p_block_ack), got_IsInSync },
4588 [P_DELAY_PROBE] = { sizeof(struct p_delay_probe93), got_skip }, 5227 [P_DELAY_PROBE] = { sizeof(struct p_delay_probe93), got_skip },
4589 [P_RS_CANCEL] = { sizeof(struct p_block_ack), got_NegRSDReply}, 5228 [P_RS_CANCEL] = { sizeof(struct p_block_ack), got_NegRSDReply },
4590 [P_MAX_CMD] = { 0, NULL }, 5229 [P_CONN_ST_CHG_REPLY]={ sizeof(struct p_req_state_reply), got_conn_RqSReply },
4591 }; 5230 [P_RETRY_WRITE] = { sizeof(struct p_block_ack), got_BlockAck },
4592 if (cmd > P_MAX_CMD || asender_tbl[cmd].process == NULL) 5231};
4593 return NULL;
4594 return &asender_tbl[cmd];
4595}
4596 5232
4597int drbd_asender(struct drbd_thread *thi) 5233int drbd_asender(struct drbd_thread *thi)
4598{ 5234{
4599 struct drbd_conf *mdev = thi->mdev; 5235 struct drbd_tconn *tconn = thi->tconn;
4600 struct p_header80 *h = &mdev->meta.rbuf.header.h80;
4601 struct asender_cmd *cmd = NULL; 5236 struct asender_cmd *cmd = NULL;
4602 5237 struct packet_info pi;
4603 int rv, len; 5238 int rv;
4604 void *buf = h; 5239 void *buf = tconn->meta.rbuf;
4605 int received = 0; 5240 int received = 0;
4606 int expect = sizeof(struct p_header80); 5241 unsigned int header_size = drbd_header_size(tconn);
4607 int empty; 5242 int expect = header_size;
4608 int ping_timeout_active = 0; 5243 bool ping_timeout_active = false;
4609 5244 struct net_conf *nc;
4610 sprintf(current->comm, "drbd%d_asender", mdev_to_minor(mdev)); 5245 int ping_timeo, tcp_cork, ping_int;
4611 5246
4612 current->policy = SCHED_RR; /* Make this a realtime task! */ 5247 current->policy = SCHED_RR; /* Make this a realtime task! */
4613 current->rt_priority = 2; /* more important than all other tasks */ 5248 current->rt_priority = 2; /* more important than all other tasks */
4614 5249
4615 while (get_t_state(thi) == Running) { 5250 while (get_t_state(thi) == RUNNING) {
4616 drbd_thread_current_set_cpu(mdev); 5251 drbd_thread_current_set_cpu(thi);
4617 if (drbd_test_and_clear_flag(mdev, SEND_PING)) {
4618 ERR_IF(!drbd_send_ping(mdev)) goto reconnect;
4619 mdev->meta.socket->sk->sk_rcvtimeo =
4620 mdev->net_conf->ping_timeo*HZ/10;
4621 ping_timeout_active = 1;
4622 }
4623 5252
4624 /* conditionally cork; 5253 rcu_read_lock();
4625 * it may hurt latency if we cork without much to send */ 5254 nc = rcu_dereference(tconn->net_conf);
4626 if (!mdev->net_conf->no_cork && 5255 ping_timeo = nc->ping_timeo;
4627 3 < atomic_read(&mdev->unacked_cnt)) 5256 tcp_cork = nc->tcp_cork;
4628 drbd_tcp_cork(mdev->meta.socket); 5257 ping_int = nc->ping_int;
4629 while (1) { 5258 rcu_read_unlock();
4630 drbd_clear_flag(mdev, SIGNAL_ASENDER); 5259
4631 flush_signals(current); 5260 if (test_and_clear_bit(SEND_PING, &tconn->flags)) {
4632 if (!drbd_process_done_ee(mdev)) 5261 if (drbd_send_ping(tconn)) {
5262 conn_err(tconn, "drbd_send_ping has failed\n");
4633 goto reconnect; 5263 goto reconnect;
4634 /* to avoid race with newly queued ACKs */ 5264 }
4635 drbd_set_flag(mdev, SIGNAL_ASENDER); 5265 tconn->meta.socket->sk->sk_rcvtimeo = ping_timeo * HZ / 10;
4636 spin_lock_irq(&mdev->req_lock); 5266 ping_timeout_active = true;
4637 empty = list_empty(&mdev->done_ee); 5267 }
4638 spin_unlock_irq(&mdev->req_lock); 5268
4639 /* new ack may have been queued right here, 5269 /* TODO: conditionally cork; it may hurt latency if we cork without
4640 * but then there is also a signal pending, 5270 much to send */
4641 * and we start over... */ 5271 if (tcp_cork)
4642 if (empty) 5272 drbd_tcp_cork(tconn->meta.socket);
4643 break; 5273 if (tconn_finish_peer_reqs(tconn)) {
5274 conn_err(tconn, "tconn_finish_peer_reqs() failed\n");
5275 goto reconnect;
4644 } 5276 }
4645 /* but unconditionally uncork unless disabled */ 5277 /* but unconditionally uncork unless disabled */
4646 if (!mdev->net_conf->no_cork) 5278 if (tcp_cork)
4647 drbd_tcp_uncork(mdev->meta.socket); 5279 drbd_tcp_uncork(tconn->meta.socket);
4648 5280
4649 /* short circuit, recv_msg would return EINTR anyways. */ 5281 /* short circuit, recv_msg would return EINTR anyways. */
4650 if (signal_pending(current)) 5282 if (signal_pending(current))
4651 continue; 5283 continue;
4652 5284
4653 rv = drbd_recv_short(mdev, mdev->meta.socket, 5285 rv = drbd_recv_short(tconn->meta.socket, buf, expect-received, 0);
4654 buf, expect-received, 0); 5286 clear_bit(SIGNAL_ASENDER, &tconn->flags);
4655 drbd_clear_flag(mdev, SIGNAL_ASENDER);
4656 5287
4657 flush_signals(current); 5288 flush_signals(current);
4658 5289
@@ -4670,87 +5301,91 @@ int drbd_asender(struct drbd_thread *thi)
4670 received += rv; 5301 received += rv;
4671 buf += rv; 5302 buf += rv;
4672 } else if (rv == 0) { 5303 } else if (rv == 0) {
4673 if (drbd_test_flag(mdev, DISCONNECT_SENT)) { 5304 if (test_bit(DISCONNECT_SENT, &tconn->flags)) {
4674 long t; /* time_left */ 5305 long t;
4675 t = wait_event_timeout(mdev->state_wait, mdev->state.conn < C_CONNECTED, 5306 rcu_read_lock();
4676 mdev->net_conf->ping_timeo * HZ/10); 5307 t = rcu_dereference(tconn->net_conf)->ping_timeo * HZ/10;
5308 rcu_read_unlock();
5309
5310 t = wait_event_timeout(tconn->ping_wait,
5311 tconn->cstate < C_WF_REPORT_PARAMS,
5312 t);
4677 if (t) 5313 if (t)
4678 break; 5314 break;
4679 } 5315 }
4680 dev_err(DEV, "meta connection shut down by peer.\n"); 5316 conn_err(tconn, "meta connection shut down by peer.\n");
4681 goto reconnect; 5317 goto reconnect;
4682 } else if (rv == -EAGAIN) { 5318 } else if (rv == -EAGAIN) {
4683 /* If the data socket received something meanwhile, 5319 /* If the data socket received something meanwhile,
4684 * that is good enough: peer is still alive. */ 5320 * that is good enough: peer is still alive. */
4685 if (time_after(mdev->last_received, 5321 if (time_after(tconn->last_received,
4686 jiffies - mdev->meta.socket->sk->sk_rcvtimeo)) 5322 jiffies - tconn->meta.socket->sk->sk_rcvtimeo))
4687 continue; 5323 continue;
4688 if (ping_timeout_active) { 5324 if (ping_timeout_active) {
4689 dev_err(DEV, "PingAck did not arrive in time.\n"); 5325 conn_err(tconn, "PingAck did not arrive in time.\n");
4690 goto reconnect; 5326 goto reconnect;
4691 } 5327 }
4692 drbd_set_flag(mdev, SEND_PING); 5328 set_bit(SEND_PING, &tconn->flags);
4693 continue; 5329 continue;
4694 } else if (rv == -EINTR) { 5330 } else if (rv == -EINTR) {
4695 continue; 5331 continue;
4696 } else { 5332 } else {
4697 dev_err(DEV, "sock_recvmsg returned %d\n", rv); 5333 conn_err(tconn, "sock_recvmsg returned %d\n", rv);
4698 goto reconnect; 5334 goto reconnect;
4699 } 5335 }
4700 5336
4701 if (received == expect && cmd == NULL) { 5337 if (received == expect && cmd == NULL) {
4702 if (unlikely(h->magic != BE_DRBD_MAGIC)) { 5338 if (decode_header(tconn, tconn->meta.rbuf, &pi))
4703 dev_err(DEV, "magic?? on meta m: 0x%08x c: %d l: %d\n",
4704 be32_to_cpu(h->magic),
4705 be16_to_cpu(h->command),
4706 be16_to_cpu(h->length));
4707 goto reconnect; 5339 goto reconnect;
4708 } 5340 cmd = &asender_tbl[pi.cmd];
4709 cmd = get_asender_cmd(be16_to_cpu(h->command)); 5341 if (pi.cmd >= ARRAY_SIZE(asender_tbl) || !cmd->fn) {
4710 len = be16_to_cpu(h->length); 5342 conn_err(tconn, "Unexpected meta packet %s (0x%04x)\n",
4711 if (unlikely(cmd == NULL)) { 5343 cmdname(pi.cmd), pi.cmd);
4712 dev_err(DEV, "unknown command?? on meta m: 0x%08x c: %d l: %d\n",
4713 be32_to_cpu(h->magic),
4714 be16_to_cpu(h->command),
4715 be16_to_cpu(h->length));
4716 goto disconnect; 5344 goto disconnect;
4717 } 5345 }
4718 expect = cmd->pkt_size; 5346 expect = header_size + cmd->pkt_size;
4719 ERR_IF(len != expect-sizeof(struct p_header80)) 5347 if (pi.size != expect - header_size) {
5348 conn_err(tconn, "Wrong packet size on meta (c: %d, l: %d)\n",
5349 pi.cmd, pi.size);
4720 goto reconnect; 5350 goto reconnect;
5351 }
4721 } 5352 }
4722 if (received == expect) { 5353 if (received == expect) {
4723 mdev->last_received = jiffies; 5354 bool err;
4724 D_ASSERT(cmd != NULL); 5355
4725 if (!cmd->process(mdev, h)) 5356 err = cmd->fn(tconn, &pi);
5357 if (err) {
5358 conn_err(tconn, "%pf failed\n", cmd->fn);
4726 goto reconnect; 5359 goto reconnect;
5360 }
5361
5362 tconn->last_received = jiffies;
4727 5363
4728 /* the idle_timeout (ping-int) 5364 if (cmd == &asender_tbl[P_PING_ACK]) {
4729 * has been restored in got_PingAck() */ 5365 /* restore idle timeout */
4730 if (cmd == get_asender_cmd(P_PING_ACK)) 5366 tconn->meta.socket->sk->sk_rcvtimeo = ping_int * HZ;
4731 ping_timeout_active = 0; 5367 ping_timeout_active = false;
5368 }
4732 5369
4733 buf = h; 5370 buf = tconn->meta.rbuf;
4734 received = 0; 5371 received = 0;
4735 expect = sizeof(struct p_header80); 5372 expect = header_size;
4736 cmd = NULL; 5373 cmd = NULL;
4737 } 5374 }
4738 } 5375 }
4739 5376
4740 if (0) { 5377 if (0) {
4741reconnect: 5378reconnect:
4742 drbd_force_state(mdev, NS(conn, C_NETWORK_FAILURE)); 5379 conn_request_state(tconn, NS(conn, C_NETWORK_FAILURE), CS_HARD);
4743 drbd_md_sync(mdev); 5380 conn_md_sync(tconn);
4744 } 5381 }
4745 if (0) { 5382 if (0) {
4746disconnect: 5383disconnect:
4747 drbd_force_state(mdev, NS(conn, C_DISCONNECTING)); 5384 conn_request_state(tconn, NS(conn, C_DISCONNECTING), CS_HARD);
4748 drbd_md_sync(mdev);
4749 } 5385 }
4750 drbd_clear_flag(mdev, SIGNAL_ASENDER); 5386 clear_bit(SIGNAL_ASENDER, &tconn->flags);
4751 5387
4752 D_ASSERT(mdev->state.conn < C_CONNECTED); 5388 conn_info(tconn, "asender terminated\n");
4753 dev_info(DEV, "asender terminated\n");
4754 5389
4755 return 0; 5390 return 0;
4756} 5391}