diff options
author | Stephen M. Cameron <scameron@beardog.cce.hp.com> | 2011-05-03 15:54:07 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2011-05-06 10:23:58 -0400 |
commit | 063d2cf72ab6101d2dd69bd6fb503b229be70325 (patch) | |
tree | eb818014e9510bc372eae990e3b102caf0504ee8 /drivers/block/cciss.c | |
parent | ec52d5f1cb9a1a0db02143fdcc6004749ea19e0b (diff) |
cciss: do not use bit 2 doorbell reset
It causes NMIs which are undesirable at best, unsurvivable at worst.
Prefer the soft reset instead.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Diffstat (limited to 'drivers/block/cciss.c')
-rw-r--r-- | drivers/block/cciss.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 865484e40841..9528e94dc8b2 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
@@ -4673,8 +4673,14 @@ static __devinit int cciss_kdump_hard_reset_controller(struct pci_dev *pdev) | |||
4673 | use_doorbell = DOORBELL_CTLR_RESET2; | 4673 | use_doorbell = DOORBELL_CTLR_RESET2; |
4674 | } else { | 4674 | } else { |
4675 | use_doorbell = misc_fw_support & MISC_FW_DOORBELL_RESET; | 4675 | use_doorbell = misc_fw_support & MISC_FW_DOORBELL_RESET; |
4676 | if (use_doorbell) | 4676 | if (use_doorbell) { |
4677 | use_doorbell = DOORBELL_CTLR_RESET; | 4677 | dev_warn(&pdev->dev, "Controller claims that " |
4678 | "'Bit 2 doorbell reset' is " | ||
4679 | "supported, but not 'bit 5 doorbell reset'. " | ||
4680 | "Firmware update is recommended.\n"); | ||
4681 | rc = -ENOTSUPP; /* use the soft reset */ | ||
4682 | goto unmap_cfgtable; | ||
4683 | } | ||
4678 | } | 4684 | } |
4679 | 4685 | ||
4680 | rc = cciss_controller_hard_reset(pdev, vaddr, use_doorbell); | 4686 | rc = cciss_controller_hard_reset(pdev, vaddr, use_doorbell); |