diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2011-11-16 10:28:16 -0500 |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2011-11-16 12:34:53 -0500 |
commit | e5e3b8abeda1cf45f5a079458dbc267952694c7a (patch) | |
tree | 46bd89885c027beaa4d549ea5f1d79f8a9279433 /drivers/base | |
parent | c2b1ecd13c6a7b19f1c0c48b68f61ab083f3ec3f (diff) |
regmap: Move initialization of regcache related fields to regcache_init
Move the initialization regcache related fields of the regmap struct to
regcache_init. This allows us to keep regmap and regcache code better
separated.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/base')
-rw-r--r-- | drivers/base/regmap/internal.h | 2 | ||||
-rw-r--r-- | drivers/base/regmap/regcache.c | 9 | ||||
-rw-r--r-- | drivers/base/regmap/regmap.c | 8 |
3 files changed, 10 insertions, 9 deletions
diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index 6483e0bda0cf..954f7b73238f 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap/internal.h | |||
@@ -106,7 +106,7 @@ static inline void regmap_debugfs_exit(struct regmap *map) { } | |||
106 | #endif | 106 | #endif |
107 | 107 | ||
108 | /* regcache core declarations */ | 108 | /* regcache core declarations */ |
109 | int regcache_init(struct regmap *map); | 109 | int regcache_init(struct regmap *map, const struct regmap_config *config); |
110 | void regcache_exit(struct regmap *map); | 110 | void regcache_exit(struct regmap *map); |
111 | int regcache_read(struct regmap *map, | 111 | int regcache_read(struct regmap *map, |
112 | unsigned int reg, unsigned int *value); | 112 | unsigned int reg, unsigned int *value); |
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index 27fae58ff4cb..0ad6cfb2c8cc 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c | |||
@@ -87,7 +87,7 @@ err_free: | |||
87 | return ret; | 87 | return ret; |
88 | } | 88 | } |
89 | 89 | ||
90 | int regcache_init(struct regmap *map) | 90 | int regcache_init(struct regmap *map, const struct regmap_config *config) |
91 | { | 91 | { |
92 | int ret; | 92 | int ret; |
93 | int i; | 93 | int i; |
@@ -108,6 +108,13 @@ int regcache_init(struct regmap *map) | |||
108 | return -EINVAL; | 108 | return -EINVAL; |
109 | } | 109 | } |
110 | 110 | ||
111 | map->reg_defaults = config->reg_defaults; | ||
112 | map->num_reg_defaults = config->num_reg_defaults; | ||
113 | map->num_reg_defaults_raw = config->num_reg_defaults_raw; | ||
114 | map->reg_defaults_raw = config->reg_defaults_raw; | ||
115 | map->cache_size_raw = (config->val_bits / 8) * config->num_reg_defaults_raw; | ||
116 | map->cache_word_size = config->val_bits / 8; | ||
117 | |||
111 | map->cache = NULL; | 118 | map->cache = NULL; |
112 | map->cache_ops = cache_types[i]; | 119 | map->cache_ops = cache_types[i]; |
113 | 120 | ||
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index b84ebf9eecf0..3cf4785c3afe 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c | |||
@@ -159,12 +159,6 @@ struct regmap *regmap_init(struct device *dev, | |||
159 | map->volatile_reg = config->volatile_reg; | 159 | map->volatile_reg = config->volatile_reg; |
160 | map->precious_reg = config->precious_reg; | 160 | map->precious_reg = config->precious_reg; |
161 | map->cache_type = config->cache_type; | 161 | map->cache_type = config->cache_type; |
162 | map->reg_defaults = config->reg_defaults; | ||
163 | map->num_reg_defaults = config->num_reg_defaults; | ||
164 | map->num_reg_defaults_raw = config->num_reg_defaults_raw; | ||
165 | map->reg_defaults_raw = config->reg_defaults_raw; | ||
166 | map->cache_size_raw = (config->val_bits / 8) * config->num_reg_defaults_raw; | ||
167 | map->cache_word_size = config->val_bits / 8; | ||
168 | 162 | ||
169 | if (config->read_flag_mask || config->write_flag_mask) { | 163 | if (config->read_flag_mask || config->write_flag_mask) { |
170 | map->read_flag_mask = config->read_flag_mask; | 164 | map->read_flag_mask = config->read_flag_mask; |
@@ -227,7 +221,7 @@ struct regmap *regmap_init(struct device *dev, | |||
227 | goto err_map; | 221 | goto err_map; |
228 | } | 222 | } |
229 | 223 | ||
230 | ret = regcache_init(map); | 224 | ret = regcache_init(map, config); |
231 | if (ret < 0) | 225 | if (ret < 0) |
232 | goto err_free_workbuf; | 226 | goto err_free_workbuf; |
233 | 227 | ||