aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/base
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2012-07-23 15:27:27 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2012-07-23 15:27:27 -0400
commita66d2c8f7ec1284206ca7c14569e2a607583f1e3 (patch)
tree08cf68bcef3559b370843cab8191e5cc0f740bde /drivers/base
parenta6be1fcbc57f95bb47ef3c8e4ee3d83731b8f21e (diff)
parent8cae6f7158ec1fa44c8a04a43db7d8020ec60437 (diff)
Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull the big VFS changes from Al Viro: "This one is *big* and changes quite a few things around VFS. What's in there: - the first of two really major architecture changes - death to open intents. The former is finally there; it was very long in making, but with Miklos getting through really hard and messy final push in fs/namei.c, we finally have it. Unlike his variant, this one doesn't introduce struct opendata; what we have instead is ->atomic_open() taking preallocated struct file * and passing everything via its fields. Instead of returning struct file *, it returns -E... on error, 0 on success and 1 in "deal with it yourself" case (e.g. symlink found on server, etc.). See comments before fs/namei.c:atomic_open(). That made a lot of goodies finally possible and quite a few are in that pile: ->lookup(), ->d_revalidate() and ->create() do not get struct nameidata * anymore; ->lookup() and ->d_revalidate() get lookup flags instead, ->create() gets "do we want it exclusive" flag. With the introduction of new helper (kern_path_locked()) we are rid of all struct nameidata instances outside of fs/namei.c; it's still visible in namei.h, but not for long. Come the next cycle, declaration will move either to fs/internal.h or to fs/namei.c itself. [me, miklos, hch] - The second major change: behaviour of final fput(). Now we have __fput() done without any locks held by caller *and* not from deep in call stack. That obviously lifts a lot of constraints on the locking in there. Moreover, it's legal now to call fput() from atomic contexts (which has immediately simplified life for aio.c). We also don't need anti-recursion logics in __scm_destroy() anymore. There is a price, though - the damn thing has become partially asynchronous. For fput() from normal process we are guaranteed that pending __fput() will be done before the caller returns to userland, exits or gets stopped for ptrace. For kernel threads and atomic contexts it's done via schedule_work(), so theoretically we might need a way to make sure it's finished; so far only one such place had been found, but there might be more. There's flush_delayed_fput() (do all pending __fput()) and there's __fput_sync() (fput() analog doing __fput() immediately). I hope we won't need them often; see warnings in fs/file_table.c for details. [me, based on task_work series from Oleg merged last cycle] - sync series from Jan - large part of "death to sync_supers()" work from Artem; the only bits missing here are exofs and ext4 ones. As far as I understand, those are going via the exofs and ext4 trees resp.; once they are in, we can put ->write_super() to the rest, along with the thread calling it. - preparatory bits from unionmount series (from dhowells). - assorted cleanups and fixes all over the place, as usual. This is not the last pile for this cycle; there's at least jlayton's ESTALE work and fsfreeze series (the latter - in dire need of fixes, so I'm not sure it'll make the cut this cycle). I'll probably throw symlink/hardlink restrictions stuff from Kees into the next pile, too. Plus there's a lot of misc patches I hadn't thrown into that one - it's large enough as it is..." * 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (127 commits) ext4: switch EXT4_IOC_RESIZE_FS to mnt_want_write_file() btrfs: switch btrfs_ioctl_balance() to mnt_want_write_file() switch dentry_open() to struct path, make it grab references itself spufs: shift dget/mntget towards dentry_open() zoran: don't bother with struct file * in zoran_map ecryptfs: don't reinvent the wheels, please - use struct completion don't expose I_NEW inodes via dentry->d_inode tidy up namei.c a bit unobfuscate follow_up() a bit ext3: pass custom EOF to generic_file_llseek_size() ext4: use core vfs llseek code for dir seeks vfs: allow custom EOF in generic_file_llseek code vfs: Avoid unnecessary WB_SYNC_NONE writeback during sys_sync and reorder sync passes vfs: Remove unnecessary flushing of block devices vfs: Make sys_sync writeout also block device inodes vfs: Create function for iterating over block devices vfs: Reorder operations during sys_sync quota: Move quota syncing to ->sync_fs method quota: Split dquot_quota_sync() to writeback and cache flushing part vfs: Move noop_backing_dev_info check from sync into writeback ...
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/devtmpfs.c98
1 files changed, 41 insertions, 57 deletions
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 765c3a28077a..d91a3a0b2325 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -227,33 +227,24 @@ static int handle_create(const char *nodename, umode_t mode, struct device *dev)
227 227
228static int dev_rmdir(const char *name) 228static int dev_rmdir(const char *name)
229{ 229{
230 struct nameidata nd; 230 struct path parent;
231 struct dentry *dentry; 231 struct dentry *dentry;
232 int err; 232 int err;
233 233
234 err = kern_path_parent(name, &nd); 234 dentry = kern_path_locked(name, &parent);
235 if (err) 235 if (IS_ERR(dentry))
236 return err; 236 return PTR_ERR(dentry);
237 237 if (dentry->d_inode) {
238 mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT); 238 if (dentry->d_inode->i_private == &thread)
239 dentry = lookup_one_len(nd.last.name, nd.path.dentry, nd.last.len); 239 err = vfs_rmdir(parent.dentry->d_inode, dentry);
240 if (!IS_ERR(dentry)) { 240 else
241 if (dentry->d_inode) { 241 err = -EPERM;
242 if (dentry->d_inode->i_private == &thread)
243 err = vfs_rmdir(nd.path.dentry->d_inode,
244 dentry);
245 else
246 err = -EPERM;
247 } else {
248 err = -ENOENT;
249 }
250 dput(dentry);
251 } else { 242 } else {
252 err = PTR_ERR(dentry); 243 err = -ENOENT;
253 } 244 }
254 245 dput(dentry);
255 mutex_unlock(&nd.path.dentry->d_inode->i_mutex); 246 mutex_unlock(&parent.dentry->d_inode->i_mutex);
256 path_put(&nd.path); 247 path_put(&parent);
257 return err; 248 return err;
258} 249}
259 250
@@ -305,50 +296,43 @@ static int dev_mynode(struct device *dev, struct inode *inode, struct kstat *sta
305 296
306static int handle_remove(const char *nodename, struct device *dev) 297static int handle_remove(const char *nodename, struct device *dev)
307{ 298{
308 struct nameidata nd; 299 struct path parent;
309 struct dentry *dentry; 300 struct dentry *dentry;
310 struct kstat stat;
311 int deleted = 1; 301 int deleted = 1;
312 int err; 302 int err;
313 303
314 err = kern_path_parent(nodename, &nd); 304 dentry = kern_path_locked(nodename, &parent);
315 if (err) 305 if (IS_ERR(dentry))
316 return err; 306 return PTR_ERR(dentry);
317 307
318 mutex_lock_nested(&nd.path.dentry->d_inode->i_mutex, I_MUTEX_PARENT); 308 if (dentry->d_inode) {
319 dentry = lookup_one_len(nd.last.name, nd.path.dentry, nd.last.len); 309 struct kstat stat;
320 if (!IS_ERR(dentry)) { 310 err = vfs_getattr(parent.mnt, dentry, &stat);
321 if (dentry->d_inode) { 311 if (!err && dev_mynode(dev, dentry->d_inode, &stat)) {
322 err = vfs_getattr(nd.path.mnt, dentry, &stat); 312 struct iattr newattrs;
323 if (!err && dev_mynode(dev, dentry->d_inode, &stat)) { 313 /*
324 struct iattr newattrs; 314 * before unlinking this node, reset permissions
325 /* 315 * of possible references like hardlinks
326 * before unlinking this node, reset permissions 316 */
327 * of possible references like hardlinks 317 newattrs.ia_uid = 0;
328 */ 318 newattrs.ia_gid = 0;
329 newattrs.ia_uid = 0; 319 newattrs.ia_mode = stat.mode & ~0777;
330 newattrs.ia_gid = 0; 320 newattrs.ia_valid =
331 newattrs.ia_mode = stat.mode & ~0777; 321 ATTR_UID|ATTR_GID|ATTR_MODE;
332 newattrs.ia_valid = 322 mutex_lock(&dentry->d_inode->i_mutex);
333 ATTR_UID|ATTR_GID|ATTR_MODE; 323 notify_change(dentry, &newattrs);
334 mutex_lock(&dentry->d_inode->i_mutex); 324 mutex_unlock(&dentry->d_inode->i_mutex);
335 notify_change(dentry, &newattrs); 325 err = vfs_unlink(parent.dentry->d_inode, dentry);
336 mutex_unlock(&dentry->d_inode->i_mutex); 326 if (!err || err == -ENOENT)
337 err = vfs_unlink(nd.path.dentry->d_inode, 327 deleted = 1;
338 dentry);
339 if (!err || err == -ENOENT)
340 deleted = 1;
341 }
342 } else {
343 err = -ENOENT;
344 } 328 }
345 dput(dentry);
346 } else { 329 } else {
347 err = PTR_ERR(dentry); 330 err = -ENOENT;
348 } 331 }
349 mutex_unlock(&nd.path.dentry->d_inode->i_mutex); 332 dput(dentry);
333 mutex_unlock(&parent.dentry->d_inode->i_mutex);
350 334
351 path_put(&nd.path); 335 path_put(&parent);
352 if (deleted && strchr(nodename, '/')) 336 if (deleted && strchr(nodename, '/'))
353 delete_path(nodename); 337 delete_path(nodename);
354 return err; 338 return err;