aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/base
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2008-12-16 15:23:36 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2009-03-24 19:38:25 -0400
commitfb069a5d132fb926ed17af3211a114ac7cf27d7a (patch)
treec104d9df7c83c27e3785265fb7412fd9332bc10a /drivers/base
parentb23530ebc339c4092ae2c9f37341a5398fea8b89 (diff)
driver core: create a private portion of struct device
This is to be used to move things out of struct device that no code outside of the driver core should ever touch. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/base.h12
-rw-r--r--drivers/base/core.c9
2 files changed, 21 insertions, 0 deletions
diff --git a/drivers/base/base.h b/drivers/base/base.h
index ca2b0376685b..62a2cb5e1780 100644
--- a/drivers/base/base.h
+++ b/drivers/base/base.h
@@ -63,6 +63,18 @@ struct class_private {
63#define to_class(obj) \ 63#define to_class(obj) \
64 container_of(obj, struct class_private, class_subsys.kobj) 64 container_of(obj, struct class_private, class_subsys.kobj)
65 65
66/**
67 * struct device_private - structure to hold the private to the driver core portions of the device structure.
68 *
69 * @device - pointer back to the struct class that this structure is
70 * associated with.
71 *
72 * Nothing outside of the driver core should ever touch these fields.
73 */
74struct device_private {
75 struct device *device;
76};
77
66/* initialisation functions */ 78/* initialisation functions */
67extern int devices_init(void); 79extern int devices_init(void);
68extern int buses_init(void); 80extern int buses_init(void);
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 059966b617f6..16d859910104 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -109,6 +109,7 @@ static struct sysfs_ops dev_sysfs_ops = {
109static void device_release(struct kobject *kobj) 109static void device_release(struct kobject *kobj)
110{ 110{
111 struct device *dev = to_dev(kobj); 111 struct device *dev = to_dev(kobj);
112 struct device_private *p = dev->p;
112 113
113 if (dev->release) 114 if (dev->release)
114 dev->release(dev); 115 dev->release(dev);
@@ -120,6 +121,7 @@ static void device_release(struct kobject *kobj)
120 WARN(1, KERN_ERR "Device '%s' does not have a release() " 121 WARN(1, KERN_ERR "Device '%s' does not have a release() "
121 "function, it is broken and must be fixed.\n", 122 "function, it is broken and must be fixed.\n",
122 dev_name(dev)); 123 dev_name(dev));
124 kfree(p);
123} 125}
124 126
125static struct kobj_type device_ktype = { 127static struct kobj_type device_ktype = {
@@ -859,6 +861,13 @@ int device_add(struct device *dev)
859 if (!dev) 861 if (!dev)
860 goto done; 862 goto done;
861 863
864 dev->p = kzalloc(sizeof(*dev->p), GFP_KERNEL);
865 if (!dev->p) {
866 error = -ENOMEM;
867 goto done;
868 }
869 dev->p->device = dev;
870
862 /* 871 /*
863 * for statically allocated devices, which should all be converted 872 * for statically allocated devices, which should all be converted
864 * some day, we need to initialize the name. We prevent reading back 873 * some day, we need to initialize the name. We prevent reading back