diff options
author | Kautuk Consul <consul.kautuk@gmail.com> | 2011-11-15 17:52:34 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-15 19:07:39 -0500 |
commit | 65e6757be42ddf0a9115ec0e6af268fec9727359 (patch) | |
tree | 78d757c6cad66bb9daf0c3136d5e92a15edb8432 /drivers/base/devtmpfs.c | |
parent | 72f8c0bfa0de64c68ee59f40eb9b2683bffffbb0 (diff) |
devtmpfsd: fix task state handling
- Set the state to TASK_INTERRUPTIBLE using __set_current_state()
instead of set_current_state() as the spin_unlock is an implicit memory
barrier.
- After return from schedule(), there is no need to set the current
state to TASK_RUNNING - a call to schedule() always returns in
TASK_RUNNING state.
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/base/devtmpfs.c')
-rw-r--r-- | drivers/base/devtmpfs.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index a4760e095ff5..2bb4bff3af7d 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c | |||
@@ -413,10 +413,9 @@ static int devtmpfsd(void *p) | |||
413 | } | 413 | } |
414 | spin_lock(&req_lock); | 414 | spin_lock(&req_lock); |
415 | } | 415 | } |
416 | set_current_state(TASK_INTERRUPTIBLE); | 416 | __set_current_state(TASK_INTERRUPTIBLE); |
417 | spin_unlock(&req_lock); | 417 | spin_unlock(&req_lock); |
418 | schedule(); | 418 | schedule(); |
419 | __set_current_state(TASK_RUNNING); | ||
420 | } | 419 | } |
421 | return 0; | 420 | return 0; |
422 | out: | 421 | out: |