diff options
author | Cornelia Huck <cornelia.huck@de.ibm.com> | 2007-02-05 19:15:26 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-04-27 13:57:29 -0400 |
commit | c6a46696f97ff260a4ecce5e287f8de4b9d7fe14 (patch) | |
tree | 335de50c9868cd575f535677e430677d33cbaaa1 /drivers/base/dd.c | |
parent | eed40d3ad2ba652c08422d62a5ff6f62ac0be16d (diff) |
driver core: don't fail attaching the device if it cannot be bound
Don't fail bus_attach_device() if the device cannot be bound.
If dev->driver has been specified, reset it to NULL if device_bind_driver()
failed and add the device as an unbound device. As a result,
bus_attach_device() now cannot fail, and we can remove some checking from
device_add().
Also remove an unneeded check in bus_rescan_devices_helper().
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/base/dd.c')
-rw-r--r-- | drivers/base/dd.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 616b4bbacf1b..18dba8e78da7 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c | |||
@@ -232,7 +232,7 @@ static int device_probe_drivers(void *data) | |||
232 | * | 232 | * |
233 | * Returns 1 if the device was bound to a driver; | 233 | * Returns 1 if the device was bound to a driver; |
234 | * 0 if no matching device was found or multithreaded probing is done; | 234 | * 0 if no matching device was found or multithreaded probing is done; |
235 | * error code otherwise. | 235 | * -ENODEV if the device is not registered. |
236 | * | 236 | * |
237 | * When called for a USB interface, @dev->parent->sem must be held. | 237 | * When called for a USB interface, @dev->parent->sem must be held. |
238 | */ | 238 | */ |
@@ -246,6 +246,10 @@ int device_attach(struct device * dev) | |||
246 | ret = device_bind_driver(dev); | 246 | ret = device_bind_driver(dev); |
247 | if (ret == 0) | 247 | if (ret == 0) |
248 | ret = 1; | 248 | ret = 1; |
249 | else { | ||
250 | dev->driver = NULL; | ||
251 | ret = 0; | ||
252 | } | ||
249 | } else { | 253 | } else { |
250 | if (dev->bus->multithread_probe) | 254 | if (dev->bus->multithread_probe) |
251 | probe_task = kthread_run(device_probe_drivers, dev, | 255 | probe_task = kthread_run(device_probe_drivers, dev, |