Driver core: Remove unneeded get_{device,driver}() calls.

Driver core: Remove unneeded get_{device,driver}() calls.

Code trying to add/remove attributes must hold a reference to
the device resp. driver anyway, so let's remove those reference
count games.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 2 insertions, 6 deletions

diff --git a/drivers/base/core.c b/drivers/base/core.c
index a0cfda553c9d..9c0070b5bd3e 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -423,10 +423,8 @@ struct kset *devices_kset;
 int device_create_file(struct device *dev, struct device_attribute *attr)
 {
         int error = 0;
-        if (get_device(dev)) {
+        if (dev)
                 error = sysfs_create_file(&dev->kobj, &attr->attr);
-                put_device(dev);
-        }
         return error;
 }
 
@@ -437,10 +435,8 @@ int device_create_file(struct device *dev, struct device_attribute *attr)
  */
 void device_remove_file(struct device *dev, struct device_attribute *attr)
 {
-        if (get_device(dev)) {
+        if (dev)
                 sysfs_remove_file(&dev->kobj, &attr->attr);
-                put_device(dev);
-        }
 }
 
 /**