diff options
author | Dave Young <hidave.darkstar@gmail.com> | 2009-02-14 08:23:22 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-03-24 19:38:25 -0400 |
commit | f48f3febb2cbfd0f2ecee7690835ba745c1034a4 (patch) | |
tree | 1cb3803049cde40ff3dc528a2120f915e65f0367 /drivers/base/bus.c | |
parent | e5779a583ddb9916b37cfbb916dc53ec2eaf0b9b (diff) |
driver-core: do not register a driver with bus_type not registered
If the bus_type is not registerd, driver_register to that bus will cause oops.
I found this bug when test built-in usb serial drivers (ie. aircable driver)
with 'nousb' cmdline params.
In this patch:
1. set the bus->p=NULL when bus_register failed and unregisterd.
2. if bus->p is NULL, driver_register BUG_ON will be triggered.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/base/bus.c')
-rw-r--r-- | drivers/base/bus.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 8547b780bb5a..11463c00451e 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c | |||
@@ -932,6 +932,7 @@ bus_uevent_fail: | |||
932 | kset_unregister(&bus->p->subsys); | 932 | kset_unregister(&bus->p->subsys); |
933 | kfree(bus->p); | 933 | kfree(bus->p); |
934 | out: | 934 | out: |
935 | bus->p = NULL; | ||
935 | return retval; | 936 | return retval; |
936 | } | 937 | } |
937 | EXPORT_SYMBOL_GPL(bus_register); | 938 | EXPORT_SYMBOL_GPL(bus_register); |
@@ -953,6 +954,7 @@ void bus_unregister(struct bus_type *bus) | |||
953 | bus_remove_file(bus, &bus_attr_uevent); | 954 | bus_remove_file(bus, &bus_attr_uevent); |
954 | kset_unregister(&bus->p->subsys); | 955 | kset_unregister(&bus->p->subsys); |
955 | kfree(bus->p); | 956 | kfree(bus->p); |
957 | bus->p = NULL; | ||
956 | } | 958 | } |
957 | EXPORT_SYMBOL_GPL(bus_unregister); | 959 | EXPORT_SYMBOL_GPL(bus_unregister); |
958 | 960 | ||