diff options
author | Julia Lawall <julia@diku.dk> | 2008-09-22 22:22:58 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-09-22 22:22:58 -0400 |
commit | 6a19309db0a02d821494f4df754046c85a230627 (patch) | |
tree | 03936c1806097bb4e0aafc9956e866727f713ea9 /drivers/atm/eni.c | |
parent | ca330c5a913a9b1690c709f4cfcd6be0c8696b14 (diff) |
drivers/atm: Use DIV_ROUND_UP
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
(d)) but is perhaps more readable.
In the case of the file drivers/atm/eni.c, I am a little bit suspicious of
the -1 at the end of the affected expression. Please check that that is
what is wanted.
An extract of the semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@haskernel@
@@
#include <linux/kernel.h>
@depends on haskernel@
expression n,d;
@@
(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm/eni.c')
-rw-r--r-- | drivers/atm/eni.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 41b2204ebc6e..5503bfc8e132 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c | |||
@@ -1270,7 +1270,7 @@ static int comp_tx(struct eni_dev *eni_dev,int *pcr,int reserved,int *pre, | |||
1270 | if (*pre < 3) (*pre)++; /* else fail later */ | 1270 | if (*pre < 3) (*pre)++; /* else fail later */ |
1271 | div = pre_div[*pre]*-*pcr; | 1271 | div = pre_div[*pre]*-*pcr; |
1272 | DPRINTK("max div %d\n",div); | 1272 | DPRINTK("max div %d\n",div); |
1273 | *res = (TS_CLOCK+div-1)/div-1; | 1273 | *res = DIV_ROUND_UP(TS_CLOCK, div)-1; |
1274 | } | 1274 | } |
1275 | if (*res < 0) *res = 0; | 1275 | if (*res < 0) *res = 0; |
1276 | if (*res > MID_SEG_MAX_RATE) *res = MID_SEG_MAX_RATE; | 1276 | if (*res > MID_SEG_MAX_RATE) *res = MID_SEG_MAX_RATE; |