diff options
author | Tejun Heo <htejun@gmail.com> | 2007-07-02 12:38:47 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-07-03 10:06:35 -0400 |
commit | 4031826b3ca40982880f6b9f2282c7d7fad60d77 (patch) | |
tree | 69dba5acc2180bd34752483a2ce777c51686b01d /drivers/ata | |
parent | aa2e09da2a332e748532aa2a71b090e7e7c3203d (diff) |
libata: fix assigned IRQ reporting
host->irq and host->irq2 should be set before ata_host_register() for
IRQ reporting to work. Move up host->irq assignment in
ata_host_activate() and add it to ata_pci_init_one() native path and
pata_cs5520.
The port info printing in ata_host_register() doesn't fit all the
different controllers. It should probably be moved out to LLDs with
some helpers in the future.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata')
-rw-r--r-- | drivers/ata/libata-core.c | 6 | ||||
-rw-r--r-- | drivers/ata/libata-sff.c | 5 | ||||
-rw-r--r-- | drivers/ata/pata_cs5520.c | 5 |
3 files changed, 11 insertions, 5 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 2407f8482948..981b397cb46b 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c | |||
@@ -6423,14 +6423,14 @@ int ata_host_activate(struct ata_host *host, int irq, | |||
6423 | if (rc) | 6423 | if (rc) |
6424 | return rc; | 6424 | return rc; |
6425 | 6425 | ||
6426 | /* Used to print device info at probe */ | ||
6427 | host->irq = irq; | ||
6428 | |||
6426 | rc = ata_host_register(host, sht); | 6429 | rc = ata_host_register(host, sht); |
6427 | /* if failed, just free the IRQ and leave ports alone */ | 6430 | /* if failed, just free the IRQ and leave ports alone */ |
6428 | if (rc) | 6431 | if (rc) |
6429 | devm_free_irq(host->dev, irq, host); | 6432 | devm_free_irq(host->dev, irq, host); |
6430 | 6433 | ||
6431 | /* Used to print device info at probe */ | ||
6432 | host->irq = irq; | ||
6433 | |||
6434 | return rc; | 6434 | return rc; |
6435 | } | 6435 | } |
6436 | 6436 | ||
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index ce84805ba5f1..fa1c22c7b38f 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c | |||
@@ -1065,10 +1065,11 @@ int ata_pci_init_one(struct pci_dev *pdev, | |||
1065 | if (rc) | 1065 | if (rc) |
1066 | goto err_out; | 1066 | goto err_out; |
1067 | 1067 | ||
1068 | if (!legacy_mode) | 1068 | if (!legacy_mode) { |
1069 | rc = devm_request_irq(dev, pdev->irq, pi->port_ops->irq_handler, | 1069 | rc = devm_request_irq(dev, pdev->irq, pi->port_ops->irq_handler, |
1070 | IRQF_SHARED, DRV_NAME, host); | 1070 | IRQF_SHARED, DRV_NAME, host); |
1071 | else { | 1071 | host->irq = pdev->irq; |
1072 | } else { | ||
1072 | irq_handler_t handler[2] = { host->ops->irq_handler, | 1073 | irq_handler_t handler[2] = { host->ops->irq_handler, |
1073 | host->ops->irq_handler }; | 1074 | host->ops->irq_handler }; |
1074 | unsigned int irq_flags[2] = { IRQF_SHARED, IRQF_SHARED }; | 1075 | unsigned int irq_flags[2] = { IRQF_SHARED, IRQF_SHARED }; |
diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c index 1aabe15ad9d3..00cf0134079c 100644 --- a/drivers/ata/pata_cs5520.c +++ b/drivers/ata/pata_cs5520.c | |||
@@ -284,6 +284,11 @@ static int __devinit cs5520_init_one(struct pci_dev *pdev, const struct pci_devi | |||
284 | ata_interrupt, 0, DRV_NAME, host); | 284 | ata_interrupt, 0, DRV_NAME, host); |
285 | if (rc) | 285 | if (rc) |
286 | return rc; | 286 | return rc; |
287 | |||
288 | if (i == 0) | ||
289 | host->irq = irq[0]; | ||
290 | else | ||
291 | host->irq2 = irq[1]; | ||
287 | } | 292 | } |
288 | 293 | ||
289 | return ata_host_register(host, &cs5520_sht); | 294 | return ata_host_register(host, &cs5520_sht); |