diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/ata | |
parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/ata')
-rw-r--r-- | drivers/ata/sata_nv.c | 6 | ||||
-rw-r--r-- | drivers/ata/sata_sil24.c | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c index e0bc9646a38e..55d6179dde58 100644 --- a/drivers/ata/sata_nv.c +++ b/drivers/ata/sata_nv.c | |||
@@ -599,9 +599,9 @@ MODULE_LICENSE("GPL"); | |||
599 | MODULE_DEVICE_TABLE(pci, nv_pci_tbl); | 599 | MODULE_DEVICE_TABLE(pci, nv_pci_tbl); |
600 | MODULE_VERSION(DRV_VERSION); | 600 | MODULE_VERSION(DRV_VERSION); |
601 | 601 | ||
602 | static int adma_enabled; | 602 | static bool adma_enabled; |
603 | static int swncq_enabled = 1; | 603 | static bool swncq_enabled = 1; |
604 | static int msi_enabled; | 604 | static bool msi_enabled; |
605 | 605 | ||
606 | static void nv_adma_register_mode(struct ata_port *ap) | 606 | static void nv_adma_register_mode(struct ata_port *ap) |
607 | { | 607 | { |
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c index 1e9140626a83..e7e610aa9a7a 100644 --- a/drivers/ata/sata_sil24.c +++ b/drivers/ata/sata_sil24.c | |||
@@ -417,7 +417,7 @@ static struct ata_port_operations sil24_ops = { | |||
417 | #endif | 417 | #endif |
418 | }; | 418 | }; |
419 | 419 | ||
420 | static int sata_sil24_msi; /* Disable MSI */ | 420 | static bool sata_sil24_msi; /* Disable MSI */ |
421 | module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); | 421 | module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); |
422 | MODULE_PARM_DESC(msi, "Enable MSI (Default: false)"); | 422 | MODULE_PARM_DESC(msi, "Enable MSI (Default: false)"); |
423 | 423 | ||