Merge branch 'for-3.13' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata

Pull libata changes from Tejun Heo:
 "Nothing too interesting.  Only two minor fixes in libata core.  Most
  changes are specific to hardware which isn't too common"

* 'for-3.13' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata:
  ahci: Add Device IDs for Intel Wildcat Point-LP
  sata_rcar: Convert to clk_prepare/unprepare
  drivers/libata: Set max sector to 65535 for Slimtype DVD A DS8A9SH drive
  libata: Add some missing command descriptions
  sata_highbank: clear whole array in highbank_initialize_phys()
  ahci: disabled FBS prior to issuing software reset
  libata: Fix display of sata speed
  ahci: imx: setup power saving methods
  ata_piix: minor typo and a printk fix
  ahci: Changing two module params with static and __read_mostly

11 files changed, 164 insertions, 35 deletions

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 8e28f923cf7f..e2903d03180e 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -292,6 +292,10 @@ static const struct pci_device_id ahci_pci_tbl[] = {
         { PCI_VDEVICE(INTEL, 0x8d66), board_ahci }, /* Wellsburg RAID */
         { PCI_VDEVICE(INTEL, 0x8d6e), board_ahci }, /* Wellsburg RAID */
         { PCI_VDEVICE(INTEL, 0x23a3), board_ahci }, /* Coleto Creek AHCI */
+        { PCI_VDEVICE(INTEL, 0x9c83), board_ahci }, /* Wildcat Point-LP AHCI */
+        { PCI_VDEVICE(INTEL, 0x9c85), board_ahci }, /* Wildcat Point-LP RAID */
+        { PCI_VDEVICE(INTEL, 0x9c87), board_ahci }, /* Wildcat Point-LP RAID */
+        { PCI_VDEVICE(INTEL, 0x9c8f), board_ahci }, /* Wildcat Point-LP RAID */
 
         /* JMicron 360/1/3/5/6, match class to avoid IDE function */
         { PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 11456371f29b..2289efdf8203 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -339,6 +339,7 @@ extern struct device_attribute *ahci_sdev_attrs[];
         .sdev_attrs             = ahci_sdev_attrs
 
 extern struct ata_port_operations ahci_ops;
+extern struct ata_port_operations ahci_platform_ops;
 extern struct ata_port_operations ahci_pmp_retry_srst_ops;
 
 unsigned int ahci_dev_classify(struct ata_port *ap);
@@ -368,6 +369,7 @@ irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance);
 irqreturn_t ahci_thread_fn(int irq, void *dev_instance);
 void ahci_print_info(struct ata_host *host, const char *scc_s);
 int ahci_host_activate(struct ata_host *host, int irq, unsigned int n_msis);
+void ahci_error_handler(struct ata_port *ap);
 
 static inline void __iomem *__ahci_port_base(struct ata_host *host,
                                              unsigned int port_no)
diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
index 58debb0acc3a..ae2d73fe321e 100644
--- a/drivers/ata/ahci_imx.c
+++ b/drivers/ata/ahci_imx.c
@@ -1,6 +1,6 @@
 /*
+ * copyright (c) 2013 Freescale Semiconductor, Inc.
  * Freescale IMX AHCI SATA platform driver
- * Copyright 2013 Freescale Semiconductor, Inc.
  *
  * based on the AHCI SATA platform driver by Jeff Garzik and Anton Vorontsov
  *
@@ -25,10 +25,13 @@
 #include <linux/of_device.h>
 #include <linux/mfd/syscon.h>
 #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
+#include <linux/libata.h>
 #include "ahci.h"
 
 enum {
-        HOST_TIMER1MS = 0xe0, /* Timer 1-ms */
+        PORT_PHY_CTL = 0x178,                   /* Port0 PHY Control */
+        PORT_PHY_CTL_PDDQ_LOC = 0x100000,       /* PORT_PHY_CTL bits */
+        HOST_TIMER1MS = 0xe0,                   /* Timer 1-ms */
 };
 
 struct imx_ahci_priv {
@@ -36,6 +39,56 @@ struct imx_ahci_priv {
         struct clk *sata_ref_clk;
         struct clk *ahb_clk;
         struct regmap *gpr;
+        bool no_device;
+        bool first_time;
+};
+
+static int ahci_imx_hotplug;
+module_param_named(hotplug, ahci_imx_hotplug, int, 0644);
+MODULE_PARM_DESC(hotplug, "AHCI IMX hot-plug support (0=Don't support, 1=support)");
+
+static void ahci_imx_error_handler(struct ata_port *ap)
+{
+        u32 reg_val;
+        struct ata_device *dev;
+        struct ata_host *host = dev_get_drvdata(ap->dev);
+        struct ahci_host_priv *hpriv = host->private_data;
+        void __iomem *mmio = hpriv->mmio;
+        struct imx_ahci_priv *imxpriv = dev_get_drvdata(ap->dev->parent);
+
+        ahci_error_handler(ap);
+
+        if (!(imxpriv->first_time) || ahci_imx_hotplug)
+                return;
+
+        imxpriv->first_time = false;
+
+        ata_for_each_dev(dev, &ap->link, ENABLED)
+                return;
+        /*
+         * Disable link to save power.  An imx ahci port can't be recovered
+         * without full reset once the pddq mode is enabled making it
+         * impossible to use as part of libata LPM.
+         */
+        reg_val = readl(mmio + PORT_PHY_CTL);
+        writel(reg_val | PORT_PHY_CTL_PDDQ_LOC, mmio + PORT_PHY_CTL);
+        regmap_update_bits(imxpriv->gpr, IOMUXC_GPR13,
+                        IMX6Q_GPR13_SATA_MPLL_CLK_EN,
+                        !IMX6Q_GPR13_SATA_MPLL_CLK_EN);
+        clk_disable_unprepare(imxpriv->sata_ref_clk);
+        imxpriv->no_device = true;
+}
+
+static struct ata_port_operations ahci_imx_ops = {
+        .inherits       = &ahci_platform_ops,
+        .error_handler  = ahci_imx_error_handler,
+};
+
+static const struct ata_port_info ahci_imx_port_info = {
+        .flags          = AHCI_FLAG_COMMON,
+        .pio_mask       = ATA_PIO4,
+        .udma_mask      = ATA_UDMA6,
+        .port_ops       = &ahci_imx_ops,
 };
 
 static int imx6q_sata_init(struct device *dev, void __iomem *mmio)
@@ -117,9 +170,51 @@ static void imx6q_sata_exit(struct device *dev)
         clk_disable_unprepare(imxpriv->sata_ref_clk);
 }
 
+static int imx_ahci_suspend(struct device *dev)
+{
+        struct imx_ahci_priv *imxpriv =  dev_get_drvdata(dev->parent);
+
+        /*
+         * If no_device is set, The CLKs had been gated off in the
+         * initialization so don't do it again here.
+         */
+        if (!imxpriv->no_device) {
+                regmap_update_bits(imxpriv->gpr, IOMUXC_GPR13,
+                                IMX6Q_GPR13_SATA_MPLL_CLK_EN,
+                                !IMX6Q_GPR13_SATA_MPLL_CLK_EN);
+                clk_disable_unprepare(imxpriv->sata_ref_clk);
+        }
+
+        return 0;
+}
+
+static int imx_ahci_resume(struct device *dev)
+{
+        struct imx_ahci_priv *imxpriv =  dev_get_drvdata(dev->parent);
+        int ret;
+
+        if (!imxpriv->no_device) {
+                ret = clk_prepare_enable(imxpriv->sata_ref_clk);
+                if (ret < 0) {
+                        dev_err(dev, "pre-enable sata_ref clock err:%d\n", ret);
+                        return ret;
+                }
+
+                regmap_update_bits(imxpriv->gpr, IOMUXC_GPR13,
+                                IMX6Q_GPR13_SATA_MPLL_CLK_EN,
+                                IMX6Q_GPR13_SATA_MPLL_CLK_EN);
+                usleep_range(1000, 2000);
+        }
+
+        return 0;
+}
+
 static struct ahci_platform_data imx6q_sata_pdata = {
         .init = imx6q_sata_init,
         .exit = imx6q_sata_exit,
+        .ata_port_info = &ahci_imx_port_info,
+        .suspend = imx_ahci_suspend,
+        .resume = imx_ahci_resume,
 };
 
 static const struct of_device_id imx_ahci_of_match[] = {
@@ -152,6 +247,8 @@ static int imx_ahci_probe(struct platform_device *pdev)
         ahci_dev = &ahci_pdev->dev;
         ahci_dev->parent = dev;
 
+        imxpriv->no_device = false;
+        imxpriv->first_time = true;
         imxpriv->ahb_clk = devm_clk_get(dev, "ahb");
         if (IS_ERR(imxpriv->ahb_clk)) {
                 dev_err(dev, "can't get ahb clock.\n");
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index 7d3b85385bfc..f9554318504f 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -49,10 +49,11 @@ static struct platform_device_id ahci_devtype[] = {
 };
 MODULE_DEVICE_TABLE(platform, ahci_devtype);
 
-static struct ata_port_operations ahci_platform_ops = {
+struct ata_port_operations ahci_platform_ops = {
         .inherits       = &ahci_ops,
         .host_stop      = ahci_host_stop,
 };
+EXPORT_SYMBOL_GPL(ahci_platform_ops);
 
 static struct ata_port_operations ahci_platform_retry_srst_ops = {
         .inherits       = &ahci_pmp_retry_srst_ops,
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 513ad7ed0c99..6334c8d7c3f1 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -100,7 +100,7 @@
 
 enum {
         PIIX_IOCFG              = 0x54, /* IDE I/O configuration register */
-        ICH5_PMR                = 0x90, /* port mapping register */
+        ICH5_PMR                = 0x90, /* address map register */
         ICH5_PCS                = 0x92, /* port control and status */
         PIIX_SIDPR_BAR          = 5,
         PIIX_SIDPR_LEN          = 16,
@@ -233,7 +233,7 @@ static const struct pci_device_id piix_pci_tbl[] = {
           PCI_CLASS_STORAGE_IDE << 8, 0xffff00, ich6m_sata },
         /* 82801GB/GR/GH (ICH7, identical to ICH6) */
         { 0x8086, 0x27c0, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich6_sata },
-        /* 2801GBM/GHM (ICH7M, identical to ICH6M) */
+        /* 82801GBM/GHM (ICH7M, identical to ICH6M)  */
         { 0x8086, 0x27c4, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich6m_sata },
         /* Enterprise Southbridge 2 (631xESB/632xESB) */
         { 0x8086, 0x2680, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich6_sata },
@@ -517,7 +517,7 @@ static int ich_pata_cable_detect(struct ata_port *ap)
         const struct ich_laptop *lap = &ich_laptop[0];
         u8 mask;
 
-        /* Check for specials - Acer Aspire 5602WLMi */
+        /* Check for specials */
         while (lap->device) {
                 if (lap->device == pdev->device &&
                     lap->subvendor == pdev->subsystem_vendor &&
@@ -1366,38 +1366,39 @@ static const int *piix_init_sata_map(struct pci_dev *pdev,
         const int *map;
         int i, invalid_map = 0;
         u8 map_value;
+        char buf[32];
+        char *p = buf, *end = buf + sizeof(buf);
 
         pci_read_config_byte(pdev, ICH5_PMR, &map_value);
 
         map = map_db->map[map_value & map_db->mask];
 
-        dev_info(&pdev->dev, "MAP [");
         for (i = 0; i < 4; i++) {
                 switch (map[i]) {
                 case RV:
                         invalid_map = 1;
-                        pr_cont(" XX");
+                        p += scnprintf(p, end - p, " XX");
                         break;
 
                 case NA:
-                        pr_cont(" --");
+                        p += scnprintf(p, end - p, " --");
                         break;
 
                 case IDE:
                         WARN_ON((i & 1) || map[i + 1] != IDE);
                         pinfo[i / 2] = piix_port_info[ich_pata_100];
                         i++;
-                        pr_cont(" IDE IDE");
+                        p += scnprintf(p, end - p, " IDE IDE");
                         break;
 
                 default:
-                        pr_cont(" P%d", map[i]);
+                        p += scnprintf(p, end - p, " P%d", map[i]);
                         if (i & 1)
                                 pinfo[i / 2].flags |= ATA_FLAG_SLAVE_POSS;
                         break;
                 }
         }
-        pr_cont(" ]\n");
+        dev_info(&pdev->dev, "MAP [%s ]\n", buf);
 
         if (invalid_map)
                 dev_err(&pdev->dev, "invalid MAP value %u\n", map_value);
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index aaac4fb0d564..c482f8cadd7a 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -89,7 +89,6 @@ static int ahci_pmp_retry_softreset(struct ata_link *link, unsigned int *class,
 static int ahci_hardreset(struct ata_link *link, unsigned int *class,
                           unsigned long deadline);
 static void ahci_postreset(struct ata_link *link, unsigned int *class);
-static void ahci_error_handler(struct ata_port *ap);
 static void ahci_post_internal_cmd(struct ata_queued_cmd *qc);
 static void ahci_dev_config(struct ata_device *dev);
 #ifdef CONFIG_PM
@@ -189,14 +188,15 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
 };
 EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
 
-int ahci_em_messages = 1;
+static bool ahci_em_messages __read_mostly = true;
 EXPORT_SYMBOL_GPL(ahci_em_messages);
-module_param(ahci_em_messages, int, 0444);
+module_param(ahci_em_messages, bool, 0444);
 /* add other LED protocol types when they become supported */
 MODULE_PARM_DESC(ahci_em_messages,
         "AHCI Enclosure Management Message control (0 = off, 1 = on)");
 
-int devslp_idle_timeout = 1000; /* device sleep idle timeout in ms */
+/* device sleep idle timeout in ms */
+static int devslp_idle_timeout __read_mostly = 1000;
 module_param(devslp_idle_timeout, int, 0644);
 MODULE_PARM_DESC(devslp_idle_timeout, "device sleep idle timeout");
 
@@ -1275,9 +1275,11 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class,
 {
         struct ata_port *ap = link->ap;
         struct ahci_host_priv *hpriv = ap->host->private_data;
+        struct ahci_port_priv *pp = ap->private_data;
         const char *reason = NULL;
         unsigned long now, msecs;
         struct ata_taskfile tf;
+        bool fbs_disabled = false;
         int rc;
 
         DPRINTK("ENTER\n");
@@ -1287,6 +1289,16 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class,
         if (rc && rc != -EOPNOTSUPP)
                 ata_link_warn(link, "failed to reset engine (errno=%d)\n", rc);
 
+        /*
+         * According to AHCI-1.2 9.3.9: if FBS is enable, software shall
+         * clear PxFBS.EN to '0' prior to issuing software reset to devices
+         * that is attached to port multiplier.
+         */
+        if (!ata_is_host_link(link) && pp->fbs_enabled) {
+                ahci_disable_fbs(ap);
+                fbs_disabled = true;
+        }
+
         ata_tf_init(link->device, &tf);
 
         /* issue the first D2H Register FIS */
@@ -1327,6 +1339,10 @@ int ahci_do_softreset(struct ata_link *link, unsigned int *class,
         } else
                 *class = ahci_dev_classify(ap);
 
+        /* re-enable FBS if disabled before */
+        if (fbs_disabled)
+                ahci_enable_fbs(ap);
+
         DPRINTK("EXIT, class=%u\n", *class);
         return 0;
 
@@ -1989,7 +2005,7 @@ static void ahci_thaw(struct ata_port *ap)
         writel(pp->intr_mask, port_mmio + PORT_IRQ_MASK);
 }
 
-static void ahci_error_handler(struct ata_port *ap)
+void ahci_error_handler(struct ata_port *ap)
 {
         if (!(ap->pflags & ATA_PFLAG_FROZEN)) {
                 /* restart engine */
@@ -2002,6 +2018,7 @@ static void ahci_error_handler(struct ata_port *ap)
         if (!ata_dev_enabled(ap->link.device))
                 ahci_stop_engine(ap);
 }
+EXPORT_SYMBOL_GPL(ahci_error_handler);
 
 static void ahci_post_internal_cmd(struct ata_queued_cmd *qc)
 {
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 83b1a9fb2d44..81a94a3919db 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4126,6 +4126,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
         { "TORiSAN DVD-ROM DRD-N216", NULL,     ATA_HORKAGE_MAX_SEC_128 },
         { "QUANTUM DAT    DAT72-000", NULL,     ATA_HORKAGE_ATAPI_MOD16_DMA },
         { "Slimtype DVD A  DS8A8SH", NULL,      ATA_HORKAGE_MAX_SEC_LBA48 },
+        { "Slimtype DVD A  DS8A9SH", NULL,      ATA_HORKAGE_MAX_SEC_LBA48 },
 
         /* Devices we expect to fail diagnostics */
 
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 370462fa8e01..77bbc8266883 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2293,6 +2293,7 @@ const char *ata_get_cmd_descript(u8 command)
                 { ATA_CMD_IDLE,                 "IDLE" },
                 { ATA_CMD_EDD,                  "EXECUTE DEVICE DIAGNOSTIC" },
                 { ATA_CMD_DOWNLOAD_MICRO,       "DOWNLOAD MICROCODE" },
+                { ATA_CMD_DOWNLOAD_MICRO_DMA,   "DOWNLOAD MICROCODE DMA" },
                 { ATA_CMD_NOP,                  "NOP" },
                 { ATA_CMD_FLUSH,                "FLUSH CACHE" },
                 { ATA_CMD_FLUSH_EXT,            "FLUSH CACHE EXT" },
@@ -2313,6 +2314,8 @@ const char *ata_get_cmd_descript(u8 command)
                 { ATA_CMD_WRITE_QUEUED_FUA_EXT, "WRITE DMA QUEUED FUA EXT" },
                 { ATA_CMD_FPDMA_READ,           "READ FPDMA QUEUED" },
                 { ATA_CMD_FPDMA_WRITE,          "WRITE FPDMA QUEUED" },
+                { ATA_CMD_FPDMA_SEND,           "SEND FPDMA QUEUED" },
+                { ATA_CMD_FPDMA_RECV,           "RECEIVE FPDMA QUEUED" },
                 { ATA_CMD_PIO_READ,             "READ SECTOR(S)" },
                 { ATA_CMD_PIO_READ_EXT,         "READ SECTOR(S) EXT" },
                 { ATA_CMD_PIO_WRITE,            "WRITE SECTOR(S)" },
@@ -2339,12 +2342,15 @@ const char *ata_get_cmd_descript(u8 command)
                 { ATA_CMD_WRITE_LOG_EXT,        "WRITE LOG EXT" },
                 { ATA_CMD_READ_LOG_DMA_EXT,     "READ LOG DMA EXT" },
                 { ATA_CMD_WRITE_LOG_DMA_EXT,    "WRITE LOG DMA EXT" },
+                { ATA_CMD_TRUSTED_NONDATA,      "TRUSTED NON-DATA" },
                 { ATA_CMD_TRUSTED_RCV,          "TRUSTED RECEIVE" },
                 { ATA_CMD_TRUSTED_RCV_DMA,      "TRUSTED RECEIVE DMA" },
                 { ATA_CMD_TRUSTED_SND,          "TRUSTED SEND" },
                 { ATA_CMD_TRUSTED_SND_DMA,      "TRUSTED SEND DMA" },
                 { ATA_CMD_PMP_READ,             "READ BUFFER" },
+                { ATA_CMD_PMP_READ_DMA,         "READ BUFFER DMA" },
                 { ATA_CMD_PMP_WRITE,            "WRITE BUFFER" },
+                { ATA_CMD_PMP_WRITE_DMA,        "WRITE BUFFER DMA" },
                 { ATA_CMD_CONF_OVERLAY,         "DEVICE CONFIGURATION OVERLAY" },
                 { ATA_CMD_SEC_SET_PASS,         "SECURITY SET PASSWORD" },
                 { ATA_CMD_SEC_UNLOCK,           "SECURITY UNLOCK" },
@@ -2363,6 +2369,8 @@ const char *ata_get_cmd_descript(u8 command)
                 { ATA_CMD_CFA_TRANS_SECT,       "CFA TRANSLATE SECTOR" },
                 { ATA_CMD_CFA_ERASE,            "CFA ERASE SECTORS" },
                 { ATA_CMD_CFA_WRITE_MULT_NE,    "CFA WRITE MULTIPLE WITHOUT ERASE" },
+                { ATA_CMD_REQ_SENSE_DATA,       "REQUEST SENSE DATA EXT" },
+                { ATA_CMD_SANITIZE_DEVICE,      "SANITIZE DEVICE" },
                 { ATA_CMD_READ_LONG,            "READ LONG (with retries)" },
                 { ATA_CMD_READ_LONG_ONCE,       "READ LONG (without retries)" },
                 { ATA_CMD_WRITE_LONG,           "WRITE LONG (with retries)" },
diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c
index 150a917f0c3c..e37413228228 100644
--- a/drivers/ata/libata-transport.c
+++ b/drivers/ata/libata-transport.c
@@ -321,25 +321,25 @@ int ata_tport_add(struct device *parent,
 /*
  * ATA link attributes
  */
+static int noop(int x) { return x; }
 
-
-#define ata_link_show_linkspeed(field)                                  \
+#define ata_link_show_linkspeed(field, format)                          \
 static ssize_t                                                          \
 show_ata_link_##field(struct device *dev,                               \
                       struct device_attribute *attr, char *buf)         \
 {                                                                       \
         struct ata_link *link = transport_class_to_link(dev);           \
                                                                         \
-        return sprintf(buf,"%s\n", sata_spd_string(fls(link->field)));  \
+        return sprintf(buf, "%s\n", sata_spd_string(format(link->field))); \
 }
 
-#define ata_link_linkspeed_attr(field)                                  \
-        ata_link_show_linkspeed(field)                                  \
+#define ata_link_linkspeed_attr(field, format)                          \
+        ata_link_show_linkspeed(field, format)                          \
 static DEVICE_ATTR(field, S_IRUGO, show_ata_link_##field, NULL)
 
-ata_link_linkspeed_attr(hw_sata_spd_limit);
-ata_link_linkspeed_attr(sata_spd_limit);
-ata_link_linkspeed_attr(sata_spd);
+ata_link_linkspeed_attr(hw_sata_spd_limit, fls);
+ata_link_linkspeed_attr(sata_spd_limit, fls);
+ata_link_linkspeed_attr(sata_spd, noop);
 
 
 static DECLARE_TRANSPORT_CLASS(ata_link_class,
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
index 7f5e5d96327f..ea3b3dc10f33 100644
--- a/drivers/ata/sata_highbank.c
+++ b/drivers/ata/sata_highbank.c
@@ -343,13 +343,11 @@ static int highbank_initialize_phys(struct device *dev, void __iomem *addr)
 {
         struct device_node *sata_node = dev->of_node;
         int phy_count = 0, phy, port = 0, i;
-        void __iomem *cphy_base[CPHY_PHY_COUNT];
-        struct device_node *phy_nodes[CPHY_PHY_COUNT];
-        u32 tx_atten[CPHY_PORT_COUNT];
+        void __iomem *cphy_base[CPHY_PHY_COUNT] = {};
+        struct device_node *phy_nodes[CPHY_PHY_COUNT] = {};
+        u32 tx_atten[CPHY_PORT_COUNT] = {};
 
         memset(port_data, 0, sizeof(struct phy_lane_info) * CPHY_PORT_COUNT);
-        memset(phy_nodes, 0, sizeof(struct device_node*) * CPHY_PHY_COUNT);
-        memset(tx_atten, 0xff, CPHY_PORT_COUNT);
 
         do {
                 u32 tmp;
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index c2d95e9fb971..1dae9a9009f7 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -792,7 +792,7 @@ static int sata_rcar_probe(struct platform_device *pdev)
                 dev_err(&pdev->dev, "failed to get access to sata clock\n");
                 return PTR_ERR(priv->clk);
         }
-        clk_enable(priv->clk);
+        clk_prepare_enable(priv->clk);
 
         host = ata_host_alloc(&pdev->dev, 1);
         if (!host) {
@@ -822,7 +822,7 @@ static int sata_rcar_probe(struct platform_device *pdev)
                 return 0;
 
 cleanup:
-        clk_disable(priv->clk);
+        clk_disable_unprepare(priv->clk);
 
         return ret;
 }
@@ -841,7 +841,7 @@ static int sata_rcar_remove(struct platform_device *pdev)
         iowrite32(0, base + SATAINTSTAT_REG);
         iowrite32(0x7ff, base + SATAINTMASK_REG);
 
-        clk_disable(priv->clk);
+        clk_disable_unprepare(priv->clk);
 
         return 0;
 }
@@ -861,7 +861,7 @@ static int sata_rcar_suspend(struct device *dev)
                 /* mask */
                 iowrite32(0x7ff, base + SATAINTMASK_REG);
 
-                clk_disable(priv->clk);
+                clk_disable_unprepare(priv->clk);
         }
 
         return ret;
@@ -873,7 +873,7 @@ static int sata_rcar_resume(struct device *dev)
         struct sata_rcar_priv *priv = host->private_data;
         void __iomem *base = priv->base;
 
-        clk_enable(priv->clk);
+        clk_prepare_enable(priv->clk);
 
         /* ack and mask */
         iowrite32(0, base + SATAINTSTAT_REG);