aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2010-01-18 12:17:03 -0500
committerJeff Garzik <jgarzik@redhat.com>2010-03-01 14:58:45 -0500
commitf777582f4963413320ce5fe1d1d3651a32075c07 (patch)
treeb77cbf3944a9eaa51e7b319d798544e9fbd8cf9a /drivers/ata
parentcfcf9ee26a5991f0786d24b4bd334b103d06268e (diff)
pata_via: fix address setup timings underlocking
Correct via_do_set_mode() documentation while at it. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/pata_via.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ata/pata_via.c b/drivers/ata/pata_via.c
index 0d97890af681..82e75a1f1b95 100644
--- a/drivers/ata/pata_via.c
+++ b/drivers/ata/pata_via.c
@@ -229,7 +229,7 @@ static int via_pre_reset(struct ata_link *link, unsigned long deadline)
229 229
230 230
231/** 231/**
232 * via_do_set_mode - set initial PIO mode data 232 * via_do_set_mode - set transfer mode data
233 * @ap: ATA interface 233 * @ap: ATA interface
234 * @adev: ATA device 234 * @adev: ATA device
235 * @mode: ATA mode being programmed 235 * @mode: ATA mode being programmed
@@ -273,7 +273,7 @@ static void via_do_set_mode(struct ata_port *ap, struct ata_device *adev, int mo
273 273
274 pci_read_config_byte(pdev, 0x4C, &setup); 274 pci_read_config_byte(pdev, 0x4C, &setup);
275 setup &= ~(3 << shift); 275 setup &= ~(3 << shift);
276 setup |= clamp_val(t.setup, 1, 4) << shift; /* 1,4 or 1,4 - 1 FIXME */ 276 setup |= (clamp_val(t.setup, 1, 4) - 1) << shift;
277 pci_write_config_byte(pdev, 0x4C, setup); 277 pci_write_config_byte(pdev, 0x4C, setup);
278 } 278 }
279 279