diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-03 15:15:40 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-10-09 20:22:20 -0400 |
commit | 1855256c497ecfefc730df6032243f26855ce52c (patch) | |
tree | b73947f1a5e1b798e1dec068ac1cda25ae910bf6 /drivers/ata | |
parent | bbf25010f1a6b761914430f5fca081ec8c7accd1 (diff) |
drivers/firmware: const-ify DMI API and internals
Three main sets of changes:
1) dmi_get_system_info() return value should have been marked const,
since callers should not be changing that data.
2) const-ify DMI internals, since DMI firmware tables should,
whenever possible, be marked const to ensure we never ever write to
that data area.
3) const-ify DMI API, to enable marking tables const where possible
in low-level drivers.
And if we're really lucky, this might enable some additional
optimizations on the part of the compiler.
The bulk of the changes are #2 and #3, which are interrelated. #1 could
have been a separate patch, but it was so small compared to the others,
it was easier to roll it into this changeset.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r-- | drivers/ata/ata_piix.c | 4 | ||||
-rw-r--r-- | drivers/ata/pata_ali.c | 2 | ||||
-rw-r--r-- | drivers/ata/pata_cs5530.c | 2 | ||||
-rw-r--r-- | drivers/ata/pata_via.c | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c index 6996eb5b7506..92c2d5082bef 100644 --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c | |||
@@ -919,7 +919,7 @@ static void ich_set_dmamode (struct ata_port *ap, struct ata_device *adev) | |||
919 | #ifdef CONFIG_PM | 919 | #ifdef CONFIG_PM |
920 | static int piix_broken_suspend(void) | 920 | static int piix_broken_suspend(void) |
921 | { | 921 | { |
922 | static struct dmi_system_id sysids[] = { | 922 | static const struct dmi_system_id sysids[] = { |
923 | { | 923 | { |
924 | .ident = "TECRA M3", | 924 | .ident = "TECRA M3", |
925 | .matches = { | 925 | .matches = { |
@@ -1183,7 +1183,7 @@ static void __devinit piix_init_sata_map(struct pci_dev *pdev, | |||
1183 | 1183 | ||
1184 | static void piix_iocfg_bit18_quirk(struct pci_dev *pdev) | 1184 | static void piix_iocfg_bit18_quirk(struct pci_dev *pdev) |
1185 | { | 1185 | { |
1186 | static struct dmi_system_id sysids[] = { | 1186 | static const struct dmi_system_id sysids[] = { |
1187 | { | 1187 | { |
1188 | /* Clevo M570U sets IOCFG bit 18 if the cdrom | 1188 | /* Clevo M570U sets IOCFG bit 18 if the cdrom |
1189 | * isn't used to boot the system which | 1189 | * isn't used to boot the system which |
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index 71bdc3b3189c..32a10c99c06f 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c | |||
@@ -40,7 +40,7 @@ | |||
40 | * Cable special cases | 40 | * Cable special cases |
41 | */ | 41 | */ |
42 | 42 | ||
43 | static struct dmi_system_id cable_dmi_table[] = { | 43 | static const struct dmi_system_id cable_dmi_table[] = { |
44 | { | 44 | { |
45 | .ident = "HP Pavilion N5430", | 45 | .ident = "HP Pavilion N5430", |
46 | .matches = { | 46 | .matches = { |
diff --git a/drivers/ata/pata_cs5530.c b/drivers/ata/pata_cs5530.c index c6066aa43ec8..eaaea848b649 100644 --- a/drivers/ata/pata_cs5530.c +++ b/drivers/ata/pata_cs5530.c | |||
@@ -214,7 +214,7 @@ static struct ata_port_operations cs5530_port_ops = { | |||
214 | .port_start = ata_port_start, | 214 | .port_start = ata_port_start, |
215 | }; | 215 | }; |
216 | 216 | ||
217 | static struct dmi_system_id palmax_dmi_table[] = { | 217 | static const struct dmi_system_id palmax_dmi_table[] = { |
218 | { | 218 | { |
219 | .ident = "Palmax PD1100", | 219 | .ident = "Palmax PD1100", |
220 | .matches = { | 220 | .matches = { |
diff --git a/drivers/ata/pata_via.c b/drivers/ata/pata_via.c index 636c4f1a0b24..f143db4559e0 100644 --- a/drivers/ata/pata_via.c +++ b/drivers/ata/pata_via.c | |||
@@ -129,7 +129,7 @@ static const struct via_isa_bridge { | |||
129 | * Cable special cases | 129 | * Cable special cases |
130 | */ | 130 | */ |
131 | 131 | ||
132 | static struct dmi_system_id cable_dmi_table[] = { | 132 | static const struct dmi_system_id cable_dmi_table[] = { |
133 | { | 133 | { |
134 | .ident = "Acer Ferrari 3400", | 134 | .ident = "Acer Ferrari 3400", |
135 | .matches = { | 135 | .matches = { |