diff options
author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-03-03 16:35:20 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-03-04 08:23:40 -0500 |
commit | 53540098b23c3884b4a0b4f220b9d977bc496af3 (patch) | |
tree | fe86061c4772efaa92fbe68920f803ae4280b2d0 /drivers/ata | |
parent | 9b27516fcd7ab7dc416edf418446c24c61729938 (diff) |
ACPI / glue: Add .match() callback to struct acpi_bus_type
USB uses the .find_bridge() callback from struct acpi_bus_type
incorrectly, because as a result of the way it is used by USB every
device in the system that doesn't have a bus type or parent is
passed to usb_acpi_find_device() for inspection.
What USB actually needs, though, is to call usb_acpi_find_device()
for USB ports that don't have a bus type defined, but have
usb_port_device_type as their device type, as well as for USB
devices.
To fix that replace the struct bus_type pointer in struct
acpi_bus_type used for matching devices to specific subsystems
with a .match() callback to be used for this purpose and update
the users of struct acpi_bus_type, including USB, accordingly.
Define the .match() callback routine for USB, usb_acpi_bus_match(),
in such a way that it will cover both USB devices and USB ports
and remove the now redundant .find_bridge() callback pointer from
usb_acpi_bus.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Yinghai Lu <yinghai@kernel.org>
Acked-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r-- | drivers/ata/libata-acpi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 0ea1018280bd..c832a5ca09ad 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c | |||
@@ -1150,6 +1150,7 @@ static int ata_acpi_find_dummy(struct device *dev, acpi_handle *handle) | |||
1150 | } | 1150 | } |
1151 | 1151 | ||
1152 | static struct acpi_bus_type ata_acpi_bus = { | 1152 | static struct acpi_bus_type ata_acpi_bus = { |
1153 | .name = "ATA", | ||
1153 | .find_bridge = ata_acpi_find_dummy, | 1154 | .find_bridge = ata_acpi_find_dummy, |
1154 | .find_device = ata_acpi_find_device, | 1155 | .find_device = ata_acpi_find_device, |
1155 | }; | 1156 | }; |