diff options
author | Grant Likely <grant.likely@secretlab.ca> | 2010-04-13 19:13:02 -0400 |
---|---|---|
committer | Grant Likely <grant.likely@secretlab.ca> | 2010-05-22 02:10:40 -0400 |
commit | 4018294b53d1dae026880e45f174c1cc63b5d435 (patch) | |
tree | 6db3538eaf91b653381720a6d92f4f15634a93d0 /drivers/ata | |
parent | 597b9d1e44e9ba69f2454a5318bbe7a6d5e6930a (diff) |
of: Remove duplicate fields from of_platform_driver
.name, .match_table and .owner are duplicated in both of_platform_driver
and device_driver. This patch is a removes the extra copies from struct
of_platform_driver and converts all users to the device_driver members.
This patch is a pretty mechanical change. The usage model doesn't change
and if any drivers have been missed, or if anything has been fixed up
incorrectly, then it will fail with a compile time error, and the fixup
will be trivial. This patch looks big and scary because it touches so
many files, but it should be pretty safe.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Sean MacLennan <smaclennan@pikatech.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r-- | drivers/ata/pata_mpc52xx.c | 4 | ||||
-rw-r--r-- | drivers/ata/pata_of_platform.c | 7 | ||||
-rw-r--r-- | drivers/ata/sata_fsl.c | 7 |
3 files changed, 11 insertions, 7 deletions
diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index 4cce719add3f..88e6b6008bd6 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c | |||
@@ -884,9 +884,6 @@ static struct of_device_id mpc52xx_ata_of_match[] = { | |||
884 | 884 | ||
885 | 885 | ||
886 | static struct of_platform_driver mpc52xx_ata_of_platform_driver = { | 886 | static struct of_platform_driver mpc52xx_ata_of_platform_driver = { |
887 | .owner = THIS_MODULE, | ||
888 | .name = DRV_NAME, | ||
889 | .match_table = mpc52xx_ata_of_match, | ||
890 | .probe = mpc52xx_ata_probe, | 887 | .probe = mpc52xx_ata_probe, |
891 | .remove = mpc52xx_ata_remove, | 888 | .remove = mpc52xx_ata_remove, |
892 | #ifdef CONFIG_PM | 889 | #ifdef CONFIG_PM |
@@ -896,6 +893,7 @@ static struct of_platform_driver mpc52xx_ata_of_platform_driver = { | |||
896 | .driver = { | 893 | .driver = { |
897 | .name = DRV_NAME, | 894 | .name = DRV_NAME, |
898 | .owner = THIS_MODULE, | 895 | .owner = THIS_MODULE, |
896 | .of_match_table = mpc52xx_ata_of_match, | ||
899 | }, | 897 | }, |
900 | }; | 898 | }; |
901 | 899 | ||
diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c index 19da29f011db..5a1b82c08be9 100644 --- a/drivers/ata/pata_of_platform.c +++ b/drivers/ata/pata_of_platform.c | |||
@@ -91,8 +91,11 @@ static struct of_device_id pata_of_platform_match[] = { | |||
91 | MODULE_DEVICE_TABLE(of, pata_of_platform_match); | 91 | MODULE_DEVICE_TABLE(of, pata_of_platform_match); |
92 | 92 | ||
93 | static struct of_platform_driver pata_of_platform_driver = { | 93 | static struct of_platform_driver pata_of_platform_driver = { |
94 | .name = "pata_of_platform", | 94 | .driver = { |
95 | .match_table = pata_of_platform_match, | 95 | .name = "pata_of_platform", |
96 | .owner = THIS_MODULE, | ||
97 | .of_match_table = pata_of_platform_match, | ||
98 | }, | ||
96 | .probe = pata_of_platform_probe, | 99 | .probe = pata_of_platform_probe, |
97 | .remove = __devexit_p(pata_of_platform_remove), | 100 | .remove = __devexit_p(pata_of_platform_remove), |
98 | }; | 101 | }; |
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index e3339e25b152..61c89b54ea23 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c | |||
@@ -1427,8 +1427,11 @@ static struct of_device_id fsl_sata_match[] = { | |||
1427 | MODULE_DEVICE_TABLE(of, fsl_sata_match); | 1427 | MODULE_DEVICE_TABLE(of, fsl_sata_match); |
1428 | 1428 | ||
1429 | static struct of_platform_driver fsl_sata_driver = { | 1429 | static struct of_platform_driver fsl_sata_driver = { |
1430 | .name = "fsl-sata", | 1430 | .driver = { |
1431 | .match_table = fsl_sata_match, | 1431 | .name = "fsl-sata", |
1432 | .owner = THIS_MODULE, | ||
1433 | .of_match_table = fsl_sata_match, | ||
1434 | }, | ||
1432 | .probe = sata_fsl_probe, | 1435 | .probe = sata_fsl_probe, |
1433 | .remove = sata_fsl_remove, | 1436 | .remove = sata_fsl_remove, |
1434 | #ifdef CONFIG_PM | 1437 | #ifdef CONFIG_PM |