diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/sata_uli.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/sata_uli.c')
-rw-r--r-- | drivers/ata/sata_uli.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/ata/sata_uli.c b/drivers/ata/sata_uli.c index 3072fd3f11c6..b54ebfcdda32 100644 --- a/drivers/ata/sata_uli.c +++ b/drivers/ata/sata_uli.c | |||
@@ -145,7 +145,6 @@ static int uli_scr_write(struct ata_link *link, unsigned int sc_reg, u32 val) | |||
145 | 145 | ||
146 | static int uli_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | 146 | static int uli_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) |
147 | { | 147 | { |
148 | static int printed_version; | ||
149 | const struct ata_port_info *ppi[] = { &uli_port_info, NULL }; | 148 | const struct ata_port_info *ppi[] = { &uli_port_info, NULL }; |
150 | unsigned int board_idx = (unsigned int) ent->driver_data; | 149 | unsigned int board_idx = (unsigned int) ent->driver_data; |
151 | struct ata_host *host; | 150 | struct ata_host *host; |
@@ -154,8 +153,7 @@ static int uli_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
154 | struct ata_ioports *ioaddr; | 153 | struct ata_ioports *ioaddr; |
155 | int n_ports, rc; | 154 | int n_ports, rc; |
156 | 155 | ||
157 | if (!printed_version++) | 156 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
158 | dev_info(&pdev->dev, "version " DRV_VERSION "\n"); | ||
159 | 157 | ||
160 | rc = pcim_enable_device(pdev); | 158 | rc = pcim_enable_device(pdev); |
161 | if (rc) | 159 | if (rc) |