diff options
author | Tejun Heo <htejun@gmail.com> | 2008-04-07 09:47:16 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:21 -0400 |
commit | 9363c3825ea9ad76561eb48a395349dd29211ed6 (patch) | |
tree | abe89a0f7c82b805d84b1a211c97b317f6628d5f /drivers/ata/sata_sx4.c | |
parent | b67a1064cb1c1d3b43e01e8b43a6a8dcdefed733 (diff) |
libata: rename SFF functions
SFF functions have confusing names. Some have sff prefix, some have
bmdma, some std, some pci and some none. Unify the naming by...
* SFF functions which are common to both BMDMA and non-BMDMA are
prefixed with ata_sff_.
* SFF functions which are specific to BMDMA are prefixed with
ata_bmdma_.
* SFF functions which are specific to PCI but apply to both BMDMA and
non-BMDMA are prefixed with ata_pci_sff_.
* SFF functions which are specific to PCI and BMDMA are prefixed with
ata_pci_bmdma_.
* Drop generic prefixes from LLD specific routines. For example,
bfin_std_dev_select -> bfin_dev_select.
The following renames are noteworthy.
ata_qc_issue_prot() -> ata_sff_qc_issue()
ata_pci_default_filter() -> ata_bmdma_mode_filter()
ata_dev_try_classify() -> ata_sff_dev_classify()
This rename is in preparation of separating SFF support out of libata
core layer. This patch strictly renames functions and doesn't
introduce any behavior difference.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/sata_sx4.c')
-rw-r--r-- | drivers/ata/sata_sx4.c | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/drivers/ata/sata_sx4.c b/drivers/ata/sata_sx4.c index 8d7f39532d4a..40be2ff60902 100644 --- a/drivers/ata/sata_sx4.c +++ b/drivers/ata/sata_sx4.c | |||
@@ -232,7 +232,7 @@ static void pdc20621_get_from_dimm(struct ata_host *host, | |||
232 | static void pdc20621_put_to_dimm(struct ata_host *host, | 232 | static void pdc20621_put_to_dimm(struct ata_host *host, |
233 | void *psource, u32 offset, u32 size); | 233 | void *psource, u32 offset, u32 size); |
234 | static void pdc20621_irq_clear(struct ata_port *ap); | 234 | static void pdc20621_irq_clear(struct ata_port *ap); |
235 | static unsigned int pdc20621_qc_issue_prot(struct ata_queued_cmd *qc); | 235 | static unsigned int pdc20621_qc_issue(struct ata_queued_cmd *qc); |
236 | 236 | ||
237 | 237 | ||
238 | static struct scsi_host_template pdc_sata_sht = { | 238 | static struct scsi_host_template pdc_sata_sht = { |
@@ -244,17 +244,17 @@ static struct scsi_host_template pdc_sata_sht = { | |||
244 | /* TODO: inherit from base port_ops after converting to new EH */ | 244 | /* TODO: inherit from base port_ops after converting to new EH */ |
245 | static struct ata_port_operations pdc_20621_ops = { | 245 | static struct ata_port_operations pdc_20621_ops = { |
246 | .tf_load = pdc_tf_load_mmio, | 246 | .tf_load = pdc_tf_load_mmio, |
247 | .tf_read = ata_tf_read, | 247 | .tf_read = ata_sff_tf_read, |
248 | .check_status = ata_check_status, | 248 | .check_status = ata_sff_check_status, |
249 | .exec_command = pdc_exec_command_mmio, | 249 | .exec_command = pdc_exec_command_mmio, |
250 | .dev_select = ata_std_dev_select, | 250 | .dev_select = ata_sff_dev_select, |
251 | .phy_reset = pdc_20621_phy_reset, | 251 | .phy_reset = pdc_20621_phy_reset, |
252 | .qc_prep = pdc20621_qc_prep, | 252 | .qc_prep = pdc20621_qc_prep, |
253 | .qc_issue = pdc20621_qc_issue_prot, | 253 | .qc_issue = pdc20621_qc_issue, |
254 | .data_xfer = ata_data_xfer, | 254 | .data_xfer = ata_sff_data_xfer, |
255 | .eng_timeout = pdc_eng_timeout, | 255 | .eng_timeout = pdc_eng_timeout, |
256 | .irq_clear = pdc20621_irq_clear, | 256 | .irq_clear = pdc20621_irq_clear, |
257 | .irq_on = ata_irq_on, | 257 | .irq_on = ata_sff_irq_on, |
258 | .port_start = pdc_port_start, | 258 | .port_start = pdc_port_start, |
259 | }; | 259 | }; |
260 | 260 | ||
@@ -682,7 +682,7 @@ static void pdc20621_packet_start(struct ata_queued_cmd *qc) | |||
682 | } | 682 | } |
683 | } | 683 | } |
684 | 684 | ||
685 | static unsigned int pdc20621_qc_issue_prot(struct ata_queued_cmd *qc) | 685 | static unsigned int pdc20621_qc_issue(struct ata_queued_cmd *qc) |
686 | { | 686 | { |
687 | switch (qc->tf.protocol) { | 687 | switch (qc->tf.protocol) { |
688 | case ATA_PROT_DMA: | 688 | case ATA_PROT_DMA: |
@@ -698,7 +698,7 @@ static unsigned int pdc20621_qc_issue_prot(struct ata_queued_cmd *qc) | |||
698 | break; | 698 | break; |
699 | } | 699 | } |
700 | 700 | ||
701 | return ata_qc_issue_prot(qc); | 701 | return ata_sff_qc_issue(qc); |
702 | } | 702 | } |
703 | 703 | ||
704 | static inline unsigned int pdc20621_host_intr(struct ata_port *ap, | 704 | static inline unsigned int pdc20621_host_intr(struct ata_port *ap, |
@@ -770,7 +770,7 @@ static inline unsigned int pdc20621_host_intr(struct ata_port *ap, | |||
770 | /* command completion, but no data xfer */ | 770 | /* command completion, but no data xfer */ |
771 | } else if (qc->tf.protocol == ATA_PROT_NODATA) { | 771 | } else if (qc->tf.protocol == ATA_PROT_NODATA) { |
772 | 772 | ||
773 | status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000); | 773 | status = ata_sff_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000); |
774 | DPRINTK("BUS_NODATA (drv_stat 0x%X)\n", status); | 774 | DPRINTK("BUS_NODATA (drv_stat 0x%X)\n", status); |
775 | qc->err_mask |= ac_err_mask(status); | 775 | qc->err_mask |= ac_err_mask(status); |
776 | ata_qc_complete(qc); | 776 | ata_qc_complete(qc); |
@@ -879,7 +879,7 @@ static void pdc_eng_timeout(struct ata_port *ap) | |||
879 | break; | 879 | break; |
880 | 880 | ||
881 | default: | 881 | default: |
882 | drv_stat = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000); | 882 | drv_stat = ata_sff_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000); |
883 | 883 | ||
884 | ata_port_printk(ap, KERN_ERR, | 884 | ata_port_printk(ap, KERN_ERR, |
885 | "unknown timeout, cmd 0x%x stat 0x%x\n", | 885 | "unknown timeout, cmd 0x%x stat 0x%x\n", |
@@ -898,7 +898,7 @@ static void pdc_tf_load_mmio(struct ata_port *ap, const struct ata_taskfile *tf) | |||
898 | { | 898 | { |
899 | WARN_ON(tf->protocol == ATA_PROT_DMA || | 899 | WARN_ON(tf->protocol == ATA_PROT_DMA || |
900 | tf->protocol == ATA_PROT_NODATA); | 900 | tf->protocol == ATA_PROT_NODATA); |
901 | ata_tf_load(ap, tf); | 901 | ata_sff_tf_load(ap, tf); |
902 | } | 902 | } |
903 | 903 | ||
904 | 904 | ||
@@ -906,7 +906,7 @@ static void pdc_exec_command_mmio(struct ata_port *ap, const struct ata_taskfile | |||
906 | { | 906 | { |
907 | WARN_ON(tf->protocol == ATA_PROT_DMA || | 907 | WARN_ON(tf->protocol == ATA_PROT_DMA || |
908 | tf->protocol == ATA_PROT_NODATA); | 908 | tf->protocol == ATA_PROT_NODATA); |
909 | ata_exec_command(ap, tf); | 909 | ata_sff_exec_command(ap, tf); |
910 | } | 910 | } |
911 | 911 | ||
912 | 912 | ||