diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/sata_sis.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/sata_sis.c')
-rw-r--r-- | drivers/ata/sata_sis.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/ata/sata_sis.c b/drivers/ata/sata_sis.c index ae040dee419e..447d9c05fb5a 100644 --- a/drivers/ata/sata_sis.c +++ b/drivers/ata/sata_sis.c | |||
@@ -193,7 +193,6 @@ static int sis_scr_write(struct ata_link *link, unsigned int sc_reg, u32 val) | |||
193 | 193 | ||
194 | static int sis_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | 194 | static int sis_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) |
195 | { | 195 | { |
196 | static int printed_version; | ||
197 | struct ata_port_info pi = sis_port_info; | 196 | struct ata_port_info pi = sis_port_info; |
198 | const struct ata_port_info *ppi[] = { &pi, &pi }; | 197 | const struct ata_port_info *ppi[] = { &pi, &pi }; |
199 | struct ata_host *host; | 198 | struct ata_host *host; |
@@ -202,8 +201,7 @@ static int sis_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
202 | u8 port2_start = 0x20; | 201 | u8 port2_start = 0x20; |
203 | int i, rc; | 202 | int i, rc; |
204 | 203 | ||
205 | if (!printed_version++) | 204 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
206 | dev_info(&pdev->dev, "version " DRV_VERSION "\n"); | ||
207 | 205 | ||
208 | rc = pcim_enable_device(pdev); | 206 | rc = pcim_enable_device(pdev); |
209 | if (rc) | 207 | if (rc) |