diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:51:58 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | a44fec1fce5d5d14cc3ac4545b8da346394de666 (patch) | |
tree | fa3d16a4c8f1a6a7e9af867f16f7201a5b5442f9 /drivers/ata/sata_sil24.c | |
parent | 02f8c6aee8df3cdc935e9bdd4f2d020306035dbe (diff) |
ata: Convert dev_printk(KERN_<LEVEL> to dev_<level>(
Saves a bit of text as the call takes fewer args.
Coalesce a few formats.
Convert a few bare printks to pr_cont.
$ size drivers/ata/built-in.o*
text data bss dec hex filename
558429 73893 117864 750186 b726a drivers/ata/built-in.o.allyesconfig.new
559574 73893 117888 751355 b76fb drivers/ata/built-in.o.allyesconfig.old
149567 14689 4220 168476 2921c drivers/ata/built-in.o.defconfig.new
149851 14689 4220 168760 29338 drivers/ata/built-in.o.defconfig.old
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/sata_sil24.c')
-rw-r--r-- | drivers/ata/sata_sil24.c | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c index 06c564e55051..164d52ed6b62 100644 --- a/drivers/ata/sata_sil24.c +++ b/drivers/ata/sata_sil24.c | |||
@@ -1256,8 +1256,8 @@ static void sil24_init_controller(struct ata_host *host) | |||
1256 | PORT_CS_PORT_RST, | 1256 | PORT_CS_PORT_RST, |
1257 | PORT_CS_PORT_RST, 10, 100); | 1257 | PORT_CS_PORT_RST, 10, 100); |
1258 | if (tmp & PORT_CS_PORT_RST) | 1258 | if (tmp & PORT_CS_PORT_RST) |
1259 | dev_printk(KERN_ERR, host->dev, | 1259 | dev_err(host->dev, |
1260 | "failed to clear port RST\n"); | 1260 | "failed to clear port RST\n"); |
1261 | } | 1261 | } |
1262 | 1262 | ||
1263 | /* configure port */ | 1263 | /* configure port */ |
@@ -1302,9 +1302,8 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
1302 | if (pi.flags & SIL24_FLAG_PCIX_IRQ_WOC) { | 1302 | if (pi.flags & SIL24_FLAG_PCIX_IRQ_WOC) { |
1303 | tmp = readl(iomap[SIL24_HOST_BAR] + HOST_CTRL); | 1303 | tmp = readl(iomap[SIL24_HOST_BAR] + HOST_CTRL); |
1304 | if (tmp & (HOST_CTRL_TRDY | HOST_CTRL_STOP | HOST_CTRL_DEVSEL)) | 1304 | if (tmp & (HOST_CTRL_TRDY | HOST_CTRL_STOP | HOST_CTRL_DEVSEL)) |
1305 | dev_printk(KERN_INFO, &pdev->dev, | 1305 | dev_info(&pdev->dev, |
1306 | "Applying completion IRQ loss on PCI-X " | 1306 | "Applying completion IRQ loss on PCI-X errata fix\n"); |
1307 | "errata fix\n"); | ||
1308 | else | 1307 | else |
1309 | pi.flags &= ~SIL24_FLAG_PCIX_IRQ_WOC; | 1308 | pi.flags &= ~SIL24_FLAG_PCIX_IRQ_WOC; |
1310 | } | 1309 | } |
@@ -1322,22 +1321,21 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
1322 | if (rc) { | 1321 | if (rc) { |
1323 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); | 1322 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); |
1324 | if (rc) { | 1323 | if (rc) { |
1325 | dev_printk(KERN_ERR, &pdev->dev, | 1324 | dev_err(&pdev->dev, |
1326 | "64-bit DMA enable failed\n"); | 1325 | "64-bit DMA enable failed\n"); |
1327 | return rc; | 1326 | return rc; |
1328 | } | 1327 | } |
1329 | } | 1328 | } |
1330 | } else { | 1329 | } else { |
1331 | rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); | 1330 | rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); |
1332 | if (rc) { | 1331 | if (rc) { |
1333 | dev_printk(KERN_ERR, &pdev->dev, | 1332 | dev_err(&pdev->dev, "32-bit DMA enable failed\n"); |
1334 | "32-bit DMA enable failed\n"); | ||
1335 | return rc; | 1333 | return rc; |
1336 | } | 1334 | } |
1337 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); | 1335 | rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); |
1338 | if (rc) { | 1336 | if (rc) { |
1339 | dev_printk(KERN_ERR, &pdev->dev, | 1337 | dev_err(&pdev->dev, |
1340 | "32-bit consistent DMA enable failed\n"); | 1338 | "32-bit consistent DMA enable failed\n"); |
1341 | return rc; | 1339 | return rc; |
1342 | } | 1340 | } |
1343 | } | 1341 | } |
@@ -1350,7 +1348,7 @@ static int sil24_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
1350 | sil24_init_controller(host); | 1348 | sil24_init_controller(host); |
1351 | 1349 | ||
1352 | if (sata_sil24_msi && !pci_enable_msi(pdev)) { | 1350 | if (sata_sil24_msi && !pci_enable_msi(pdev)) { |
1353 | dev_printk(KERN_INFO, &pdev->dev, "Using MSI\n"); | 1351 | dev_info(&pdev->dev, "Using MSI\n"); |
1354 | pci_intx(pdev, 0); | 1352 | pci_intx(pdev, 0); |
1355 | } | 1353 | } |
1356 | 1354 | ||