aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/sata_sil24.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-01-23 10:05:14 -0500
committerJeff Garzik <jgarzik@redhat.com>2008-04-17 15:44:16 -0400
commit8cebf274dd1c955a6e03385a85fd6569ce445946 (patch)
treec459cd20ef93413e063826bb99ca0bcaf67ec8d2 /drivers/ata/sata_sil24.c
parent672b2d65ba83a6f3f801fd3d58851aa9c0725a54 (diff)
libata: kill ATA_LFLAG_SKIP_D2H_BSY
Some controllers can't reliably record the initial D2H FIS after SATA link is brought online for whatever reason. Advanced controllers which don't have traditional TF register based interface often have this problem as they don't really have the TF registers to update while the controller and link are being initialized. SKIP_D2H_BSY works around the problem by skipping the wait for device readiness before issuing SRST, so for such controllers libata issues SRST blindly and hopes for the best. Now that libata defaults to hardreset, this workaround is no longer necessary. For controllers which have support for hardreset, SRST is never issued by itself. It is only issued as follow-up SRST for device classification and PMP initialization, so there's no need to wait for it from prereset. Kill ATA_LFLAG_SKIP_D2H_BSY. Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/sata_sil24.c')
-rw-r--r--drivers/ata/sata_sil24.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index aa8d0323c9bb..ba0c00e8ee7f 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -254,7 +254,6 @@ enum {
254 ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA | 254 ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA |
255 ATA_FLAG_NCQ | ATA_FLAG_ACPI_SATA | 255 ATA_FLAG_NCQ | ATA_FLAG_ACPI_SATA |
256 ATA_FLAG_AN | ATA_FLAG_PMP, 256 ATA_FLAG_AN | ATA_FLAG_PMP,
257 SIL24_COMMON_LFLAGS = ATA_LFLAG_SKIP_D2H_BSY,
258 SIL24_FLAG_PCIX_IRQ_WOC = (1 << 24), /* IRQ loss errata on PCI-X */ 257 SIL24_FLAG_PCIX_IRQ_WOC = (1 << 24), /* IRQ loss errata on PCI-X */
259 258
260 IRQ_STAT_4PORTS = 0xf, 259 IRQ_STAT_4PORTS = 0xf,
@@ -449,7 +448,6 @@ static const struct ata_port_info sil24_port_info[] = {
449 { 448 {
450 .flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(4) | 449 .flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(4) |
451 SIL24_FLAG_PCIX_IRQ_WOC, 450 SIL24_FLAG_PCIX_IRQ_WOC,
452 .link_flags = SIL24_COMMON_LFLAGS,
453 .pio_mask = 0x1f, /* pio0-4 */ 451 .pio_mask = 0x1f, /* pio0-4 */
454 .mwdma_mask = 0x07, /* mwdma0-2 */ 452 .mwdma_mask = 0x07, /* mwdma0-2 */
455 .udma_mask = ATA_UDMA5, /* udma0-5 */ 453 .udma_mask = ATA_UDMA5, /* udma0-5 */
@@ -458,7 +456,6 @@ static const struct ata_port_info sil24_port_info[] = {
458 /* sil_3132 */ 456 /* sil_3132 */
459 { 457 {
460 .flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(2), 458 .flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(2),
461 .link_flags = SIL24_COMMON_LFLAGS,
462 .pio_mask = 0x1f, /* pio0-4 */ 459 .pio_mask = 0x1f, /* pio0-4 */
463 .mwdma_mask = 0x07, /* mwdma0-2 */ 460 .mwdma_mask = 0x07, /* mwdma0-2 */
464 .udma_mask = ATA_UDMA5, /* udma0-5 */ 461 .udma_mask = ATA_UDMA5, /* udma0-5 */
@@ -467,7 +464,6 @@ static const struct ata_port_info sil24_port_info[] = {
467 /* sil_3131/sil_3531 */ 464 /* sil_3131/sil_3531 */
468 { 465 {
469 .flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(1), 466 .flags = SIL24_COMMON_FLAGS | SIL24_NPORTS2FLAG(1),
470 .link_flags = SIL24_COMMON_LFLAGS,
471 .pio_mask = 0x1f, /* pio0-4 */ 467 .pio_mask = 0x1f, /* pio0-4 */
472 .mwdma_mask = 0x07, /* mwdma0-2 */ 468 .mwdma_mask = 0x07, /* mwdma0-2 */
473 .udma_mask = ATA_UDMA5, /* udma0-5 */ 469 .udma_mask = ATA_UDMA5, /* udma0-5 */