aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/sata_sil24.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-01-13 00:04:16 -0500
committerJeff Garzik <jeff@garzik.org>2008-01-14 21:11:02 -0500
commitc2e14f11120bbef0c883e795da8180b58f3cddae (patch)
tree3ecad039951b09fc7de9271d9f9b498402d99eb9 /drivers/ata/sata_sil24.c
parent7293fa8fb74f17077a2ac7ccd5b58ae3225317d0 (diff)
sata_sil24: freeze on non-dev errors reported via CERR
CERR reports errors detected during executing a command. This doesn't mean the error is tied to the command and can be recovered by just issuing it again. Many of the errors are fatal port-wide connditions including HSM violation, host bus error and ATA bus error and require freezing and port reset. The freezing part wasn't implemented previously. This used to be okay because port resets were scheduled anyway and EH eventually resets and recovers the port. With PMP support added, this is no longer true. The error condition and recover actions are attributed to the fan-out port and the host port condition isn't properly recovered leading to EH failures. This patch makes CERR errors which require resets to freeze the port. This will force host port reset and proper recovery. Signed-off-by: Tejun Heo <htejun@gmail.com> Cc: Andrew Ryder <tireman@shaw.ca> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/sata_sil24.c')
-rw-r--r--drivers/ata/sata_sil24.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index d9c8b32b483c..864c1c1b8511 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -1094,10 +1094,13 @@ static void sil24_error_intr(struct ata_port *ap)
1094 if (ci && ci->desc) { 1094 if (ci && ci->desc) {
1095 err_mask |= ci->err_mask; 1095 err_mask |= ci->err_mask;
1096 action |= ci->action; 1096 action |= ci->action;
1097 if (action & ATA_EH_RESET_MASK)
1098 freeze = 1;
1097 ata_ehi_push_desc(ehi, "%s", ci->desc); 1099 ata_ehi_push_desc(ehi, "%s", ci->desc);
1098 } else { 1100 } else {
1099 err_mask |= AC_ERR_OTHER; 1101 err_mask |= AC_ERR_OTHER;
1100 action |= ATA_EH_SOFTRESET; 1102 action |= ATA_EH_SOFTRESET;
1103 freeze = 1;
1101 ata_ehi_push_desc(ehi, "unknown command error %d", 1104 ata_ehi_push_desc(ehi, "unknown command error %d",
1102 cerr); 1105 cerr);
1103 } 1106 }