diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-07-09 12:16:50 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-07-09 12:17:35 -0400 |
commit | bf6263a853c9c143bf03f0a6fdcc68ab714fb5f5 (patch) | |
tree | baf6189fc6e5c13934749488948e1cbfc6e65dea /drivers/ata/sata_mv.c | |
parent | cd70c26617f4686355263be4533ce8030242740e (diff) |
[libata] Use ATA_UDMAx standard masks when filling driver's udma_mask info
The ATA_UDMAx masks are self-documenting, and far better than manually
writing in the hex mask.
Note that pata_it8213 mask differed from the comment. Added a FIXME there.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/sata_mv.c')
-rw-r--r-- | drivers/ata/sata_mv.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index 590f2f92b4e0..d65ec234be5c 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c | |||
@@ -526,44 +526,44 @@ static const struct ata_port_info mv_port_info[] = { | |||
526 | { /* chip_504x */ | 526 | { /* chip_504x */ |
527 | .flags = MV_COMMON_FLAGS, | 527 | .flags = MV_COMMON_FLAGS, |
528 | .pio_mask = 0x1f, /* pio0-4 */ | 528 | .pio_mask = 0x1f, /* pio0-4 */ |
529 | .udma_mask = 0x7f, /* udma0-6 */ | 529 | .udma_mask = ATA_UDMA6, |
530 | .port_ops = &mv5_ops, | 530 | .port_ops = &mv5_ops, |
531 | }, | 531 | }, |
532 | { /* chip_508x */ | 532 | { /* chip_508x */ |
533 | .flags = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC), | 533 | .flags = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC), |
534 | .pio_mask = 0x1f, /* pio0-4 */ | 534 | .pio_mask = 0x1f, /* pio0-4 */ |
535 | .udma_mask = 0x7f, /* udma0-6 */ | 535 | .udma_mask = ATA_UDMA6, |
536 | .port_ops = &mv5_ops, | 536 | .port_ops = &mv5_ops, |
537 | }, | 537 | }, |
538 | { /* chip_5080 */ | 538 | { /* chip_5080 */ |
539 | .flags = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC), | 539 | .flags = (MV_COMMON_FLAGS | MV_FLAG_DUAL_HC), |
540 | .pio_mask = 0x1f, /* pio0-4 */ | 540 | .pio_mask = 0x1f, /* pio0-4 */ |
541 | .udma_mask = 0x7f, /* udma0-6 */ | 541 | .udma_mask = ATA_UDMA6, |
542 | .port_ops = &mv5_ops, | 542 | .port_ops = &mv5_ops, |
543 | }, | 543 | }, |
544 | { /* chip_604x */ | 544 | { /* chip_604x */ |
545 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS), | 545 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS), |
546 | .pio_mask = 0x1f, /* pio0-4 */ | 546 | .pio_mask = 0x1f, /* pio0-4 */ |
547 | .udma_mask = 0x7f, /* udma0-6 */ | 547 | .udma_mask = ATA_UDMA6, |
548 | .port_ops = &mv6_ops, | 548 | .port_ops = &mv6_ops, |
549 | }, | 549 | }, |
550 | { /* chip_608x */ | 550 | { /* chip_608x */ |
551 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS | | 551 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS | |
552 | MV_FLAG_DUAL_HC), | 552 | MV_FLAG_DUAL_HC), |
553 | .pio_mask = 0x1f, /* pio0-4 */ | 553 | .pio_mask = 0x1f, /* pio0-4 */ |
554 | .udma_mask = 0x7f, /* udma0-6 */ | 554 | .udma_mask = ATA_UDMA6, |
555 | .port_ops = &mv6_ops, | 555 | .port_ops = &mv6_ops, |
556 | }, | 556 | }, |
557 | { /* chip_6042 */ | 557 | { /* chip_6042 */ |
558 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS), | 558 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS), |
559 | .pio_mask = 0x1f, /* pio0-4 */ | 559 | .pio_mask = 0x1f, /* pio0-4 */ |
560 | .udma_mask = 0x7f, /* udma0-6 */ | 560 | .udma_mask = ATA_UDMA6, |
561 | .port_ops = &mv_iie_ops, | 561 | .port_ops = &mv_iie_ops, |
562 | }, | 562 | }, |
563 | { /* chip_7042 */ | 563 | { /* chip_7042 */ |
564 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS), | 564 | .flags = (MV_COMMON_FLAGS | MV_6XXX_FLAGS), |
565 | .pio_mask = 0x1f, /* pio0-4 */ | 565 | .pio_mask = 0x1f, /* pio0-4 */ |
566 | .udma_mask = 0x7f, /* udma0-6 */ | 566 | .udma_mask = ATA_UDMA6, |
567 | .port_ops = &mv_iie_ops, | 567 | .port_ops = &mv_iie_ops, |
568 | }, | 568 | }, |
569 | }; | 569 | }; |