aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/sata_mv.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-03-24 23:22:48 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-17 15:44:17 -0400
commit6bd99b4e0998571808fc1f09d5162348f21ff8c1 (patch)
treee338bd445aaa5cda4bbf1f5598acf70f0d6b68de /drivers/ata/sata_mv.c
parent358f9a77a668660729e705fde9c3cf69f013aa98 (diff)
libata: normalize port_info, port_operations and sht tables
Over the time, port info, ops and sht structures developed quite a bit of inconsistencies. This patch updates drivers. * Enable/disable_pm callbacks added to all ahci ops tables. * Every driver for SFF controllers now uses ata_sff_port_start() instead of ata_port_start() unless the driver has custom implementation. * Every driver for SFF controllers now uses ata_pci_default_filter() unless the driver has custom implementation. * Removed an odd port_info->sht initialization from ata_piix.c. Likely a merge byproduct. * A port which has ATA_FLAG_SATA set doesn't need to set cable_detect to ata_cable_sata(). Remove it from via and mv port ops. * Some drivers had unnecessary .max_sectors initialization which is ignored and was missing .slave_destroy callback. Fixed. * Removed unnecessary sht initializations port_info's. * Removed onsolete scsi device suspend/resume callbacks from pata_bf54x. * No reason to set ata_pci_default_filter() and bmdma functions for PIO-only drivers. Remove those callbacks and replace ata_bmdma_irq_clear with ata_noop_irq_clear. * pata_platform sets port_start to ata_dummy_ret0. port_start can just be set to NULL. * sata_fsl supports NCQ but was missing qc_defer. Fixed. * pata_rb600_cf implements dummy port_start. Removed. Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/sata_mv.c')
-rw-r--r--drivers/ata/sata_mv.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index b3b3da4eaa03..4685bce745bb 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -557,8 +557,6 @@ static const struct ata_port_operations mv5_ops = {
557 .exec_command = ata_exec_command, 557 .exec_command = ata_exec_command,
558 .dev_select = ata_std_dev_select, 558 .dev_select = ata_std_dev_select,
559 559
560 .cable_detect = ata_cable_sata,
561
562 .qc_prep = mv_qc_prep, 560 .qc_prep = mv_qc_prep,
563 .qc_issue = mv_qc_issue, 561 .qc_issue = mv_qc_issue,
564 .data_xfer = ata_data_xfer, 562 .data_xfer = ata_data_xfer,
@@ -585,8 +583,6 @@ static const struct ata_port_operations mv6_ops = {
585 .exec_command = ata_exec_command, 583 .exec_command = ata_exec_command,
586 .dev_select = ata_std_dev_select, 584 .dev_select = ata_std_dev_select,
587 585
588 .cable_detect = ata_cable_sata,
589
590 .qc_prep = mv_qc_prep, 586 .qc_prep = mv_qc_prep,
591 .qc_issue = mv_qc_issue, 587 .qc_issue = mv_qc_issue,
592 .data_xfer = ata_data_xfer, 588 .data_xfer = ata_data_xfer,
@@ -613,8 +609,6 @@ static const struct ata_port_operations mv_iie_ops = {
613 .exec_command = ata_exec_command, 609 .exec_command = ata_exec_command,
614 .dev_select = ata_std_dev_select, 610 .dev_select = ata_std_dev_select,
615 611
616 .cable_detect = ata_cable_sata,
617
618 .qc_prep = mv_qc_prep_iie, 612 .qc_prep = mv_qc_prep_iie,
619 .qc_issue = mv_qc_issue, 613 .qc_issue = mv_qc_issue,
620 .data_xfer = ata_data_xfer, 614 .data_xfer = ata_data_xfer,