diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-10-31 07:27:59 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-11-03 08:46:28 -0400 |
commit | 25ce945a8e775d1f494447969e6a8fffcebcc352 (patch) | |
tree | 9eee585fe65bff63a790149f918eb1856bbe157f /drivers/ata/sata_fsl.c | |
parent | 2a52e8d4ea86a9143b4c3a1c1ec249a3b8bee74e (diff) |
ata/sata_fsl: remove unneeded on-stack copy of FIS
Remove unneeded on-stack copy of FIS
in sata_fsl_cache_taskfile_from_d2h_fis().
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/sata_fsl.c')
-rw-r--r-- | drivers/ata/sata_fsl.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index e3bf9546fd08..c47f2d4bf860 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c | |||
@@ -561,7 +561,6 @@ static inline void sata_fsl_cache_taskfile_from_d2h_fis(struct ata_queued_cmd | |||
561 | struct ata_port *ap) | 561 | struct ata_port *ap) |
562 | { | 562 | { |
563 | struct sata_fsl_port_priv *pp = ap->private_data; | 563 | struct sata_fsl_port_priv *pp = ap->private_data; |
564 | u8 fis[6 * 4]; | ||
565 | struct sata_fsl_host_priv *host_priv = ap->host->private_data; | 564 | struct sata_fsl_host_priv *host_priv = ap->host->private_data; |
566 | void __iomem *hcr_base = host_priv->hcr_base; | 565 | void __iomem *hcr_base = host_priv->hcr_base; |
567 | unsigned int tag = sata_fsl_tag(qc->tag, hcr_base); | 566 | unsigned int tag = sata_fsl_tag(qc->tag, hcr_base); |
@@ -569,8 +568,7 @@ static inline void sata_fsl_cache_taskfile_from_d2h_fis(struct ata_queued_cmd | |||
569 | 568 | ||
570 | cd = pp->cmdentry + tag; | 569 | cd = pp->cmdentry + tag; |
571 | 570 | ||
572 | memcpy(fis, &cd->sfis, 6 * 4); /* should we use memcpy_from_io() */ | 571 | ata_tf_from_fis(cd->sfis, &pp->tf); |
573 | ata_tf_from_fis(fis, &pp->tf); | ||
574 | } | 572 | } |
575 | 573 | ||
576 | static u8 sata_fsl_check_status(struct ata_port *ap) | 574 | static u8 sata_fsl_check_status(struct ata_port *ap) |