diff options
author | Jeff Garzik <jeff@garzik.org> | 2007-08-15 05:38:46 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2007-10-12 14:55:34 -0400 |
commit | 6d32d30f55020d766388df7515f771f68c973033 (patch) | |
tree | ec0efe48460b5b3f177fed2698ccd04b7964359b /drivers/ata/pata_sis.c | |
parent | cb94c1cf5a6beffbd8935eb91227df0dd1987644 (diff) |
[libata] Remove ->irq_ack() hook, and ata_dummy_irq_on()
* ->irq_ack() is redundant to what the irq handler already
performs... chk-status + irq-clear. Furthermore, it is only
called in one place, when screaming-irq-debugging is enabled,
so we don't want to bother with a hook just for that.
* ata_dummy_irq_on() is only ever used in drivers that have
no callpath reaching ->irq_on(). Remove .irq_on hook from
those drivers, and the now-unused ata_dummy_irq_on()
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/pata_sis.c')
-rw-r--r-- | drivers/ata/pata_sis.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c index b72227676f00..72850667d371 100644 --- a/drivers/ata/pata_sis.c +++ b/drivers/ata/pata_sis.c | |||
@@ -559,7 +559,6 @@ static const struct ata_port_operations sis_133_ops = { | |||
559 | .irq_handler = ata_interrupt, | 559 | .irq_handler = ata_interrupt, |
560 | .irq_clear = ata_bmdma_irq_clear, | 560 | .irq_clear = ata_bmdma_irq_clear, |
561 | .irq_on = ata_irq_on, | 561 | .irq_on = ata_irq_on, |
562 | .irq_ack = ata_irq_ack, | ||
563 | 562 | ||
564 | .port_start = ata_port_start, | 563 | .port_start = ata_port_start, |
565 | }; | 564 | }; |
@@ -593,7 +592,6 @@ static const struct ata_port_operations sis_133_for_sata_ops = { | |||
593 | .irq_handler = ata_interrupt, | 592 | .irq_handler = ata_interrupt, |
594 | .irq_clear = ata_bmdma_irq_clear, | 593 | .irq_clear = ata_bmdma_irq_clear, |
595 | .irq_on = ata_irq_on, | 594 | .irq_on = ata_irq_on, |
596 | .irq_ack = ata_irq_ack, | ||
597 | 595 | ||
598 | .port_start = ata_port_start, | 596 | .port_start = ata_port_start, |
599 | }; | 597 | }; |
@@ -627,7 +625,6 @@ static const struct ata_port_operations sis_133_early_ops = { | |||
627 | .irq_handler = ata_interrupt, | 625 | .irq_handler = ata_interrupt, |
628 | .irq_clear = ata_bmdma_irq_clear, | 626 | .irq_clear = ata_bmdma_irq_clear, |
629 | .irq_on = ata_irq_on, | 627 | .irq_on = ata_irq_on, |
630 | .irq_ack = ata_irq_ack, | ||
631 | 628 | ||
632 | .port_start = ata_port_start, | 629 | .port_start = ata_port_start, |
633 | }; | 630 | }; |
@@ -661,7 +658,6 @@ static const struct ata_port_operations sis_100_ops = { | |||
661 | .irq_handler = ata_interrupt, | 658 | .irq_handler = ata_interrupt, |
662 | .irq_clear = ata_bmdma_irq_clear, | 659 | .irq_clear = ata_bmdma_irq_clear, |
663 | .irq_on = ata_irq_on, | 660 | .irq_on = ata_irq_on, |
664 | .irq_ack = ata_irq_ack, | ||
665 | 661 | ||
666 | .port_start = ata_port_start, | 662 | .port_start = ata_port_start, |
667 | }; | 663 | }; |
@@ -695,7 +691,6 @@ static const struct ata_port_operations sis_66_ops = { | |||
695 | .irq_handler = ata_interrupt, | 691 | .irq_handler = ata_interrupt, |
696 | .irq_clear = ata_bmdma_irq_clear, | 692 | .irq_clear = ata_bmdma_irq_clear, |
697 | .irq_on = ata_irq_on, | 693 | .irq_on = ata_irq_on, |
698 | .irq_ack = ata_irq_ack, | ||
699 | 694 | ||
700 | .port_start = ata_port_start, | 695 | .port_start = ata_port_start, |
701 | }; | 696 | }; |
@@ -729,7 +724,6 @@ static const struct ata_port_operations sis_old_ops = { | |||
729 | .irq_handler = ata_interrupt, | 724 | .irq_handler = ata_interrupt, |
730 | .irq_clear = ata_bmdma_irq_clear, | 725 | .irq_clear = ata_bmdma_irq_clear, |
731 | .irq_on = ata_irq_on, | 726 | .irq_on = ata_irq_on, |
732 | .irq_ack = ata_irq_ack, | ||
733 | 727 | ||
734 | .port_start = ata_port_start, | 728 | .port_start = ata_port_start, |
735 | }; | 729 | }; |