libata: make ata_pci_init_one() not use ops->irq_handler and pi->sht

ata_pci_init_one() is the only function which uses ops->irq_handler
and pi->sht.  Other initialization functions take the same information
as arguments.  This causes confusion and duplicate unused entries in
structures.

Make ata_pci_init_one() take sht as an argument and use ata_interrupt
implicitly.  All current users use ata_interrupt and if different irq
handler is necessary open coding ata_pci_init_one() using
ata_prepare_sff_host() and ata_activate_sff_host can be done under ten
lines including error handling and driver which requires custom
interrupt handler is likely to require custom initialization anyway.

As ata_pci_init_one() was the last user of ops->irq_handler, this
patch also kills the field.

Signed-off-by: Tejun Heo <htejun@gmail.com>

1 files changed, 1 insertions, 9 deletions

diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
index 3ed628670cd7..32be13ba5f06 100644
--- a/drivers/ata/pata_sis.c
+++ b/drivers/ata/pata_sis.c
@@ -565,7 +565,6 @@ static struct ata_port_operations sis_old_ops = {
 };
 
 static const struct ata_port_info sis_info = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS,
         .pio_mask       = 0x1f, /* pio0-4 */
         .mwdma_mask     = 0x07,
@@ -573,7 +572,6 @@ static const struct ata_port_info sis_info = {
         .port_ops       = &sis_old_ops,
 };
 static const struct ata_port_info sis_info33 = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS,
         .pio_mask       = 0x1f, /* pio0-4 */
         .mwdma_mask     = 0x07,
@@ -581,42 +579,36 @@ static const struct ata_port_info sis_info33 = {
         .port_ops       = &sis_old_ops,
 };
 static const struct ata_port_info sis_info66 = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS,
         .pio_mask       = 0x1f, /* pio0-4 */
         .udma_mask      = ATA_UDMA4,    /* UDMA 66 */
         .port_ops       = &sis_66_ops,
 };
 static const struct ata_port_info sis_info100 = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS,
         .pio_mask       = 0x1f, /* pio0-4 */
         .udma_mask      = ATA_UDMA5,
         .port_ops       = &sis_100_ops,
 };
 static const struct ata_port_info sis_info100_early = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS,
         .udma_mask      = ATA_UDMA5,
         .pio_mask       = 0x1f, /* pio0-4 */
         .port_ops       = &sis_66_ops,
 };
 static const struct ata_port_info sis_info133 = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS,
         .pio_mask       = 0x1f, /* pio0-4 */
         .udma_mask      = ATA_UDMA6,
         .port_ops       = &sis_133_ops,
 };
 const struct ata_port_info sis_info133_for_sata = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST,
         .pio_mask       = 0x1f, /* pio0-4 */
         .udma_mask      = ATA_UDMA6,
         .port_ops       = &sis_133_for_sata_ops,
 };
 static const struct ata_port_info sis_info133_early = {
-        .sht            = &sis_sht,
         .flags          = ATA_FLAG_SLAVE_POSS,
         .pio_mask       = 0x1f, /* pio0-4 */
         .udma_mask      = ATA_UDMA6,
@@ -844,7 +836,7 @@ static int sis_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
 
         sis_fixup(pdev, chipset);
 
-        return ata_pci_init_one(pdev, ppi);
+        return ata_pci_init_one(pdev, ppi, &sis_sht);
 }
 
 static const struct pci_device_id sis_pci_tbl[] = {