aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/pata_sis.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2007-01-20 02:00:28 -0500
committerJeff Garzik <jeff@garzik.org>2007-02-09 17:39:37 -0500
commit24dc5f33ea4b504cfbd23fa159a4cacba8e4d800 (patch)
treed76de456157f555c9a65b83f426fd805fee1e846 /drivers/ata/pata_sis.c
parentf0d36efdc624beb3d9e29b9ab9e9537bf0f25d5b (diff)
libata: update libata LLDs to use devres
Update libata LLDs to use devres. Core layer is already converted to support managed LLDs. This patch simplifies initialization and fixes many resource related bugs in init failure and detach path. For example, all converted drivers now handle ata_device_add() failure gracefully without excessive resource rollback code. As most resources are released automatically on driver detach, many drivers don't need or can do with much simpler ->{port|host}_stop(). In general, stop callbacks are need iff port or host needs to be given commands to shut it down. Note that freezing is enough in many cases and ports are automatically frozen before being detached. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/pata_sis.c')
-rw-r--r--drivers/ata/pata_sis.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
index 5e616d3cc870..1c5219f3ffde 100644
--- a/drivers/ata/pata_sis.c
+++ b/drivers/ata/pata_sis.c
@@ -608,8 +608,6 @@ static const struct ata_port_operations sis_133_ops = {
608 .irq_clear = ata_bmdma_irq_clear, 608 .irq_clear = ata_bmdma_irq_clear,
609 609
610 .port_start = ata_port_start, 610 .port_start = ata_port_start,
611 .port_stop = ata_port_stop,
612 .host_stop = ata_host_stop,
613}; 611};
614 612
615static const struct ata_port_operations sis_133_early_ops = { 613static const struct ata_port_operations sis_133_early_ops = {
@@ -641,8 +639,6 @@ static const struct ata_port_operations sis_133_early_ops = {
641 .irq_clear = ata_bmdma_irq_clear, 639 .irq_clear = ata_bmdma_irq_clear,
642 640
643 .port_start = ata_port_start, 641 .port_start = ata_port_start,
644 .port_stop = ata_port_stop,
645 .host_stop = ata_host_stop,
646}; 642};
647 643
648static const struct ata_port_operations sis_100_ops = { 644static const struct ata_port_operations sis_100_ops = {
@@ -675,8 +671,6 @@ static const struct ata_port_operations sis_100_ops = {
675 .irq_clear = ata_bmdma_irq_clear, 671 .irq_clear = ata_bmdma_irq_clear,
676 672
677 .port_start = ata_port_start, 673 .port_start = ata_port_start,
678 .port_stop = ata_port_stop,
679 .host_stop = ata_host_stop,
680}; 674};
681 675
682static const struct ata_port_operations sis_66_ops = { 676static const struct ata_port_operations sis_66_ops = {
@@ -708,8 +702,6 @@ static const struct ata_port_operations sis_66_ops = {
708 .irq_clear = ata_bmdma_irq_clear, 702 .irq_clear = ata_bmdma_irq_clear,
709 703
710 .port_start = ata_port_start, 704 .port_start = ata_port_start,
711 .port_stop = ata_port_stop,
712 .host_stop = ata_host_stop,
713}; 705};
714 706
715static const struct ata_port_operations sis_old_ops = { 707static const struct ata_port_operations sis_old_ops = {
@@ -741,8 +733,6 @@ static const struct ata_port_operations sis_old_ops = {
741 .irq_clear = ata_bmdma_irq_clear, 733 .irq_clear = ata_bmdma_irq_clear,
742 734
743 .port_start = ata_port_start, 735 .port_start = ata_port_start,
744 .port_stop = ata_port_stop,
745 .host_stop = ata_host_stop,
746}; 736};
747 737
748static struct ata_port_info sis_info = { 738static struct ata_port_info sis_info = {