diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/pata_sis.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/pata_sis.c')
-rw-r--r-- | drivers/ata/pata_sis.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c index be08ff92db17..533f2aefab87 100644 --- a/drivers/ata/pata_sis.c +++ b/drivers/ata/pata_sis.c | |||
@@ -681,7 +681,6 @@ static void sis_fixup(struct pci_dev *pdev, struct sis_chipset *sis) | |||
681 | 681 | ||
682 | static int sis_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) | 682 | static int sis_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) |
683 | { | 683 | { |
684 | static int printed_version; | ||
685 | const struct ata_port_info *ppi[] = { NULL, NULL }; | 684 | const struct ata_port_info *ppi[] = { NULL, NULL }; |
686 | struct pci_dev *host = NULL; | 685 | struct pci_dev *host = NULL; |
687 | struct sis_chipset *chipset = NULL; | 686 | struct sis_chipset *chipset = NULL; |
@@ -735,9 +734,7 @@ static int sis_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) | |||
735 | 0x0, &sis_info100 | 734 | 0x0, &sis_info100 |
736 | }; | 735 | }; |
737 | 736 | ||
738 | if (!printed_version++) | 737 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
739 | dev_printk(KERN_DEBUG, &pdev->dev, | ||
740 | "version " DRV_VERSION "\n"); | ||
741 | 738 | ||
742 | rc = pcim_enable_device(pdev); | 739 | rc = pcim_enable_device(pdev); |
743 | if (rc) | 740 | if (rc) |