diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/pata_rdc.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/pata_rdc.c')
-rw-r--r-- | drivers/ata/pata_rdc.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/ata/pata_rdc.c b/drivers/ata/pata_rdc.c index 5fbe9b166c69..4d318f86ae86 100644 --- a/drivers/ata/pata_rdc.c +++ b/drivers/ata/pata_rdc.c | |||
@@ -312,7 +312,6 @@ static struct scsi_host_template rdc_sht = { | |||
312 | static int __devinit rdc_init_one(struct pci_dev *pdev, | 312 | static int __devinit rdc_init_one(struct pci_dev *pdev, |
313 | const struct pci_device_id *ent) | 313 | const struct pci_device_id *ent) |
314 | { | 314 | { |
315 | static int printed_version; | ||
316 | struct device *dev = &pdev->dev; | 315 | struct device *dev = &pdev->dev; |
317 | struct ata_port_info port_info[2]; | 316 | struct ata_port_info port_info[2]; |
318 | const struct ata_port_info *ppi[] = { &port_info[0], &port_info[1] }; | 317 | const struct ata_port_info *ppi[] = { &port_info[0], &port_info[1] }; |
@@ -321,9 +320,7 @@ static int __devinit rdc_init_one(struct pci_dev *pdev, | |||
321 | struct rdc_host_priv *hpriv; | 320 | struct rdc_host_priv *hpriv; |
322 | int rc; | 321 | int rc; |
323 | 322 | ||
324 | if (!printed_version++) | 323 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
325 | dev_printk(KERN_DEBUG, &pdev->dev, | ||
326 | "version " DRV_VERSION "\n"); | ||
327 | 324 | ||
328 | port_info[0] = rdc_port_info; | 325 | port_info[0] = rdc_port_info; |
329 | port_info[1] = rdc_port_info; | 326 | port_info[1] = rdc_port_info; |