aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/pata_rb500_cf.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-03-24 23:22:48 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-17 15:44:17 -0400
commit6bd99b4e0998571808fc1f09d5162348f21ff8c1 (patch)
treee338bd445aaa5cda4bbf1f5598acf70f0d6b68de /drivers/ata/pata_rb500_cf.c
parent358f9a77a668660729e705fde9c3cf69f013aa98 (diff)
libata: normalize port_info, port_operations and sht tables
Over the time, port info, ops and sht structures developed quite a bit of inconsistencies. This patch updates drivers. * Enable/disable_pm callbacks added to all ahci ops tables. * Every driver for SFF controllers now uses ata_sff_port_start() instead of ata_port_start() unless the driver has custom implementation. * Every driver for SFF controllers now uses ata_pci_default_filter() unless the driver has custom implementation. * Removed an odd port_info->sht initialization from ata_piix.c. Likely a merge byproduct. * A port which has ATA_FLAG_SATA set doesn't need to set cable_detect to ata_cable_sata(). Remove it from via and mv port ops. * Some drivers had unnecessary .max_sectors initialization which is ignored and was missing .slave_destroy callback. Fixed. * Removed unnecessary sht initializations port_info's. * Removed onsolete scsi device suspend/resume callbacks from pata_bf54x. * No reason to set ata_pci_default_filter() and bmdma functions for PIO-only drivers. Remove those callbacks and replace ata_bmdma_irq_clear with ata_noop_irq_clear. * pata_platform sets port_start to ata_dummy_ret0. port_start can just be set to NULL. * sata_fsl supports NCQ but was missing qc_defer. Fixed. * pata_rb600_cf implements dummy port_start. Removed. Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/pata_rb500_cf.c')
-rw-r--r--drivers/ata/pata_rb500_cf.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/drivers/ata/pata_rb500_cf.c b/drivers/ata/pata_rb500_cf.c
index 08c32af1c84d..22cb9e1a02f5 100644
--- a/drivers/ata/pata_rb500_cf.c
+++ b/drivers/ata/pata_rb500_cf.c
@@ -117,11 +117,6 @@ static irqreturn_t rb500_pata_irq_handler(int irq, void *dev_instance)
117 return IRQ_HANDLED; 117 return IRQ_HANDLED;
118} 118}
119 119
120static int rb500_pata_port_start(struct ata_port *ap)
121{
122 return 0;
123}
124
125static struct ata_port_operations rb500_pata_port_ops = { 120static struct ata_port_operations rb500_pata_port_ops = {
126 .tf_load = ata_tf_load, 121 .tf_load = ata_tf_load,
127 .tf_read = ata_tf_read, 122 .tf_read = ata_tf_read,
@@ -138,12 +133,10 @@ static struct ata_port_operations rb500_pata_port_ops = {
138 .freeze = rb500_pata_freeze, 133 .freeze = rb500_pata_freeze,
139 .thaw = rb500_pata_thaw, 134 .thaw = rb500_pata_thaw,
140 .error_handler = ata_bmdma_error_handler, 135 .error_handler = ata_bmdma_error_handler,
136 .post_internal_cmd = ata_bmdma_post_internal_cmd,
141 137
142 .irq_handler = rb500_pata_irq_handler,
143 .irq_clear = ata_noop_irq_clear, 138 .irq_clear = ata_noop_irq_clear,
144 .irq_on = ata_irq_on, 139 .irq_on = ata_irq_on,
145
146 .port_start = rb500_pata_port_start,
147}; 140};
148 141
149/* ------------------------------------------------------------------------ */ 142/* ------------------------------------------------------------------------ */