diff options
author | Tejun Heo <htejun@gmail.com> | 2008-03-24 23:22:48 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-17 15:44:17 -0400 |
commit | 6bd99b4e0998571808fc1f09d5162348f21ff8c1 (patch) | |
tree | e338bd445aaa5cda4bbf1f5598acf70f0d6b68de /drivers/ata/pata_platform.c | |
parent | 358f9a77a668660729e705fde9c3cf69f013aa98 (diff) |
libata: normalize port_info, port_operations and sht tables
Over the time, port info, ops and sht structures developed quite a bit
of inconsistencies. This patch updates drivers.
* Enable/disable_pm callbacks added to all ahci ops tables.
* Every driver for SFF controllers now uses ata_sff_port_start()
instead of ata_port_start() unless the driver has custom
implementation.
* Every driver for SFF controllers now uses ata_pci_default_filter()
unless the driver has custom implementation.
* Removed an odd port_info->sht initialization from ata_piix.c.
Likely a merge byproduct.
* A port which has ATA_FLAG_SATA set doesn't need to set cable_detect
to ata_cable_sata(). Remove it from via and mv port ops.
* Some drivers had unnecessary .max_sectors initialization which is
ignored and was missing .slave_destroy callback. Fixed.
* Removed unnecessary sht initializations port_info's.
* Removed onsolete scsi device suspend/resume callbacks from
pata_bf54x.
* No reason to set ata_pci_default_filter() and bmdma functions for
PIO-only drivers. Remove those callbacks and replace
ata_bmdma_irq_clear with ata_noop_irq_clear.
* pata_platform sets port_start to ata_dummy_ret0. port_start can
just be set to NULL.
* sata_fsl supports NCQ but was missing qc_defer. Fixed.
* pata_rb600_cf implements dummy port_start. Removed.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/pata_platform.c')
-rw-r--r-- | drivers/ata/pata_platform.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform.c index a8429f5c3006..602f5562d6fb 100644 --- a/drivers/ata/pata_platform.c +++ b/drivers/ata/pata_platform.c | |||
@@ -46,8 +46,6 @@ static int pata_platform_set_mode(struct ata_link *link, struct ata_device **unu | |||
46 | return 0; | 46 | return 0; |
47 | } | 47 | } |
48 | 48 | ||
49 | static int ata_dummy_ret0(struct ata_port *ap) { return 0; } | ||
50 | |||
51 | static struct scsi_host_template pata_platform_sht = { | 49 | static struct scsi_host_template pata_platform_sht = { |
52 | .module = THIS_MODULE, | 50 | .module = THIS_MODULE, |
53 | .name = DRV_NAME, | 51 | .name = DRV_NAME, |
@@ -88,8 +86,6 @@ static struct ata_port_operations pata_platform_port_ops = { | |||
88 | 86 | ||
89 | .irq_clear = ata_noop_irq_clear, | 87 | .irq_clear = ata_noop_irq_clear, |
90 | .irq_on = ata_irq_on, | 88 | .irq_on = ata_irq_on, |
91 | |||
92 | .port_start = ata_dummy_ret0, | ||
93 | }; | 89 | }; |
94 | 90 | ||
95 | static void pata_platform_setup_port(struct ata_ioports *ioaddr, | 91 | static void pata_platform_setup_port(struct ata_ioports *ioaddr, |