diff options
author | Joe Perches <joe@perches.com> | 2011-04-15 18:52:00 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@pobox.com> | 2011-07-23 17:57:36 -0400 |
commit | 06296a1e684bcd40b9a28d5d8030809e4295528b (patch) | |
tree | 474fcc8507fb11107e9e5de885217396a12d99f1 /drivers/ata/pata_oldpiix.c | |
parent | a9a79dfec239568bdbf778242f8fcd10bcc5b9e2 (diff) |
ata: Add and use ata_print_version_once
Use a single mechanism to show driver version.
Reduces text a tiny bit too.
Remove uses of static int printed_version
Add and use ata_print_version(const struct device *, const char *ver)
and ata_print_version_once.
$ size drivers/ata/built-in.*
text data bss dec hex filename
544969 73893 116584 735446 b38d6 drivers/ata/built-in.allyesconfig.ata.o
543870 73893 116592 734355 b34ad drivers/ata/built-in.allyesconfig.print_once.o
141328 14689 4220 160237 271ed drivers/ata/built-in.defconfig.ata.o
141212 14689 4220 160121 27179 drivers/ata/built-in.defconfig.print_once.o
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/ata/pata_oldpiix.c')
-rw-r--r-- | drivers/ata/pata_oldpiix.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/ata/pata_oldpiix.c b/drivers/ata/pata_oldpiix.c index b811c1636204..98cdf50e4065 100644 --- a/drivers/ata/pata_oldpiix.c +++ b/drivers/ata/pata_oldpiix.c | |||
@@ -235,7 +235,6 @@ static struct ata_port_operations oldpiix_pata_ops = { | |||
235 | 235 | ||
236 | static int oldpiix_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) | 236 | static int oldpiix_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) |
237 | { | 237 | { |
238 | static int printed_version; | ||
239 | static const struct ata_port_info info = { | 238 | static const struct ata_port_info info = { |
240 | .flags = ATA_FLAG_SLAVE_POSS, | 239 | .flags = ATA_FLAG_SLAVE_POSS, |
241 | .pio_mask = ATA_PIO4, | 240 | .pio_mask = ATA_PIO4, |
@@ -244,9 +243,7 @@ static int oldpiix_init_one (struct pci_dev *pdev, const struct pci_device_id *e | |||
244 | }; | 243 | }; |
245 | const struct ata_port_info *ppi[] = { &info, NULL }; | 244 | const struct ata_port_info *ppi[] = { &info, NULL }; |
246 | 245 | ||
247 | if (!printed_version++) | 246 | ata_print_version_once(&pdev->dev, DRV_VERSION); |
248 | dev_printk(KERN_DEBUG, &pdev->dev, | ||
249 | "version " DRV_VERSION "\n"); | ||
250 | 247 | ||
251 | return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL, 0); | 248 | return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL, 0); |
252 | } | 249 | } |